July 2024 - gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: ttcn3-ggsn-test/jenkins: tweak loop logic

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37329?usp=email ) Change subject: ttcn3-ggsn-test/jenkins: tweak loop logic ...................................................................... ttcn3-ggsn-test/jenkins: tweak loop logic Iterate over TEST_CONFIGS instead of TEST_CONFIGS_ALL and then filtering with test_config_enabled. Change-Id: Ie7701abe6ab7cff139766eca9240e0f26af32231 --- M ttcn3-ggsn-test/jenkins.sh 1 file changed, 13 insertions(+), 5 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/ttcn3-ggsn-test/jenkins.sh b/ttcn3-ggsn-test/jenkins.sh index 7c9c7ac..bd0fae1 100755 --- a/ttcn3-ggsn-test/jenkins.sh +++ b/ttcn3-ggsn-test/jenkins.sh @@ -109,11 +109,7 @@ CONFIGS_DIR="osmo-ggsn" fi -for i in $TEST_CONFIGS_ALL; do - if ! test_config_enabled "$i"; then - continue - fi - +for i in $TEST_CONFIGS; do # OS#6106: Currently it is not possible to configure multiple APNs with # gtpu-mode kernel-gtp in OsmoGGSN, because it cannot share the GTP-U # bind socket between tunnels. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37329?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie7701abe6ab7cff139766eca9240e0f26af32231 Gerrit-Change-Number: 37329 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 3 weeks

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-ggsn-test/jenkins: tweak loop logic

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37329?usp=email ) Change subject: ttcn3-ggsn-test/jenkins: tweak loop logic ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37329?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie7701abe6ab7cff139766eca9240e0f26af32231 Gerrit-Change-Number: 37329 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jul 2024 12:07:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-ggsn-test/jenkins: tweak loop logic

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37329?usp=email ) Change subject: ttcn3-ggsn-test/jenkins: tweak loop logic ...................................................................... ttcn3-ggsn-test/jenkins: tweak loop logic Iterate over TEST_CONFIGS instead of TEST_CONFIGS_ALL and then filtering with test_config_enabled. Change-Id: Ie7701abe6ab7cff139766eca9240e0f26af32231 --- M ttcn3-ggsn-test/jenkins.sh 1 file changed, 13 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/29/37329/1 diff --git a/ttcn3-ggsn-test/jenkins.sh b/ttcn3-ggsn-test/jenkins.sh index 7c9c7ac..bd0fae1 100755 --- a/ttcn3-ggsn-test/jenkins.sh +++ b/ttcn3-ggsn-test/jenkins.sh @@ -109,11 +109,7 @@ CONFIGS_DIR="osmo-ggsn" fi -for i in $TEST_CONFIGS_ALL; do - if ! test_config_enabled "$i"; then - continue - fi - +for i in $TEST_CONFIGS; do # OS#6106: Currently it is not possible to configure multiple APNs with # gtpu-mode kernel-gtp in OsmoGGSN, because it cannot share the GTP-U # bind socket between tunnels. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37329?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie7701abe6ab7cff139766eca9240e0f26af32231 Gerrit-Change-Number: 37329 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-hlr[master]: mslookup: don't ignore return value of write()

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/37328?usp=email ) Change subject: mslookup: don't ignore return value of write() ...................................................................... mslookup: don't ignore return value of write() Fix GCC 13.2.0 refuses to build this with -Werror: src/mslookup/osmo-mslookup-client.c: In function 'socket_client_respond_result': src/osmo-hlr/src/mslookup/osmo-mslookup-client.c:432:9: error: ignoring return value of 'write' declared with attribute 'warn_unused_result' [-Werror=unused-result] 432 | write(c->ofd.fd, response, strlen(response)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/mslookup/osmo-mslookup-client.c: In function 'socket_accept': src/osmo-hlr/src/mslookup/osmo-mslookup-client.c:530:17: error: ignoring return value of 'write' declared with attribute 'warn_unused_result' [-Werror=unused-result] 530 | write(c->ofd.fd, CSV_HEADERS, strlen(CSV_HEADERS)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I4b2e5cabe5306a999197f7c98362d872a3739078 --- M src/mslookup/osmo-mslookup-client.c 1 file changed, 32 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/mslookup/osmo-mslookup-client.c b/src/mslookup/osmo-mslookup-client.c index 37f1256..0a29645 100644 --- a/src/mslookup/osmo-mslookup-client.c +++ b/src/mslookup/osmo-mslookup-client.c @@ -429,7 +429,11 @@ void socket_client_respond_result(struct socket_client *c, const char *response) { - write(c->ofd.fd, response, strlen(response)); + size_t len = strlen(response); + int rc = write(c->ofd.fd, response, len); + + if (rc != len) + print_error("%s: write() returned %d instead of %zu\n", __func__, rc, len); } static int socket_read_cb(struct osmo_fd *ofd) @@ -526,8 +530,13 @@ llist_add(&c->entry, &globals.socket_clients); - if (globals.format == FORMAT_CSV && cmdline_opts.csv_headers) - write(c->ofd.fd, CSV_HEADERS, strlen(CSV_HEADERS)); + if (globals.format == FORMAT_CSV && cmdline_opts.csv_headers) { + size_t len = strlen(CSV_HEADERS); + int rc = write(c->ofd.fd, CSV_HEADERS, strlen(CSV_HEADERS)); + + if (rc != len) + print_error("%s: write() returned %d instead of %zu\n", __func__, rc, len); + } return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/37328?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I4b2e5cabe5306a999197f7c98362d872a3739078 Gerrit-Change-Number: 37328 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-hlr[master]: mslookup: don't ignore return value of write()

by osmith

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/37328?usp=email ) Change subject: mslookup: don't ignore return value of write() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/37328?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I4b2e5cabe5306a999197f7c98362d872a3739078 Gerrit-Change-Number: 37328 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jul 2024 11:54:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-ci[master]: publish-tarballs-for-tags.sh: publish osmo-epdg's versions

by osmith

Attention is currently required from: laforge, lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37324?usp=email ) Change subject: publish-tarballs-for-tags.sh: publish osmo-epdg's versions ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37324?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3445e76f6fd6ebb49ada5dc4320c6b9fa717f00c Gerrit-Change-Number: 37324 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 03 Jul 2024 11:53:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-hlr[master]: mslookup: don't ignore return value of write()

by pespin

Attention is currently required from: neels, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/37328?usp=email ) Change subject: mslookup: don't ignore return value of write() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/37328?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I4b2e5cabe5306a999197f7c98362d872a3739078 Gerrit-Change-Number: 37328 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jul 2024 11:27:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: config/sys.config: print prefix before msg, if present

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37327?usp=email ) Change subject: config/sys.config: print prefix before msg, if present ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37327?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib88801b8d38976b98a02ed06e1638e0e9056bafb Gerrit-Change-Number: 37327 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jul 2024 11:25:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: rebar.{config,lock}: add pfcplib to deps[]

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37267?usp=email ) Change subject: rebar.{config,lock}: add pfcplib to deps[] ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37267?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I4cf3b3b09b19ebabbaad082c616c31ffc1327fd7 Gerrit-Change-Number: 37267 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jul 2024 11:25:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

[S] Change in osmo-e1d[master]: e1_ts_stop: clear tx_started flag

by tnt

Attention is currently required from: falconia. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/37319?usp=email ) Change subject: e1_ts_stop: clear tx_started flag ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/37319?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I28ff68208f1d3d20dc57c5306fec74bd2f884cb1 Gerrit-Change-Number: 37319 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 03 Jul 2024 11:06:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024