pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37333?usp=email )
Change subject: asterisk: IMS: Fix To tag not updated when sending PRACK in MT call
......................................................................
asterisk: IMS: Fix To tag not updated when sending PRACK in MT call
Change-Id: I55716b7a48b63bc97ea936904a712e53899f03f6
---
M asterisk/IMS_ConnectionHandler.ttcn
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/37333/1
diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn
index 1609304..ec163f5 100644
--- a/asterisk/IMS_ConnectionHandler.ttcn
+++ b/asterisk/IMS_ConnectionHandler.ttcn
@@ -1238,6 +1238,9 @@
g_pars.subscr.cp.peer_sdp.media_list[0].attributes));
}
+ /* Update To with the tags received from peer: */
+ g_pars.subscr.cp.to_addr := g_rx_sip_resp.msgHeader.toField;
+
/* Tx PRACK */
req := ts_SIP_PRACK(g_pars.subscr.cp.to_addr.addressField.nameAddr.addrSpec,
g_pars.subscr.cp.sip_call_id,
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37333?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I55716b7a48b63bc97ea936904a712e53899f03f6
Gerrit-Change-Number: 37333
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37332?usp=email )
Change subject: WIP: asterisk: Avoid waiting for 183 to signal DedicatedBearerStatus Up
......................................................................
WIP: asterisk: Avoid waiting for 183 to signal DedicatedBearerStatus Up
Change-Id: Icca6268f484d2a723d4d70de8755b7ec605b9194
---
M asterisk/IMS_ConnectionHandler.ttcn
1 file changed, 14 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/32/37332/1
diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn
index 51f96ea..1609304 100644
--- a/asterisk/IMS_ConnectionHandler.ttcn
+++ b/asterisk/IMS_ConnectionHandler.ttcn
@@ -1190,6 +1190,11 @@
g_pars.subscr.cp.sip_seq_nr, "INVITE");
d_trying := activate(as_SIP_ignore_resp(exp));
+ if (g_pars.subscr.cp.mt.tx_coord_cmd_session_progress) {
+ /* Signal used to inform that Dedicated bearer can be established: */
+ COORD.send(IMS_COORD_CMD_CALL_SESSION_PROGRESS);
+ }
+
if (g_pars.subscr.cp.require_precondition_ext) {
var template (present) SDP_attribute_list preconds;
/* Rx 183 Session Progress */
@@ -1246,11 +1251,6 @@
body := omit);
SIP.send(req);
- if (g_pars.subscr.cp.mt.tx_coord_cmd_session_progress) {
- /* Signal used to inform that Dedicated bearer can be established: */
- COORD.send(IMS_COORD_CMD_CALL_SESSION_PROGRESS);
- }
-
/* Rx 200 OK (PRACK) */
exp := tr_SIP_Response(g_pars.subscr.cp.sip_call_id,
from_addr_exp,
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37332?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Icca6268f484d2a723d4d70de8755b7ec605b9194
Gerrit-Change-Number: 37332
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/37321?usp=email )
Change subject: mux from not-started raw TS: fill with 0xFF
......................................................................
mux from not-started raw TS: fill with 0xFF
When the channelized mux reads from a raw TS, but that raw TS is
not in tx_started state yet, the read function returns "fake" data.
However, it was actually returning uninitialized memory content,
rather than 0xFF filler used everywhere else, thereby transmitting
uninit-memory garbage to whatever is connected to the E1 line.
Change it to fill with 0xFF, same as the filler used in other cases
such as inactive timeslots.
Change-Id: I42849a6d19b020bab789853c3b60af6a1c09f92f
---
M src/mux_demux.c
1 file changed, 20 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, but someone else must approve
tnt: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/mux_demux.c b/src/mux_demux.c
index a0ae717..72379fe 100644
--- a/src/mux_demux.c
+++ b/src/mux_demux.c
@@ -55,8 +55,10 @@
/* If we're not started yet, we 'fake' data until the other side
* send something */
- if (l < 0 && errno == EAGAIN && !ts->raw.tx_started)
+ if (l < 0 && errno == EAGAIN && !ts->raw.tx_started) {
+ memset(buf, 0xFF, len);
return len;
+ }
ts->raw.tx_started = true;
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/37321?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I42849a6d19b020bab789853c3b60af6a1c09f92f
Gerrit-Change-Number: 37321
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: merged
falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/37319?usp=email )
Change subject: e1_ts_stop: clear tx_started flag
......................................................................
e1_ts_stop: clear tx_started flag
ts->raw.tx_started flag gets set in the channelized mux process
when bytes begin arriving from the raw TS client application.
However, there is no reset of this flag anywhere, hence if a user
opens some TS, then kills that client application, then opens it
again (with the same or different client app), there is a flood
of error messages about TS read underflow. Solution: clear the
tx_started flag when the TS is stopped.
Change-Id: I28ff68208f1d3d20dc57c5306fec74bd2f884cb1
---
M src/ctl.c
1 file changed, 18 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
tnt: Looks good to me, approved
diff --git a/src/ctl.c b/src/ctl.c
index e63589b..a9818b3 100644
--- a/src/ctl.c
+++ b/src/ctl.c
@@ -119,6 +119,7 @@
ts->raw.rx_buf = NULL;
ts->raw.rx_buf_size = 0;
ts->raw.rx_buf_used = 0;
+ ts->raw.tx_started = false;
}
static void
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/37319?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I28ff68208f1d3d20dc57c5306fec74bd2f884cb1
Gerrit-Change-Number: 37319
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: merged
falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/37318?usp=email )
Change subject: configure.ac: lower libusb-1.0 requirement to 1.0.20
......................................................................
configure.ac: lower libusb-1.0 requirement to 1.0.20
Current configure.ac requires libusb version to be >= 1.0.21.
Slackware 14.2 has libusb version 1.0.20. Lowering the
requirement in configure.ac produces a successful build,
i.e., the actual code does not use any libusb APIs that are
new with version 1.0.21.
Change-Id: I15586757e2985184359a4488c79f2c587affeb56
---
M configure.ac
1 file changed, 16 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/configure.ac b/configure.ac
index 8bec040..cea8eb4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -38,7 +38,7 @@
PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.9.0)
PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.9.0)
PKG_CHECK_MODULES(LIBOSMOUSB, libosmousb >= 1.9.0)
-PKG_CHECK_MODULES(LIBUSB, libusb-1.0 >= 1.0.21)
+PKG_CHECK_MODULES(LIBUSB, libusb-1.0 >= 1.0.20)
AC_CONFIG_MACRO_DIR([m4])
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/37318?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I15586757e2985184359a4488c79f2c587affeb56
Gerrit-Change-Number: 37318
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: merged