July 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: obs: use specific mirror

by lynxis lazus

Attention is currently required from: osmith. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37437?usp=email ) Change subject: obs: use specific mirror ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iee06b6c6cc418a1b2f4eba094704c6e5e156799c Gerrit-Change-Number: 37437 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Jul 2024 11:10:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: obs: use specific mirror

by osmith

Attention is currently required from: lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37437?usp=email ) Change subject: obs: use specific mirror ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/37437/comment/f8176853_f0216fb6 PS1, Line 10: See the related issue for detailed reasoning. > please write a short summary in here. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iee06b6c6cc418a1b2f4eba094704c6e5e156799c Gerrit-Change-Number: 37437 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 10 Jul 2024 10:19:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: obs: use specific mirror

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/37437?usp=email to look at the new patch set (#2). Change subject: obs: use specific mirror ...................................................................... obs: use specific mirror Use debian.inf.tu-dresden.de (which has a proper TLS certificate) instead of the generic ftp.de.debian.org. Closes: OS#6499 Change-Id: Iee06b6c6cc418a1b2f4eba094704c6e5e156799c --- M scripts/obs/sync_obs_projects.py 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/37/37437/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iee06b6c6cc418a1b2f4eba094704c6e5e156799c Gerrit-Change-Number: 37437 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: obs: use specific mirror

by lynxis lazus

Attention is currently required from: osmith. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37437?usp=email ) Change subject: obs: use specific mirror ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/37437/comment/84e140e6_813baf06 PS1, Line 10: See the related issue for detailed reasoning. please write a short summary in here. It is much harder to look up the issue and issue tracker might go down or migrate to a different server. Git repos tend to be much more reliable. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iee06b6c6cc418a1b2f4eba094704c6e5e156799c Gerrit-Change-Number: 37437 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Jul 2024 10:15:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: obs: use specific mirror

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/37437?usp=email ) Change subject: obs: use specific mirror ...................................................................... obs: use specific mirror Use debian.inf.tu-dresden.de instead of the generic ftp.de.debian.org. See the related issue for detailed reasoning. Closes: OS#6499 Change-Id: Iee06b6c6cc418a1b2f4eba094704c6e5e156799c --- M scripts/obs/sync_obs_projects.py 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/37/37437/1 diff --git a/scripts/obs/sync_obs_projects.py b/scripts/obs/sync_obs_projects.py index cc4635a..beb3e09 100755 --- a/scripts/obs/sync_obs_projects.py +++ b/scripts/obs/sync_obs_projects.py @@ -182,15 +182,16 @@ # (e.g. <pubkey>debian-archive-12</pubkey>): # https://github.com/openSUSE/open-build-service/pull/14528 # Also we don't have such a pubkeydir set up on our OBS server. Assume - # ftp.de.debian.org is a trusted mirror, switch to HTTPS and skip the - # PGP verification by removing the pubkey blocks. + # https://debian.inf.tu-dresden.de/ is a trusted mirror, switch to + # HTTPS and skip the PGP verification by removing the pubkey blocks. if project.startswith("Debian:"): for download in repository.findall(".download"): url = download.get("url") print(f" changing url to https: {url}") assert url.startswith("http://ftp.de.debian.org/debian"), \ f"unexpected mirror URL" - download.set("url", url.replace("http://", "https://")) + download.set("url", url.replace("http://ftp.de.debian.org/debian", + "https://debian.inf.tu-dresden.de/debian")) for pubkey in download.findall("pubkey"): download.remove(pubkey) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iee06b6c6cc418a1b2f4eba094704c6e5e156799c Gerrit-Change-Number: 37437 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Introduce test TC_ims_call_mo_holdresume_mo

by laforge

Attention is currently required from: jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37426?usp=email ) Change subject: asterisk: Introduce test TC_ims_call_mo_holdresume_mo ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37426?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifffa1c4021f324871f11a60264c17b640569e18b Gerrit-Change-Number: 37426 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Jul 2024 06:52:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in docker-playground[master]: asterisk: pjsip.conf: Forward Hold/Resume SIP UA -> IMS Core

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37434?usp=email ) Change subject: asterisk: pjsip.conf: Forward Hold/Resume SIP UA -> IMS Core ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37434?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I70e7e5df2d9c91acdc85c689cf8e48c5a44b2a34 Gerrit-Change-Number: 37434 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Jul 2024 06:52:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: tests: Add ProfileElementSD and ProfileElementSSD to test_constructor...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37418?usp=email ) Change subject: tests: Add ProfileElementSD and ProfileElementSSD to test_constructor_encode ...................................................................... tests: Add ProfileElementSD and ProfileElementSSD to test_constructor_encode Change-Id: Idc6f37b487dfa8a69ac7a50a537cfc317113d501 --- M tests/test_esim_saip.py 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/tests/test_esim_saip.py b/tests/test_esim_saip.py index 704f513..4c1b936 100755 --- a/tests/test_esim_saip.py +++ b/tests/test_esim_saip.py @@ -66,7 +66,8 @@ def test_constructor_encode(self): """Test that DER-encoding of PE created by "empty" constructor works without raising exception.""" for cls in [ProfileElementMF, ProfileElementPuk, ProfileElementPin, ProfileElementTelecom, - ProfileElementUSIM, ProfileElementISIM, ProfileElementAKA]: + ProfileElementUSIM, ProfileElementISIM, ProfileElementAKA, ProfileElementSD, + ProfileElementSSD]: with self.subTest(cls.__name__): pes = ProfileElementSequence() inst = cls() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37418?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idc6f37b487dfa8a69ac7a50a537cfc317113d501 Gerrit-Change-Number: 37418 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: pySim.saip.oid: Properly differentiate optional from non-optional tem...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37419?usp=email ) Change subject: pySim.saip.oid: Properly differentiate optional from non-optional templates ...................................................................... pySim.saip.oid: Properly differentiate optional from non-optional templates There are e.g. templates for usim and for opt-usim, and they should not be confused with each other. Let's reflect that in the naming. Change-Id: Ic6d04ce3172dc969c6b8c018b8d305eb6fd3f550 --- M pySim/esim/saip/__init__.py M pySim/esim/saip/oid.py M pySim/esim/saip/templates.py 3 files changed, 26 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 2cddbe8..6e17de3 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -54,14 +54,14 @@ aid = h2b("") mandatory_services = ["csim"] pe_types = ["csim", "opt-csim", "cdmaParameter"] - templates = [oid.ADF_CSIM_by_default, oid.ADF_CSIM_not_by_default] + templates = [oid.ADF_CSIM_by_default, oid.ADF_CSIMopt_not_by_default] class NaaUsim(Naa): name = "usim" aid = h2b("") mandatory_services = ["usim"] pe_types = ["usim", "opt-usim"] - templates = [oid.ADF_USIM_by_default, oid.ADF_USIM_not_by_default, + templates = [oid.ADF_USIM_by_default, oid.ADF_USIMopt_not_by_default, oid.DF_PHONEBOOK_ADF_USIM, oid.DF_GSM_ACCESS_ADF_USIM, oid.DF_EAP, oid.DF_5GS, oid.DF_SAIP, oid.DF_SNPN, oid.DF_5GProSe] @@ -71,7 +71,7 @@ aid = h2b("") mandatory_services = ["isim"] pe_types = ["isim", "opt-isim"] - templates = [oid.ADF_ISIM_by_default, oid.ADF_ISIM_not_by_default] + templates = [oid.ADF_ISIM_by_default, oid.ADF_ISIMopt_not_by_default] NAAs = { NaaCsim.name: NaaCsim, diff --git a/pySim/esim/saip/oid.py b/pySim/esim/saip/oid.py index d33b786..91a48c1 100644 --- a/pySim/esim/saip/oid.py +++ b/pySim/esim/saip/oid.py @@ -57,18 +57,18 @@ DF_TELECOM_v2 = eOID("2.3.2") ADF_USIM_by_default = eOID("2.4") ADF_USIM_by_default_v2 = eOID("2.4.2") -ADF_USIM_not_by_default = eOID("2.5") -ADF_USIM_not_by_default_v2 = eOID("2.5.2") -ADF_USIM_not_by_default_v3 = eOID("2.5.3") +ADF_USIMopt_not_by_default = eOID("2.5") +ADF_USIMopt_not_by_default_v2 = eOID("2.5.2") +ADF_USIMopt_not_by_default_v3 = eOID("2.5.3") DF_PHONEBOOK_ADF_USIM = eOID("2.6") DF_GSM_ACCESS_ADF_USIM = eOID("2.7") ADF_ISIM_by_default = eOID("2.8") -ADF_ISIM_not_by_default = eOID("2.9") -ADF_ISIM_not_by_default_v2 = eOID("2.9.2") +ADF_ISIMopt_not_by_default = eOID("2.9") +ADF_ISIMopt_not_by_default_v2 = eOID("2.9.2") ADF_CSIM_by_default = eOID("2.10") ADF_CSIM_by_default_v2 = eOID("2.10.2") -ADF_CSIM_not_by_default = eOID("2.11") -ADF_CSIM_not_by_default_v2 = eOID("2.11.2") +ADF_CSIMopt_not_by_default = eOID("2.11") +ADF_CSIMopt_not_by_default_v2 = eOID("2.11.2") DF_EAP = eOID("2.12") DF_5GS = eOID("2.13") DF_5GS_v2 = eOID("2.13.2") diff --git a/pySim/esim/saip/templates.py b/pySim/esim/saip/templates.py index cd76247..417c83b 100644 --- a/pySim/esim/saip/templates.py +++ b/pySim/esim/saip/templates.py @@ -318,7 +318,7 @@ # Section 9.5.2 v2.3.1 class FilesUsimOptional(ProfileTemplate): created_by_default = False - oid = OID.ADF_USIM_not_by_default + oid = OID.ADF_USIMopt_not_by_default files = [ FileTemplate(0x6f05, 'EF.LI', 'TR', None, 6, 1, 0x02, 'FF...FF', False), FileTemplate(0x6f37, 'EF.ACMmax', 'TR', None, 3, 5, None, '000000', False, ass_serv=[13], pe_name='ef-acmax'), @@ -400,7 +400,7 @@ # Section 9.5.2 class FilesUsimOptionalV2(ProfileTemplate): created_by_default = False - oid = OID.ADF_USIM_not_by_default_v2 + oid = OID.ADF_USIMopt_not_by_default_v2 files = [ FileTemplate(0x6f05, 'EF.LI', 'TR', None, 6, 1, 0x02, 'FF...FF', False), FileTemplate(0x6f37, 'EF.ACMmax', 'TR', None, 3, 5, None, '000000', False, ass_serv=[13]), @@ -601,7 +601,7 @@ # Section 9.6.2 v2.3.1 class FilesIsimOptional(ProfileTemplate): created_by_default = False - oid = OID.ADF_ISIM_not_by_default + oid = OID.ADF_ISIMopt_not_by_default files = [ FileTemplate(0x6f09, 'EF.P-CSCF', 'LF', 1, None, 2, None, None, True, ['size'], ass_serv=[1,5]), FileTemplate(0x6f3c, 'EF.SMS', 'LF', 10, 176, 5, None, '00FF...FF', False, ass_serv=[6,8]), @@ -618,7 +618,7 @@ # Section 9.6.2 class FilesIsimOptionalv2(ProfileTemplate): created_by_default = False - oid = OID.ADF_ISIM_not_by_default_v2 + oid = OID.ADF_ISIMopt_not_by_default_v2 files = [ FileTemplate(0x6f09, 'EF.PCSCF', 'LF', 1, None, 2, None, None, True, ['size'], ass_serv=[1,5]), FileTemplate(0x6f3c, 'EF.SMS', 'LF', 10, 176, 5, None, '00FF...FF', False, ass_serv=[6,8]), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37419?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic6d04ce3172dc969c6b8c018b8d305eb6fd3f550 Gerrit-Change-Number: 37419 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: pySim.saip: Add ProfileElementRFM class

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37421?usp=email ) Change subject: pySim.saip: Add ProfileElementRFM class ...................................................................... pySim.saip: Add ProfileElementRFM class Change-Id: I547e02c12345932deafa4b914fcaeaa183b69798 --- M pySim/esim/saip/__init__.py M tests/test_esim_saip.py 2 files changed, 44 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index e87e5c0..e5173d7 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -553,6 +553,34 @@ 'uiccToolkitApplicationSpecificParametersField': h2b('01000001000000020112036C756500'), } +class ProfileElementRFM(ProfileElement): + type = 'rfm' + + def __init__(self, decoded: Optional[dict] = None, + inst_aid: Optional[bytes] = None, sd_aid: Optional[bytes] = None, + adf_aid: Optional[bytes] = None, + tar_list: Optional[List[bytes]] = [], msl: Optional[int] = 0x06): + super().__init__() + ADM1_ACCESS = h2b('02000100') + if decoded: + self.decoded = decoded + return + # provide some reasonable defaults for a MNO-SD + self.decoded = OrderedDict() + self.decoded['rfm-header'] = { 'mandated': None, 'identification': None} + self.decoded['instanceAID'] = inst_aid + self.decoded['securityDomainAID'] = sd_aid + self.decoded['tarList'] = tar_list + self.decoded['minimumSecurityLevel'] = bytes([msl]) + self.decoded['uiccAccessDomain'] = ADM1_ACCESS + self.decoded['uiccAdminAccessDomain'] = ADM1_ACCESS + if adf_aid: + self.decoded['adfRFMAccess'] = { + 'adfAID': adf_aid, + 'adfAccessDomain': ADM1_ACCESS, + 'adfAdminAccessDomain': ADM1_ACCESS, + } + class ProfileElementUSIM(ProfileElement): type = 'usim' diff --git a/tests/test_esim_saip.py b/tests/test_esim_saip.py index 5a1284e..e87a073 100755 --- a/tests/test_esim_saip.py +++ b/tests/test_esim_saip.py @@ -74,6 +74,13 @@ pes.append(inst) pes.to_der() + # RFM requires some constructor arguments + cls = ProfileElementRFM + with self.subTest(cls.__name__): + pes = ProfileElementSequence() + inst = cls(inst_aid=b'\x01\x02', sd_aid=b'\x03\x04', tar_list=[b'\x01\x02\x03']) + pes.append(inst) + pes.to_der() if __name__ == "__main__": -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37421?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I547e02c12345932deafa4b914fcaeaa183b69798 Gerrit-Change-Number: 37421 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024