June 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-abis[master]: rtp2trau_hr16: set CRC bits correctly

by pespin

Attention is currently required from: dexter, falconia, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37180?usp=email ) Change subject: rtp2trau_hr16: set CRC bits correctly ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5c8aa5891e3862f978f14093bff46bd00b6702a5 Gerrit-Change-Number: 37180 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jun 2024 15:30:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Implement SIP UA unregister

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37193?usp=email ) Change subject: asterisk: Implement SIP UA unregister ...................................................................... asterisk: Implement SIP UA unregister Change-Id: I1ea6be662db00e52dbd39c4f54bb656dc4587ec7 --- M asterisk/Asterisk_Tests.ttcn M asterisk/SIP_ConnectionHandler.ttcn 2 files changed, 66 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/37193/1 diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index bb1ed90..7126118 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -183,7 +183,9 @@ private function f_TC_internal_registration(charstring id) runs on SIPConnHdlr { f_SIP_register(); - // f_SIP_deregister(); + /* Trigger unregistration: */ + f_sleep(1.0); + f_SIP_unregister(); setverdict(pass); } testcase TC_internal_registration() runs on test_CT { @@ -209,6 +211,8 @@ COORD.receive(COORD_CMD_HANGUP); f_SIP_do_call_hangup(); + f_SIP_unregister(); + setverdict(pass); } private function f_TC_internal_call_mt(charstring id) runs on SIPConnHdlr { @@ -234,6 +238,8 @@ } as_SIP_exp_call_hangup(g_pars.cp.sip_seq_nr + 1); + f_SIP_unregister(); + setverdict(pass); } testcase TC_internal_call_momt() runs on test_CT { diff --git a/asterisk/SIP_ConnectionHandler.ttcn b/asterisk/SIP_ConnectionHandler.ttcn index 05f872f..892f5a3 100644 --- a/asterisk/SIP_ConnectionHandler.ttcn +++ b/asterisk/SIP_ConnectionHandler.ttcn @@ -61,6 +61,7 @@ SipUrl local_sip_url_ext, SipAddr local_sip_record, Contact local_contact, + Authorization authorization optional, CallPars cp optional } type record of SIPConnHdlrPars SIPConnHdlrParsList; @@ -147,6 +148,7 @@ ts_UserInfo(user))), omit) })), + authorization := omit, cp := cp } @@ -299,10 +301,11 @@ as_SIP_expect_resp(exp); /* Digest Auth: RFC 2617 */ - authorization := f_sip_digest_gen_Authorization_MD5(g_rx_sip_resp.msgHeader.wwwAuthenticate, - g_pars.user, g_pars.password, - "REGISTER", - f_sip_SipUrl_to_str(g_pars.registrar_sip_req_uri)) + g_pars.authorization := + f_sip_digest_gen_Authorization_MD5(g_rx_sip_resp.msgHeader.wwwAuthenticate, + g_pars.user, g_pars.password, + "REGISTER", + f_sip_SipUrl_to_str(g_pars.registrar_sip_req_uri)) /* New transaction: */ g_pars.registrar_sip_seq_nr := g_pars.registrar_sip_seq_nr + 1; @@ -320,7 +323,49 @@ g_pars.registrar_sip_seq_nr, g_pars.local_contact, ts_Expires("7200"), - authorization := authorization)); + authorization := g_pars.authorization)); + + /* Wait for OK answer */ + exp := tr_SIP_Response( + g_pars.registrar_sip_call_id, + from_addr, + to_addr_exp, + f_tr_Via_response(via), + *, + "REGISTER", 200, + g_pars.registrar_sip_seq_nr, "OK"); + as_SIP_expect_resp(exp); + + /* Prepare for next use: */ + g_pars.registrar_sip_seq_nr := g_pars.registrar_sip_seq_nr + 1; + return g_rx_sip_resp; +} + +function f_SIP_unregister() runs on SIPConnHdlr return PDU_SIP_Response +{ + var template (present) PDU_SIP_Response exp; + var Via via := g_pars.local_via; + var From from_addr := valueof(ts_From(g_pars.registrar_sip_record.addr, g_pars.registrar_sip_record.params)); + var To to_addr := valueof(ts_To(g_pars.registrar_sip_record.addr, g_pars.registrar_sip_record.params)); + var template (present) To to_addr_exp := tr_To(tr_Addr_Union_from_val(to_addr.addressField), *); + var charstring branch_value; + + branch_value := f_sip_gen_branch(f_sip_SipAddr_to_str(g_pars.registrar_sip_record), + f_sip_SipAddr_to_str(g_pars.registrar_sip_record), + g_pars.registrar_sip_call_id, + g_pars.registrar_sip_seq_nr); + + via.viaBody[0].viaParams := f_sip_param_set(via.viaBody[0].viaParams, "branch", branch_value); + from_addr.fromParams := f_sip_param_set(from_addr.fromParams, "tag", f_sip_rand_tag()); + SIP.send(ts_SIP_REGISTER(g_pars.registrar_sip_req_uri, + g_pars.registrar_sip_call_id, + from_addr, + to_addr, + via, + g_pars.registrar_sip_seq_nr, + g_pars.local_contact, + ts_Expires("0"), + authorization := g_pars.authorization)); /* Wait for OK answer */ exp := tr_SIP_Response( -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1ea6be662db00e52dbd39c4f54bb656dc4587ec7 Gerrit-Change-Number: 37193 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in docker-playground[master]: jenkins-common: Treat -asan builds as -master

by daniel

Attention is currently required from: osmith. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email ) Change subject: jenkins-common: Treat -asan builds as -master ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: See https://projects.osmocom.org/issues/6486 Maybe we need a better way to separate image "version" (latest/master) and "variant" (asan, uring(?))? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibf93880345f38668f8dc812d1523b985d368dfcc Gerrit-Change-Number: 37192 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jun 2024 15:25:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in docker-playground[master]: jenkins-common: Treat -asan builds as -master

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email ) Change subject: jenkins-common: Treat -asan builds as -master ...................................................................... jenkins-common: Treat -asan builds as -master This fixes the jenkins test failures seen in ttcn3-stp-test-asan. TTCN3 tries to connect to stp via TCP, but since the jenkins.sh script doesn't consider this a build from master the corresponding config is not added to osmo-stp.cfg. Related: OS#6486 Change-Id: Ibf93880345f38668f8dc812d1523b985d368dfcc --- M jenkins-common.sh 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/92/37192/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index 1caa5dd..809bd06 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -548,6 +548,7 @@ image_suffix_is_master() { case "$IMAGE_SUFFIX" in master*) return 0 ;; + asan*) return 0 ;; *) return 1 ;; esac } -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ibf93880345f38668f8dc812d1523b985d368dfcc Gerrit-Change-Number: 37192 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in libosmo-abis[master]: rtp2trau_hr16: set D bits correctly

by falconia

Attention is currently required from: pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37150?usp=email ) Change subject: rtp2trau_hr16: set D bits correctly ...................................................................... Patch Set 2: (1 comment) File src/trau/trau_rtp_conv.c: https://gerrit.osmocom.org/c/libosmo-abis/+/37150/comment/25ceba64_357d52e5 PS1, Line 428: osmo_pbit2ubit(tf->d_bits, data, 112); > It is the number of bits in a GSM-HR codec frame. […] I changed that raw 112 to GSM_HR_BYTES*8. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Icb6a21a12fe82f6637f327d45bd843686a90a458 Gerrit-Change-Number: 37150 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Jun 2024 15:16:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in libosmo-abis[master]: rtp2trau_hr16: set D bits correctly

by falconia

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/37150?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: rtp2trau_hr16: set D bits correctly ...................................................................... rtp2trau_hr16: set D bits correctly The original code failed to do the step of osmo_pbit2ubit() for transferring HRv1 payload bits from packed to unpacked form, instead doing the bogon of memcpy()ing the RTP payload directly into tf->d_bits array - fix it. Also set all D bits to zeros in the case of empty payload input - not ideal, but better than transmitting uninitialized memory content. Change-Id: Icb6a21a12fe82f6637f327d45bd843686a90a458 --- M src/trau/trau_rtp_conv.c 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/50/37150/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Icb6a21a12fe82f6637f327d45bd843686a90a458 Gerrit-Change-Number: 37150 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year

1
0
0 0

[S] Change in libosmo-abis[master]: rtp2trau_hr16: accept both TS 101 318 and RFC 5993 payload formats

by falconia

Attention is currently required from: dexter, falconia. Hello Jenkins Builder, dexter, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/37151?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: rtp2trau_hr16: accept both TS 101 318 and RFC 5993 payload formats ...................................................................... rtp2trau_hr16: accept both TS 101 318 and RFC 5993 payload formats OsmoBTS already accepts both payload formats for HRv1 - do likewise when interfacing to E1-based BTS. While OsmoMGW does have a vty config option to convert between TS 101 318 and RFC 5993 payload formats on the fly, it should be considered deprecated, and we should be moving toward recommended configurations with that option disabled. Change-Id: I125d57d3451b030e35a7b2b95a45e38b4581626c --- M src/trau/trau_rtp_conv.c 1 file changed, 29 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/51/37151/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37151?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I125d57d3451b030e35a7b2b95a45e38b4581626c Gerrit-Change-Number: 37151 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year

1
0
0 0

[M] Change in libosmo-abis[master]: RTP->TRAU, FR/EFR: accept TW-TS-001 extended payloads

by falconia

Attention is currently required from: falconia. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/37153?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: RTP->TRAU, FR/EFR: accept TW-TS-001 extended payloads ...................................................................... RTP->TRAU, FR/EFR: accept TW-TS-001 extended payloads TW-TS-001 is an enhanced RTP transport format for FR and EFR codecs that replicates the functionality and semantics of GSM 08.60 TRAU-UL frames. Given that libosmotrau functions support converting from RTP to either TRAU-UL or TRAU-DL, the option of TW-TS-001 fits in naturally. It needs to be noted, however, that the fully correct path in OsmoMGW from RTP input to E1 output will need to include one more critical step _before_ the call to osmo_rtp2trau(): it will be a stateful preening engine that implements the rules of TS 28.062 section C.3.2.1.1, a codec-dependent stateful transform that can be fairly complex. The necessary engines will most likely be implemented in Themyscira codec libraries, and OsmoMGW will need to be outfitted with an _optional_ dependency on those libs. The "native" support for TW-TS-001 input in osmo_rtp2trau() for TRAU-DL (as opposed to TRAU-UL) output is a fallback in the case of OsmoMGW built without any Themyscira codec libraries. Related: OS#6448 Change-Id: I3b2a33c1fcc5a7dafe06736dce5fa5b7b1138e54 --- M src/trau/trau_rtp_conv.c 1 file changed, 77 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/53/37153/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3b2a33c1fcc5a7dafe06736dce5fa5b7b1138e54 Gerrit-Change-Number: 37153 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newpatchset

1 year

1
0
0 0

[M] Change in libosmo-abis[master]: trau2rtp_hr16: change output format to RFC 5993

by falconia

Attention is currently required from: dexter, falconia. Hello Jenkins Builder, dexter, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/37152?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: trau2rtp_hr16: change output format to RFC 5993 ...................................................................... trau2rtp_hr16: change output format to RFC 5993 Emitting RFC 5993 payload format instead of TS 101 318 brings Osmocom+E1 BSS into compliance with TS 48.103 (which requires RFC 5993 format at AoIP interface), and will also make it much easier to add optional support for TW-TS-002. There are no backward compatibility issues: OsmoMGW E1 support currently works only for FR and EFR, not for HR. Related: OS#6448 Change-Id: I0bcfdccbf4df5a5cd90a65525527f08107be2cf5 --- M src/trau/trau_rtp_conv.c 1 file changed, 43 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/52/37152/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0bcfdccbf4df5a5cd90a65525527f08107be2cf5 Gerrit-Change-Number: 37152 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year

1
0
0 0

[S] Change in libosmo-abis[master]: rtp2trau_hr16: set CRC bits correctly

by falconia

Attention is currently required from: dexter, falconia, fixeria, pespin. Hello Jenkins Builder, dexter, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/37180?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: rtp2trau_hr16: set CRC bits correctly ...................................................................... rtp2trau_hr16: set CRC bits correctly The code previously failed to set the CRC bits in the TRAU frame output, containing a misleading comment that this operation is done by the TRAU frame encoding function (it isn't). Set these bits correctly in the rtp2trau step, like we do for EFR. Change-Id: I5c8aa5891e3862f978f14093bff46bd00b6702a5 --- M src/trau/trau_rtp_conv.c 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/80/37180/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5c8aa5891e3862f978f14093bff46bd00b6702a5 Gerrit-Change-Number: 37180 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2024