May 2024 - gerrit-log - lists.osmocom.org

[XL] Change in osmo-hnbgw[master]: per-HNB GTP-U traffic counters via nft

by pespin

Attention is currently required from: laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email ) Change subject: per-HNB GTP-U traffic counters via nft ...................................................................... Patch Set 9: (16 comments) File include/osmocom/hnbgw/hnbgw.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/84344d4d_b07e3a98 PS6, Line 384: /* When rules to count traffic to and from this hNodeB are present, this reflects the state in nftables > Done ACK. https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/ac15f67a_9120ed54 PS6, Line 394: struct osmo_sockaddr_str addr_remote; > libnftables interfacing is string based, as the patch should show in other places Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/f00243b2_56949943 PS6, Line 402: struct { > (in an earlier patch set i actually had the two combined in one struct.) […] Oh I didn't mean joining the dl and ul. My proposal was to simply make the struct named so it can be declared one, used twice. That also makes it possible to pass a pointer to it. File include/osmocom/hnbgw/nft_kpi.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/2d63fa0a_4f91520d PS6, Line 21: int nft_kpi_hnb_start(struct hnb_persistent *hnbp, const struct osmo_sockaddr_str *gtpu_remote); > nftables uses strings (also all logging), so it makes sense to use strings here. […] Done File src/osmo-hnbgw/hnbgw.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/09ce5455_93fb3768 PS6, Line 346: hnb_persistent_disconnected(ctx->persistent); > (or "active" and "inactive", s.a. […] Yeah, whatever, just give it a second though :) https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/d495300f_44ccb1b7 PS6, Line 607: { > exactly what i mean above. But this patch is not about fixing the HNBAP / HNB activity tracking. […] Ack File src/osmo-hnbgw/hnbgw_hnbap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/2b5a2a59_fccd98c0 PS6, Line 571: hnb_persistent_connected(ctx->persistent); > yes, but how osmo-hnbgw handles HNBAP is weird. […] Can actually an HNB be registered without being connected? I don't think so. My understanding is that a HNBAP link disconnect makes the HNB implicitly become "unregistered". File src/osmo-hnbgw/hnbgw_vty.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/f3192d20_704f761c PS6, Line 884: DEFUN(cfg_hnbgw_nft_kpi, cfg_hnbgw_nft_kpi_cmd, > I wanted to, but it does not exist AFAICT: […] Ah then it's probably the default. DONE. File src/osmo-hnbgw/nft_kpi.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/7fd077cd_6b1f1569 PS6, Line 86: static __thread struct nft_thread *g_nft_thread = NULL; > the nft_thread could be launched any number of times. […] Ok, I'm not really a fan of having this sort of generic thread which may or may not do stuff, makes the architecture more open for no good reason, but fine. I'd prefer having 2 (actually 3 counting the main thread) distinct threads doing specific stuff with specific context, but if you like it the other way we can keep it. https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/16d564ff_9dfe2e27 PS6, Line 120: LOGP(DNFT, LOGL_ERROR, "error running nft cmd %s#%u: rc=%d cmd=%s\n", > yes we have the rc that is carried back to the main thread in the queued response. […] Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/9c8b547a_5f808d31 PS6, Line 182: enum nft_thread_req_type { > can, but this is the part of the file that defines the thread request queue, so i'd like this to be […] Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/68d34dcd_2c071dcd PS6, Line 207: struct { > hence the naming yes Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/7ade3ea8_0eef8f10 PS6, Line 251: OSMO_ASSERT(g_nft_thread); > Why allocate it using talloc? […] Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/6601dced_9cada900 PS6, Line 297: static void nft_t2m_enqueue(struct nft_thread *t, struct nft_thread_req *req) > The terms I use so far are "main()" and "(nft-)thread", because main() isn't started by pthread_crea […] Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/0e333f77_964f8f30 PS6, Line 415: static int update_ctr(struct rate_ctr_group *cg, int cgidx, uint64_t *last_val, uint64_t new_val) > but the second thought made you realize that there is a cg counter group involved, right =) Yes, after looking at the surrounding code. Just sharing that we use "ctrg" in lots of places already, so it's easier for osmocom users to understand right away. https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/27662d54_da2b328d PS6, Line 452: size_t want = g_nft_thread->counters_len + 64; > I used \*2 in an array list for a diff algorithm implementation in the https://gameoftrees. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib2f0a9252715ea4b2fe9c367aa65f771357768ca Gerrit-Change-Number: 36539 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 22 May 2024 09:20:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-hnbgw[master]: contrib/jenkins: set --enable-werror

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36897?usp=email ) Change subject: contrib/jenkins: set --enable-werror ...................................................................... contrib/jenkins: set --enable-werror Fixes: OS#6460 Change-Id: I6d85b077f57a86b0bad29cb868f1f4f848506f46 --- M contrib/jenkins.sh 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index dfbbbfe..1c4fa2b 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -59,7 +59,7 @@ cd "$base" autoreconf --install --force -./configure --enable-sanitize --enable-external-tests $CONFIG +./configure --enable-sanitize --enable-external-tests --enable-werror $CONFIG $MAKE $PARALLEL_MAKE LD_LIBRARY_PATH="$inst/lib" $MAKE check \ || cat-testlogs.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I6d85b077f57a86b0bad29cb868f1f4f848506f46 Gerrit-Change-Number: 36897 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-hnbgw[master]: contrib/jenkins: set --enable-werror

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36897?usp=email ) Change subject: contrib/jenkins: set --enable-werror ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I6d85b077f57a86b0bad29cb868f1f4f848506f46 Gerrit-Change-Number: 36897 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 May 2024 07:08:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-hnbgw[master]: contrib/jenkins: set --enable-werror

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36897?usp=email ) Change subject: contrib/jenkins: set --enable-werror ...................................................................... contrib/jenkins: set --enable-werror Fixes: OS#6460 Change-Id: I6d85b077f57a86b0bad29cb868f1f4f848506f46 --- M contrib/jenkins.sh 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/97/36897/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index dfbbbfe..1c4fa2b 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -59,7 +59,7 @@ cd "$base" autoreconf --install --force -./configure --enable-sanitize --enable-external-tests $CONFIG +./configure --enable-sanitize --enable-external-tests --enable-werror $CONFIG $MAKE $PARALLEL_MAKE LD_LIBRARY_PATH="$inst/lib" $MAKE check \ || cat-testlogs.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I6d85b077f57a86b0bad29cb868f1f4f848506f46 Gerrit-Change-Number: 36897 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[M] Change in osmo-hnbgw[master]: KPI: Add initial set of DTAP message type rate counters

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36788?usp=email ) Change subject: KPI: Add initial set of DTAP message type rate counters ...................................................................... Patch Set 5: (1 comment) File src/osmo-hnbgw/context_map_rua.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36788/comment/55b76f78_9cc2b0c1 PS5, Line 217: struct hnbgw_context_map *map = fi->priv; > looks like jenkins tested patchset 4, not the rebase in patchset 5 that was submitted -> https://osmocom.org/issues/6460 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36788?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3e1ad7a2aa71674a22a27c31512600f2de139032 Gerrit-Change-Number: 36788 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 22 May 2024 06:39:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-hnbgw[master]: KPI: Add initial set of DTAP message type rate counters

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36788?usp=email ) Change subject: KPI: Add initial set of DTAP message type rate counters ...................................................................... Patch Set 5: (1 comment) File src/osmo-hnbgw/context_map_rua.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36788/comment/68a96698_8b64eb1d PS5, Line 217: struct hnbgw_context_map *map = fi->priv; > This is now an unused variable -- why did jenkins not complain about this? […] looks like jenkins tested patchset 4, not the rebase in patchset 5 that was submitted -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36788?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3e1ad7a2aa71674a22a27c31512600f2de139032 Gerrit-Change-Number: 36788 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 22 May 2024 06:35:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-msc[master]: SMS-over-GSUP: set log context in gsm411_gsup_rx()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email ) Change subject: SMS-over-GSUP: set log context in gsm411_gsup_rx() ...................................................................... SMS-over-GSUP: set log context in gsm411_gsup_rx() Change-Id: I3414953d2aa7b075fcee1cf6e5e76c527ae7b507 --- M src/libmsc/gsm_04_11_gsup.c 1 file changed, 12 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c index 1afdfab..328d047 100644 --- a/src/libmsc/gsm_04_11_gsup.c +++ b/src/libmsc/gsm_04_11_gsup.c @@ -133,9 +133,6 @@ const char *msg_name; bool msg_is_err; - /* Associate logging messages with this subscriber */ - log_set_context(LOG_CTX_VLR_SUBSCR, vsub); - /* Determine the message type and name */ msg_is_err = OSMO_GSUP_IS_MSGT_ERROR(gsup_msg->message_type); switch (gsup_msg->message_type) { @@ -241,9 +238,6 @@ bool sm_rp_mmts_ind; int rc; - /* Associate logging messages with this subscriber */ - log_set_context(LOG_CTX_VLR_SUBSCR, vsub); - LOGP(DLSMS, LOGL_DEBUG, "RX MT-forwardSM-Req\n"); /** @@ -310,6 +304,9 @@ return -GMM_CAUSE_IMSI_UNKNOWN; } + /* Associate logging messages with this subscriber */ + log_set_context(LOG_CTX_VLR_SUBSCR, vsub); + switch (gsup_msg->message_type) { /* GSM 04.11 code implementing MO SMS */ case OSMO_GSUP_MSGT_MO_FORWARD_SM_ERROR: -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3414953d2aa7b075fcee1cf6e5e76c527ae7b507 Gerrit-Change-Number: 36861 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-msc[master]: SMS-over-GSUP: set log context in gsm411_gsup_rx()

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email ) Change subject: SMS-over-GSUP: set log context in gsm411_gsup_rx() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Why are you removing the log context lines? Because I am moving setting the log context to the common code path. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3414953d2aa7b075fcee1cf6e5e76c527ae7b507 Gerrit-Change-Number: 36861 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 22 May 2024 03:43:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: fix sending dummy TCH/A[FH]S blocks

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/36879?usp=email ) Change subject: trxcon/l1sched: fix sending dummy TCH/A[FH]S blocks ...................................................................... trxcon/l1sched: fix sending dummy TCH/A[FH]S blocks ... in the absence of valid Uplink TCH/A[FH]S or FACCH frames. Change-Id: I26205e8672cb2849ea79bd6206c1eff1172bd9d9 Related: libosmocore.git I82ce2adf995a4b42d1f378c5819f88d773b9104a Related: OS#6049 --- M src/host/trxcon/src/sched_lchan_tchf.c M src/host/trxcon/src/sched_lchan_tchh.c 2 files changed, 17 insertions(+), 14 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/trxcon/src/sched_lchan_tchf.c b/src/host/trxcon/src/sched_lchan_tchf.c index 37e0cea..d11b314 100644 --- a/src/host/trxcon/src/sched_lchan_tchf.c +++ b/src/host/trxcon/src/sched_lchan_tchf.c @@ -305,13 +305,7 @@ const uint8_t *data = msg ? msgb_l2(msg) : NULL; size_t data_len = msg ? msgb_l2len(msg) : 0; - if (msg == NULL) { - /* TODO: It's not clear what to do for TCH/AFS. - * TODO: Send dummy FACCH maybe? */ - goto send_burst; /* send something */ - } - - if (data_len != GSM_MACBLOCK_LEN) { /* TCH/AFS: speech */ + if (msg != NULL && msg != msg_facch) { /* TCH/AFS: speech */ if (!l1sched_lchan_amr_prim_is_valid(lchan, msg, amr_fn_is_cmr)) goto free_bad_msg; /* pull the AMR header - sizeof(struct amr_hdr) */ @@ -319,6 +313,7 @@ data += 2; } + /* if msg == NULL, transmit a dummy speech block with inverted CRC6 */ rc = gsm0503_tch_afs_encode(BUFPOS(bursts_p, 0), data, data_len, amr_fn_is_cmr, diff --git a/src/host/trxcon/src/sched_lchan_tchh.c b/src/host/trxcon/src/sched_lchan_tchh.c index 99e2680..0d3de00 100644 --- a/src/host/trxcon/src/sched_lchan_tchh.c +++ b/src/host/trxcon/src/sched_lchan_tchh.c @@ -512,13 +512,7 @@ const uint8_t *data = msg ? msgb_l2(msg) : NULL; size_t data_len = msg ? msgb_l2len(msg) : 0; - if (msg == NULL) { - /* TODO: It's not clear what to do for TCH/AHS. - * TODO: Send dummy FACCH maybe? */ - goto send_burst; /* send garbage */ - } - - if (data_len != GSM_MACBLOCK_LEN) { /* TCH/AHS: speech */ + if (msg != NULL && msg != msg_facch) { /* TCH/AHS: speech */ if (!l1sched_lchan_amr_prim_is_valid(lchan, msg, amr_fn_is_cmr)) goto free_bad_msg; /* pull the AMR header - sizeof(struct amr_hdr) */ @@ -526,6 +520,7 @@ data += 2; } + /* if msg == NULL, transmit a dummy speech block with inverted CRC6 */ rc = gsm0503_tch_ahs_encode(BUFPOS(bursts_p, 0), data, data_len, amr_fn_is_cmr, -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/36879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I26205e8672cb2849ea79bd6206c1eff1172bd9d9 Gerrit-Change-Number: 36879 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[M] Change in osmo-bts[master]: common: add support for TW-TS-001

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36896?usp=email ) Change subject: common: add support for TW-TS-001 ...................................................................... Patch Set 1: (12 comments) File src/common/l1sap.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/bcb9c1b8_64c97313 PS1, Line 1998: uint8_t teh; 'teh' may be misspelled - perhaps 'the'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/d1802a21_bc319f6a PS1, Line 2003: teh = 0xE0; 'teh' may be misspelled - perhaps 'the'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/09c46f74_0b55d5d4 PS1, Line 2005: teh = 0xE2; 'teh' may be misspelled - perhaps 'the'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/848fe8cc_61f31b81 PS1, Line 2008: teh = 0xE6; 'teh' may be misspelled - perhaps 'the'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/3e1d16df_ae355de3 PS1, Line 2013: teh |= 0x08; 'teh' may be misspelled - perhaps 'the'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/1719c13b_81877257 PS1, Line 2015: teh |= 0x01; 'teh' may be misspelled - perhaps 'the'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/05608687_536519ec PS1, Line 2017: msgb_push_u8(msg, teh); 'teh' may be misspelled - perhaps 'the'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/2d2d3d9d_8b3d11e9 PS1, Line 2020: send_ul_rtp_packet_speech(lchan, fn, &teh, 1); 'teh' may be misspelled - perhaps 'the'? File src/common/rtp_input_preen.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/c8288bb0_de6f62a8 PS1, Line 74: /* TEH octet must be correct, and not a BFI */ 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/54c04f2c_71cd8e94 PS1, Line 80: /* Strip TEH octet, leaving only standard FR payload. */ 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/0dc63208_dade06ad PS1, Line 98: /* TEH octet must be correct, and not a BFI */ 'TEH' may be misspelled - perhaps 'THE'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16235): https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/23da6236_9207b679 PS1, Line 104: /* Strip TEH octet, leaving only standard EFR payload. */ 'TEH' may be misspelled - perhaps 'THE'? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36896?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id997e8666bc19e60936aaa83b43a968d30320bd7 Gerrit-Change-Number: 36896 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 22 May 2024 02:38:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024