May 2024 - gerrit-log - lists.osmocom.org

[XL] Change in osmo-hnbgw[master]: per-HNB GTP-U traffic counters via nft

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email ) Change subject: per-HNB GTP-U traffic counters via nft ...................................................................... Patch Set 12: (3 comments) File src/osmo-hnbgw/hnbgw_hnbap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/9af84649_52b5f700 PS6, Line 571: hnb_persistent_connected(ctx->persistent); > It really depends on the specific event you want to track here. […] I agree pespin's wording is more clear. File src/osmo-hnbgw/hnbgw_vty.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/09c3a806_e0667d5b PS12, Line 885: "nft-kpi [TABLE_NAME]", shouldn't this be in some kind of #ifdef block to suppress offering those vty commands in case the program was not compiled with nftables support? File src/osmo-hnbgw/nft_kpi.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/7158d6e7_658478a9 PS9, Line 994: nft_kpi_get_counters_schedule(); > I really think we want to at least do as I described, which is really quick to implement (adding one […] I agree with neels that his approach implements what we discussed (for the reasons we discussed and he stated). Yes, it's not ideal from the user point of view, but let's not be perfect at the cost of dragging this another week. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib2f0a9252715ea4b2fe9c367aa65f771357768ca Gerrit-Change-Number: 36539 Gerrit-PatchSet: 12 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 May 2024 14:44:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-hnbgw[master]: fix rate_ctr leak in hnb_persistent_free()

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36911?usp=email ) Change subject: fix rate_ctr leak in hnb_persistent_free() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: nitpick: It is likely not really a leak as hnbp->ctrs uses hnbp as talloc context and will be talloc_free'd due to the hierarchical nature. It's more that the llist_del of ctrs->list doesn't happen and we're avoiding linked list corruption here. So the fix is right, just commit message probably incorrect. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I14e050bfb91b993f194e3800eacdc0d10f2b1a4e Gerrit-Change-Number: 36911 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 May 2024 14:36:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[L] Change in libosmocore[master]: add jhash.h, copied from linux/jhash.h

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36913?usp=email ) Change subject: add jhash.h, copied from linux/jhash.h ...................................................................... Patch Set 1: Verified-1 (1 comment) Patchset: PS1: I thought the linter failures were in copied jhash.h code, so I manually set V+1 and removed the jenkins builder/linter. However, it's in the unit test and hence should be fixed. Adding my -1 as a replacement of the deleted verify-build. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36913?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0c9652bbc9e2a18b1200e7d63bb6f64ded7d75fa Gerrit-Change-Number: 36913 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 May 2024 14:34:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[L] Change in libosmocore[master]: add jhash.h, copied from linux/jhash.h

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36913?usp=email ) Change subject: add jhash.h, copied from linux/jhash.h ...................................................................... Patch Set 1: Verified+1 Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36913?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0c9652bbc9e2a18b1200e7d63bb6f64ded7d75fa Gerrit-Change-Number: 36913 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 May 2024 14:32:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: fix update_exp: s/soft_uart.ok/soft_uart_test.ok

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36909?usp=email ) Change subject: fix update_exp: s/soft_uart.ok/soft_uart_test.ok ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2fb70b684978fa8a591d1d9e3cace919d590d1ef Gerrit-Change-Number: 36909 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 May 2024 14:32:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmocom-bb[master]: trxcon/l1sched: refactor prim management in tx_tch[fh]_fn()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/36915?usp=email ) Change subject: trxcon/l1sched: refactor prim management in tx_tch[fh]_fn() ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I'm not sure it is an improvement, tbh. There's nothing wrong with goto, if we can avoid code dupliation. It looks like you're introducing code duplication here - maybe I didn't read carefully enough? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/36915?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5292abf6fcd308c9f7f12c7145d004103c9c7675 Gerrit-Change-Number: 36915 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 May 2024 14:31:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: make l1sched_lchan_emit_data_cnf() NULL-safe

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/36914?usp=email ) Change subject: trxcon/l1sched: make l1sched_lchan_emit_data_cnf() NULL-safe ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: like with a number of your patches in recent weeks, I'm missing the rationale _why_ something is changed in the changelog. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/36914?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie64c176265f66a6c1515c66eb465d7e60f6768db Gerrit-Change-Number: 36914 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 May 2024 14:30:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: RSPDefinitions_Templates: add iccid to ts_profileInstallationResultData

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36917?usp=email ) Change subject: RSPDefinitions_Templates: add iccid to ts_profileInstallationResultData ...................................................................... RSPDefinitions_Templates: add iccid to ts_profileInstallationResultData In the context of the ProfileInstallationResultData the iccid plays a major role as profile identifier, so we should not omit it in ts_profileInstallationResultData. Related: SYS#6824 Change-Id: I7f16b490aadf17cb56eaa42a75d99cc781488a2e --- M library/euicc/RSPDefinitions_Templates.ttcn 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/euicc/RSPDefinitions_Templates.ttcn b/library/euicc/RSPDefinitions_Templates.ttcn index fc87ff6..0746c48 100644 --- a/library/euicc/RSPDefinitions_Templates.ttcn +++ b/library/euicc/RSPDefinitions_Templates.ttcn @@ -229,7 +229,7 @@ seqNumber := 1234, profileManagementOperation := '01'B, /* is this correct? (notificationInstall) */ notificationAddress := "smdp.example.com", - iccid := omit + iccid := '123456789ABCDEFFAAAA'O }, smdpOid := id_rsp, /* random OBJECT IDENTIFIER for testing */ finalResult := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7f16b490aadf17cb56eaa42a75d99cc781488a2e Gerrit-Change-Number: 36917 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: RSPDefinitions_Templates: remove template/code dup

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36918?usp=email ) Change subject: RSPDefinitions_Templates: remove template/code dup ...................................................................... RSPDefinitions_Templates: remove template/code dup We can use ts_profileInstallationResultData in ts_retrieveNotificationsListResponse. Related: SYS#6824 Change-Id: I2dca9500572141642cc76ecacb3b2a6ed2cbfaad --- M library/euicc/RSPDefinitions_Templates.ttcn 1 file changed, 14 insertions(+), 16 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/library/euicc/RSPDefinitions_Templates.ttcn b/library/euicc/RSPDefinitions_Templates.ttcn index 0746c48..4791cf5 100644 --- a/library/euicc/RSPDefinitions_Templates.ttcn +++ b/library/euicc/RSPDefinitions_Templates.ttcn @@ -563,22 +563,7 @@ notificationList := { { profileInstallationResult := { - profileInstallationResultData := { - transactionId := 'AABBCC'O, - notificationMetadata := { - seqNumber := 1234, - profileManagementOperation := '01'B, /* is this correct? (notificationInstall) */ - notificationAddress := "smdp.example.com", - iccid := omit - }, - smdpOid := id_rsp, /* random OBJECT IDENTIFIER for testing */ - finalResult := { - successResult := { - aid := 'A0000005591010FFFFFFFF8900000D00'O, - simaResponse := 'AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA'O - } - } - }, + profileInstallationResultData := ts_profileInstallationResultData, euiccSignPIR := 'BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB'O } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36918?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2dca9500572141642cc76ecacb3b2a6ed2cbfaad Gerrit-Change-Number: 36918 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add templates for eCOs

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36919?usp=email ) Change subject: SGP32Definitions_Templates: add templates for eCOs ...................................................................... SGP32Definitions_Templates: add templates for eCOs We do not have any templates for eCOs yet. This patch adds templates for all currently specified eCOs. Related: SYS#6824 Change-Id: I15d6a036b77c329e30a6f7323d511f8071683ec0 --- M library/euicc/SGP32Definitions_Templates.ttcn 1 file changed, 224 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index b1b946f..709a58f 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -408,6 +408,72 @@ } } } +template (present) EuiccPackage +tr_euiccPackage_addEim := { + ecoList := { + { + addEim := tr_eimConfigurationData + } + } +} +template (value) EuiccPackage +ts_euiccPackage_addEim := { + ecoList := { + { + addEim := ts_eimConfigurationData + } + } +} +template (present) EuiccPackage +tr_euiccPackage_deleteEim := { + ecoList := { + { + deleteEim := ? + } + } +} +template (value) EuiccPackage +ts_euiccPackage_deleteEim := { + ecoList := { + { + deleteEim := { + eimId := "eIM" + } + } + } +} +template (present) EuiccPackage +tr_euiccPackage_updateEim := { + ecoList := { + { + updateEim := tr_eimConfigurationData + } + } +} +template (value) EuiccPackage +ts_euiccPackage_updateEim := { + ecoList := { + { + updateEim := ts_eimConfigurationData + } + } +} +template (present) EuiccPackage +tr_euiccPackage_listEim := { + ecoList := { + { + listEim := { } + } + } +} +template (value) EuiccPackage +ts_euiccPackage_listEim := { + ecoList := { + { + listEim := { } + } + } +} /* GSMA SGP.32, section 6.3.2.6 */ template (present) EsipaMessageFromEimToIpa @@ -851,6 +917,151 @@ euiccSignEPR := '00112233445566778899AABBCCDDEEFF'O } } +template (present) EuiccPackageResult +tr_euiccPackageResultSigned_addEim := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := ?, + counterValue := ?, + transactionId := *, + seqNumber := ?, + euiccResult := { + { + addEimResult := ? + } + } + }, + euiccSignEPR := ? + } +} +template (value) EuiccPackageResult +ts_euiccPackageResultSigned_addEim := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := "myEIM", + counterValue := 1, + transactionId := omit, + seqNumber := 123, + euiccResult := { + { + addEimResult := { + addEimResultCode := 0 + } + } + } + }, + euiccSignEPR := '00112233445566778899AABBCCDDEEFF'O + } +} +template (present) EuiccPackageResult +tr_euiccPackageResultSigned_deleteEim := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := ?, + counterValue := ?, + transactionId := *, + seqNumber := ?, + euiccResult := { + { + deleteEimResult := ? + } + } + }, + euiccSignEPR := ? + } +} +template (value) EuiccPackageResult +ts_euiccPackageResultSigned_deleteEim := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := "myEIM", + counterValue := 1, + transactionId := omit, + seqNumber := 123, + euiccResult := { + { + deleteEimResult := 0 + } + } + }, + euiccSignEPR := '00112233445566778899AABBCCDDEEFF'O + } +} +template (present) EuiccPackageResult +tr_euiccPackageResultSigned_updateEim := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := ?, + counterValue := ?, + transactionId := *, + seqNumber := ?, + euiccResult := { + { + updateEimResult := ? + } + } + }, + euiccSignEPR := ? + } +} +template (value) EuiccPackageResult +ts_euiccPackageResultSigned_updateEim := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := "myEIM", + counterValue := 1, + transactionId := omit, + seqNumber := 123, + euiccResult := { + { + updateEimResult := 0 + } + } + }, + euiccSignEPR := '00112233445566778899AABBCCDDEEFF'O + } +} +template (present) EuiccPackageResult +tr_euiccPackageResultSigned_listEim := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := ?, + counterValue := ?, + transactionId := *, + seqNumber := ?, + euiccResult := { + { + listEimResult := ? + } + } + }, + euiccSignEPR := ? + } +} +template (value) EuiccPackageResult +ts_euiccPackageResultSigned_listEim := { + euiccPackageResultSigned := { + euiccPackageResultDataSigned := { + eimId := "myEIM", + counterValue := 1, + transactionId := omit, + seqNumber := 123, + euiccResult := { + { + listEimResult := { + eimIdList := { + { + eimId := "eIM", + eimIdType := omit + } + } + } + } + } + }, + euiccSignEPR := '00112233445566778899AABBCCDDEEFF'O + } +} template (present) EsipaMessageFromIpaToEim tr_provideEimPackageResult_ePRAndNotif(template (present) EuiccPackageResult euiccPackageResult := tr_euiccPackageResultSigned_enablePsmo) := { provideEimPackageResult := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36919?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I15d6a036b77c329e30a6f7323d511f8071683ec0 Gerrit-Change-Number: 36919 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024