May 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: tests/osmo-bts.vty: aligh with recent libosmovty changes

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email ) Change subject: tests/osmo-bts.vty: aligh with recent libosmovty changes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > What if I build an old osmo-bts with new libosmocore? It would build just fine and pass the unit tests, but not the vty transcript test. I am not really sure if we can fix this in the python script, or more precisely **how**. It's simply executing commands and matching the program output against the expected output. We cannot just change the script to ignore spacing, as that would break other stuff. Maybe @nhofmeyr@sysmocom.de has an idea? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I80f896e45a88550909c5767169286fc321a36e56 Gerrit-Change-Number: 36761 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 May 2024 10:23:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: Use ActionID field in Action Login

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36763?usp=email ) Change subject: asterisk: Use ActionID field in Action Login ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iec320762ff0cca86319f7374b53c642f08a6e6df Gerrit-Change-Number: 36763 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 May 2024 08:37:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: AMI_Functions: Tx ActionID instead of ActionId

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36762?usp=email ) Change subject: AMI_Functions: Tx ActionID instead of ActionId ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36762?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8097e461fd0cadfa780d52ab1666e41b9d2b8a0e Gerrit-Change-Number: 36762 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 May 2024 08:36:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: AMI_Function: Match field keys in case insensitive way

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36758?usp=email ) Change subject: AMI_Function: Match field keys in case insensitive way ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File asterisk/AMI_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36758/comment/38890a4f_dd53… PS1, Line 89: tr_AMI_Field_ActionId(template (present) charstring val := ?) := tr_AMI_Field(AMI_FIELD_ACTION_ID, val); > This seems to be working afaict, thanks, I'll submit a new patch version soon. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36758?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9080f617c4e7272b9dd67d616069ac9350411f3c Gerrit-Change-Number: 36758 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 May 2024 08:36:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Emulation: Handle SIP REGISTER from peer

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36757?usp=email ) Change subject: SIP_Emulation: Handle SIP REGISTER from peer ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36757?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49dfe54434113eb8b75306a3a8ddda940fa14743 Gerrit-Change-Number: 36757 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 May 2024 08:35:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Implement AMI_Adapter using IPL4 instead of TELNET

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email ) Change subject: asterisk: Implement AMI_Adapter using IPL4 instead of TELNET ...................................................................... Patch Set 3: (2 comments) File asterisk/AMI_Functions.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755/comment/931c0bd2_5625… PS3, Line 260: /* TEXT Enc/dec is not happy with values containing "; ", get rid of them: : * "AppData: 5,0502: Call pjsip endpoint from 0501\r\n" */ : var integer pos := f_strstr(patched_txt, "AppData: ", 0); : if (pos >= 0) { : var integer pos_end := f_strstr(patched_txt, "\r\n", pos) + lengthof("\r\n"); : var charstring to_remove := substr(patched_txt, pos, pos_end - pos); : patched_txt := f_str_replace(patched_txt, to_remove, ""); : } I don't understand what this does. The comment mentions "; ", but it is not in the example in the comment or code below. From the code it seems more like removing \r\n in a string that looks like "Appdata:\r\nvalue-of-appdata-here\r\n"? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755/comment/eb409d8a_e3c6… PS3, Line 480: log("AMI_Msg decoded: ", msg); add some sort of assert / check at the end, that the decode lead to the expected result? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36755?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icaf2860c1dd4befa4498f0d176cfadf26cfa8d1d Gerrit-Change-Number: 36755 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 May 2024 08:33:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: Misc_Helpers.ttcn: Add some more string handling API helpers

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36754?usp=email ) Change subject: Misc_Helpers.ttcn: Add some more string handling API helpers ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36754?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d6da125a10807b7a2f3ecad8145a046a322c7d6 Gerrit-Change-Number: 36754 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 May 2024 08:15:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: tests/osmo-bts.vty: aligh with recent libosmovty changes

by osmith

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email ) Change subject: tests/osmo-bts.vty: aligh with recent libosmovty changes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36761?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I80f896e45a88550909c5767169286fc321a36e56 Gerrit-Change-Number: 36761 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 May 2024 08:08:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in libosmo-netif[master]: contrib: remove rpm spec file

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36725?usp=email ) Change subject: contrib: remove rpm spec file ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I think this is used by libosmo-sccp/osmo-stp, which we need to maintain? see https://gerrit.osmocom.org/c/libosmo-sccp/+/36727/comments/4284a8e4_6d259ddf -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Iff549b7695512c76514ed8915c4807c455e2bdcc Gerrit-Change-Number: 36725 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 10 May 2024 07:55:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-hnodeb[master]: contrib: remove rpm spec file

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/36740?usp=email ) Change subject: contrib: remove rpm spec file ...................................................................... contrib: remove rpm spec file Related: https://osmocom.org/news/255 Related: OS#6446 Change-Id: Idd67d52ca736c4e145387ea8d4030f9cf4b9596d --- M Makefile.am M configure.ac D contrib/osmo-hnodeb.spec.in 3 files changed, 11 insertions(+), 114 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Makefile.am b/Makefile.am index 3fdc737..2168ff0 100644 --- a/Makefile.am +++ b/Makefile.am @@ -19,7 +19,6 @@ BUILT_SOURCES = $(top_srcdir)/.version EXTRA_DIST = \ .version \ - contrib/osmo-hnodeb.spec.in \ debian \ git-version-gen \ osmoappdesc.py \ diff --git a/configure.ac b/configure.ac index 685e6b2..b603e5e 100644 --- a/configure.ac +++ b/configure.ac @@ -226,5 +226,4 @@ doc/manuals/Makefile contrib/Makefile contrib/systemd/Makefile - contrib/osmo-hnodeb.spec Makefile) diff --git a/contrib/osmo-hnodeb.spec.in b/contrib/osmo-hnodeb.spec.in deleted file mode 100644 index e28340e..0000000 --- a/contrib/osmo-hnodeb.spec.in +++ /dev/null @@ -1,112 +0,0 @@ -# -# spec file for package osmo-hnodeb -# -# Copyright (c) 2017, Martin Hauke <mardnh(a)gmx.de> -# -# All modifications and additions to the file contributed by third parties -# remain the property of their copyright owners, unless otherwise agreed -# upon. The license for this file, and modifications and additions to the -# file, is the same license as for the pristine package itself (unless the -# license for the pristine package is not an Open Source License, in which -# case the license is the MIT License). An "Open Source License" is a -# license that conforms to the Open Source Definition (Version 1.9) -# published by the Open Source Initiative. - -## Disable LTO for now since it breaks compilation of the tests -## https://osmocom.org/issues/4113 -%define _lto_cflags %{nil} - -Name: osmo-hnodeb -Version: @VERSION@ -Release: 0 -Summary: Osmohnodeb: Osmocom's Base Station Controller for 2G CS mobile networks -License: AGPL-3.0-or-later AND GPL-2.0-or-later -Group: Hardware/Mobile -URL: https://osmocom.org/projects/osmohnodeb -Source: %{name}-%{version}.tar.xz -BuildRequires: autoconf-archive -BuildRequires: automake >= 1.9 -BuildRequires: libtool >= 2 -BuildRequires: lksctp-tools-devel -BuildRequires: pkgconfig >= 0.20 -%if 0%{?suse_version} -BuildRequires: systemd-rpm-macros -%endif -BuildRequires: pkgconfig(libcrypto) >= 0.9.5 -BuildRequires: pkgconfig(libosmo-netif) >= 1.4.0 -BuildRequires: pkgconfig(libosmo-sigtran) >= 1.8.0 -BuildRequires: pkgconfig(libosmoabis) >= 1.5.0 -BuildRequires: pkgconfig(libosmotrau) >= 1.5.0 -BuildRequires: pkgconfig(libosmocore) >= 1.9.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.9.0 -BuildRequires: pkgconfig(libosmogb) >= 1.9.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.9.0 -BuildRequires: pkgconfig(libosmovty) >= 1.9.0 -BuildRequires: pkgconfig(libosmo-hnbap) >= 1.5.0 -BuildRequires: pkgconfig(libosmo-ranap) >= 1.5.0 -BuildRequires: pkgconfig(libosmo-rua) >= 1.5.0 -BuildRequires: pkgconfig(talloc) -BuildRequires: pkgconfig(libasn1c) >= 0.9.30 -%{?systemd_requires} - -%description -OsmoHNodeB: Osmocom's Home NodeB for 3G mobile networks. - -%prep -%setup -q - -%build -echo "%{version}" >.tarball-version -autoreconf -fi -%configure \ - --docdir=%{_docdir}/%{name} \ - --with-systemdsystemunitdir=%{_unitdir} -make %{?_smp_mflags} - -%install -%make_install - -%preun -%if 0%{?suse_version} -%service_del_preun %{name}.service -%endif - -%postun -%if 0%{?suse_version} -%service_del_postun %{name}.service -%endif - -%pre -getent group osmocom >/dev/null || groupadd --system osmocom -getent passwd osmocom >/dev/null || useradd --system --gid osmocom --home-dir /var/lib/osmocom \ - --shell /sbin/nologin --comment "Open Source Mobile Communications" osmocom -%if 0%{?suse_version} -%service_add_pre %{name}.service -%endif - -%post -%if 0%{?suse_version} -%service_add_post %{name}.service -%endif -chown osmocom:osmocom /etc/osmocom/osmo-hnodeb.cfg -chmod 0660 /etc/osmocom/osmo-hnodeb.cfg -chown root:osmocom /etc/osmocom -chmod 2775 /etc/osmocom -mkdir -p /var/lib/osmocom -chown -R osmocom:osmocom /var/lib/osmocom - -%check -make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) - -%files -%license COPYING -%doc AUTHORS README.md -%{_bindir}/osmo-hnodeb -%dir %{_docdir}/%{name}/examples -%dir %{_docdir}/%{name}/examples/osmo-hnodeb -%{_docdir}/%{name}/examples/osmo-hnodeb/osmo-hnodeb.cfg -%dir %{_sysconfdir}/osmocom -%config(noreplace) %{_sysconfdir}/osmocom/osmo-hnodeb.cfg -%{_unitdir}/%{name}.service - -%changelog -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/36740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Idd67d52ca736c4e145387ea8d4030f9cf4b9596d Gerrit-Change-Number: 36740 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024