December 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-remsim[master]: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39044?usp=email ) Change subject: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif ...................................................................... Patch Set 2: (1 comment) This change is ready for review. Patchset: PS1: > I'm still having some weird issues with output stopping while running REMSIM_tests (server) with thi […] Tests passing now. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id9784c69f1524872053436b59712f67ad5fbfe94 Gerrit-Change-Number: 39044 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 10 Dec 2024 12:48:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: make copy= more intuitive

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39080?usp=email ) Change subject: testenv: make copy= more intuitive ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39080/comment/6e5a2321_379d… : PS1, Line 10: source file name under the target directory: copy=dir/file.cfg creates > well the problem for me to gasp was the "copy=bankd/file.cfg bankd/file. […] oh then I actually misunderstood what you meant... but I still think this is a good improvement, should make it more intuitive and makes the code simpler. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39080?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9e4ea066d0a0e72ccd83e4f6f887f382bf61e46 Gerrit-Change-Number: 39080 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 12:22:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: make copy= more intuitive

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39080?usp=email ) Change subject: testenv: make copy= more intuitive ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39080/comment/7dc0863b_c129… : PS1, Line 10: source file name under the target directory: copy=dir/file.cfg creates well the problem for me to gasp was the "copy=bankd/file.cfg bankd/file.cfg" which would end up generating "/bankd/bankd/file.cfg". What "copy=dir/file.cfg" would also be a good question, I'd perhaps expect to end up with "/dir/file.cfg" instead of "/file.cfg". But anyway I'd probably not use that syntax myself since it's confusing, so fine with whatever in this scenario. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39080?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9e4ea066d0a0e72ccd83e4f6f887f382bf61e46 Gerrit-Change-Number: 39080 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 12:20:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: make copy= more intuitive

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39080?usp=email ) Change subject: testenv: make copy= more intuitive ...................................................................... testenv: make copy= more intuitive Currently copy= in testenv.cfg creates copies of files under the full source file name under the target directory: copy=dir/file.cfg creates dir/file.cfg (like "cp -a --parents"). This is not very intuitive, change it to create a "file.cfg" instead without subdirectory. With this change, it behaves the same as "cp -a". Suggested-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Change-Id: Id9e4ea066d0a0e72ccd83e4f6f887f382bf61e46 --- M _testenv/README.md M _testenv/testenv/testdir.py M ggsn_tests/open5gs/open5gs-smf.yaml M ggsn_tests/testenv_open5gs.cfg 4 files changed, 7 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/39080/1 diff --git a/_testenv/README.md b/_testenv/README.md index bd102a8..2a08e7d 100644 --- a/_testenv/README.md +++ b/_testenv/README.md @@ -89,7 +89,7 @@ * `copy=`: optionally copy a space separated list of files or directories from the testsuite directory to the test directory, like `.cfg` and `.confmerge` - files. + files. Testenv runs `cp -a <SOURCES> <TEST DIR>` internally. * `make=`: osmo-dev make target for building from source, if running without `--binary-repo`. This is usually the name of the git repository, but could diff --git a/_testenv/testenv/testdir.py b/_testenv/testenv/testdir.py index b18efd1..2f21d23 100644 --- a/_testenv/testenv/testdir.py +++ b/_testenv/testenv/testdir.py @@ -85,19 +85,8 @@ testenv.cmd.run(["install", "-Dm644", path, path_dest]) if "copy" in section_data: - for copy_entry in section_data["copy"].split(" "): - path = os.path.join(testsuite_dir, copy_entry) - if os.path.isdir(path): - pattern = os.path.join(path, "**") - paths = glob.glob(pattern, recursive=True) - else: - paths = [path] - for path in paths: - if os.path.isdir(path): - continue - path_dest = os.path.join(section_dir, os.path.relpath(path, testsuite_dir)) - mode = 755 if os.access(path, os.X_OK) else 644 - testenv.cmd.run(["install", f"-Dm{mode}", path, path_dest]) + sources = section_data["copy"].split(" ") + testenv.cmd.run(["cp", "-a"] + sources + [section_dir], no_podman=True, cwd=testsuite_dir) # Referenced in testsuite cfgs: *.default pattern = os.path.join(testsuite_dir, "*.default") diff --git a/ggsn_tests/open5gs/open5gs-smf.yaml b/ggsn_tests/open5gs/open5gs-smf.yaml index 0e26550..2532665 100644 --- a/ggsn_tests/open5gs/open5gs-smf.yaml +++ b/ggsn_tests/open5gs/open5gs-smf.yaml @@ -46,7 +46,7 @@ mtu: 1400 ctf: enabled: auto - freeDiameter: open5gs/freediameter.conf + freeDiameter: freediameter.conf parameter: diff --git a/ggsn_tests/testenv_open5gs.cfg b/ggsn_tests/testenv_open5gs.cfg index 2d107a8..6d951f2 100644 --- a/ggsn_tests/testenv_open5gs.cfg +++ b/ggsn_tests/testenv_open5gs.cfg @@ -3,14 +3,14 @@ config=GGSN_Tests.cfg [smf] -program=open5gs-smfd -c open5gs/open5gs-smf.yaml +program=open5gs-smfd -c open5gs-smf.yaml make=open5gs package=open5gs-smf copy=open5gs/open5gs-smf.yaml open5gs/freediameter.conf [upf] -program=open5gs-upfd -c open5gs/open5gs-upf.yaml +program=open5gs-upfd -c open5gs-upf.yaml make=open5gs package=open5gs-upf copy=open5gs/open5gs-upf.yaml open5gs/testenv.sh -clean=open5gs/testenv.sh +clean=./testenv.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39080?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9e4ea066d0a0e72ccd83e4f6f887f382bf61e46 Gerrit-Change-Number: 39080 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: Service Request: expect a CommonId when stoppin...

by lynxis lazus

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38415?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: Service Request: expect a CommonId when stopping on SecurityCommand Complete ...................................................................... Abandoned Merged into a previous commit of the chain -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie81c5eb01eb695d0399770b8a7feb9b4549148b3 Gerrit-Change-Number: 38415 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack

by lynxis lazus

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email ) Change subject: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack ...................................................................... Patch Set 4: (1 comment) File library/RAW_NS.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063/comment/d66b1456_0200… : PS4, Line 512: if (isvalue(cause) and valueof(cause) == NS_CAUSE_UNKNOWN_IP_ENDPOINT) { > @vyanitskiy@sysmocom. […] the ttcn3 cheat sheet says it's only for record/unions. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c659e43db79400c1b428ed745267a5e6e59102 Gerrit-Change-Number: 39063 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 12:08:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack

by pespin

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email ) Change subject: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File library/RAW_NS.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063/comment/2e5d435d_3ccc… : PS4, Line 512: if (isvalue(cause) and valueof(cause) == NS_CAUSE_UNKNOWN_IP_ENDPOINT) { @vyanitskiy@sysmocom.de is "isvalue()" working fine here or should "ispresent()" be used? I always find confusing what each of those returns in each scenario... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c659e43db79400c1b428ed745267a5e6e59102 Gerrit-Change-Number: 39063 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 10 Dec 2024 12:06:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: SNS Add: handle NS_Alive while waiting for SNS_Ack

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39060?usp=email ) Change subject: PCU_Tests_SNS: SNS Add: handle NS_Alive while waiting for SNS_Ack ...................................................................... PCU_Tests_SNS: SNS Add: handle NS_Alive while waiting for SNS_Ack Similiar to 61ccea9ecadc ("PCU_Tests_SNS: del/change weight: don't fail on NS"), the SNS Add procedure might have to handle a NS Alive PDU in the receiving queue while waiting for a SNS ACK. Related: OS#6611 Change-Id: I10646d9acfe280ddfb8852a4d5c37882aae99874 --- M pcu/PCU_Tests_SNS.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pcu/PCU_Tests_SNS.ttcn b/pcu/PCU_Tests_SNS.ttcn index 263e205..07f147c 100644 --- a/pcu/PCU_Tests_SNS.ttcn +++ b/pcu/PCU_Tests_SNS.ttcn @@ -303,7 +303,9 @@ /* create another NS codec port on the tester side */ f_init_ns_codec(mp_nsconfig, 2); + g_handle_rx_alive := true; f_outgoing_sns_add(idx_add := 2, w_sig := 0, w_user := 1, idx := 0); + g_handle_rx_alive := false; /* wait for one ALIVE cycle, then ACK any further ALIVE in the background */ as_rx_alive_tx_ack(oneshot := true, idx := 2); @@ -316,6 +318,8 @@ /* Test adding an already present IP endpoint at runtime */ testcase TC_sns_add_nack() runs on RAW_Test_CT { + g_handle_rx_alive := true; + f_sns_bringup_1c1u(); f_outgoing_sns_add(idx_add := 0, w_sig := 0, w_user := 1, idx := 0, cause := NS_CAUSE_PROTOCOL_ERROR_UNSPECIFIED); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39060?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I10646d9acfe280ddfb8852a4d5c37882aae99874 Gerrit-Change-Number: 39060 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: f_TC_attach_usim_resync: fix IMEISV value

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39073?usp=email ) Change subject: SGSN_Tests: f_TC_attach_usim_resync: fix IMEISV value ...................................................................... SGSN_Tests: f_TC_attach_usim_resync: fix IMEISV value IMEISV is IMEI + 2 digit software version. Change-Id: I044eeccd02e2d3f891879516f5a9c003ac8f849a --- M sgsn/SGSN_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index c6c2c0a..99e53f5 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -2177,7 +2177,7 @@ if (ispresent(l3_mt.msgs.gprs_mm.authenticationAndCipheringRequest.imeisvRequest) and l3_mt.msgs.gprs_mm.authenticationAndCipheringRequest.imeisvRequest.valueField == '001'B) { l3_mo.msgs.gprs_mm.authenticationAndCipheringResponse.imeisv := - valueof(ts_MI_IMEISV_TLV(g_pars.imei & '0'H)); + valueof(ts_MI_IMEISV_TLV(g_pars.imei & '00'H)); } f_send_l3(l3_mo); deactivate(di); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39073?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I044eeccd02e2d3f891879516f5a9c003ac8f849a Gerrit-Change-Number: 39073 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: f_TC_attach_usim_resync: fix IMEISV value

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39073?usp=email ) Change subject: SGSN_Tests: f_TC_attach_usim_resync: fix IMEISV value ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: 1+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39073?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I044eeccd02e2d3f891879516f5a9c003ac8f849a Gerrit-Change-Number: 39073 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 12:03:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024