December 2024 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-abis[master]: ipaccess: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39042?usp=email ) Change subject: ipaccess: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39042?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I6164a44847fcd88d08c77f977d928c2fdf657719 Gerrit-Change-Number: 39042 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 14:20:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: tests/Makefile.am: Fix missing LIBOSMONETIF_LIBS/CFLAGS

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39081?usp=email ) Change subject: tests/Makefile.am: Fix missing LIBOSMONETIF_LIBS/CFLAGS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39081?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5b62e17deb9a6d769ddf98a5751e84d69132fecc Gerrit-Change-Number: 39081 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 14:15:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-sgsn[master]: sgsn_vty: Drop unneeded use of abis/ipa.h header

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39083?usp=email ) Change subject: sgsn_vty: Drop unneeded use of abis/ipa.h header ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39083?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I48a513b8ea63dadbc6d6d571380980f55ff04a06 Gerrit-Change-Number: 39083 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 14:13:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: Drop unneeded use of abis/ipa.h header

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39084?usp=email ) Change subject: Drop unneeded use of abis/ipa.h header ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib5b9557ff5611fd6606cd0ae6af9046e14cceda0 Gerrit-Change-Number: 39084 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 14:13:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hlr[master]: Drop unneeded use of abis/ipa.h header

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39085?usp=email ) Change subject: Drop unneeded use of abis/ipa.h header ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39085?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I72d0787d4f5641a6a2fbe51427ac490120cbc616 Gerrit-Change-Number: 39085 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 14:13:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email ) Change subject: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File library/RAW_NS.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063/comment/1695852d_ab2d… : PS4, Line 512: if (isvalue(cause) and valueof(cause) == NS_CAUSE_UNKNOWN_IP_ENDPOINT) { > the ttcn3 cheat sheet says it's only for record/unions. `ispresent()` is suitable for matching templates that can be `?`/`*`, but here `cause` is restricted to `(omit)` (a value or `omit`), so `isvalue()` is fine here. You could also do it like this: `match(cause, NS_CAUSE_UNKNOWN_IP_ENDPOINT)`, but I am fine either way. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c659e43db79400c1b428ed745267a5e6e59102 Gerrit-Change-Number: 39063 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 10 Dec 2024 14:11:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hlr[master]: Drop unneeded use of abis/ipa.h header

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39085?usp=email ) Change subject: Drop unneeded use of abis/ipa.h header ...................................................................... Drop unneeded use of abis/ipa.h header Direct include of abis/ipa.h is not needed there, remove it to ease later deprecation of such header. Change-Id: I72d0787d4f5641a6a2fbe51427ac490120cbc616 --- M src/remote_hlr.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/85/39085/1 diff --git a/src/remote_hlr.c b/src/remote_hlr.c index 93157a3..f80f460 100644 --- a/src/remote_hlr.c +++ b/src/remote_hlr.c @@ -20,7 +20,7 @@ #include <osmocom/gsm/protocol/gsm_04_08_gprs.h> #include <osmocom/gsm/gsup.h> #include <osmocom/gsm/gsm23003.h> -#include <osmocom/abis/ipa.h> +#include <osmocom/gsm/ipa.h> #include <osmocom/gsupclient/gsup_client.h> #include <osmocom/hlr/logging.h> #include <osmocom/hlr/hlr.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39085?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I72d0787d4f5641a6a2fbe51427ac490120cbc616 Gerrit-Change-Number: 39085 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: Drop unneeded use of abis/ipa.h header

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39084?usp=email ) Change subject: Drop unneeded use of abis/ipa.h header ...................................................................... Drop unneeded use of abis/ipa.h header The header is not needed and will eventually be deprecated. Change-Id: Ib5b9557ff5611fd6606cd0ae6af9046e14cceda0 --- M src/ipaccess/ipaccess-config-e1-driver.c M src/ipaccess/ipaccess-proxy.c M src/osmo-bsc/osmo_bsc_msc.c 3 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/39084/1 diff --git a/src/ipaccess/ipaccess-config-e1-driver.c b/src/ipaccess/ipaccess-config-e1-driver.c index 71e70e1..17a5dde 100644 --- a/src/ipaccess/ipaccess-config-e1-driver.c +++ b/src/ipaccess/ipaccess-config-e1-driver.c @@ -52,7 +52,6 @@ #include <osmocom/netif/stream.h> #include <osmocom/netif/ipa.h> #include <osmocom/abis/e1_input.h> -#include <osmocom/abis/ipa.h> /* default port at BTS for incoming connections */ #define IPACCESS_BTS_LISTEN_OML_PORT 3006 diff --git a/src/ipaccess/ipaccess-proxy.c b/src/ipaccess/ipaccess-proxy.c index e659708..61c2fc2 100644 --- a/src/ipaccess/ipaccess-proxy.c +++ b/src/ipaccess/ipaccess-proxy.c @@ -45,7 +45,6 @@ #include <osmocom/gsm/tlv.h> #include <osmocom/gsm/protocol/ipaccess.h> #include <osmocom/gsm/ipa.h> -#include <osmocom/abis/ipa.h> #include <osmocom/bsc/gsm_data.h> #include <osmocom/bsc/debug.h> #include <osmocom/bsc/ipaccess.h> diff --git a/src/osmo-bsc/osmo_bsc_msc.c b/src/osmo-bsc/osmo_bsc_msc.c index f062533..6ce2ded 100644 --- a/src/osmo-bsc/osmo_bsc_msc.c +++ b/src/osmo-bsc/osmo_bsc_msc.c @@ -37,8 +37,6 @@ #include <osmocom/gsm/gsm0808.h> #include <osmocom/gsm/gsm23236.h> -#include <osmocom/abis/ipa.h> - #include <osmocom/mgcp_client/mgcp_client.h> #include <osmocom/mgcp_client/mgcp_client_pool.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib5b9557ff5611fd6606cd0ae6af9046e14cceda0 Gerrit-Change-Number: 39084 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[L] Change in libosmo-abis[master]: Drop ipa_proxy

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39082?usp=email ) Change subject: Drop ipa_proxy ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This may actually be some sort of copy/variant of osmo-bsc.git/src/ipaccess/ipaccess-proxy.c ? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39082?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7fbc3ad7277369d21cf31159407ef6672ebdf64f Gerrit-Change-Number: 39082 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 10 Dec 2024 13:40:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-sgsn[master]: sgsn_vty: Drop unneeded use of abis/ipa.h header

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39083?usp=email ) Change subject: sgsn_vty: Drop unneeded use of abis/ipa.h header ...................................................................... sgsn_vty: Drop unneeded use of abis/ipa.h header The header is not needed and will eventually be deprecated. Change-Id: I48a513b8ea63dadbc6d6d571380980f55ff04a06 --- M src/sgsn/sgsn_vty.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/83/39083/1 diff --git a/src/sgsn/sgsn_vty.c b/src/sgsn/sgsn_vty.c index 2cb8819..1a104b3 100644 --- a/src/sgsn/sgsn_vty.c +++ b/src/sgsn/sgsn_vty.c @@ -54,7 +54,6 @@ #include <osmocom/vty/misc.h> #include <osmocom/crypt/gprs_cipher.h> #include <osmocom/crypt/utran_cipher.h> -#include <osmocom/abis/ipa.h> #include <osmocom/gprs/gprs_bssgp.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39083?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I48a513b8ea63dadbc6d6d571380980f55ff04a06 Gerrit-Change-Number: 39083 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024