November 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Add test TC_ps_rab_assignment_concurrent

by pespin

Attention is currently required from: fixeria, laforge, osmith. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38676?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Code-Review+2 by fixeria, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: hnbgw: Add test TC_ps_rab_assignment_concurrent ...................................................................... hnbgw: Add test TC_ps_rab_assignment_concurrent Related: SYS#6602 Change-Id: I053950373cec93ed8dbdfd6b8a71ffe31de3806f --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/expected-results.xml 2 files changed, 32 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/76/38676/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38676?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I053950373cec93ed8dbdfd6b8a71ffe31de3806f Gerrit-Change-Number: 38676 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Parametrize MgcpParameters MGCP endpoint

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38677?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: hnbgw: Parametrize MgcpParameters MGCP endpoint ...................................................................... hnbgw: Parametrize MgcpParameters MGCP endpoint This will be needed if we want to run several CS RAB ConnHdlrs in parallel. Change-Id: I4bb28dea22a6ea5b415d6ca16bde61b835d435bc --- M hnbgw/ConnHdlr.ttcn M hnbgw/HNBGW_Tests.ttcn 2 files changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/38677/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4bb28dea22a6ea5b415d6ca16bde61b835d435bc Gerrit-Change-Number: 38677 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: mgcp: Support running CS RAB ConnHdlr concurrently

by pespin

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38678?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: hnbgw: mgcp: Support running CS RAB ConnHdlr concurrently ...................................................................... hnbgw: mgcp: Support running CS RAB ConnHdlr concurrently Use Mutex to serialize CRCX wildcard endpoint, in order to be able to properly steer the message to the good ConnHdlr. Change-Id: Ibd97a37d98abfa746b58db0ea8bb591e7c8dc638 --- M hnbgw/ConnHdlr.ttcn M hnbgw/HNBGW_Tests.ttcn 2 files changed, 14 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/38678/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38678?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibd97a37d98abfa746b58db0ea8bb591e7c8dc638 Gerrit-Change-Number: 38678 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_rab_assignment_concurrent

by pespin

Attention is currently required from: fixeria, laforge, osmith. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38679?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: hnbgw: Introduce test TC_rab_assignment_concurrent ...................................................................... hnbgw: Introduce test TC_rab_assignment_concurrent Related: SYS#6602 Change-Id: I1f717edbe4a758288d017861c4b77836c5811040 --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/expected-results.xml 2 files changed, 44 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/38679/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38679?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1f717edbe4a758288d017861c4b77836c5811040 Gerrit-Change-Number: 38679 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: RUA_Emulation: Add missing msg component destination

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38680?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: RUA_Emulation: Add missing msg component destination ...................................................................... RUA_Emulation: Add missing msg component destination Seen while running lots of components concurrently: "RUA_Emulation.ttcn:315 Dynamic test case error: Port CLIENT has more than one active connections. Message can be sent on it only with explicit addressing." Change-Id: Ief257969a451f2d11ad7619fb97af16d7dd7e199 --- M library/rua/RUA_Emulation.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/38680/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38680?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ief257969a451f2d11ad7619fb97af16d7dd7e199 Gerrit-Change-Number: 38680 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_rab_assignment_concurrent

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38679?usp=email ) Change subject: hnbgw: Introduce test TC_rab_assignment_concurrent ...................................................................... Patch Set 1: (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38679/comment/2cb4ca1d_3ce7… : PS1, Line 1059: private > is this a related change? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38679?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1f717edbe4a758288d017861c4b77836c5811040 Gerrit-Change-Number: 38679 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Nov 2024 15:12:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: mgcp: Support running CS RAB ConnHdlr concurrently

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38678?usp=email ) Change subject: hnbgw: mgcp: Support running CS RAB ConnHdlr concurrently ...................................................................... Patch Set 1: (3 comments) File hnbgw/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38678/comment/64d82ac5_a62c… : PS1, Line 691: with > which? Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38678/comment/1e4df836_55d2… : PS1, Line 691: S1AP > likewise, `s/S1AP/RANAP/`? Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38678/comment/680e72de_e479… : PS1, Line 693: PFCP session establishment > copy-pasted Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38678?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibd97a37d98abfa746b58db0ea8bb591e7c8dc638 Gerrit-Change-Number: 38678 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Nov 2024 15:07:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Add test TC_ps_rab_assignment_concurrent

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38676?usp=email ) Change subject: hnbgw: Add test TC_ps_rab_assignment_concurrent ...................................................................... Patch Set 1: (2 comments) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38676/comment/2903ba12_c138… : PS1, Line 1523: vc_conn_list := vc_conn_list & { vc_conn }; > BTW, you can just do `vc_conn_list[i] := vc_conn;` -- this works fine. Thanks didn't know. Still I prefer this way, looks safer in my brain :D https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38676/comment/615222ff_2c32… : PS1, Line 1527: vc_conn_list[i].done; > Maybe add `f_ConnHdlrList_all_done()` like we did in S1GW_Tests? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38676?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I053950373cec93ed8dbdfd6b8a71ffe31de3806f Gerrit-Change-Number: 38676 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Nov 2024 15:05:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: with-pfcp: Support running ConnHdlr concurrently

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38674?usp=email ) Change subject: hnbgw: with-pfcp: Support running ConnHdlr concurrently ...................................................................... Patch Set 1: (1 comment) File hnbgw/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38674/comment/f46b9853_6f5b… : PS1, Line 782: S1AP > hey, there's no S1AP in HNBGW ;) RANAP I guess? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie19ee0bd1b811e9381e3c245a4b1208de8afcbce Gerrit-Change-Number: 38674 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Nov 2024 15:01:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hlr: refactor f_SS_expect()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email ) Change subject: hlr: refactor f_SS_expect() ...................................................................... hlr: refactor f_SS_expect() Prepare for follow-up patches reworking SS related GSUP templates. Avoid passing "omit" for parameter 'ss' of the receive templates because this will no longer work as expected. Clean up code flow. Change-Id: I162a79e3c7ff9dafb031e3da8a78af313534cac7 --- M hlr/HLR_Tests.ttcn 1 file changed, 37 insertions(+), 35 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn index 46b98c2..45a8fb3 100644 --- a/hlr/HLR_Tests.ttcn +++ b/hlr/HLR_Tests.ttcn @@ -716,45 +716,20 @@ template SS_FacilityInformation facility := *, template octetstring destination_name := omit) runs on HLR_ConnHdlr return GSUP_PDU { - var GSUP_PDU ret; + var GSUP_IeValue ie; + var GSUP_PDU pdu; timer T := 3.0; - var boolean exp_ss := true; - if (istemplatekind(facility, "omit")) { - exp_ss := false; - } + T.start; alt { - [] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?, ?)) -> value ret { - setverdict(fail, "Unexpected PROC_SS ERROR Cause"); + [] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?, ?)) -> value pdu { + setverdict(fail, "Unexpected PROC_SS ERROR: ", pdu); mtc.stop; } - [not exp_ss] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, omit, destination_name := destination_name)) -> value ret { - setverdict(pass); - } - [exp_ss] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, omit)) -> value ret { - setverdict(fail, "Unexpected PROC_SS.res without SS IE"); - mtc.stop; - } -/* - [exp_ss] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, decmatch facility, destination_name := destination_name)) -> value ret { - setverdict(pass); - } -*/ - - [exp_ss] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, ?, destination_name := destination_name)) -> value ret { - var GSUP_IeValue ss_ie; - f_gsup_find_ie(ret, OSMO_GSUP_SS_INFO_IE, ss_ie); - var SS_FacilityInformation dec_fac := dec_SS_FacilityInformation(ss_ie.ss_info); - log("pattern: ", facility); - if (match(dec_fac, facility)) { - setverdict(pass); - } else { - setverdict(fail, "Unexpected PROC_SS.res with non-matching facility IE"); - mtc.stop; - } - } - [] GSUP.receive { - setverdict(fail, "Unexpected GSUP"); + [] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, + destination_name := destination_name)) -> value pdu; + [] GSUP.receive(GSUP_PDU:?) -> value pdu { + setverdict(fail, "Unexpected GSUP PDU: ", pdu); mtc.stop; } [] T.timeout { @@ -763,7 +738,34 @@ } } - return ret; + /* case a) SS Info can be any value or not present */ + if (istemplatekind(facility, "*")) { + return pdu; /* skip the remaining SS Info checks */ + } + + /* case b) SS Info shall *not* be present */ + if (istemplatekind(facility, "omit")) { + if (f_gsup_find_ie(pdu, OSMO_GSUP_SS_INFO_IE, ie)) { + setverdict(fail, "Unexpected PROC_SS.res with SS Info IE"); + mtc.stop; + } + return pdu; /* skip the remaining SS Info checks */ + } + + /* case c) SS Info shall be present */ + if (not f_gsup_find_ie(pdu, OSMO_GSUP_SS_INFO_IE, ie)) { + setverdict(fail, "Unexpected PROC_SS.res without SS Info IE"); + mtc.stop; + } + + var SS_FacilityInformation dec_fac := dec_SS_FacilityInformation(ie.ss_info); + if (not match(dec_fac, facility)) { + setverdict(fail, "Unexpected PROC_SS.res with non-matching facility IE"); + mtc.stop; + } + + setverdict(pass); + return pdu; } function f_perform_CHECK_IMEI(hexstring imsi, hexstring imei, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I162a79e3c7ff9dafb031e3da8a78af313534cac7 Gerrit-Change-Number: 38671 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024