January 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: pseudotalloc: add talloc_memdup(), use it in talloc_strdup()

by neels

Attention is currently required from: fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35467?usp=email ) Change subject: pseudotalloc: add talloc_memdup(), use it in talloc_strdup() ...................................................................... Patch Set 4: (1 comment) File src/pseudotalloc/pseudotalloc.c: https://gerrit.osmocom.org/c/libosmocore/+/35467/comment/92493437_bca0d7cb PS4, Line 61: (should it check for size == 0? ... seems talloc_size() happily allocates a talloc hdr with zero payload size) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35467?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifcf377c3496a9e75404932a1aaba7d74888cf4cf Gerrit-Change-Number: 35467 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jan 2024 17:03:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in libosmocore[master]: core: osmo_tdef_fsm_inst_state_chg(): allow millisecond precision

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35466?usp=email ) Change subject: core: osmo_tdef_fsm_inst_state_chg(): allow millisecond precision ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: should we immediately improve to full microsecond granularity, as in not repeat the earlier mistake? File src/core/tdef.c: https://gerrit.osmocom.org/c/libosmocore/+/35466/comment/7903d0fc_8fdb90ee PS4, Line 347: val = osmo_tdef_get(tdefs, t->T, OSMO_TDEF_S, default_timeout); IIRC osmo_tdef_get(..., OSMO_TDEF_MS, ...) should do exactly what is intended here. why is the condition necessary / which corner case fails? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35466?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4c4ee89e7e32e86f74cd215f5cbfa44ace5426c1 Gerrit-Change-Number: 35466 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jan 2024 16:56:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in libosmocore[master]: tests/tdef: also test OSMO_TDEF_US and negative T values

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35465?usp=email ) Change subject: tests/tdef: also test OSMO_TDEF_US and negative T values ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > (what was the motivation? did you suspect a bug somewhere?) Well, I needed to pick a new T-value for testing `OSMO_TDEF_US` and thought it would be a good idea to use a negative value, killing two birds with one stone: testing handling of `OSMO_TDEF_US` and X-timers. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35465?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I09945d277a5ec94985900a3f39f1cbb54c8ed6ff Gerrit-Change-Number: 35465 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jan 2024 16:51:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in libosmocore[master]: tests/tdef: also test OSMO_TDEF_US and negative T values

by neels

Attention is currently required from: fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35465?usp=email ) Change subject: tests/tdef: also test OSMO_TDEF_US and negative T values ...................................................................... Patch Set 2: (1 comment) File tests/tdef/tdef_test.ok: https://gerrit.osmocom.org/c/libosmocore/+/35465/comment/b9dc5d57_c3d63951 PS1, Line 27: T-5=100ms > T-5 and X5 are not different timers, they are not mapped. They are exactly identical. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35465?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I09945d277a5ec94985900a3f39f1cbb54c8ed6ff Gerrit-Change-Number: 35465 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jan 2024 16:42:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in libosmocore[master]: tests/tdef: also test OSMO_TDEF_US and negative T values

by neels

Attention is currently required from: fixeria, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35465?usp=email ) Change subject: tests/tdef: also test OSMO_TDEF_US and negative T values ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Patchset: PS2: (what was the motivation? did you suspect a bug somewhere?) File tests/tdef/tdef_test.ok: https://gerrit.osmocom.org/c/libosmocore/+/35465/comment/dc05c0ca_56542cbd PS1, Line 27: T-5=100ms > It's just the test logic not printing negative timers as X. […] T-5 and X5 are not different timers, they are not mapped. They are exactly identical. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35465?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I09945d277a5ec94985900a3f39f1cbb54c8ed6ff Gerrit-Change-Number: 35465 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Jan 2024 16:42:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in docker-playground[master]: mme: Use LAC from SGSN with most significat bit set to 0

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35432?usp=email ) Change subject: mme: Use LAC from SGSN with most significat bit set to 0 ...................................................................... mme: Use LAC from SGSN with most significat bit set to 0 Adapt to the new default value used by ttcn3 tests. Depends: osmo-ttcn3-hacks.git Change-Id Iaf89228f6f026e04d5f583211959025e6d8d4a1d Change-Id: Ifefbd9bf2ed1bce8089e3dc4c6f9fe901e72308e --- M ttcn3-mme-test-ogs/ogs/open5gs-mme-latest.yaml M ttcn3-mme-test-ogs/ogs/open5gs-mme-master.yaml 2 files changed, 14 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ttcn3-mme-test-ogs/ogs/open5gs-mme-latest.yaml b/ttcn3-mme-test-ogs/ogs/open5gs-mme-latest.yaml index 13247cd..af5d96e 100644 --- a/ttcn3-mme-test-ogs/ogs/open5gs-mme-latest.yaml +++ b/ttcn3-mme-test-ogs/ogs/open5gs-mme-latest.yaml @@ -51,7 +51,7 @@ plmn_id: mcc: 262 mnc: 42 - lac: 43690 + lac: 39594 rac: 187 ci: 1223 diff --git a/ttcn3-mme-test-ogs/ogs/open5gs-mme-master.yaml b/ttcn3-mme-test-ogs/ogs/open5gs-mme-master.yaml index 2ce3d0c..66c9b66 100644 --- a/ttcn3-mme-test-ogs/ogs/open5gs-mme-master.yaml +++ b/ttcn3-mme-test-ogs/ogs/open5gs-mme-master.yaml @@ -31,7 +31,7 @@ plmn_id: mcc: 262 mnc: 42 - lac: 43690 + lac: 39594 rac: 187 ci: 1223 metrics: -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35432?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ifefbd9bf2ed1bce8089e3dc4c6f9fe901e72308e Gerrit-Change-Number: 35432 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: mme: Trigger last parts of procedure TC_ue_cell_reselect_eutran_to_geran

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413?usp=email ) Change subject: mme: Trigger last parts of procedure TC_ue_cell_reselect_eutran_to_geran ...................................................................... mme: Trigger last parts of procedure TC_ue_cell_reselect_eutran_to_geran Some later parts of the 4G->2G cell reselection where missing, mostly related to tear down after MS has successfuly moved to the new SGSN. mainly: - S6a Diameter Cancel Location Req + Answer initiated by HSS. - Handle UeReleaseContextCommand and answer with UeReleaseContextComplete, emulating the ENB. - handle S11 GTPv2C Delete Session Request and answer with Delete Session Response, emulating the SGW. Change-Id: Ic0263a3aec922194aad22b031b2c82a99954354d --- M mme/MME_Tests.ttcn 1 file changed, 135 insertions(+), 34 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 3d081ba..339f121 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -178,6 +178,9 @@ /* S6 interface */ charstring mp_s6_local_ip := "127.0.0.4"; integer mp_s6_local_port := 3868; + charstring mp_s6_diam_realm := "localdomain"; + charstring mp_s6_local_diam_host := "hss.localdomain"; + charstring mp_s6_remote_diam_host := "mme.localdomain"; /* SGs interface */ charstring mp_sgs_local_ip := "127.0.0.1"; @@ -643,6 +646,30 @@ } } +private altstep as_s1ap_handle_UeContextReleaseCmd(template S1AP_IEs.Cause cause := ?) runs on ConnHdlr { + var S1AP_PDU rx_msg; + var PDU_NAS_EPS rx_nas; + [] S1AP.receive(tr_S1AP_UeContextReleaseCmd(?, cause)) -> value rx_msg { + var template MME_UE_S1AP_ID mme_ue_id; + var template ENB_UE_S1AP_ID enb_ue_id; + if (not ispresent(rx_msg.initiatingMessage.value_.uEContextReleaseCommand.protocolIEs[0].value_.uE_S1AP_IDs.uE_S1AP_ID_pair)) { + /* TODO: The UE CONTEXT RELEASE COMMAND (see also: 3GPP TS 36.413, section 9.1.4.6), may identify the + * context by either an uE_S1AP_ID_pair (MME_UE_S1AP_ID and ENB_UE_S1AP_ID) or an MME_UE_S1AP_ID alone. + * The latter case is not implemented here yet. */ + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("complete implementation of UeContextReleaseCmd handling")); + return; + } + + mme_ue_id := rx_msg.initiatingMessage.value_.uEContextReleaseCommand.protocolIEs[0].value_.uE_S1AP_IDs.uE_S1AP_ID_pair.mME_UE_S1AP_ID; + enb_ue_id := rx_msg.initiatingMessage.value_.uEContextReleaseCommand.protocolIEs[0].value_.uE_S1AP_IDs.uE_S1AP_ID_pair.eNB_UE_S1AP_ID; + + S1AP.send(ts_S1AP_UeContextReleaseCompl(mme_ue_id, enb_ue_id)); + } + [] S1AP.receive(PDU_NAS_EPS:?) -> value rx_nas { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Rx Unexpected NAS PDU msg: ", rx_nas)); + } +} + /* Exepect AuthInfoReq (AIR) from HSS; respond with AuthInforAnswer (AIA) */ private altstep as_DIA_AuthInfo() runs on ConnHdlr { var PDU_DIAMETER rx_dia; @@ -698,6 +725,33 @@ } } +private function f_DIA_CancelLocation(integer idx := 0, template S1AP_IEs.Cause cause := omit) runs on ConnHdlr { + + var UINT32 hbh_id := f_rnd_octstring(4); + var UINT32 ete_id := f_rnd_octstring(4); + var PDU_DIAMETER rx_dia; + + /* Unlike CLR, CLA contains no IMSI. Register ete_id in DIAMETER_Emulation, + * so AIA is forwarded back to us in DIAMETER port instead of MTC_CT.DIAMETER_UNIT. + */ + f_diameter_expect_eteid(ete_id); + + DIAMETER.send(ts_DIA_CLR(g_pars.ue_pars.imsi, SGSN_UPDATE_PROCEDURE, + orig_host := mp_s6_local_diam_host, + orig_realm := mp_s6_diam_realm, + dest_host := mp_s6_remote_diam_host, + dest_realm := mp_s6_diam_realm, + hbh_id := hbh_id, + ete_id := ete_id)); + + alt { + [] DIAMETER.receive(tr_DIA_CLA) -> value rx_dia {} + [] DIAMETER.receive(PDU_DIAMETER:?) -> value rx_dia { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected Diameter S6b msg rx: ", rx_dia)); + } + } +} + private altstep as_GTP2C_CreateSession_success() runs on ConnHdlr { var PDU_GTPCv2 rx_msg; var BearerContextIEs rx_bctx_ies; @@ -781,6 +835,57 @@ } } +private altstep as_GTP2C_DeleteSession_success() runs on ConnHdlr { + var PDU_GTPCv2 rx_msg; + + [] GTP2.receive(tr_GTP2C_DeleteSessionReq(g_pars.ue_pars.s11_teic_local)) -> value rx_msg { + GTP2.send(ts_GTP2C_DeleteSessionResp(g_pars.ue_pars.s11_teic_remote, + rx_msg.sequenceNumber, + Request_accepted)); + setverdict(pass); + } + [] GTP2.receive { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Unexpected GTPv2/S11 message from MME")); + } +} + +private function f_gtp_sgsn_context_4g_to_2g(OCT4 new_sgsn_local_teid := '12345678'O) runs on ConnHdlr { + var template (value) GTPC_PDUs SGSNContextReqPDU; + var RoutingAreaIdentity rai; + var OCT4 ptmsi; + var OCT3 ptmsi_sig; + var Gtp1cUnitdata gtpc_pdu; + var OCT4 old_mme_local_teid; + + guti2rai_ptmsi(g_pars.ue_pars.guti, rai, ptmsi, ptmsi_sig); + + SGSNContextReqPDU := ts_SGSNContextReqPDU(rai, new_sgsn_local_teid, f_inet_addr(mp_gn_local_ip), + ptmsi := ts_PTMSI(ptmsi), ptmsi_sig := ts_PTMSI_sig(ptmsi_sig)); + GTP.send(ts_GTPC_SGSNContextReq(g_gn_iface_peer, 0, SGSNContextReqPDU)); + + timer T := 5.0; + T.start; + alt { + [] GTP.receive(tr_GTPC_SGSNContextResp(g_gn_iface_peer, new_sgsn_local_teid, + tr_SGSNContextRespPDU(GTP_CAUSE_REQUEST_ACCEPTED, + g_pars.ue_pars.imsi))) -> value gtpc_pdu { + old_mme_local_teid := gtpc_pdu.gtpc.gtpc_pdu.sgsn_ContextResponse.teidControlPlane.teidControlPlane; + setverdict(pass); + } + [] GTP.receive { + setverdict(fail, "unexpected GTPC message from MME"); + } + [] T.timeout { + setverdict(fail, "no SGSN Context Response from MME"); + } + } + + GTP.send(ts_GTPC_SGSNContextAck(g_gn_iface_peer, old_mme_local_teid, + oct2int(gtpc_pdu.gtpc.opt_part.sequenceNumber), + ts_SGSNContextAckPDU(GTP_CAUSE_REQUEST_ACCEPTED))); + +} private function f_attach() runs on ConnHdlr { var template (value) EPS_MobileIdentityV mi := ts_NAS_MobileId_IMSI(g_pars.ue_pars.imsi); @@ -1231,47 +1336,26 @@ /* TODO: mMEC "also copied into the 8 Most Significant Bits of the NRI field within the P-TMSI" */ } private function f_TC_ue_cell_reselect_eutran_to_geran(ConnHdlrPars pars) runs on ConnHdlr { - var template (value) GTPC_PDUs SGSNContextReqPDU; - var RoutingAreaIdentity rai; - var OCT4 ptmsi; - var OCT3 ptmsi_sig; - var Gtp1cUnitdata gtpc_pdu; - var OCT4 new_sgsn_local_teid := '12345678'O; - var OCT4 old_mme_local_teid; - f_init_handler(pars); f_gtp_register_imsi(g_pars.ue_pars.imsi); f_attach(); - /* TODO: take GUTI from as_s1ap_handle_IntialCtxSetupReq() in g_pars, - * convert it to P-TMSI and pass P-TMSI below */ - guti2rai_ptmsi(g_pars.ue_pars.guti, rai, ptmsi, ptmsi_sig); + /* TS 23.401 Figure D.3.5-1 Steps 1,2,3,4: */ + f_gtp_sgsn_context_4g_to_2g(); - SGSNContextReqPDU := ts_SGSNContextReqPDU(rai, new_sgsn_local_teid, f_inet_addr(mp_gn_local_ip), - ptmsi := ts_PTMSI(ptmsi), ptmsi_sig := ts_PTMSI_sig(ptmsi_sig)); - GTP.send(ts_GTPC_SGSNContextReq(g_gn_iface_peer, 0, SGSNContextReqPDU)); + /* TS 23.401 Figure D.3.5-1 Step 8: */ + f_DIA_CancelLocation(); - timer T := 5.0; - T.start; - alt { - [] GTP.receive(tr_GTPC_SGSNContextResp(g_gn_iface_peer, new_sgsn_local_teid, - tr_SGSNContextRespPDU(GTP_CAUSE_REQUEST_ACCEPTED, - g_pars.ue_pars.imsi))) -> value gtpc_pdu { - old_mme_local_teid := gtpc_pdu.gtpc.gtpc_pdu.sgsn_ContextResponse.teidControlPlane.teidControlPlane; - setverdict(pass); - } - [] GTP.receive { - setverdict(fail, "unexpected GTPC message from MME"); - } - [] T.timeout { - setverdict(fail, "no SGSN Context Response from MME"); - } - } + /* TS 23.401 Figure D.3.5-1 Step 13: + * Upon rx of SGSN Context Acknowledge, MME released the ENB/UE context: + */ + as_s1ap_handle_UeContextReleaseCmd(); - GTP.send(ts_GTPC_SGSNContextAck(g_gn_iface_peer, old_mme_local_teid, - oct2int(gtpc_pdu.gtpc.opt_part.sequenceNumber), - ts_SGSNContextAckPDU(GTP_CAUSE_REQUEST_ACCEPTED))); - /* Give some time to process the SGSNContextACK: */ + /* TS 23.401 Figure D.3.5-1 Step 13: + * After Gn timer triggers, the SGW session is deleted: + */ + as_GTP2C_DeleteSession_success(); + /* Let MME some time to handle the Create Session Response: */ f_sleep(3.0); } testcase TC_ue_cell_reselect_eutran_to_geran() runs on MTC_CT { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35413?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic0263a3aec922194aad22b031b2c82a99954354d Gerrit-Change-Number: 35413 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: mme: Parametrize RAI+CI used by emulated SGSN

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35429?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mme: Parametrize RAI+CI used by emulated SGSN ...................................................................... mme: Parametrize RAI+CI used by emulated SGSN This will be used further in subsequent tests, plus it is configured in the sgsn peer list of open5gs-mmed.cfg, so it knows how to route/find SGSN peers. Change-Id: Ia7d807bb5d75d711be7d4f6fbccd8fd123da171f --- M mme/MME_Tests.ttcn 1 file changed, 23 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index c931449..bcf53d1 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -192,7 +192,13 @@ charstring mp_gn_local_ip := "127.0.0.22"; integer mp_gn_local_port := 2123; charstring mp_gn_remote_ip := "127.0.0.2"; + /* RAI+CI served from emulated peer SGSN: */ integer mp_gn_remote_port := 2123; + hexstring mp_gn_local_mcc := '262'H; + hexstring mp_gn_local_mnc := 'f42'H; + uint16_t mp_gn_local_lac := 43690; + uint8_t mp_gn_local_rac := 187; + uint16_t mp_gn_local_ci := 1223; /* S11 interface (GTPv2C, interface between MME and SGW) */ charstring mp_s11_local_ip := "127.0.0.3"; @@ -1171,10 +1177,10 @@ var GTP_CellId geran_gtp_ci; /* Assemble data of a fictitiously GERAN cell */ - geran_gtp_ci.ra_id.rac := oct2int('BB'O); - geran_gtp_ci.ra_id.lai.mcc_mnc := '262f42'H - geran_gtp_ci.ra_id.lai.lac := oct2int('AAAA'O); - geran_gtp_ci.cell_id := oct2int('04C7'O); + geran_gtp_ci.ra_id.rac := mp_gn_local_rac; + geran_gtp_ci.ra_id.lai.mcc_mnc := mp_gn_local_mcc & mp_gn_local_mnc; + geran_gtp_ci.ra_id.lai.lac := mp_gn_local_lac; + geran_gtp_ci.cell_id := mp_gn_local_ci; const octetstring geran_si1 := '198fb100000000000000000000000000007900002b'O; const octetstring geran_si3 := '1b753000f110236ec9033c2747407900003c0b2b2b'O; const octetstring geran_si13 := '009000185a6fc9e08410ab2b2b2b2b2b2b2b2b2b2b'O; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35429?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia7d807bb5d75d711be7d4f6fbccd8fd123da171f Gerrit-Change-Number: 35429 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: mme: TC_ue_cell_reselect_eutran_to_geran: Make sure oI flag is not se...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35428?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mme: TC_ue_cell_reselect_eutran_to_geran: Make sure oI flag is not set in DeleteSessionReq ...................................................................... mme: TC_ue_cell_reselect_eutran_to_geran: Make sure oI flag is not set in DeleteSessionReq Make sure Operation Indication is set to 0, to tell the SGW to keep the Session up at the PGW. Change-Id: If863f260a274fec5921ed888216c1688ff115ade --- M library/GTPv2_Templates.ttcn M mme/MME_Tests.ttcn 2 files changed, 84 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/library/GTPv2_Templates.ttcn b/library/GTPv2_Templates.ttcn index 65bc559..5dea7e9 100644 --- a/library/GTPv2_Templates.ttcn +++ b/library/GTPv2_Templates.ttcn @@ -283,8 +283,74 @@ additionalOctets := * } +/* 8.12 */ +template (present) Indication +tr_GTP2C_Indication(template (present) BIT1 oI := ?) := { + elementIdentifier := '4D'O, + lengthIndicator := ?, + instance := '0000'B, + spare := '0000'B, + sGWCI := ?, + iSRAI := ?, + iSRSI := ?, + oI := oI, + dFI := ?, + hI := ?, + dTF := ?, + dAF := ?, + mSV := ?, + sI := ?, + pT := ?, + pBit := ?, + cRSI := ?, + cFSI := ?, + uIMSI := ?, + sQCI := ?, + cCRSI := *, + iSRAU := *, + mBMDT := *, + s4AF := *, + s6AF := *, + sRNI := *, + pBIC := *, + retLoc := *, + cPSR := *, + cLII := *, + cSFBI := *, + pPSI := *, + pPON_PPEI := *, + pPOF := *, + aRRL := *, + cPRAI := *, + aOPI := *, + aOSI := *, + pCRI := *, + pSCI := *, + bDWI := *, + dTCI := *, + uASI := *, + nSI := *, + wPMSI := *, + uNACCSI := *, + pNSI := *, + s11TF := *, + pMTSMI := *, + cPOPCI := *, + ePCOSI := *, + rOAAI := *, + tSPCMI := *, + spare_1 := *, + spare_2 := *, + spare_3 := *, + spare_4 := *, + spare_5 := *, + spare_6 := *, + spare_7 := *, + additionalOctets := * +} + /* 8.14 */ template (value) PDN_AddressAllocation ts_GTP2C_PdnAddrAlloc(template (value) BIT3 pdn_type, @@ -943,13 +1009,14 @@ template (present) OCT3 seq := ?, template GTP2C_Cause cause := *, template (present) uint4_t bearer_id := ?, + template Indication indicationFlags := *, template FullyQualifiedTEID sender_fteid := *) := tr_PDU_GTP2C(d_teid, seq, { deleteSessionRequest := { cause := fr_GTP2C_Cause(cause), linkedEPS_Bearer_ID := tr_GTP2C_EpsBearerId(bearer_id), uLI := *, - indicationFlags := *, + indicationFlags := indicationFlags, protocolConfigOptions := *, originatingNode := *, fullyQualifiedTEID := sender_fteid, diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 339f121..c931449 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -835,10 +835,10 @@ } } -private altstep as_GTP2C_DeleteSession_success() runs on ConnHdlr { +private altstep as_GTP2C_DeleteSession_success(template Indication ind_flags := *) runs on ConnHdlr { var PDU_GTPCv2 rx_msg; - [] GTP2.receive(tr_GTP2C_DeleteSessionReq(g_pars.ue_pars.s11_teic_local)) -> value rx_msg { + [] GTP2.receive(tr_GTP2C_DeleteSessionReq(g_pars.ue_pars.s11_teic_local, indicationFlags := ind_flags)) -> value rx_msg { GTP2.send(ts_GTP2C_DeleteSessionResp(g_pars.ue_pars.s11_teic_remote, rx_msg.sequenceNumber, Request_accepted)); @@ -1352,9 +1352,10 @@ as_s1ap_handle_UeContextReleaseCmd(); /* TS 23.401 Figure D.3.5-1 Step 13: - * After Gn timer triggers, the SGW session is deleted: + * After Gn timer triggers, the SGW session is deleted. + * Make sure Operation Indication is set to 0, to tell the SGW to keep the Session up at the PGW. */ - as_GTP2C_DeleteSession_success(); + as_GTP2C_DeleteSession_success(tr_GTP2C_Indication(oI := '0'B)); /* Let MME some time to handle the Create Session Response: */ f_sleep(3.0); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If863f260a274fec5921ed888216c1688ff115ade Gerrit-Change-Number: 35428 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: mme: Use LAC from SGSN with most significat bit set to 0

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35430?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mme: Use LAC from SGSN with most significat bit set to 0 ...................................................................... mme: Use LAC from SGSN with most significat bit set to 0 According to 3GPP TS 23.003 sec 2.8.2.2.2, LACs from GERAN are configured with MSB 0 in order to differentiate it from EUTRAN ones. This is used by MMEs to figure out if the peer is an SGSN, based on the the LAC mapped into MME group ID in GUTI . Change-Id: Iaf89228f6f026e04d5f583211959025e6d8d4a1d --- M mme/MME_Tests.ttcn 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index bcf53d1..0c5c8e9 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -196,7 +196,7 @@ integer mp_gn_remote_port := 2123; hexstring mp_gn_local_mcc := '262'H; hexstring mp_gn_local_mnc := 'f42'H; - uint16_t mp_gn_local_lac := 43690; + uint16_t mp_gn_local_lac := 39594; uint8_t mp_gn_local_rac := 187; uint16_t mp_gn_local_ci := 1223; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35430?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf89228f6f026e04d5f583211959025e6d8d4a1d Gerrit-Change-Number: 35430 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2024