January 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: vty: Ensure radio-link-timeout is a multiple of 4
by pespin 04 Jan '24

04 Jan '24

Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35484?usp=email ) Change subject: vty: Ensure radio-link-timeout is a multiple of 4 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I733591d5f72f2e4f822761ca9eda85de7a4c6c81 Gerrit-Change-Number: 35484 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Thu, 04 Jan 2024 17:06:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: vty: Ensure radio-link-timeout is a multiple of 4
by matanp 04 Jan '24

04 Jan '24

Attention is currently required from: matanp. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/35484?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: vty: Ensure radio-link-timeout is a multiple of 4 ...................................................................... vty: Ensure radio-link-timeout is a multiple of 4 According to Table 10.5.2.3.1 in TS 144.018, radio-link-timeout values are between 4 to 64 in steps of 4. Change-Id: I733591d5f72f2e4f822761ca9eda85de7a4c6c81 --- M src/osmo-bsc/bts_vty.c 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/35484/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I733591d5f72f2e4f822761ca9eda85de7a4c6c81 Gerrit-Change-Number: 35484 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in libosmocore[master]: Add LLC and HLC transcoding to MNCC transcoding functions
by pespin 04 Jan '24

04 Jan '24

Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email ) Change subject: Add LLC and HLC transcoding to MNCC transcoding functions ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: To me it's even clearer now that these structs and related APIs are not really needed. I mean, it's just a buffer plus a related buffer len. We have/use tons of those all around, imagine we had to add structs for all types of buffer+len, it makes no sense imho. Letting others provide feedback here. File include/osmocom/gsm/mncc.h: https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/2cad1d71_f7c1a16f PS3, Line 37: int len; this should be unsigned. And probably uint8_t. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia6a2159ecf810a02f85b558026edf20b934567de Gerrit-Change-Number: 35391 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Jan 2024 16:11:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: vty: Ensure radio-link-timeout is a multiple of 4
by pespin 04 Jan '24

04 Jan '24

Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35484?usp=email ) Change subject: vty: Ensure radio-link-timeout is a multiple of 4 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Some spec reference in code and in commit may be worth it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I733591d5f72f2e4f822761ca9eda85de7a4c6c81 Gerrit-Change-Number: 35484 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Thu, 04 Jan 2024 16:05:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: Add LLC and HLC transcoding to MNCC transcoding functions
by jolly 04 Jan '24

04 Jan '24

Attention is currently required from: fixeria, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email ) Change subject: Add LLC and HLC transcoding to MNCC transcoding functions ...................................................................... Patch Set 3: (2 comments) File src/gsm/gsm48_ie.c: https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/ee3c19c8_2b9ee687 PS1, Line 412: /*! Encode TS 04.08 High Layer compatibility IE (10.5.4.16) */ > You are right, I simplified the functions by removing the 'local buffer'. […] Done File src/gsm/gsm48_ie.c: https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/933e2e27_548ccf9c PS2, Line 413: gsm48_encode_highl_compat > The `encode`/`decode` in symbol names creates a false impression that these functions actually `enco […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia6a2159ecf810a02f85b558026edf20b934567de Gerrit-Change-Number: 35391 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Jan 2024 15:42:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: Add LLC and HLC information to MNCC interface definiton
by jolly 04 Jan '24

04 Jan '24

Attention is currently required from: fixeria, laforge, neels. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35392?usp=email ) Change subject: Add LLC and HLC information to MNCC interface definiton ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > In general we are breaking compatibility *way* too often with interfaces like PCU or MNCC. […] I tested old version of osmo-sip-connector with new version of osmo-msc and vice versa, also both with new version. I tested TTCN3 MSC tests with new version and there was no new fails (only fails that were expected). -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35392?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I15f5afcf069ee6c1c4641108ceacc837bee311b5 Gerrit-Change-Number: 35392 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Jan 2024 15:42:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: Add LLC and HLC information forwarding to MNCC interface
by jolly 04 Jan '24

04 Jan '24

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/35393?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add LLC and HLC information forwarding to MNCC interface ...................................................................... Add LLC and HLC information forwarding to MNCC interface low/high layer compatibility are used for capability checking between caller and called entitiy. The transcoding is performed by libosmogsm. Related: OS#6152 Depends: libosmocore.git Ia6a2159ecf810a02f85b558026edf20b934567de Change-Id: I760980a7e17e2fa81615adc69ef85797eb0c07f1 --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 32 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/93/35393/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I760980a7e17e2fa81615adc69ef85797eb0c07f1 Gerrit-Change-Number: 35393 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[M] Change in libosmocore[master]: Add LLC and HLC transcoding to MNCC transcoding functions
by jolly 04 Jan '24

04 Jan '24

Attention is currently required from: jolly, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Add LLC and HLC transcoding to MNCC transcoding functions ...................................................................... Add LLC and HLC transcoding to MNCC transcoding functions low/high layer compatibility are used for capability checking between caller and called entitiy. They are transparently forwarded, so there is no parsing or assembling of the elements. Related: OS#6152 Change-Id: Ia6a2159ecf810a02f85b558026edf20b934567de --- M include/osmocom/gsm/gsm48_ie.h M include/osmocom/gsm/mncc.h M src/gsm/gsm48_ie.c M src/gsm/libosmogsm.map 4 files changed, 90 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/35391/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia6a2159ecf810a02f85b558026edf20b934567de Gerrit-Change-Number: 35391 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: vty: Ensure radio-link-timeout is a multiple of 4
by matanp 04 Jan '24

04 Jan '24

matanp has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35484?usp=email ) Change subject: vty: Ensure radio-link-timeout is a multiple of 4 ...................................................................... vty: Ensure radio-link-timeout is a multiple of 4 Change-Id: I733591d5f72f2e4f822761ca9eda85de7a4c6c81 --- M src/osmo-bsc/bts_vty.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/35484/1 diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index ef8b8bd..33ff4e4 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -1481,8 +1481,14 @@ "Radio link timeout value (lost SACCH block)\n") { struct gsm_bts *bts = vty->index; + unsigned int radio_link_timeout = atoi(argv[0]); - gsm_bts_set_radio_link_timeout(bts, atoi(argv[0])); + if (radio_link_timeout % 4 != 0) { + vty_out(vty, "%% Radio link timeout must be a multiple of 4%s", VTY_NEWLINE); + return CMD_WARNING; + } + + gsm_bts_set_radio_link_timeout(bts, radio_link_timeout); return CMD_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I733591d5f72f2e4f822761ca9eda85de7a4c6c81 Gerrit-Change-Number: 35484 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in libosmocore[master]: ecu: fix alignment of fr_ecu_state
by pespin 04 Jan '24

04 Jan '24

Attention is currently required from: dexter, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email ) Change subject: ecu: fix alignment of fr_ecu_state ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I28672856e8e8f47e04ffe09ee3e07b577108cdc7 Gerrit-Change-Number: 35212 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Jan 2024 13:49:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0