September 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: ASCI: Ignore LAPD frames from MS, while the uplink is not active

by fixeria

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34423?usp=email ) Change subject: ASCI: Ignore LAPD frames from MS, while the uplink is not active ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5075115123055b2997481f56ddf473430a1dc9e3 Gerrit-Change-Number: 34423 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 21 Sep 2023 08:54:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[L] Change in libosmo-sccp[master]: sccp: Introduce initial support for SCCP LUDT + LUDTS messages

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34467?usp=email ) Change subject: sccp: Introduce initial support for SCCP LUDT + LUDTS messages ...................................................................... Patch Set 3: (1 comment) File include/osmocom/sccp/sccp_types.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/fef22539_c68dfba8 PS2, Line 505: #if VARIABLE > I see that this is elsewhere in the file too, but being curious: are the "if VARIABLE" and "if OPTIO […] Yeah I think so, I also was a bit confused. I simply followed the existing code here... -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34467?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ic91abfc921f5e4f36045bfa325333112cddd9fa6 Gerrit-Change-Number: 34467 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 08:52:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[M] Change in osmo-bsc[master]: abis_nm: handle NM_EV_SW_ACT_REP in ST_OP_DISABLED_{DEPENDENCY,OFFLINE}

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34470?usp=email ) Change subject: abis_nm: handle NM_EV_SW_ACT_REP in ST_OP_DISABLED_{DEPENDENCY,OFFLINE} ...................................................................... Patch Set 1: Code-Review+1 (3 comments) File src/osmo-bsc/nm_bts_sm_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34470/comment/da7398ce_1b0e28c8 PS1, Line 123: case NM_EV_SW_ACT_REP: > Because no other events in this function call it, e.g. `NM_EV_SETUP_RAMP_READY` does not. […] Ah well, it's an optimization because anyway in DEPENDENCY we pass allow_upstart=false so we'll never have to do anything, because there's no Get/SetAttr messages to send here so far. But even if it's a noop, it may make sense to call the functions for the sake of completeness/similariy to other FSMs. See what other FSMs are doing, you may also need to add it to NM_EV_STATE_CHG_REP too. File src/osmo-bsc/nm_gprs_nsvc_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34470/comment/a5396fb1_f7b83898 PS1, Line 179: case NM_EV_SW_ACT_REP: > It's not missing. What's missing is the `break`, so we fall-through. ACK, though maybe I'd have it call explicitly, but up to you. https://gerrit.osmocom.org/c/osmo-bsc/+/34470/comment/c6813346_b4a2fcfa PS1, Line 233: case NM_EV_SW_ACT_REP: > It's not missing. What's missing is the `break`, so we fall-through. ACK, though maybe I'd have it call explicitly, but up to you. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34470?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I00a423adcde5c34977f4c4dad920874687fa493c Gerrit-Change-Number: 34470 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 08:51:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in libosmo-sccp[master]: sccp2sua: Produce smaller output if msg contains no optional section

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34466?usp=email ) Change subject: sccp2sua: Produce smaller output if msg contains no optional section ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/sccp2sua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34466/comment/23e2dbaa_544c4d5c PS1, Line 1007: ommited > omitted Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34466?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I5c8fcb30b76ac7bafd4a99bc3004049644e7e3f9 Gerrit-Change-Number: 34466 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 08:49:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[L] Change in libosmo-sccp[master]: sccp: Introduce initial support for SCCP LUDT + LUDTS messages

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34467?usp=email ) Change subject: sccp: Introduce initial support for SCCP LUDT + LUDTS messages ...................................................................... Patch Set 3: (5 comments) File include/osmocom/sccp/sccp_types.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/87eeecf1_f8e0f0f6 PS2, Line 505: #if VARIABLE I see that this is elsewhere in the file too, but being curious: are the "if VARIABLE" and "if OPTIONAL" blocks just comments? https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/a1fcfa74_bad67a50 PS2, Line 529: indent with one less tab here for consistency with the rest of the file? https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/9b015c1f_2b32a267 PS2, Line 543: importancd importance (same typo is elsewhere in the file too) File src/sccp2sua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/9f729b5d_d5ba6ae4 PS2, Line 1449: sccp_longdata_to_sua_ptr(xua, SUA_IEI_DATA, (uint8_t *)&ludt->variable_data); there's probably a reason, but to be sure: why not run sccp_longptr_part_consistent again here, and after sccp_to_xua_opt below? same with sccp_to_xua_ludts File tests/xua/xua_test.ok: https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/61d4196a_dcbe7552 PS2, Line 102: Input != re-encoded output! is this expected? if so, maybe add a comment about it like done in the previous patch? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34467?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ic91abfc921f5e4f36045bfa325333112cddd9fa6 Gerrit-Change-Number: 34467 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 08:47:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[M] Change in osmo-bsc[master]: abis_nm: handle NM_EV_SW_ACT_REP in ST_OP_DISABLED_{DEPENDENCY,OFFLINE}

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34470?usp=email ) Change subject: abis_nm: handle NM_EV_SW_ACT_REP in ST_OP_DISABLED_{DEPENDENCY,OFFLINE} ...................................................................... Patch Set 1: (3 comments) File src/osmo-bsc/nm_bts_sm_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34470/comment/e3da0ddb_eebdf5e3 PS1, Line 123: case NM_EV_SW_ACT_REP: > why is configure_loop() not called here? Because no other events in this function call it, e.g. `NM_EV_SETUP_RAMP_READY` does not. Do you think it should be called here? And also in the case of `NM_EV_SETUP_RAMP_READY`? I can update the patch. File src/osmo-bsc/nm_gprs_nsvc_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34470/comment/3a85e2d5_7cdee485 PS1, Line 179: case NM_EV_SW_ACT_REP: > missing configure_loop? It's not missing. What's missing is the `break`, so we fall-through. https://gerrit.osmocom.org/c/osmo-bsc/+/34470/comment/4ebea1f4_6b290d7d PS1, Line 233: case NM_EV_SW_ACT_REP: > missing configure_loop? It's not missing. What's missing is the `break`, so we fall-through. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34470?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I00a423adcde5c34977f4c4dad920874687fa493c Gerrit-Change-Number: 34470 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 08:44:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[L] Change in osmo-bts[master]: oml: implement handling of NM_ATT_IPACC_SUPP_FEATURES

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34434?usp=email ) Change subject: oml: implement handling of NM_ATT_IPACC_SUPP_FEATURES ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34434?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I88c6c6af18be054bd152832e60c8afbbd16098a3 Gerrit-Change-Number: 34434 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 08:40:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmo-bsc[master]: abis_nm: send Get Attributes to GPRS Cell MO(s)

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34360?usp=email ) Change subject: abis_nm: send Get Attributes to GPRS Cell MO(s) ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib6d87da49217f1c8d76445ce623a511a07daedbf Gerrit-Change-Number: 34360 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 08:35:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmo-bsc[master]: abis_nm: send Get Attributes to Rado Carrier MO(s)

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34359?usp=email ) Change subject: abis_nm: send Get Attributes to Rado Carrier MO(s) ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If7b75689c12a253377f2747babd4d7ebd1db5f87 Gerrit-Change-Number: 34359 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 08:35:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmo-bsc[master]: abis_nm: send Get Attributes to Rado Carrier MO(s)

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34359?usp=email ) Change subject: abis_nm: send Get Attributes to Rado Carrier MO(s) ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If7b75689c12a253377f2747babd4d7ebd1db5f87 Gerrit-Change-Number: 34359 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 08:35:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2023