Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34509?usp=email )
Change subject: sockaddr_str.h Fix OSMO_SOCKADDR_STR_FMT_ARGS_NOT_NULL syntax error
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> might this be something for a patch release?
Maybe if we ever do a patch release, but I don't think it's worth it on its own, basically because there were no users of such define so far. So it's more like we say this define is added in the next release.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34509?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iee361d740845257fa62c9093e30e8079fa933827
Gerrit-Change-Number: 34509
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 25 Sep 2023 21:03:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: daniel.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34524?usp=email )
Change subject: osmo_io: Clean up code
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Minor cleanup (I suppose there is no good reason to keep these lines, @dwillmann@sysmocom.de ?)
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34524?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I77f7ae2b211507f420d87c484ec75ee054fceb63
Gerrit-Change-Number: 34524
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Sep 2023 20:06:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34524?usp=email )
Change subject: osmo_io: Clean up code
......................................................................
osmo_io: Clean up code
- Remove osmo_io_init() from header, since it has no function definition
- Remove osmo_iofd_init from .map file, because it doesn't need to be exposed
(it is called by on_dso_load_osmo_io() in osmo_io.c)
Change-Id: I77f7ae2b211507f420d87c484ec75ee054fceb63
---
M include/osmocom/core/osmo_io.h
M src/core/libosmocore.map
2 files changed, 13 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/24/34524/1
diff --git a/include/osmocom/core/osmo_io.h b/include/osmocom/core/osmo_io.h
index b780d9a..4ff6bbc 100644
--- a/include/osmocom/core/osmo_io.h
+++ b/include/osmocom/core/osmo_io.h
@@ -69,8 +69,6 @@
};
};
-void osmo_io_init(void);
-
struct osmo_io_fd *osmo_iofd_setup(const void *ctx, int fd, const char *name,
enum osmo_io_fd_mode mode, const struct osmo_io_ops *ioops, void *data);
int osmo_iofd_register(struct osmo_io_fd *iofd, int fd);
diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map
index c0e164b..a8b2c18 100644
--- a/src/core/libosmocore.map
+++ b/src/core/libosmocore.map
@@ -260,7 +260,6 @@
osmo_iofd_get_name;
osmo_iofd_set_name;
osmo_iofd_get_priv_nr;
-osmo_iofd_init;
osmo_iofd_ops;
osmo_iofd_register;
osmo_iofd_sendto_msgb;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34524?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I77f7ae2b211507f420d87c484ec75ee054fceb63
Gerrit-Change-Number: 34524
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-MessageType: newchange
falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34516?usp=email )
Change subject: gsup_client_mux: set destination_name in error reply function
......................................................................
gsup_client_mux: set destination_name in error reply function
If the GSUP request message to which we are replying is an MT SMS
delivery from an SMSC relayed via OsmoHLR, we must set destination_name
in our reply - otherwise our reply won't make it back to the SMSC.
Related: OS#6135
Change-Id: I892fe87a733a78ed9d5761a8ce238caa135dea1e
---
M src/libmsc/gsup_client_mux.c
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
diff --git a/src/libmsc/gsup_client_mux.c b/src/libmsc/gsup_client_mux.c
index 1900377..9a0dc16 100644
--- a/src/libmsc/gsup_client_mux.c
+++ b/src/libmsc/gsup_client_mux.c
@@ -150,6 +150,8 @@
.cause = cause,
.message_type = OSMO_GSUP_TO_MSGT_ERROR(gsup_orig->message_type),
.message_class = gsup_orig->message_class,
+ .destination_name = gsup_orig->source_name,
+ .destination_name_len = gsup_orig->source_name_len,
/* RP-Message-Reference is mandatory for SM Service */
.sm_rp_mr = gsup_orig->sm_rp_mr,
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34516?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I892fe87a733a78ed9d5761a8ce238caa135dea1e
Gerrit-Change-Number: 34516
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34511?usp=email )
Change subject: sccplite: Support multiple MGW in MGW pool
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34511?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia106a21b7692eb5b2ac3b5ac2b358bedbc3b9da6
Gerrit-Change-Number: 34511
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Sep 2023 19:10:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: jolly.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34519?usp=email )
Change subject: Do not prefix UI header to System Information Type 10
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34519?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ifede42bfd84ea5914b559a20ae68f594d2ee1a5c
Gerrit-Change-Number: 34519
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 25 Sep 2023 19:08:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment