September 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-netif[master]: stream: Add new stream_{cli,srv_link} parameters to set SCTP_INITMSG ...

by pespin

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/34348?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: stream: Add new stream_{cli,srv_link} parameters to set SCTP_INITMSG sockopt values ...................................................................... stream: Add new stream_{cli,srv_link} parameters to set SCTP_INITMSG sockopt values This will allow osmo_stream users (like libosmo-sccp) to set SCTP_INITMSG related parameters, like number on inbound/outbound streams, connect attempts, connect timeout. Related: SYS#6558 Change-Id: I5343c7659881b29e0201e72badbc2d07e1ef2dca --- M include/osmocom/netif/stream.h M src/stream_cli.c M src/stream_srv.c 3 files changed, 62 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/48/34348/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34348?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5343c7659881b29e0201e72badbc2d07e1ef2dca Gerrit-Change-Number: 34348 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

[S] Change in libosmocore[master]: ASCI: Add definition for TALKER INDICATION and UPLINK RELEASE

by fixeria

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34363?usp=email ) Change subject: ASCI: Add definition for TALKER INDICATION and UPLINK RELEASE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5ab196d46cdee160e59ee4ecf72c79aa1b25815f Gerrit-Change-Number: 34363 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 11 Sep 2023 17:24:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in libosmocore[master]: LAPDM: Use correct offset to short header on recevied frame

by fixeria

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34362?usp=email ) Change subject: LAPDM: Use correct offset to short header on recevied frame ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8345776768fdf2a700b2ca1d117f9ef4b15777cc Gerrit-Change-Number: 34362 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 11 Sep 2023 17:24:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in libosmocore[master]: ASCI: Add BCC call state definitions

by fixeria

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34361?usp=email ) Change subject: ASCI: Add BCC call state definitions ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmocom/gsm/protocol/gsm_44_068.h: https://gerrit.osmocom.org/c/libosmocore/+/34361/comment/73b671e2_d084d12a PS1, Line 69: OSMO_GSM44068_CSTATE_U2sl_U2 So, you're changing public API here. The usual approach is to add defines with old names for backwards compatibility. But I see that it's relatively new API (2023-04-20), and most likely there are no API users, so it should be fine. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2180b43b940542565188f52c554c960858fe2a95 Gerrit-Change-Number: 34361 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 11 Sep 2023 17:22:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in libosmocore[master]: ASCI: Add definition for TALKER INDICATION and UPLINK RELEASE

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34363?usp=email ) Change subject: ASCI: Add definition for TALKER INDICATION and UPLINK RELEASE ...................................................................... ASCI: Add definition for TALKER INDICATION and UPLINK RELEASE Change-Id: I5ab196d46cdee160e59ee4ecf72c79aa1b25815f --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/63/34363/1 diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index c70e2e6..84b2b2a 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -1418,6 +1418,18 @@ uint8_t rr_cause; } __attribute__((packed)); +/* Section 9.1.44 */ +struct gsm48_talker_indication { + uint8_t cm2_len; + struct gsm48_classmark2 cm2; + uint8_t data[0]; +} __attribute__((packed)); + +/* Section 9.1.48 */ +struct gsm48_uplink_release { + uint8_t rr_cause; +} __attribute__((packed)); + /* Section 10.2 + GSM 04.07 12.2.3.1.1 + 3GPP TS 24.007 11.2.3.1.1 */ #define GSM48_PDISC_GROUP_CC 0x00 #define GSM48_PDISC_BCAST_CC 0x01 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5ab196d46cdee160e59ee4ecf72c79aa1b25815f Gerrit-Change-Number: 34363 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 0

[M] Change in osmo-bsc[master]: oml: ipacc: send GPRS Cell attributes based on IPA Object Version

by fixeria

Attention is currently required from: fixeria, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34298?usp=email ) Change subject: oml: ipacc: send GPRS Cell attributes based on IPA Object Version ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34298?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie0fb3eaf76e1f70e5a19bb088e1674b7e553d32a Gerrit-Change-Number: 34298 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Sep 2023 16:20:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in libosmocore[master]: LAPDM: Use correct offset to short header on recevied frame

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34362?usp=email ) Change subject: LAPDM: Use correct offset to short header on recevied frame ...................................................................... LAPDM: Use correct offset to short header on recevied frame The offset of the short header on main DCCH is 0, not 2. Change-Id: I8345776768fdf2a700b2ca1d117f9ef4b15777cc --- M src/gsm/lapdm.c 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/34362/1 diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c index 9f795c6..86dc242 100644 --- a/src/gsm/lapdm.c +++ b/src/gsm/lapdm.c @@ -754,7 +754,7 @@ msg->l2h += 2; } else { /* A Short L3 header has both bits == 0. */ - if (LAPDm_ADDR_SHORT_L2(msg->l2h[2]) == 0) { + if (LAPDm_ADDR_SHORT_L2(msg->l2h[0]) == 0) { mctx.lapdm_fmt = LAPDm_FMT_Bter; n201 = N201_Bter_SDCCH; sapi = 0; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8345776768fdf2a700b2ca1d117f9ef4b15777cc Gerrit-Change-Number: 34362 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 0

[S] Change in libosmocore[master]: ASCI: Add BCC call state definitions

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34361?usp=email ) Change subject: ASCI: Add BCC call state definitions ...................................................................... ASCI: Add BCC call state definitions BCC and GCC share same call states, except for two states that have same value, but different state names and conditions. Related: OS#5364 Change-Id: I2180b43b940542565188f52c554c960858fe2a95 --- M include/osmocom/gsm/protocol/gsm_44_068.h M src/gsm/gsm44068.c 2 files changed, 17 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/34361/1 diff --git a/include/osmocom/gsm/protocol/gsm_44_068.h b/include/osmocom/gsm/protocol/gsm_44_068.h index b1c4b45..3a33c16 100644 --- a/include/osmocom/gsm/protocol/gsm_44_068.h +++ b/include/osmocom/gsm/protocol/gsm_44_068.h @@ -66,12 +66,12 @@ enum osmo_gsm44068_call_state { OSMO_GSM44068_CSTATE_U0 = 0x0, OSMO_GSM44068_CSTATE_U1 = 0x1, - OSMO_GSM44068_CSTATE_U2sl = 0x2, + OSMO_GSM44068_CSTATE_U2sl_U2 = 0x2, OSMO_GSM44068_CSTATE_U3 = 0x3, OSMO_GSM44068_CSTATE_U4 = 0x4, OSMO_GSM44068_CSTATE_U5 = 0x5, OSMO_GSM44068_CSTATE_U0p = 0x6, - OSMO_GSM44068_CSTATE_Uwr = 0x7, + OSMO_GSM44068_CSTATE_U2wr_U6 = 0x7, OSMO_GSM44068_CSTATE_U2r = 0x8, OSMO_GSM44068_CSTATE_U2ws = 0x9, OSMO_GSM44068_CSTATE_U2sr = 0xa, diff --git a/src/gsm/gsm44068.c b/src/gsm/gsm44068.c index 7da5ae2..2556b12 100644 --- a/src/gsm/gsm44068.c +++ b/src/gsm/gsm44068.c @@ -89,12 +89,12 @@ const struct value_string osmo_gsm44068_call_state_names[] = { { OSMO_GSM44068_CSTATE_U0, "U0" }, { OSMO_GSM44068_CSTATE_U1, "U1" }, - { OSMO_GSM44068_CSTATE_U2sl, "U2sl/U2" }, + { OSMO_GSM44068_CSTATE_U2sl_U2, "U2sl/U2" }, { OSMO_GSM44068_CSTATE_U3, "U3" }, { OSMO_GSM44068_CSTATE_U4, "U4" }, { OSMO_GSM44068_CSTATE_U5, "U5" }, { OSMO_GSM44068_CSTATE_U0p, "U0.p" }, - { OSMO_GSM44068_CSTATE_Uwr, "Uwr" }, + { OSMO_GSM44068_CSTATE_U2wr_U6, "U2wr/U6" }, { OSMO_GSM44068_CSTATE_U2r, "U2r" }, { OSMO_GSM44068_CSTATE_U2ws, "U2ws" }, { OSMO_GSM44068_CSTATE_U2sr, "U2sr" }, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2180b43b940542565188f52c554c960858fe2a95 Gerrit-Change-Number: 34361 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 0

[M] Change in osmo-bsc[master]: oml: ipacc: fix sending hard-coded GPRS Cell attributes

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/34357?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: oml: ipacc: fix sending hard-coded GPRS Cell attributes ...................................................................... oml: ipacc: fix sending hard-coded GPRS Cell attributes Change-Id: I7d90ca3d6a660af8e953e890c7919194f5d297d2 Related: OS#4505 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c M tests/nanobts_omlattr/nanobts_omlattr_test.c M tests/nanobts_omlattr/nanobts_omlattr_test.ok 3 files changed, 40 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/34357/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7d90ca3d6a660af8e953e890c7919194f5d297d2 Gerrit-Change-Number: 34357 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 9 months

1
0
0 0

[S] Change in osmo-bsc[master]: abis_nm: get rid of MAX_BTS_ATTR

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34355?usp=email ) Change subject: abis_nm: get rid of MAX_BTS_ATTR ...................................................................... abis_nm: get rid of MAX_BTS_ATTR This is a partial revert of commit [1], which defined a limit on the number of attributes and SW Description IEs as a constant and added a spec. reference. The problem is that there is no such limit in the referenced 3GPP TS 52.021. The attributes and SW Description IEs are using TL16V encoding, so there can be as many as the Length part can represent. It's actually the limitation of our side, since we allocate a buffer of fixed size on the stack for parsing. * Remove the MAX_BTS_ATTR and confusing spec. reference. * For the SW Description IEs, define SW_DESCR_MAX locally. * For the attributes, define the buffer size in place. Change-Id: Idd8b971d32cf0f7a910a664d921e644b7c32d831 Related: [1] 1ebf23b7fe "Prepare for BTS attribute reporting via OML" Related: OS#4505 --- M include/osmocom/bsc/abis_nm.h M src/osmo-bsc/abis_nm.c M src/osmo-bsc/nm_bb_transc_fsm.c M src/osmo-bsc/nm_bts_fsm.c 4 files changed, 30 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/55/34355/1 diff --git a/include/osmocom/bsc/abis_nm.h b/include/osmocom/bsc/abis_nm.h index bfafa63..7f1ec74 100644 --- a/include/osmocom/bsc/abis_nm.h +++ b/include/osmocom/bsc/abis_nm.h @@ -29,9 +29,6 @@ #include <osmocom/bsc/gsm_data.h> #include <osmocom/bsc/signal.h> -/* max number of attributes represented as 3GPP TS 52.021 §9.4.62 SW Description array */ -#define MAX_BTS_ATTR 5 - /* The BCCH info from an ip.access test, in host byte order * and already parsed... */ struct ipac_bcch_info { diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index 1b544fe..90b28eb 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -58,6 +58,9 @@ #define OM_HEADROOM_SIZE 128 #define IPACC_SEGMENT_SIZE 245 +/* max number of SW Description IEs we can parse */ +#define SW_DESCR_MAX 5 + #define LOGPMO(mo, ss, lvl, fmt, args ...) \ LOGP(ss, lvl, "OC=%s(%02x) INST=(%02x,%02x,%02x): " fmt, \ get_value_string(abis_nm_obj_class_names, (mo)->obj_class), \ @@ -610,7 +613,6 @@ uint16_t port; struct in_addr ia = {0}; char unit_id[40]; - struct abis_nm_sw_desc sw_descr[MAX_BTS_ATTR]; switch (bts->type) { case GSM_BTS_TYPE_OSMOBTS: @@ -638,6 +640,7 @@ /* Parse Attribute Response Info content for 3GPP TS 52.021 §9.4.61 SW Configuration */ if (TLVP_PRESENT(tp, NM_ATT_SW_CONFIG)) { + struct abis_nm_sw_desc sw_descr[SW_DESCR_MAX]; data = TLVP_VAL(tp, NM_ATT_SW_CONFIG); len = TLVP_LEN(tp, NM_ATT_SW_CONFIG); /* after parsing manufacturer-specific attributes there's list of replies in form of sw-conf structure: */ @@ -749,7 +752,7 @@ struct tlv_parsed tp; const uint8_t *sw_config; int ret, sw_config_len, len; - struct abis_nm_sw_desc sw_descr[MAX_BTS_ATTR]; + struct abis_nm_sw_desc sw_descr[SW_DESCR_MAX]; DEBUGPFOH(DNM, foh, "Software Activate Request, ACKing and Activating\n"); diff --git a/src/osmo-bsc/nm_bb_transc_fsm.c b/src/osmo-bsc/nm_bb_transc_fsm.c index 4b5e2b2..b68dc67 100644 --- a/src/osmo-bsc/nm_bb_transc_fsm.c +++ b/src/osmo-bsc/nm_bb_transc_fsm.c @@ -111,7 +111,7 @@ /* Request TRX-level attributes */ if (!bb_transc->mo.get_attr_sent && !bb_transc->mo.get_attr_rep_received) { - uint8_t attr_buf[MAX_BTS_ATTR]; + uint8_t attr_buf[3]; /* enlarge if needed */ uint8_t *ptr = &attr_buf[0]; *(ptr++) = NM_ATT_MANUF_STATE; diff --git a/src/osmo-bsc/nm_bts_fsm.c b/src/osmo-bsc/nm_bts_fsm.c index a9b6604..544efb4 100644 --- a/src/osmo-bsc/nm_bts_fsm.c +++ b/src/osmo-bsc/nm_bts_fsm.c @@ -98,7 +98,7 @@ /* Request generic BTS-level attributes */ if (!bts->mo.get_attr_sent && !bts->mo.get_attr_rep_received) { - uint8_t attr_buf[MAX_BTS_ATTR]; + uint8_t attr_buf[3]; /* enlarge if needed */ uint8_t *ptr = &attr_buf[0]; *(ptr++) = NM_ATT_MANUF_ID; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34355?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idd8b971d32cf0f7a910a664d921e644b7c32d831 Gerrit-Change-Number: 34355 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2023