August 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-gprs[master]: README.md: upade the list of libraries
by fixeria 13 Aug '23

13 Aug '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34148 ) Change subject: README.md: upade the list of libraries ...................................................................... README.md: upade the list of libraries Change-Id: I0572e9435330c15469f6609505867c21be9c3483 --- M README.md 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/48/34148/1 diff --git a/README.md b/README.md index c857f66..b88c581 100644 --- a/README.md +++ b/README.md @@ -3,9 +3,13 @@ This project is a home for several libraries providing common GPRS routines: -* libosmo-csn1 - CSN.1 (Concrete Syntax Notation 1) codec, -* libosmo-gprs-llc - LLC (Logical Link Control) layer, -* libosmo-gprs-rlcmac - RLC/MAC message definitions. + +* libosmo-csn1 - CSN.1 (Concrete Syntax Notation 1) codec; +* libosmo-gprs-rlcmac - RLC/MAC as per 3GPP TS 44.060, TS 44.018; +* libosmo-gprs-llc - LLC (Logical Link Control) as per 3GPP TS 44.064; +* libosmo-gprs-gmm - GMM (GPRS Mobility Management) as per 3GPP TS 24.008 section 9.4; +* libosmo-gprs-sm - SM (GPRS Session Management) as per 3GPP TS 24.008 section 9.5; +* libosmo-gprs-sndcp - SNDCP (Subnetwork Dependent Convergence Protocol) as per 3GPP TS 44.065. Homepage -------- -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34148 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I0572e9435330c15469f6609505867c21be9c3483 Gerrit-Change-Number: 34148 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: README.md: sort dependencies, document smpp.pdu
by Florian Klink 13 Aug '23

13 Aug '23

Florian Klink has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34147 ) Change subject: README.md: sort dependencies, document smpp.pdu ...................................................................... README.md: sort dependencies, document smpp.pdu This dependency is currently only mentioned in requirements.txt, it makes sense to also document it here. Change-Id: I89760dd4008829c91fafbd442483d076c92a7ed4 --- M README.md 1 file changed, 21 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/47/34147/1 diff --git a/README.md b/README.md index c3c5a25..7801283 100644 --- a/README.md +++ b/README.md @@ -73,19 +73,20 @@ Please install the following dependencies: + - bidict + - cmd2 >= 1.5.0 + - colorlog + - construct >= 2.9.51 + - gsm0338 + - jsonpath-ng + - packaging + - pycryptodomex - pyscard - pyserial - pytlv - - cmd2 >= 1.5.0 - - jsonpath-ng - - construct >= 2.9.51 - - bidict - - gsm0338 - pyyaml >= 5.1 + - smpp.pdu (from `github.com/hologram-io/smpp.pdu`) - termcolor - - colorlog - - packaging - - pycryptodomex Example for Debian: ```sh -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I89760dd4008829c91fafbd442483d076c92a7ed4 Gerrit-Change-Number: 34147 Gerrit-PatchSet: 1 Gerrit-Owner: Florian Klink <flokli(a)flokli.de> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: setup.py: fix package name
by Florian Klink 13 Aug '23

13 Aug '23

Florian Klink has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34146 ) Change subject: setup.py: fix package name ...................................................................... setup.py: fix package name The package providing the serial python module seems to be called pyserial, which also matches what's written in requirements.txt. Change-Id: I71ef6a19a487101e552219f10f2fa6215b966abd --- M setup.py 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/46/34146/1 diff --git a/setup.py b/setup.py index f776443..620e246 100644 --- a/setup.py +++ b/setup.py @@ -10,7 +10,7 @@ description='Tools related to SIM/USIM/ISIM cards', install_requires=[ "pyscard", - "serial", + "pyserial", "pytlv", "cmd2 >= 1.5.0", "jsonpath-ng", -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71ef6a19a487101e552219f10f2fa6215b966abd Gerrit-Change-Number: 34146 Gerrit-PatchSet: 1 Gerrit-Owner: Florian Klink <flokli(a)flokli.de> Gerrit-MessageType: newchange

1 0

[L] Change in libosmo-netif[master]: stream: Add client-side (segmentation) support for IPA
by fixeria 12 Aug '23

12 Aug '23

Attention is currently required from: arehbein, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 ) Change subject: stream: Add client-side (segmentation) support for IPA ...................................................................... Patch Set 17: (1 comment) File examples/ipa-stream-client.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33198/comment/fa5a9e29_27f97f95 PS17, Line 119: num = ntohl(*((int *)(msg->data))); `num = osmo_load32be(msg->data)` -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6 Gerrit-Change-Number: 33198 Gerrit-PatchSet: 17 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Aug 2023 06:52:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in libosmo-netif[master]: stream: Add server-side (segmentation) support for IPA
by fixeria 12 Aug '23

12 Aug '23

Attention is currently required from: arehbein, laforge, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33197 ) Change subject: stream: Add server-side (segmentation) support for IPA ...................................................................... Patch Set 14: (1 comment) File tests/stream/stream_test.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/c156454d_eeb80d36 PS14, Line 410: IPAC_MSG_TYPES may be a good idea to add a `struct value_string` to libosmocore.git. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6c91ff385cb5f36ab6b6c96d0e44997995d0d24c Gerrit-Change-Number: 33197 Gerrit-PatchSet: 14 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Aug 2023 06:47:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in libosmocore[master]: osmo_io: Add io_uring backend
by fixeria 12 Aug '23

12 Aug '23

Attention is currently required from: pespin, daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32536 ) Change subject: osmo_io: Add io_uring backend ...................................................................... Patch Set 10: Code-Review-1 (15 comments) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/7b908048_52ef20e0 PS10, Line 118: return Looks like `msg` is leaked here. Why not just doing `OSMO_ASSERT(msghdr != NULL)` here and above? https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/08e1b5a8_82b81a6d PS10, Line 126: Could not get io_uring_sqe missing `\n` https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/14e794d5_0ee1be02 PS10, Line 130: // Prep msgb/iov cosmetic: use the `/* ... */` syntax for comments https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/fdf60304_f81b136b PS10, Line 135: // NOTE: This only works if we have one read per fd cosmetic: use the `/* ... */` syntax for comments https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/d41c243f_84af22ea PS10, Line 153: return Again, looks like `msg` is leaked here. https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/5325b092_4262a866 PS10, Line 165: Could not get io_uring_sqe Again missing `\n`. https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/6b190445_c091700c PS10, Line 275: /* Fallthrough */ This comment is not really needed since there is no code preceding it. https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/d08ec083_f1575d91 PS10, Line 295: io_uring_peek_cqe Are you sure this is correct? This function is called in the conditional part of the loop, and then here again? https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/55656c2e_28db9f0a PS10, Line 326: Could not get io_uring_sqe missing '\n' https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/0052e548_5fbcfce6 PS10, Line 360: if (!sqe) : OSMO_ASSERT(0); `OSMO_ASSERT(sqe != NULL)` https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/4a83f92c_c58b12e1 PS10, Line 362: (void *)0x0 Why not `NULL`? https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/7671a770_7cc3fa79 PS10, Line 369: if (!sqe) : OSMO_ASSERT(0); `OSMO_ASSERT(sqe != NULL)` https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/edcfbf5a_a7da4d60 PS10, Line 397: return `msg` is leaked here. https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/c8418e78_b814190e PS10, Line 404: Could not get io_uring_sqe missing `\n` https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/ba3a389e_cdf33736 PS10, Line 438: ws -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5152129eb84b31ccc9e02bc2a5c5bdb046d331bc Gerrit-Change-Number: 32536 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Aug 2023 06:36:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: gsm: Introduce functions to convert between FN and RFN (Reduced FN)
by fixeria 12 Aug '23

12 Aug '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34145 ) Change subject: gsm: Introduce functions to convert between FN and RFN (Reduced FN) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib71e8da976f6cc84c3a4ab17b0a8c2101492e243 Gerrit-Change-Number: 34145 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 12 Aug 2023 06:07:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmo-gprs[master]: rlcmac: Fix Starting Time rfn->fn calculation
by pespin 11 Aug '23

11 Aug '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34044 ) Change subject: rlcmac: Fix Starting Time rfn->fn calculation ...................................................................... Patch Set 3: (1 comment) File src/rlcmac/rlcmac_dec.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/8beaeab0_fc803265 PS3, Line 434: rfn_to_fn > Ack https://gerrit.osmocom.org/c/libosmocore/+/34145 gsm: Introduce functions to convert between FN and RFN (Reduced FN) Once it gets review, I'll update this patch to use that one. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34044 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I00741289333853a8db472950ee2ac38dc2c74fd3 Gerrit-Change-Number: 34044 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Aug 2023 18:46:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: gsm: Introduce functions to convert between FN and RFN (Reduced FN)
by pespin 11 Aug '23

11 Aug '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34145 ) Change subject: gsm: Introduce functions to convert between FN and RFN (Reduced FN) ...................................................................... gsm: Introduce functions to convert between FN and RFN (Reduced FN) Implementation ported from osmo-pcu.git e98b315d12fb009359410809f4169f9380f3d933, function bts_rfn_to_fn(). This functionality can be used by osmo-pcu, libosmo-gprs or any other related code which needs to handle RFNs. Change-Id: Ib71e8da976f6cc84c3a4ab17b0a8c2101492e243 --- M include/osmocom/gsm/gsm_utils.h M src/gsm/gsm_utils.c M src/gsm/libosmogsm.map M tests/gsm0408/gsm0408_test.c 4 files changed, 90 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/45/34145/1 diff --git a/include/osmocom/gsm/gsm_utils.h b/include/osmocom/gsm/gsm_utils.h index 721456d..b250c59 100644 --- a/include/osmocom/gsm/gsm_utils.h +++ b/include/osmocom/gsm/gsm_utils.h @@ -188,6 +188,14 @@ char *osmo_dump_gsmtime_buf(char *buf, size_t buf_len, const struct gsm_time *tm); char *osmo_dump_gsmtime_c(const void *ctx, const struct gsm_time *tm); +/* Reduced Frame Number (3GPP TS 44.018 §10.5.2.38) */ +#define GSM_RFN_MODULUS 42432 +uint32_t gsm_rfn2fn(uint16_t rfn, uint32_t curr_fn); +static inline uint16_t gsm_fn2rfn(uint32_t fn) +{ + return fn % GSM_RFN_MODULUS; +} + /* GSM TS 03.03 Chapter 2.6 */ enum gprs_tlli_type { TLLI_LOCAL, diff --git a/src/gsm/gsm_utils.c b/src/gsm/gsm_utils.c index 06b2406..bb40339 100644 --- a/src/gsm/gsm_utils.c +++ b/src/gsm/gsm_utils.c @@ -80,6 +80,7 @@ #include <osmocom/gsm/gsm_utils.h> #include <osmocom/gsm/meas_rep.h> #include <osmocom/gsm/protocol/gsm_04_08.h> +#include <osmocom/gsm/gsm0502.h> #include <stdlib.h> #include <stdint.h> @@ -924,6 +925,45 @@ return osmo_dump_gsmtime_buf(buf, 64, tm); } +#define GSM_RFN_THRESHOLD (GSM_RFN_MODULUS / 2) +uint32_t gsm_rfn2fn(uint16_t rfn, uint32_t curr_fn) +{ + uint32_t curr_rfn; + uint32_t fn_rounded; + const uint32_t rfn32 = rfn; /* used as 32bit for calculations */ + + /* Ensure that all following calculations are performed with the + * relative frame number */ + OSMO_ASSERT(rfn32 < GSM_RFN_MODULUS); + + /* Compute an internal relative frame number from the full internal + frame number */ + curr_rfn = gsm_fn2rfn(curr_fn); + + /* Compute a "rounded" version of the internal frame number, which + * exactly fits in the RFN_MODULUS raster */ + fn_rounded = GSM_TDMA_FN_SUB(curr_fn, curr_rfn); + + /* If the delta between the internal and the external relative frame + * number exceeds a certain limit, we need to assume that the incoming + * request belongs to a the previous rfn period. To correct this, + * we roll back the rounded frame number by one RFN_MODULUS */ + if (GSM_TDMA_FN_DIFF(rfn32, curr_rfn) > GSM_RFN_THRESHOLD) { + /* Race condition between rfn and curr_fn detected: rfn belongs + to the previous RFN_MODULUS cycle, wrapping... */ + if (fn_rounded < GSM_RFN_MODULUS) { + /* Corner case detected: wrapping crosses GSM_MAX_FN border */ + fn_rounded = GSM_TDMA_FN_SUB(GSM_MAX_FN, (GSM_TDMA_FN_SUB(GSM_RFN_MODULUS, fn_rounded))); + } else { + fn_rounded = GSM_TDMA_FN_SUB(fn_rounded, GSM_RFN_MODULUS); + } + } + + /* The real frame number is the sum of the rounded frame number and the + * relative framenumber computed via RACH */ + return GSM_TDMA_FN_SUM(fn_rounded, rfn32); +} + /*! append range1024 encoded data to bit vector * \param[out] bv Caller-provided output bit-vector * \param[in] r Input Range1024 sructure */ diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map index 951cbcb..49db282 100644 --- a/src/gsm/libosmogsm.map +++ b/src/gsm/libosmogsm.map @@ -544,6 +544,7 @@ osmo_dump_gsmtime; osmo_dump_gsmtime_buf; osmo_dump_gsmtime_c; +gsm_rfn2fn; gsm_milenage; gsm_septet_encode; diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c index f4353e2..5b3f5cd 100644 --- a/tests/gsm0408/gsm0408_test.c +++ b/tests/gsm0408/gsm0408_test.c @@ -1946,6 +1946,31 @@ } } +static void test_gsm_rfn2fn(void) +{ + unsigned int i; + struct { + uint32_t curr_fn; + uint16_t rfn; + uint32_t exp_fn; + } input[] = { + { .curr_fn = 0, .rfn = 0, .exp_fn = 0 }, + { .curr_fn = 0, .rfn = 4, .exp_fn = 4 }, + { .curr_fn = 2229729, .rfn = 23322, .exp_fn = 2229786 }, + { .curr_fn = 2229777, .rfn = 23322, .exp_fn = 2229786 }, + { .curr_fn = 1320458, .rfn = 5070, .exp_fn = 1320462 }, + }; + + for (i = 0; i < ARRAY_SIZE(input); i++) { + uint32_t fn = gsm_rfn2fn(input[i].rfn, input[i].curr_fn); + if (fn != input[i].exp_fn) { + printf("Wrong frame number computed! curr_fn=%u, rfn=%u ==> fn=%u, expected fn=%u\n", + input[i].curr_fn, input[i].rfn, fn, input[i].exp_fn); + OSMO_ASSERT(false); + } + } +} + int main(int argc, char **argv) { test_bearer_cap(); @@ -1967,6 +1992,7 @@ test_power_ctrl(); test_rach_tx_integer_raw2val(); test_gsm_gsmtime2fn(); + test_gsm_rfn2fn(); return EXIT_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib71e8da976f6cc84c3a4ab17b0a8c2101492e243 Gerrit-Change-Number: 34145 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmo-gprs[master]: rlcmac: Fix Starting Time rfn->fn calculation
by pespin 11 Aug '23

11 Aug '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34044 ) Change subject: rlcmac: Fix Starting Time rfn->fn calculation ...................................................................... Patch Set 3: -Code-Review (2 comments) File src/rlcmac/rlcmac_dec.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/0895ce09_86c82d6c PS3, Line 434: rfn_to_fn > May be a good idea to have this function in libosmocore.git (`src/gsm/gsm0502. […] Ack File tests/rlcmac/Makefile.am: https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/c9da486f_12cb7d75 PS3, Line 52: rlcmac_types_test_LDADD = $(LDADD) > " No newline at end of right file. […] Ack -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34044 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I00741289333853a8db472950ee2ac38dc2c74fd3 Gerrit-Change-Number: 34044 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Aug 2023 18:02:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log August 2023