August 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sccp[master]: asp: Monitor SCTP_PEER_ADDR_CHANGE events to re-apply configured Prim...

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34112 ) Change subject: asp: Monitor SCTP_PEER_ADDR_CHANGE events to re-apply configured Primary Address ...................................................................... Patch Set 3: (3 comments) File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34112/comment/8d868c9e_b8fe5409 PS3, Line 1529: anoter another https://gerrit.osmocom.org/c/libosmo-sccp/+/34112/comment/959aabfa_f3dc7b48 PS3, Line 1529: is was (this is important for understanding this IMHO, another address was made primary before and here it gets replaced with the primary address configured via VTY) https://gerrit.osmocom.org/c/libosmo-sccp/+/34112/comment/139f0143_c1b18dd1 PS3, Line 1558: } IMHO this is hard to read, might be worth refactoring to: * return early if notif->sn_paddr_change.spc_state is not relevant * figure ev_addr and compare it with primary configured in VTY * then depending on spc_state do things if it is the same as the vty configured primary address or not -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I2e54e6f9e424350474db6dec6ab604b33a03f88b Gerrit-Change-Number: 34112 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Aug 2023 10:29:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[L] Change in libosmo-sccp[master]: asp: Allow setting IP address as SCTP primary upon conn establishment

by pespin

Attention is currently required from: osmith. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34111 to look at the new patch set (#4). Change subject: asp: Allow setting IP address as SCTP primary upon conn establishment ...................................................................... asp: Allow setting IP address as SCTP primary upon conn establishment This is an initial implementation to set the local SCTP Primary address as well as the peer's Primary Address (through SCTP ASCONF messages). The Primary address is only set upon conn establishment (after connect() for clients, or accept() for severs), which means no logic is introduced to make sure that primary address is kept during the entire operation of the SCTP association (for instance if the Primary address becomes unavailable and the stack changes the primary, and later on that address becomes available again, the primary addres won't be set back to the initially configured one). Related: OS#6076 Change-Id: I4a9fc1a4ad82ed20ece328bc53fca58299d744ca --- M TODO-RELEASE M include/osmocom/sigtran/osmo_ss7.h M src/osmo_ss7.c M src/osmo_ss7_vty.c M tests/vty/ss7_asp_test.vty 5 files changed, 318 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/11/34111/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4a9fc1a4ad82ed20ece328bc53fca58299d744ca Gerrit-Change-Number: 34111 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 11 months

1
0
0 0

[L] Change in libosmo-sccp[master]: asp: Allow setting IP address as SCTP primary upon conn establishment

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34111 ) Change subject: asp: Allow setting IP address as SCTP primary upon conn establishment ...................................................................... Patch Set 3: (4 comments) File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/15267516_6afa8c8d PS3, Line 1285: if (idx_primary >= (int)host_cnt) > How about: […] Ack https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/0260c48a_0ca30e14 PS3, Line 1382: is_primary > is_primary_addr Ack https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/230a12f9_b41271d4 PS3, Line 1402: an > "an" is wrong here Ack https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/75e8a261_6f4c80ec PS3, Line 2067: rc = > previous rc gets overwritten here (check it before?), same in xua_accept_cb() yeah, but I don't really want the entire connection to fail if this feature is not supported (may happen in older kernels). It's fine the way it is now IMHO. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4a9fc1a4ad82ed20ece328bc53fca58299d744ca Gerrit-Change-Number: 34111 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Aug 2023 10:21:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in libosmo-sccp[master]: ss7: Use libosmo-netif's osmo_stream_{cli,srv}_recv() APIs

by osmith

Attention is currently required from: laforge, pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34089 ) Change subject: ss7: Use libosmo-netif's osmo_stream_{cli,srv}_recv() APIs ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34089/comment/fa675f3a_2146fc43 PS1, Line 1951: rc = 0; > Yes, this is fine, we just clear any error code (like -EBADF) which may trigger stuff in the callbac […] Ack https://gerrit.osmocom.org/c/libosmo-sccp/+/34089/comment/aa78c0fd_55606344 PS1, Line 1954: if (rc < 0) { > I prefer keeping the 2 scenarios separate, even if we end up doing the same right now. […] Ack -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: If3d78b636e8e224aa9c8597d0b242e29d3e3c84e Gerrit-Change-Number: 34089 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Aug 2023 10:13:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[L] Change in libosmo-sccp[master]: asp: Allow setting IP address as SCTP primary upon conn establishment

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34111 ) Change subject: asp: Allow setting IP address as SCTP primary upon conn establishment ...................................................................... Patch Set 3: (4 comments) File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/43d2e6c0_85f75efb PS3, Line 1285: if (idx_primary >= (int)host_cnt) How about: ``` if (idx_primary >= (int)host_cnt || idx_primary < -1) ``` https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/cef205ed_a2314bf3 PS3, Line 1382: is_primary is_primary_addr https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/d321dd53_bfb5b928 PS3, Line 1402: an "an" is wrong here https://gerrit.osmocom.org/c/libosmo-sccp/+/34111/comment/469c425e_ede9ecb2 PS3, Line 2067: rc = previous rc gets overwritten here (check it before?), same in xua_accept_cb() -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4a9fc1a4ad82ed20ece328bc53fca58299d744ca Gerrit-Change-Number: 34111 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Aug 2023 10:13:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in osmo-hnbgw[master]: Tear down call if local IuUP MGW address changed during MDCX

by pespin

Attention is currently required from: neels, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34043 ) Change subject: Tear down call if local IuUP MGW address changed during MDCX ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This patch is still missing review for the last 3 weeks. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34043 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I32c4a7f838ceb5077bec7945e7976ce455d6b025 Gerrit-Change-Number: 34043 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Aug 2023 09:54:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in libosmo-sccp[master]: ss7: Use libosmo-netif's osmo_stream_{cli,srv}_recv() APIs

by pespin

Attention is currently required from: osmith, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34089 ) Change subject: ss7: Use libosmo-netif's osmo_stream_{cli,srv}_recv() APIs ...................................................................... Patch Set 1: (2 comments) File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34089/comment/615ea90e_ef7bdc8a PS1, Line 1951: rc = 0; > What if rc == -EAGAIN, do you want it to be set to 0? (probably, but just to be sure) Yes, this is fine, we just clear any error code (like -EBADF) which may trigger stuff in the callback caller. It's totally fine returning 0 instead of EAGAIN here, since we already did whatever we had to do (and the READ flag is still set so poll will trigger again if the kernel finds out the socket has somethig else for us). https://gerrit.osmocom.org/c/libosmo-sccp/+/34089/comment/76ce9aee_f6c97fe0 PS1, Line 1954: if (rc < 0) { > why not if (rc <= 0) {? […] I prefer keeping the 2 scenarios separate, even if we end up doing the same right now. In the future we may want to check for specific errors in this path. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: If3d78b636e8e224aa9c8597d0b242e29d3e3c84e Gerrit-Change-Number: 34089 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Aug 2023 09:50:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in libosmo-sccp[master]: ss7: Use libosmo-netif's osmo_stream_{cli,srv}_recv() APIs

by osmith

Attention is currently required from: laforge, pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34089 ) Change subject: ss7: Use libosmo-netif's osmo_stream_{cli,srv}_recv() APIs ...................................................................... Patch Set 1: (2 comments) File src/osmo_ss7.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34089/comment/36a57edf_91cc416e PS1, Line 1951: rc = 0; What if rc == -EAGAIN, do you want it to be set to 0? (probably, but just to be sure) https://gerrit.osmocom.org/c/libosmo-sccp/+/34089/comment/bb41784e_910b250e PS1, Line 1954: if (rc < 0) { why not if (rc <= 0) {? Same for xua_srv_conn_cb -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: If3d78b636e8e224aa9c8597d0b242e29d3e3c84e Gerrit-Change-Number: 34089 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 21 Aug 2023 09:47:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in libosmo-gprs[master]: WIP: DO NOT MERGE

by pespin

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34167 ) Change subject: WIP: DO NOT MERGE ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34167 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2c4e4c207203cc637c20eca931dd3ffd9cefab59 Gerrit-Change-Number: 34167 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

1 year, 11 months

1
0
0 0

[M] Change in libosmo-gprs[master]: rlcmac: ul_tbf: Implement TBF_Starting time (phase1)

by pespin

Attention is currently required from: fixeria. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34046 to look at the new patch set (#6). Change subject: rlcmac: ul_tbf: Implement TBF_Starting time (phase1) ...................................................................... rlcmac: ul_tbf: Implement TBF_Starting time (phase1) This is unfortunately not yet working since lower layers are always sending hardcoded fn=0 and hence ctx->tbf_starting_time calculated in handle_imm_ass()->TBF_StartingTime_to_fn() is wrong. Related: OS#6130 Change-Id: If6b7766ee1ba6667db4e54e897f376f5b27ad73d --- M src/rlcmac/tbf_ul_ass_fsm.c M tests/rlcmac/rlcmac_prim_test.err 2 files changed, 57 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/46/34046/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: If6b7766ee1ba6667db4e54e897f376f5b27ad73d Gerrit-Change-Number: 34046 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023