August 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: msc_a_up_call_assignment_complete: check CSD codec

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34173 ) Change subject: msc_a_up_call_assignment_complete: check CSD codec ...................................................................... Patch Set 1: (1 comment) File src/libmsc/msc_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/34173/comment/e8bde856_2be35fb6 PS1, Line 1488: codec_if_known->type != GSM0808_SCT_CSD) { > indentation what way would you recommend? I intentionally didn't put it on the same level as LOG_TRANS(), so it's clear that this is part of the if condition (not sure if our linter complains about that but IIRC flake8 for python does). -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34173 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I94de84df41bcd050d0e7b4e4fea1c6a6551ef7d3 Gerrit-Change-Number: 34173 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Aug 2023 15:14:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in osmo-msc[master]: csd_bs_list_to_gsm0808_ct: assert -> ret -EINVAL

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34171 ) Change subject: csd_bs_list_to_gsm0808_ct: assert -> ret -EINVAL ...................................................................... csd_bs_list_to_gsm0808_ct: assert -> ret -EINVAL Instead of asserting on an empty list of bearer services, return -EINVAL. This makes the function more similar to sdp_audio_codecs_to_gsm0808_channel_type which also doesn't assert if an empty list of codecs is passed. Related: OS#4394 Change-Id: I15a389e1f7a9d3d17b6531c9836d3d5f9d148267 --- M src/libmsc/csd_bs.c 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/libmsc/csd_bs.c b/src/libmsc/csd_bs.c index 3a2c82a..caea057 100644 --- a/src/libmsc/csd_bs.c +++ b/src/libmsc/csd_bs.c @@ -382,7 +382,8 @@ .ch_indctr = GSM0808_CHAN_DATA, }; - OSMO_ASSERT(list->count); + if (!list->count) + return -EINVAL; if (csd_bs_is_transp(list->bs[0])) { ct->data_transparent = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I15a389e1f7a9d3d17b6531c9836d3d5f9d148267 Gerrit-Change-Number: 34171 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[S] Change in osmo-msc[master]: Cosmetic: fix typo

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34170 ) Change subject: Cosmetic: fix typo ...................................................................... Cosmetic: fix typo Change-Id: Ib707fa66ae789abfa8795b4e521a16e24c77647d --- M src/libmsc/transaction.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve osmith: Verified diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c index 3e458f1..7ae4c7d 100644 --- a/src/libmsc/transaction.c +++ b/src/libmsc/transaction.c @@ -186,7 +186,7 @@ static uint32_t new_call_id = 1; /*! Allocate a new transaction and add it to network list - * \param[in] net Netwokr in which we allocate transaction + * \param[in] net Network in which we allocate transaction * \param[in] subscr Subscriber for which we allocate transaction * \param[in] protocol Protocol (CC/SMS/...) * \param[in] callref Call Reference -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib707fa66ae789abfa8795b4e521a16e24c77647d Gerrit-Change-Number: 34170 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[S] Change in osmo-msc[master]: Cosmetic: fix typo

by osmith

osmith has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34170 ) Change subject: Cosmetic: fix typo ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib707fa66ae789abfa8795b4e521a16e24c77647d Gerrit-Change-Number: 34170 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: deleteVote

1 year, 11 months

1
0
0 0

[S] Change in osmo-msc[master]: Cosmetic: fix typo

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34170 ) Change subject: Cosmetic: fix typo ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib707fa66ae789abfa8795b4e521a16e24c77647d Gerrit-Change-Number: 34170 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Aug 2023 15:12:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in osmo-msc[master]: Cosmetic: fix typo

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34170 ) Change subject: Cosmetic: fix typo ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34170 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib707fa66ae789abfa8795b4e521a16e24c77647d Gerrit-Change-Number: 34170 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Aug 2023 15:12:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: rebar3.lock: Update epcap dep to v1.1.1 to fix compilation error

by fixeria

Attention is currently required from: laforge, pespin, daniel, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34180 ) Change subject: rebar3.lock: Update epcap dep to v1.1.1 to fix compilation error ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I033f0e8882cb64c596c6f2802a1f90b3cfeed621 Gerrit-Change-Number: 34180 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 23 Aug 2023 15:10:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/gerrit: osmo-dia2gsup: test debian 11 and 12

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34181 ) Change subject: jobs/gerrit: osmo-dia2gsup: test debian 11 and 12 ...................................................................... jobs/gerrit: osmo-dia2gsup: test debian 11 and 12 Don't try to build the debian package for debian 10. It fails as rebar3 is not in debian 10. Test the build for debian 11 and 12, which is what we build the package for on obs.osmocom.org. Change-Id: Id01b466f1bacc9cbb8e835f69da765f5fdccfdc2 --- M jobs/gerrit-verifications.yml 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index f6c91fb..9317720 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -189,7 +189,7 @@ repos_url: '{gerrit_url}/erlang/{repos}' gerrit_project: 'erlang/{repos}' cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' - pipeline_binpkgs: "debian:10 debian:12" + pipeline_binpkgs: "debian:11 debian:12" - osmo-e1-hardware: a2_name: JOB_TYPE -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id01b466f1bacc9cbb8e835f69da765f5fdccfdc2 Gerrit-Change-Number: 34181 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/gerrit: osmo-dia2gsup: test debian 11 and 12

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34181 ) Change subject: jobs/gerrit: osmo-dia2gsup: test debian 11 and 12 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id01b466f1bacc9cbb8e835f69da765f5fdccfdc2 Gerrit-Change-Number: 34181 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Aug 2023 15:04:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: add helper func f_set_cpars_csd()

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34176 ) Change subject: msc: add helper func f_set_cpars_csd() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34176/comment/53b0b253_f044… PS1, Line 7190: function f_set_cpars_csd(CallParameters cpars, charstring bs_name, BIT1 async, > private function This function should require an "out CallParameters cpars" which is filled, and not return a copy. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49c29af736cc37c393cecde4c45c4ffd41322bf7 Gerrit-Change-Number: 34176 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Aug 2023 15:03:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023