July 2023 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: TLV_IE_Collection: use snake-style names during from_dict()

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/33660 ) Change subject: TLV_IE_Collection: use snake-style names during from_dict() ...................................................................... TLV_IE_Collection: use snake-style names during from_dict() The TLV_IE_Collection, just like the individual TLV classes, do use their snake-style names when converting from binary to dict using the to_dict() method. It is inconsistent (and a bug) to expect the CamelCase names during encoding (from_dict). After all, we want the output of to_dict() to be used as input to from_dict(). Change-Id: Iabd1ad98c3878659d123eef919c22ca824886f8a --- M pySim/ara_m.py M pySim/tlv.py 2 files changed, 27 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/60/33660/1 diff --git a/pySim/ara_m.py b/pySim/ara_m.py index 59f205c..e2e6da1 100644 --- a/pySim/ara_m.py +++ b/pySim/ara_m.py @@ -349,28 +349,28 @@ # REF ref_do_content = [] if opts.aid: - ref_do_content += [{'AidRefDO': opts.aid}] + ref_do_content += [{'aid_ref_do': opts.aid}] elif opts.aid_empty: - ref_do_content += [{'AidRefEmptyDO': None}] - ref_do_content += [{'DevAppIdRefDO': opts.device_app_id}] + ref_do_content += [{'aid_ref_empty_do': None}] + ref_do_content += [{'dev_app_id_ref_do': opts.device_app_id}] if opts.pkg_ref: - ref_do_content += [{'PkgRefDO': opts.pkg_ref}] + ref_do_content += [{'pkg_ref_do': opts.pkg_ref}] # AR ar_do_content = [] if opts.apdu_never: - ar_do_content += [{'ApduArDO': {'generic_access_rule': 'never'}}] + ar_do_content += [{'apdu_ar_od': {'generic_access_rule': 'never'}}] elif opts.apdu_always: - ar_do_content += [{'ApduArDO': {'generic_access_rule': 'always'}}] + ar_do_content += [{'apdu_ar_do': {'generic_access_rule': 'always'}}] elif opts.apdu_filter: # TODO: multiple filters - ar_do_content += [{'ApduArDO': {'apdu_filter': [opts.apdu_filter]}}] + ar_do_content += [{'apdu_ar_do': {'apdu_filter': [opts.apdu_filter]}}] if opts.nfc_always: - ar_do_content += [{'NfcArDO': {'nfc_event_access_rule': 'always'}}] + ar_do_content += [{'nfc_ar_do': {'nfc_event_access_rule': 'always'}}] elif opts.nfc_never: - ar_do_content += [{'NfcArDO': {'nfc_event_access_rule': 'never'}}] + ar_do_content += [{'nfc_ar_do': {'nfc_event_access_rule': 'never'}}] if opts.android_permissions: - ar_do_content += [{'PermArDO': {'permissions': opts.android_permissions}}] - d = [{'RefArDO': [{'RefDO': ref_do_content}, {'ArDO': ar_do_content}]}] + ar_do_content += [{'perm_ar_do': {'permissions': opts.android_permissions}}] + d = [{'ref_ar_do': [{'ref_do': ref_do_content}, {'ar_do': ar_do_content}]}] csrado = CommandStoreRefArDO() csrado.from_dict(d) res_do = ADF_ARAM.store_data(self._cmd.card._scc._tp, csrado) diff --git a/pySim/tlv.py b/pySim/tlv.py index bd95505..22a14cd 100644 --- a/pySim/tlv.py +++ b/pySim/tlv.py @@ -318,7 +318,7 @@ self.members_by_tag = {} self.members_by_name = {} self.members_by_tag = {m.tag: m for m in self.members} - self.members_by_name = {m.__name__: m for m in self.members} + self.members_by_name = {camel_to_snake(m.__name__): m for m in self.members} # if we are a constructed IE, [ordered] list of actual child-IE instances self.children = kwargs.get('children', []) self.encoded = None -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iabd1ad98c3878659d123eef919c22ca824886f8a Gerrit-Change-Number: 33660 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 11 months

1
0
0 0

[S] Change in libosmocore[master]: coding: remove redundant memset()s in gsm0503_tch_fr{96,144}_encode()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33649 ) Change subject: coding: remove redundant memset()s in gsm0503_tch_fr{96,144}_encode() ...................................................................... coding: remove redundant memset()s in gsm0503_tch_fr{96,144}_encode() Convolutional codes terminated with CONV_TERM_FLUSH (the default) always append k-1 zeroes at the end to "flush" the encoder state. This is the case for both TCH/F9.6 and TCH/F14.4. Change-Id: I4a77ecb9af72b2fd4ea92c42d6748879e73d2cf2 Related: OS#1572 --- M src/coding/gsm0503_coding.c 1 file changed, 16 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c index 1249ce9..3faa512 100644 --- a/src/coding/gsm0503_coding.c +++ b/src/coding/gsm0503_coding.c @@ -3322,7 +3322,7 @@ /* 3.3.2 Block code: b1(60) + b2(60) + b3(60) + b4(60) + pad(4) */ memcpy(&conv[0], &data[0], 4 * 60); - memset(&conv[240], 0, 4); + /* pad(4) is set to 0 by osmo_conv_encode() below */ /* 3.3.3 Convolutional encoder */ osmo_conv_encode(&gsm0503_tch_f96, &conv[0], &cB[0]); @@ -3543,7 +3543,7 @@ /* 3.8.2 Block code: b(290) + pad(4) */ memcpy(&conv[0], &data[0], 290); - memset(&conv[290], 0, 4); + /* pad(4) is set to 0 by osmo_conv_encode() below */ /* 3.8.3 Convolutional encoder */ osmo_conv_encode(&gsm0503_tch_f144, &conv[0], &cB[0]); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4a77ecb9af72b2fd4ea92c42d6748879e73d2cf2 Gerrit-Change-Number: 33649 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[M] Change in libosmocore[master]: coding: implement encoding/decoding API for TCH/F2.4

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33650 ) Change subject: coding: implement encoding/decoding API for TCH/F2.4 ...................................................................... coding: implement encoding/decoding API for TCH/F2.4 See 3GPP TS 45.003 section 3.6. This channel mode is a bit special, because unlike the other CSD specific channel modes it's interleaved over 8 (not 22!) consecutive bursts, just like TCH/FS. Change-Id: I4685376c8deb04db670684c9ebf685ad6fc989fa Related: OS#1572 --- M include/osmocom/coding/gsm0503_coding.h M src/coding/gsm0503_coding.c M src/coding/libosmocoding.map M tests/coding/coding_test.c M tests/coding/coding_test.ok 5 files changed, 97 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved fixeria: Verified diff --git a/include/osmocom/coding/gsm0503_coding.h b/include/osmocom/coding/gsm0503_coding.h index 75e12e6..13d5344 100644 --- a/include/osmocom/coding/gsm0503_coding.h +++ b/include/osmocom/coding/gsm0503_coding.h @@ -101,6 +101,10 @@ int gsm0503_tch_hr48_decode(ubit_t *data, const sbit_t *bursts, int *n_errors, int *n_bits_total); +int gsm0503_tch_fr24_encode(ubit_t *bursts, const ubit_t *data); +int gsm0503_tch_fr24_decode(ubit_t *data, const sbit_t *bursts, + int *n_errors, int *n_bits_total); + int gsm0503_tch_hr24_encode(ubit_t *bursts, const ubit_t *data); int gsm0503_tch_hr24_decode(ubit_t *data, const sbit_t *bursts, int *n_errors, int *n_bits_total); diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c index 3faa512..0e7f689 100644 --- a/src/coding/gsm0503_coding.c +++ b/src/coding/gsm0503_coding.c @@ -3472,6 +3472,54 @@ return gsm0503_tch_fr96_decode(data, bursts, n_errors, n_bits_total); } +/*! Perform channel encoding of a TCH/F2.4 channel as per section 3.6. + * \param[out] bursts Caller-allocated buffer for symbols of 8 bursts, + * 8 * 2 * 58 == 928 bits total. + * \param[in] data Data to be encoded (72 unpacked bits). + * \returns 0 in case of success; negative on error */ +int gsm0503_tch_fr24_encode(ubit_t *bursts, const ubit_t *data) +{ + ubit_t iB[8 * 114], cB[4 * 114]; + const ubit_t h = 0; + + /* 3.6.{1-3} Block code and Convolutional encoder */ + osmo_conv_encode(&gsm0503_tch_f24, &data[0], &cB[0]); + + /* 3.6.4 Interleaving: as specified for the TCH/FS in subclause 3.1.3 */ + gsm0503_tch_fr_interleave(&cB[0], &iB[0]); + + /* 3.6.5 Mapping on a burst: as specified for TCH/FS in subclause 3.1.4 */ + for (unsigned int i = 0; i < 8; i++) + gsm0503_tch_burst_map(&iB[i * 114], &bursts[i * 116], &h, i >> 2); + + return 0; +} + +/*! Perform channel decoding of a TCH/F2.4 channel as per section 3.6. + * \param[out] data Caller-allocated buffer for decoded data (72 unpacked bits). + * \param[in] bursts Buffer containing the symbols of 8 bursts, + * 8 * 2 * 58 == 928 bits total. + * \param[out] n_errors Number of detected bit errors. + * \param[out] n_bits_total Total number of bits. + * \returns Number of unpacked bits used in the output buffer; negative on error. */ +int gsm0503_tch_fr24_decode(ubit_t *data, const sbit_t *bursts, + int *n_errors, int *n_bits_total) +{ + sbit_t iB[8 * 114], cB[4 * 114]; + + /* 3.6.5 Mapping on a burst: as specified for TCH/FS in subclause 3.1.4 */ + for (unsigned int i = 0; i < 8; i++) + gsm0503_tch_burst_unmap(&iB[i * 114], &bursts[i * 116], NULL, i >> 2); + + /* 3.6.4 Interleaving: as specified for the TCH/FS in subclause 3.1.3 */ + gsm0503_tch_fr_deinterleave(&cB[0], &iB[0]); + + /* 3.6.{1-3} Block code and Convolutional encoder */ + osmo_conv_decode_ber(&gsm0503_tch_f24, &cB[0], &data[0], n_errors, n_bits_total); + + return 72; +} + /*! Perform channel encoding of a TCH/H2.4 channel as per section 3.7. * \param[out] bursts Caller-allocated buffer for symbols of 22 bursts, * 22 * 2 * 58 == 2552 bits total. diff --git a/src/coding/libosmocoding.map b/src/coding/libosmocoding.map index b1087e3..0444690 100644 --- a/src/coding/libosmocoding.map +++ b/src/coding/libosmocoding.map @@ -135,6 +135,8 @@ gsm0503_tch_fr48_decode; gsm0503_tch_hr48_encode; gsm0503_tch_hr48_decode; +gsm0503_tch_fr24_encode; +gsm0503_tch_fr24_decode; gsm0503_tch_hr24_encode; gsm0503_tch_hr24_decode; gsm0503_tch_fr144_encode; diff --git a/tests/coding/coding_test.c b/tests/coding/coding_test.c index 7cef7b3..c9508f7 100644 --- a/tests/coding/coding_test.c +++ b/tests/coding/coding_test.c @@ -564,8 +564,14 @@ .half_rate = true, }, { + .name = "TCH/F2.4", + .num_bits = 2 * 36, + .enc_fn = &gsm0503_tch_fr24_encode, + .dec_fn = &gsm0503_tch_fr24_decode, + }, + { .name = "TCH/H2.4", - .num_bits = 2 * 72, + .num_bits = 4 * 36, .enc_fn = &gsm0503_tch_hr24_encode, .dec_fn = &gsm0503_tch_hr24_decode, .half_rate = true, diff --git a/tests/coding/coding_test.ok b/tests/coding/coding_test.ok index c5c145d..1fc2f1d 100644 --- a/tests/coding/coding_test.ok +++ b/tests/coding/coding_test.ok @@ -445,6 +445,16 @@ 11111111 11111111 11111111 11111111 11111111 11111111 11111111 11111111 11111111 11111111 11111111 11111111 11111111 11111111 +test_csd(TCH/F2.4): block #0 (pattern 0x00): n_errors=0 / n_bits_total=456 +00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 +00000000 +test_csd(TCH/F2.4): block #1 (pattern 0xaa): n_errors=0 / n_bits_total=456 +01010101 01010101 01010101 01010101 01010101 01010101 01010101 01010101 +01010101 +test_csd(TCH/F2.4): block #2 (pattern 0xff): n_errors=0 / n_bits_total=456 +11111111 11111111 11111111 11111111 11111111 11111111 11111111 11111111 +11111111 + test_csd(TCH/H2.4): block #0 (pattern 0x00): n_errors=0 / n_bits_total=456 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 @@ -527,6 +537,18 @@ test_csd(TCH/H4.8): FACCH/H (pattern 0x2b): n_errors=0 / n_bits_total=456 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b +test_csd(TCH/F2.4): block #0 (pattern 0x00): n_errors=0 / n_bits_total=456 +00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 +00000000 +test_csd(TCH/F2.4): block #1 (pattern 0xaa): n_errors=138 / n_bits_total=456 +11000010 10010010 10010010 10010010 10010010 10010010 10010101 00011000 +01001010 +test_csd(TCH/F2.4): block #2 (pattern 0xff): n_errors=0 / n_bits_total=456 +11111111 11111111 11111111 11111111 11111111 11111111 11111111 11111111 +11111111 +test_csd(TCH/F2.4): FACCH/F (pattern 0x2b): n_errors=0 / n_bits_total=456 +2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b + test_csd(TCH/H2.4): block #0 (pattern 0x00): n_errors=38 / n_bits_total=456 00000000 00000000 00000101 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4685376c8deb04db670684c9ebf685ad6fc989fa Gerrit-Change-Number: 33650 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[M] Change in libosmocore[master]: coding: implement encoding/decoding API for TCH/F2.4

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33650 ) Change subject: coding: implement encoding/decoding API for TCH/F2.4 ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4685376c8deb04db670684c9ebf685ad6fc989fa Gerrit-Change-Number: 33650 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 09 Jul 2023 19:14:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in osmo-bts[master]: osmo-bts-trx: implement FACCH/[FH] support for CSD

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33586 ) Change subject: osmo-bts-trx: implement FACCH/[FH] support for CSD ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4c6736e84c271240d457998de688c0baf59fe578 Gerrit-Change-Number: 33586 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 09 Jul 2023 19:10:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in libosmocore[master]: coding: implement encoding/decoding API for TCH/F2.4

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33650 ) Change subject: coding: implement encoding/decoding API for TCH/F2.4 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4685376c8deb04db670684c9ebf685ad6fc989fa Gerrit-Change-Number: 33650 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 09 Jul 2023 19:09:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in libosmocore[master]: coding: remove redundant memset()s in gsm0503_tch_fr{96,144}_encode()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33649 ) Change subject: coding: remove redundant memset()s in gsm0503_tch_fr{96,144}_encode() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4a77ecb9af72b2fd4ea92c42d6748879e73d2cf2 Gerrit-Change-Number: 33649 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 09 Jul 2023 19:08:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in libosmo-netif[master]: stream (cosmetic): Fix osmo_panic log fmts

by fixeria

Attention is currently required from: arehbein, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33206 ) Change subject: stream (cosmetic): Fix osmo_panic log fmts ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id082a9473b788f8de20cdc2ba4430b3289f4ce5a Gerrit-Change-Number: 33206 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 09 Jul 2023 18:04:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in pysim[master]: pySim/transport: Use newly-defined ResTuple type

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33659 ) Change subject: pySim/transport: Use newly-defined ResTuple type ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I122589e8aec4bf66dc2e86d7602ebecb771dcb93 Gerrit-Change-Number: 33659 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 09 Jul 2023 18:03:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in pysim[master]: pySim/transport: More type annotations

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33657 ) Change subject: pySim/transport: More type annotations ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I62e081271e3a579851a588a4ed7282017e56f852 Gerrit-Change-Number: 33657 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 09 Jul 2023 18:02:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2023