June 2023 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: modem_atcmd: make card reset cards.py compatible
by fixeria 02 Jun '23

02 Jun '23

Attention is currently required from: tobias. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33080 ) Change subject: modem_atcmd: make card reset cards.py compatible ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/33080/comment/0e8e0012_8f9111ac PS1, Line 7: make card reset cards.py compatible Thanks for your contribution. Reading the patch, I am trying to understand if we really need this. Most of the implementations raise an exception if resetting the card fails, and `cards.py` does not seem to expect/catch them. Only `pscs.py` returns an integer, both `serial.py` and `calypso.py` return `None`. I suggest the following: * modify `pcsc.py`, so that it does not `return 1`; * add a `try-except` block to `cards.py`. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I79d0fc87919efae4ee89881b7840c0e809bd7918 Gerrit-Change-Number: 33080 Gerrit-PatchSet: 1 Gerrit-Owner: tobias <t-osmocom.org(a)tobias.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tobias <t-osmocom.org(a)tobias.org> Gerrit-Comment-Date: Fri, 02 Jun 2023 10:29:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: modem_atcmd: raise ProtocolError instead of ReaderError on CME ERROR
by fixeria 02 Jun '23

02 Jun '23

Attention is currently required from: tobias. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33079 ) Change subject: modem_atcmd: raise ProtocolError instead of ReaderError on CME ERROR ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33079 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I82b50408328f8eaaee5c9e311c4620d20f930642 Gerrit-Change-Number: 33079 Gerrit-PatchSet: 1 Gerrit-Owner: tobias <t-osmocom.org(a)tobias.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tobias <t-osmocom.org(a)tobias.org> Gerrit-Comment-Date: Fri, 02 Jun 2023 10:15:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-ttcn3-hacks[master]: Added BSC tests for terminating voice group calls
by jolly 02 Jun '23

02 Jun '23

Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 ) Change subject: Added BSC tests for terminating voice group calls ...................................................................... Patch Set 2: (7 comments) File bsc/BSC_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/6ecf2314_2e57… PS1, Line 38: const charstring VGCS_CALL_EST := "VGCS_CALL_EST"; > what about prefixing them with COORD_ or VGCS_COORD_MSG to quicjlt understand those are coordination […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/dd2c29f8_6a07… PS1, Line 98: var boolean uplink_free := false; > I have the feeling you actually want to have some sort of enum containing states, and then update th […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/9856303a_10fd… PS1, Line 106: if (true) { /* VGCS/VBS ASS REQ in SCCP CR */ > sounds like this needs fixing ;) Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/0ca076fe_39e7… PS1, Line 187: [] T.timeout { > iiuc the timeout happens at the end, so you can move all this code block after the alt? Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/346040e8_8c9d… PS1, Line 382: f_sleep(2.0); > why is this needed? it shouldn't? If I don't sleep here, the test will start before the BSC has completed startup and is ready for SCCP connections. Without that sleep the test will fail if this is the first test that is executed. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/6a04a8a9_6475… PS1, Line 494: f_sleep(1.0); > check all this sleeps, I don't see a need for them? Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/d0b5a91e_fa83… PS1, Line 507: connect(call_conn:COORD, chan_conn:COORD); > smells like race condition if this connect takes to much and some of them already sent a message. the functions handlers will wait one second after starting. I hope this prevents the race condition. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6762e8adfb7d5f77df837c698ff70cd7fd715ffe Gerrit-Change-Number: 33150 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 10:05:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: Add templates for talker / listener detection to RSL_Types
by jolly 02 Jun '23

02 Jun '23

Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33143 ) Change subject: Add templates for talker / listener detection to RSL_Types ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33143/comment/92cbfc72_d695… PS1, Line 7: Add RSL_Types for talker / listener detection > not types, but templates. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc936417fedf7dc663c6b7243090a91fc55c06a2 Gerrit-Change-Number: 33143 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 09:58:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: Fixes for I949f731de794b22292b01d0ddf9a75a9e7e7e71d
by jolly 02 Jun '23

02 Jun '23

Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33149 ) Change subject: Fixes for I949f731de794b22292b01d0ddf9a75a9e7e7e71d ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > That patch has not been merged yet. Please fixup the original commit and resubmit. Done. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I147454b10c8f3127172ae84dd31003a7d299f24c Gerrit-Change-Number: 33149 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 09:57:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: Add more parameters for ASCI tests to TestHdlrParams
by jolly 02 Jun '23

02 Jun '23

Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33147 ) Change subject: Add more parameters for ASCI tests to TestHdlrParams ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Let's please have this in the same commit where you actually use them. Ok, removed it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5aaea5a92fcfa737624ef46b56dcfefb74266758 Gerrit-Change-Number: 33147 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 09:56:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: WIP: ASCI related BTS tests
by Jenkins Builder 02 Jun '23

02 Jun '23

Attention is currently required from: jolly. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33142 ) Change subject: WIP: ASCI related BTS tests ...................................................................... Patch Set 2: (1 comment) File bts/BTS_Tests_ASCI.ttcn: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7763): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33142/comment/b1d5d1ce_ecf0… PS2, Line 5: * (C) 2021 by sysmocom - s.m.f.c. GmbH <info(a)sysmocom.de> 's.m.f.c.' may be misspelled - perhaps 's.f.m.c.'? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3a93fa486a48957367d2c727cc0a8eea33d3bf11 Gerrit-Change-Number: 33142 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 02 Jun 2023 09:55:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: Add templates for talker / listener detection to RSL_Types
by jolly 02 Jun '23

02 Jun '23

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33143 to look at the new patch set (#2). Change subject: Add templates for talker / listener detection to RSL_Types ...................................................................... Add templates for talker / listener detection to RSL_Types Change-Id: Ibc936417fedf7dc663c6b7243090a91fc55c06a2 --- M library/RSL_Types.ttcn 1 file changed, 45 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/43/33143/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc936417fedf7dc663c6b7243090a91fc55c06a2 Gerrit-Change-Number: 33143 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-ttcn3-hacks[master]: GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages
by jolly 02 Jun '23

02 Jun '23

Attention is currently required from: jolly, laforge. jolly has uploaded a new patch set (#4) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 ) Change subject: GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages ...................................................................... GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages This adds support for the VBS/VGCS related L3 RR messages to GsmRrL3Union / GsmRrL3Message. Only those with proper L3 header and classic "tabular" syntax are supported so far, no CSN.1 messages with short L2 header for SACCH. Change-Id: I79ca7ee2b94bb370cd7162cfd9db436049998041 --- M library/GSM_RR_Types.ttcn 1 file changed, 125 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/47/32647/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79ca7ee2b94bb370cd7162cfd9db436049998041 Gerrit-Change-Number: 32647 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmo-ttcn3-hacks[master]: Added BSC tests for terminating voice group calls
by jolly 02 Jun '23

02 Jun '23

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 to look at the new patch set (#2). Change subject: Added BSC tests for terminating voice group calls ...................................................................... Added BSC tests for terminating voice group calls Change-Id: I6762e8adfb7d5f77df837c698ff70cd7fd715ffe --- M bsc/BSC_Tests_ASCI.ttcn M bsc/MSC_ConnectionHandler.ttcn 2 files changed, 435 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/50/33150/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6762e8adfb7d5f77df837c698ff70cd7fd715ffe Gerrit-Change-Number: 33150 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0