June 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: osmo-bts-trx: fix recent regression in Tx lchan handlers
by fixeria 03 Jun '23

03 Jun '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33156 ) Change subject: osmo-bts-trx: fix recent regression in Tx lchan handlers ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33156 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4538a8fe6b29f8d6eca33ad27d4a9852e3a3e86c Gerrit-Change-Number: 33156 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 03 Jun 2023 08:16:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: osmo-bts-trx: alloc/free burst buffers in trx_sched_set_lchan()
by fixeria 03 Jun '23

03 Jun '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31672 ) Change subject: osmo-bts-trx: alloc/free burst buffers in trx_sched_set_lchan() ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: > a situation where regular mobile phones were unable to find the network most of the time. I am not sure how could this be related to this patch. I was not able to reproduce this on my side, all phones I tested were able to find the network without problems. > Then, once it found it and it started using PDCH (using osmo-pcu master), I can see osmo-pcu receiving the same PKT CTRL ACK block in every new block.... This is indeed a regression, and yesterday we found the problem. Here is a patch: https://gerrit.osmocom.org/c/osmo-bts/+/33156 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6a5f76023fc492786076a63016f81285b3576c33 Gerrit-Change-Number: 31672 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 03 Jun 2023 08:16:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add VBS/VGCS related templates
by laforge 02 Jun '23

02 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405 ) Change subject: BSSMAP_Templates: Add VBS/VGCS related templates ...................................................................... BSSMAP_Templates: Add VBS/VGCS related templates As we want to test VBS/VGCS related aspects of BSC and/or MSC soon, we will need related templates to construct and match related messages and IEs. This requires titan.ProtocolModules.BSSMAP updated for modern-day VGCS/VBS related message definitions as I submitted in https://gitlab.eclipse.org/eclipse/titan/titan.ProtocolModules.BSSMAP_v11.2… Change-Id: I949f731de794b22292b01d0ddf9a75a9e7e7e71d --- M library/BSSMAP_Templates.ttcn 1 file changed, 728 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn index 02aad9f..c564cfd 100644 --- a/library/BSSMAP_Templates.ttcn +++ b/library/BSSMAP_Templates.ttcn @@ -2,7 +2,7 @@ /* BSSMAP Templates, building on top of BSSAP_Types from Ericsson. * - * (C) 2017-2019 by Harald Welte <laforge(a)gnumonks.org> + * (C) 2017-2023 by Harald Welte <laforge(a)gnumonks.org> * contributions by sysmocom - s.f.m.c. GmbH * All rights reserved. * @@ -396,13 +396,13 @@ } -template BSSMAP_IE_Layer3Information ts_BSSMAP_IE_L3Info(octetstring l3info) := { +template (value) BSSMAP_IE_Layer3Information ts_BSSMAP_IE_L3Info(template (value) octetstring l3info) := { elementIdentifier := '17'O, lengthIndicator := 0, layer3info := l3info } -template BSSMAP_IE_Layer3Information tr_BSSMAP_IE_L3Info(template octetstring l3info) := { +template (present) BSSMAP_IE_Layer3Information tr_BSSMAP_IE_L3Info(template (present) octetstring l3info) := { elementIdentifier := '17'O, lengthIndicator := ?, layer3info := l3info @@ -653,6 +653,32 @@ codecElements := valueof(elem) } +function ts_BSSMAP_IE_CallIdentifier(template (omit) OCT4 cid) return template (omit) BSSMAP_IE_CallIdentifier { + if (istemplatekind(cid, "omit")) { + return omit; + } else { + var template (present) BSSMAP_IE_CallIdentifier ie := { + elementIdentifier := '7F'O, + callIdentifierInfo := cid + } + return ie; + } +} +function tr_BSSMAP_IE_CallIdentifier(template OCT4 cid) return template BSSMAP_IE_CallIdentifier { + if (istemplatekind(cid, "*")) { + return *; + } else if (istemplatekind(cid, "omit")) { + return omit; + } else { + var template BSSMAP_IE_CallIdentifier ie := { + elementIdentifier := '7F'O, + callIdentifierInfo := cid + } + return ie; + } +} + + template (present) BSSMAP_IE_Osmo_OsmuxCID tr_OsmuxCID(template (present) INT1 cid := ?) := { elementIdentifier := 'F1'O, osmuxCID := cid @@ -1962,6 +1988,688 @@ rTC := '00'B /* Response Time is not specified */ } + +/* 3.2.2.55 */ +template (value) BSSMAP_IE_GroupCallReference +ts_BSSMAP_IE_GroupCallRef(template (value) GroupCallRef group_call_ref) :={ + elementIdentifier := '37'O, + lengthIndicator := 0, // overwritten + descrGroupbroadcastCallRef := group_call_ref +} +template (present) BSSMAP_IE_GroupCallReference +tr_BSSMAP_IE_GroupCallRef(template (present) GroupCallRef group_call_ref) :={ + elementIdentifier := '37'O, + lengthIndicator := 0, // overwritten + descrGroupbroadcastCallRef := group_call_ref +} + +/* 3.2.2.88 */ +template (value) BSSMAP_IE_VGCS_FeatureFlags +ts_BSSMAP_IE_VGCS_FeatureFlags(BIT1 tp_ind, BIT2 as_ind, BIT1 bss_res, BIT1 tcp) := { + elementIdentifier := '69'O, + lengthIndicator := 0, // overwritten + TP_Ind := tp_ind, + AS_Ind := as_ind, + BSS_Res := bss_res, + tCP := tcp, + spare := '000'B +}; +template (present) BSSMAP_IE_VGCS_FeatureFlags +tr_BSSMAP_IE_VGCS_FeatureFlags(BIT1 tp_ind, BIT2 as_ind, BIT1 bss_res, BIT1 tcp) := { + elementIdentifier := '69'O, + lengthIndicator := ?, + TP_Ind := tp_ind, + AS_Ind := as_ind, + BSS_Res := bss_res, + tCP := tcp, + spare := ? +}; + +/* 3.2.2.98 */ +template (value) BSSMAP_IE_ApplicationData +ts_BSSMAP_IE_ApplicationData(template (value) OCT9 adi) := { + elementIdentifier := '78'O, + lengthIndicator := 0, // overwritten + applicationDataInfo := adi +}; +template (present) BSSMAP_IE_ApplicationData +tr_BSSMAP_IE_ApplicationData(template (present) OCT9 adi) := { + elementIdentifier := '78'O, + lengthIndicator := ?, + applicationDataInfo := adi +}; + +/* 3.2.2.99 */ +template (value) BSSMAP_IE_DataIdentity +ts_BSSMAP_IE_DataIdentity(template (value) DataIdentity data_id) := { + elementIdentifier := '79'O, + lengthIndicator := 0, // overwritten + dataIdentityInfo := data_id +}; +template (present) BSSMAP_IE_DataIdentity +tr_BSSMAP_IE_DataIdentity(template (present) DataIdentity data_id) := { + elementIdentifier := '79'O, + lengthIndicator := ?, + dataIdentityInfo := data_id +}; + +/* 3.2.2.52 */ +template (value) BSSMAP_IE_AssignmentRequirement +ts_BSSMAP_IE_AssRequirement(template (value) OCT1 ass_rqm) := { + elementIdentifier := '33'O, + assignmentRequirement := ass_rqm +} +template (present) BSSMAP_IE_AssignmentRequirement +tr_BSSMAP_IE_AssRequirement(template (present) OCT1 ass_rqm) := { + elementIdentifier := '33'O, + assignmentRequirement := ass_rqm +} + +/* 3.2.2.89 */ +function ts_BSSMAP_IE_TalkerPriority(template (omit) BIT2 prio) +return template (omit) BSSMAP_IE_TalkerPriority { + if (istemplatekind(prio, "omit")) { + return omit; + } else { + var template (present) BSSMAP_IE_TalkerPriority tp := { + elementIdentifier := '6A'O, + priority := prio, + spare := '000000'B + }; + return tp; + } +} +function tr_BSSMAP_IE_TalkerPriority(template BIT2 prio) +return template BSSMAP_IE_TalkerPriority { + if (istemplatekind(prio, "omit")) { + return omit; + } else if (istemplatekind(prio, "*")) { + return *; + } else { + var template BSSMAP_IE_TalkerPriority tp := { + elementIdentifier := '6A'O, + priority := prio, + spare := ? + } + return tp; + } +} + +/* 3.2.2.90 */ +template (value) BSSMAP_IE_EmergencySetIndication +ts_BSSMAP_IE_EmergencySetIndication := { + elementIdentifier := '6B'O +} +template (present) BSSMAP_IE_EmergencySetIndication +tr_BSSMAP_IE_EmergencySetIndication := { + elementIdentifier := '6B'O +} + + + + +/* Section 3.2.1.50 */ +template (value) PDU_BSSAP +ts_BSSMAP_VGCS_VBS_Setup(template (value) GroupCallRef group_call_ref, + template (omit) BSSMAP_IE_VGCS_FeatureFlags feature_flags := omit) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSSetup := { + messageType := '04'O, + groupCallReference := ts_BSSMAP_IE_GroupCallRef(group_call_ref), + priority := omit, + vGCS_FeatureFlags := feature_flags + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_VGCS_VBS_Setup(template (present) GroupCallRef group_call_ref, + template BSSMAP_IE_VGCS_FeatureFlags feature_flags := *) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSSetup := { + messageType := '04'O, + groupCallReference := tr_BSSMAP_IE_GroupCallRef(group_call_ref), + priority := *, + vGCS_FeatureFlags := feature_flags + } + } + } +} + +/* Section 3.2.1.51 */ +template (value) PDU_BSSAP +ts_BSSMAP_VGCS_VBS_SetupAck(template (omit) BSSMAP_IE_VGCS_FeatureFlags feature_flags := omit) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSSetupAck := { + messageType := '05'O, + vGCS_FeatureFlags := feature_flags + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_VGCS_VBS_SetupAck(template BSSMAP_IE_VGCS_FeatureFlags feature_flags := *) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSSetupAck := { + messageType := '05'O, + vGCS_FeatureFlags := feature_flags + } + } + } +} + +/* Section 3.2.1.52 */ +template (value) PDU_BSSAP +ts_BSSMAP_VGCS_VBS_SetupRefuse(BssmapCause cause) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSSetupRefuse := { + messageType := '06'O, + cause := ts_BSSMAP_IE_Cause(cause) + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_VGCS_VBS_SetupRefuse(template (present) myBSSMAP_Cause cause := ?) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSSetupRefuse := { + messageType := '06'O, + cause := tr_BSSMAP_IE_Cause(cause) + } + } + } +} + +/* Section 3.2.1.53 */ +template (value) PDU_BSSAP +ts_BSSMAP_VGCS_VBS_AssignmentReq(template (value) BSSMAP_IE_ChannelType ch_type, + template (value) OCT1 ass_requirement, + template (value) BSSMAP_IE_CellIdentifier cell_id, + template (value) GroupCallRef group_call_ref, + template (omit) BSSMAP_IE_CircuitIdentityCode cic := omit, + template (omit) BSSMAP_IE_AoIP_TransportLayerAddress aoip := omit, + template (omit) OCT4 call_id := omit) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSAssignmentRequest := { + messageType := '07'O, /* overwritten */ + channelType := ch_type, + assignmentRequirement := ts_BSSMAP_IE_AssRequirement(ass_requirement), + cellIdentifier := cell_id, + groupCallReference := ts_BSSMAP_IE_GroupCallRef(group_call_ref), + priority := omit, + circuitIdentityCode := cic, + downLinkDTX_Flag := omit, + encryptionInformation := omit, + vSTK_RAND := omit, + vSTK := omit, + cellIdentifierListSegment := omit, + aoIPTransportLayer := aoip, + callIdentifier := ts_BSSMAP_IE_CallIdentifier(call_id), + codecList := omit + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_VGCS_VBS_AssignmentReq(template (present) BSSMAP_IE_ChannelType ch_type, + template (present) OCT1 ass_requirement, + template (present) BSSMAP_IE_CellIdentifier cell_id, + template (present) GroupCallRef group_call_ref, + template BSSMAP_IE_CircuitIdentityCode cic := *, + template BSSMAP_IE_AoIP_TransportLayerAddress aoip := ?, + template OCT4 call_id := ?) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSAssignmentRequest := { + messageType := '07'O, /* overwritten */ + channelType := ch_type, + assignmentRequirement := tr_BSSMAP_IE_AssRequirement(ass_requirement), + cellIdentifier := cell_id, + groupCallReference := tr_BSSMAP_IE_GroupCallRef(group_call_ref), + priority := omit, + circuitIdentityCode := cic, + downLinkDTX_Flag := omit, + encryptionInformation := omit, + vSTK_RAND := omit, + vSTK := omit, + cellIdentifierListSegment := omit, + aoIPTransportLayer := aoip, + callIdentifier := tr_BSSMAP_IE_CallIdentifier(call_id), + codecList := omit + } + } + } +} + +/* Section 3.2.1.54 */ +template (value) PDU_BSSAP +ts_BSSMAP_VGCS_VBS_AssignmentRes(template (value) BSSMAP_IE_ChannelType ch_type, + template (value) BSSMAP_IE_CellIdentifier cell_id, + template (omit) BSSMAP_IE_ChosenChannel chosen_ch := omit, + template (omit) BSSMAP_IE_CircuitIdentityCode cic := omit, + template (omit) BSSMAP_IE_AoIP_TransportLayerAddress aoip := omit, + template (omit) BSSMAP_IE_SpeechCodec speech_codec := omit, + template (omit) OCT4 call_id := omit) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSAssignmentResult := { + messageType := '1C'O, /* overwritten */ + channelType := ch_type, + cellIdentifier := cell_id, + chosenChannel := chosen_ch, + circuitIdentityCode := cic, + circuitPool := omit, + aoIPTransportLayer := aoip, + speechCodec := speech_codec, + callIdentifier := ts_BSSMAP_IE_CallIdentifier(call_id) + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_VGCS_VBS_AssignmentRes(template (present) BSSMAP_IE_ChannelType ch_type, + template (present) BSSMAP_IE_CellIdentifier cell_id, + template BSSMAP_IE_ChosenChannel chosen_ch := *, + template BSSMAP_IE_CircuitIdentityCode cic := omit, + template BSSMAP_IE_AoIP_TransportLayerAddress aoip := ?, + template BSSMAP_IE_SpeechCodec speech_codec := ?, + template OCT4 call_id := ?) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSAssignmentResult := { + messageType := '1C'O, /* overwritten */ + channelType := ch_type, + cellIdentifier := cell_id, + chosenChannel := chosen_ch, + circuitIdentityCode := cic, + circuitPool := *, + aoIPTransportLayer := aoip, + speechCodec := speech_codec, + callIdentifier := tr_BSSMAP_IE_CallIdentifier(call_id) + } + } + } +} + +/* Section 3.2.1.55 */ +template (value) PDU_BSSAP +ts_BSSMAP_VGCS_VBS_AssignmentFail(BssmapCause cause) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSAssignmentFailure := { + messageType := '1D'O, /* overwritten */ + cause := ts_BSSMAP_IE_Cause(cause), + /* we only implement AoIP for now... */ + circuitPool := omit, + circuitPoolList := omit + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_VGCS_VBS_AssignmentFail(template (present) myBSSMAP_Cause cause := ?) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSAssignmentFailure := { + messageType := '1D'O, /* overwritten */ + cause := tr_BSSMAP_IE_Cause(cause), + /* we only implement AoIP for now... */ + circuitPool := omit, + circuitPoolList := omit + } + } + } +} + +/* Section 3.2.1.56 */ +template (value) PDU_BSSAP +ts_BSSMAP_VGCS_VBS_QueuingInd +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSQueuingIndication := { + messageType := '1E'O + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_VGCS_VBS_QueuingInd +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSQueuingIndication := { + messageType := '1E'O + } + } + } +} + +/* Section 3.2.1.57 */ +template (value) PDU_BSSAP +ts_BSSMAP_UplinkReq_L3(template (value) BIT2 priority, + template (omit) BSSMAP_IE_CellIdentifier cell_id, + template (value) octetstring l3_info) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRequest := { + messageType := '1F'O, + talkerPriority := ts_BSSMAP_IE_TalkerPriority(priority), + cellIdentifier := cell_id, + layer3Information := ts_BSSMAP_IE_L3Info(l3_info), + mobileIdentity := omit + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_UplinkReq_L3(template (present) BIT2 priority, + template BSSMAP_IE_CellIdentifier cell_id, + template (present) octetstring l3_info) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRequest := { + messageType := '1F'O, + talkerPriority := tr_BSSMAP_IE_TalkerPriority(priority), + cellIdentifier := cell_id, + layer3Information := tr_BSSMAP_IE_L3Info(l3_info), + mobileIdentity := omit + } + } + } +} +template (value) PDU_BSSAP +ts_BSSMAP_UplinkReq_MI(template (omit) BIT2 priority, + template (omit) BSSMAP_IE_CellIdentifier cell_id, + template (value) BSSMAP_IE_MobileIdentity mobile_id) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRequest := { + messageType := '1F'O, + talkerPriority := ts_BSSMAP_IE_TalkerPriority(priority), + cellIdentifier := cell_id, + layer3Information := omit, + mobileIdentity := mobile_id + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_UplinkReq_MI(template BIT2 priority, + template (omit) BSSMAP_IE_CellIdentifier cell_id, + template (present) BSSMAP_IE_MobileIdentity mobile_id) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRequest := { + messageType := '1F'O, + talkerPriority := tr_BSSMAP_IE_TalkerPriority(priority), + cellIdentifier := cell_id, + layer3Information := omit, + mobileIdentity := mobile_id + } + } + } +} + +/* 3.2.1.58 */ +template (value) PDU_BSSAP +ts_BSSMAP_UplinkReqAck(template (omit) BIT2 priority, + template (omit) BSSMAP_IE_EmergencySetIndication ems := omit, + template (omit) BSSMAP_IE_TalkerIdentity talker_id := omit) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRequestAck := { + messageType := '27'O, + talkerPriority := ts_BSSMAP_IE_TalkerPriority(priority), + emergencySetIndication := ems, + talkerIdentity := talker_id + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_UplinkReqAck(template BIT2 priority, + template BSSMAP_IE_EmergencySetIndication ems := *, + template BSSMAP_IE_TalkerIdentity talker_id := *) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRequestAck := { + messageType := '27'O, + talkerPriority := tr_BSSMAP_IE_TalkerPriority(priority), + emergencySetIndication := ems, + talkerIdentity := talker_id + } + } + } +} + +/* 3.2.1.59 */ +template (value) PDU_BSSAP +ts_BSSMAP_UplinkReqConf(template (value) BSSMAP_IE_CellIdentifier cell_id, + template (omit) BSSMAP_IE_TalkerIdentity talker_id := omit, + template (value) octetstring l3_info) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRequestConfirmation := { + messageType := '49'O, + cellIdentifier := cell_id, + talkerIdentity := talker_id, + layer3Information := ts_BSSMAP_IE_L3Info(l3_info) + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_UplinkReqConf(template (present) BSSMAP_IE_CellIdentifier cell_id, + template BSSMAP_IE_TalkerIdentity talker_id := *, + template (present) octetstring l3_info) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRequestConfirmation := { + messageType := '49'O, + cellIdentifier := cell_id, + talkerIdentity := talker_id, + layer3Information := tr_BSSMAP_IE_L3Info(l3_info) + } + } + } +} + + +/* 3.2.1.60 */ +template (value) PDU_BSSAP +ts_BSSMAP_UplinkRelInd(BssmapCause cause, template (omit) BIT2 prio) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkReleaseIndication := { + messageType := '4A'O, + cause := ts_BSSMAP_IE_Cause(cause), + talkerPriority := ts_BSSMAP_IE_TalkerPriority(prio) + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_UplinkRelInd(template (present) myBSSMAP_Cause cause, template BIT2 prio) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkReleaseIndication := { + messageType := '4A'O, + cause := tr_BSSMAP_IE_Cause(cause), + talkerPriority := tr_BSSMAP_IE_TalkerPriority(prio) + } + } + } +} + + +/* 3.2.1.61 */ +template (value) PDU_BSSAP +ts_BSSMAP_UplinkRejCmd(BssmapCause cause, + template (omit) BIT2 cur_talker_prio := omit, + template (omit) BIT2 rej_talker_prio := omit, + template (omit) BSSMAP_IE_TalkerIdentity talker_id := omit) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRejectCommand := { + messageType := '4B'O, + cause := ts_BSSMAP_IE_Cause(cause), + currentTalkerPriority := ts_BSSMAP_IE_TalkerPriority(cur_talker_prio), + rejectedTalkerPriority := ts_BSSMAP_IE_TalkerPriority(rej_talker_prio), + talkerIdentity := talker_id + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_UplinkRejCmd(template (present) myBSSMAP_Cause cause, + template BIT2 cur_talker_prio := *, + template BIT2 rej_talker_prio := *, + template BSSMAP_IE_TalkerIdentity talker_id := *) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRejectCommand := { + messageType := '4B'O, + cause := tr_BSSMAP_IE_Cause(cause), + currentTalkerPriority := tr_BSSMAP_IE_TalkerPriority(cur_talker_prio), + rejectedTalkerPriority := tr_BSSMAP_IE_TalkerPriority(rej_talker_prio), + talkerIdentity := talker_id + } + } + } +} + + +/* 3.2.1.62 */ +template (value) PDU_BSSAP +ts_BSSMAP_UplinkRelCmd(BssmapCause cause) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkReleaseCommand := { + messageType := '4C'O, + cause := ts_BSSMAP_IE_Cause(cause) + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_UplinkRelCmd(template (present) myBSSMAP_Cause cause) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkReleaseCommand := { + messageType := '4C'O, + cause := tr_BSSMAP_IE_Cause(cause) + } + } + } +} + + +/* 3.2.1.63 */ +template (value) PDU_BSSAP +ts_BSSMAP_UplinkSeizedCmd(BssmapCause cause, + template (omit) BIT2 talker_prio := omit, + template (omit) BSSMAP_IE_EmergencySetIndication emerg := omit, + template (omit) BSSMAP_IE_TalkerIdentity talker_id := omit) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkSeizedCommand := { + messageType := '4D'O, + cause := ts_BSSMAP_IE_Cause(cause), + talkerPriority := ts_BSSMAP_IE_TalkerPriority(talker_prio), + emergencySetIndication := emerg, + talkerIdentity := talker_id + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_UplinkSeizedCmd(template (present) myBSSMAP_Cause cause, + template BIT2 talker_prio := *, + template BSSMAP_IE_EmergencySetIndication emerg := *, + template BSSMAP_IE_TalkerIdentity talker_id := *) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkSeizedCommand := { + messageType := '4D'O, + cause := tr_BSSMAP_IE_Cause(cause), + talkerPriority := tr_BSSMAP_IE_TalkerPriority(talker_prio), + emergencySetIndication := emerg, + talkerIdentity := talker_id + } + } + } +} + + + +/* Section 3.2.1.82 */ +template (value) PDU_BSSAP +ts_BSSMAP_NotificationData(template (value) OCT9 app_data, template (value) DataIdentity data_identity) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + notificationData := { + messageType := '62'O, + applicationData := ts_BSSMAP_IE_ApplicationData(app_data), + dataIdentity := ts_BSSMAP_IE_DataIdentity(data_identity), + mSISDN := omit + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_NotificationData(template (present) OCT9 app_data, template (present) DataIdentity data_identity) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + notificationData := { + messageType := '62'O, + applicationData := tr_BSSMAP_IE_ApplicationData(app_data), + dataIdentity := tr_BSSMAP_IE_DataIdentity(data_identity), + mSISDN := ? + } + } + } +} + + + template (value) PDU_BSSAP ts_BSSMAP_Perform_Location_Request(template (omit) BSSMAP_IE_IMSI imsi, template (omit) BSSMAP_IE_CellIdentifier cellIdentifier := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I949f731de794b22292b01d0ddf9a75a9e7e7e71d Gerrit-Change-Number: 32405 Gerrit-PatchSet: 9 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages
by laforge 02 Jun '23

02 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 ) Change subject: GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages ...................................................................... GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages This adds support for the VBS/VGCS related L3 RR messages to GsmRrL3Union/GsmRrL3Message. Only those with proper L3 header and classic "tabular" syntax are supported so far, no CSN.1 messages with short L2 header for SACCH. Change-Id: I79ca7ee2b94bb370cd7162cfd9db436049998041 --- M library/GSM_RR_Types.ttcn 1 file changed, 126 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn index d41e035..464d060 100644 --- a/library/GSM_RR_Types.ttcn +++ b/library/GSM_RR_Types.ttcn @@ -83,8 +83,16 @@ EXTENDED_MEASUREMENT_REPORT ('00110110'B), EXTENDED_MEASUREMENT_ORDER ('00110111'B), GPRS_SUSPENSION_REQUEST ('00110100'B), - //MBMS_ANNOUNCEMENT ('00010110'B), duplicate? - //SERVICE_INFORMATION ('00110110'B), duplicate? + //MBMS_ANNOUNCEMENT ('00010110'B), duplicate, DL only + //SERVICE_INFORMATION ('00110110'B), duplicate, DL only + + VGCS_UPLINK_GRANT ('00001001'B), + UPLINK_RELEASE ('00001110'B), + UPLINK_BUSY ('00101010'B), + TALKER_INDICATION ('00010001'B), + PRIORITY_UPLINK_REQUEST ('01100110'B), + DATA_INDICATION ('01100111'B), + DATA_INDICATION2 ('01101000'B), APPLICATION_INFORMATION ('00111000'B), @@ -111,8 +119,8 @@ CDMA2000_CLASSMARK_CHANGE ('01100010'B), INTERSYS_TO_UTRAN_HO_CMD ('01100011'B), INTERSYS_TO_CDMA2000_HO_CMD ('01100100'B), - GERAN_IU_MODE_CLASSMARK_CHG ('01100101'B), - INTERSYS_TO_EUTRAN_HO_CMD ('01100110'B) + GERAN_IU_MODE_CLASSMARK_CHG ('01100101'B) + //INTERSYS_TO_EUTRAN_HO_CMD ('01100110'B) duplicate, DL only } with { variant "FIELDLENGTH(8)" }; /* Table 10.4.2 of Section 10.4 / 3GPP TS 44.018 */ @@ -577,6 +585,92 @@ RestOctets rest_octets } with { variant "" }; + /* 9.1.44 */ + type record CipheringKeySeqNrTV { + HEX1 tag, + CipheringKeySeqNr cksn + } + type record TalkerIndication { + MsClassmark2LV cm2, + MobileIdentityLV mi, + CipheringKeySeqNrTV cksn optional + } with { variant "TAG(cksn, tag = 'B'H)" }; + + /* 9.1.44a */ + type record PriorityUplinkRequest { + OCT1 est_cause, + OCT4 token, + OCT4 reduced_gcr, + MobileIdentityLV mi + } with { variant "" }; + + /* 9.1.44b */ + type record DataIndication { + GsmTmsi tmsi, + OCT9 app_data, + OCT1 data_id + } with { variant "" }; + + /* 9.1.44c */ + type record DataIndication2 { + GsmTmsi tmsi, + OCT4 reduced_gcr, + OCT9 app_data, + OCT1 data_id + } with { variant "" }; + + /* 9.1.46 */ + type record UplinkBusy { + TalkerPrioEmergIndTLV prio optional, + TokenTV token optional, + TalkerIdentityTLV talker_id optional, + UplinkAccessIndTV ul_access_ind optional + } with { variant "" }; + + /* 9.1.48 */ + type record UplinkRelease { + RR_Cause cause + } with { variant "" }; + + /* 9.1.49 */ + type record VgcsUplinkGrant { + RequestReference req_ref, + TimingAdvance ta + } with { variant "" }; + + + /* 10.5.2.64 */ + type record TalkerPrioEmergIndTLV { + OCT1 iei ('31'O), + uint8_t len, + boolean es, + BIT3 spare, + boolean uai_rach, + uint3_t priority + } with { variant (len) "LENGTHTO(es,spare,uai_rach,priority)" + variant "PRESENCE(iei = '31'O)" }; + + /* 10.5.2.65 */ + type record TokenTV { + OCT1 iei ('32'O), + OCT4 token + } with { variant "PRESENCE(iei = '32'O)" }; + + /* 10.5.2.66 */ + type record TalkerIdentityTLV { + OCT1 iei ('33'O), + uint8_t len, + octetstring talker_id + } with { variant (len) "LENGTHTO(talker_id)" + variant "PRESENCE(iei = '33'O)" }; + + /* 10.5.2.74 */ + type record UplinkAccessIndTV { + HEX1 iei ('8'H), + BIT3 spare ('000'B), + boolean uai_rach + } with { variant "PRESENCE(iei = '8'H)" }; + type union RrUnion { /* SystemInformationType1 si1, @@ -648,6 +742,13 @@ MeasurementReport meas_rep, AssignmentCommand ass_cmd, HandoverCommand ho_cmd, + TalkerIndication talker_ind, + PriorityUplinkRequest priority_ul_req, + UplinkBusy uplink_busy, + UplinkRelease uplink_release, + VgcsUplinkGrant vgcs_ul_grant, + DataIndication data_ind, + DataIndication2 data_ind2, octetstring other }; @@ -659,6 +760,13 @@ meas_rep, header.message_type = MEASUREMENT_REPORT; ass_cmd, header.message_type = ASSIGNMENT_COMMAND; ho_cmd, header.message_type = HANDOVER_COMMAND; + talker_ind, header.message_type = TALKER_INDICATION; + priority_ul_req, header.message_type = PRIORITY_UPLINK_REQUEST; + uplink_busy, header.message_type = UPLINK_BUSY; + uplink_release, header.message_type = UPLINK_RELEASE; + vgcs_ul_grant, header.message_type = VGCS_UPLINK_GRANT; + data_ind, header.message_type = DATA_INDICATION; + data_ind2, header.message_type = DATA_INDICATION2; other, OTHERWISE; )" } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79ca7ee2b94bb370cd7162cfd9db436049998041 Gerrit-Change-Number: 32647 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages
by laforge 02 Jun '23

02 Jun '23

Attention is currently required from: jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 ) Change subject: GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > I think this is a result of jolly re-pushing this branch including an older version of this patch.. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79ca7ee2b94bb370cd7162cfd9db436049998041 Gerrit-Change-Number: 32647 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 17:24:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages
by laforge 02 Jun '23

02 Jun '23

Attention is currently required from: jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 ) Change subject: GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79ca7ee2b94bb370cd7162cfd9db436049998041 Gerrit-Change-Number: 32647 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 17:23:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add VBS/VGCS related templates
by laforge 02 Jun '23

02 Jun '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405 ) Change subject: BSSMAP_Templates: Add VBS/VGCS related templates ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I949f731de794b22292b01d0ddf9a75a9e7e7e71d Gerrit-Change-Number: 32405 Gerrit-PatchSet: 9 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 02 Jun 2023 17:23:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages
by laforge 02 Jun '23

02 Jun '23

Attention is currently required from: jolly, pespin. Hello Jenkins Builder, jolly, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 to look at the new patch set (#5). Change subject: GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages ...................................................................... GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages This adds support for the VBS/VGCS related L3 RR messages to GsmRrL3Union/GsmRrL3Message. Only those with proper L3 header and classic "tabular" syntax are supported so far, no CSN.1 messages with short L2 header for SACCH. Change-Id: I79ca7ee2b94bb370cd7162cfd9db436049998041 --- M library/GSM_RR_Types.ttcn 1 file changed, 126 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/47/32647/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79ca7ee2b94bb370cd7162cfd9db436049998041 Gerrit-Change-Number: 32647 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add VBS/VGCS related templates
by laforge 02 Jun '23

02 Jun '23

Attention is currently required from: jolly. Hello Jenkins Builder, jolly, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405 to look at the new patch set (#9). Change subject: BSSMAP_Templates: Add VBS/VGCS related templates ...................................................................... BSSMAP_Templates: Add VBS/VGCS related templates As we want to test VBS/VGCS related aspects of BSC and/or MSC soon, we will need related templates to construct and match related messages and IEs. This requires titan.ProtocolModules.BSSMAP updated for modern-day VGCS/VBS related message definitions as I submitted in https://gitlab.eclipse.org/eclipse/titan/titan.ProtocolModules.BSSMAP_v11.2… Change-Id: I949f731de794b22292b01d0ddf9a75a9e7e7e71d --- M library/BSSMAP_Templates.ttcn 1 file changed, 728 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/32405/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I949f731de794b22292b01d0ddf9a75a9e7e7e71d Gerrit-Change-Number: 32405 Gerrit-PatchSet: 9 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-hnbgw[master]: coverity: fix type of local var
by pespin 02 Jun '23

02 Jun '23

Attention is currently required from: neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33158 ) Change subject: coverity: fix type of local var ...................................................................... Patch Set 1: (1 comment) File src/osmo-hnbgw/context_map.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33158/comment/f6a1b9df_a0478508 PS1, Line 99: if (new_scu_conn_id < 0) { > pespin: that's on 32bit, yes. […] yes, and 64bit arch still have 32 bit int afair, so it will fail in most architectures :) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I2623c06c23691acb75f6ee6ff3a42ac7d10a4b1f Gerrit-Change-Number: 33158 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 02 Jun 2023 16:17:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0