June 2023 - gerrit-log - lists.osmocom.org

[L] Change in osmo-hlr[master]: Port to new libosmogsm 'struct osmo_sub_auth_data2'
by neels 06 Jun '23

06 Jun '23

Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33097 ) Change subject: Port to new libosmogsm 'struct osmo_sub_auth_data2' ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File include/osmocom/hlr/db.h: https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/40756aba_28f89587 PS2, Line 124: /* Like struct osmo_sub_auth_data2, but the keys are in hexdump representation. intentional rename? is sub_auth_data_str also used for osmo_sub_auth_data2? File src/db_hlr.c: https://gerrit.osmocom.org/c/osmo-hlr/+/33097/comment/9c2efa8b_eadbadd7 PS2, Line 289: if (!osmo_is_hexstr(aud->u.umts.k, 32, 64, true)) { (this patch intends no change of length, right?) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I3207c7bfb73e9ff5471e5c26b66639549e4d48a2 Gerrit-Change-Number: 33097 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 05 Jun 2023 22:29:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: tweak lots of logging
by neels 05 Jun '23

05 Jun '23

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171 to look at the new patch set (#3). Change subject: tweak lots of logging ...................................................................... tweak lots of logging Make lots of small tweaks in logging around RUA to SCCP context maps, CN link selection and HNBAP: - remove duplicate log context (e.g. LOGHNB() already shows the HNB Id) - bring more sense into logging categories and levels / reduce noise - add and clarify the details being logged at what points in time Related: SYS#6412 Change-Id: I41275d8c3e272177976a9302795884666c35cd06 --- M include/osmocom/hnbgw/context_map.h M src/osmo-hnbgw/context_map.c M src/osmo-hnbgw/context_map_sccp.c M src/osmo-hnbgw/hnbgw.c M src/osmo-hnbgw/hnbgw_cn.c M src/osmo-hnbgw/hnbgw_hnbap.c M src/osmo-hnbgw/hnbgw_l3.c M src/osmo-hnbgw/hnbgw_rua.c 8 files changed, 96 insertions(+), 41 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/71/33171/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I41275d8c3e272177976a9302795884666c35cd06 Gerrit-Change-Number: 33171 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmo-hnbgw[master]: detect in/active CN links by RANAP RESET
by neels 05 Jun '23

05 Jun '23

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33175 to look at the new patch set (#3). Change subject: detect in/active CN links by RANAP RESET ...................................................................... detect in/active CN links by RANAP RESET Implement cnlink FSM. This is a copy of osmo-bsc/bssmap_reset.c, except for the connection success/failure counting. The reason to exclude the CONN_CFM_FAILURE/_SUCCESS: it is a rather experimental feature and should probably rather be covered by PCSTATE notifications and protocol layer timeout tuning (e.g. SCCP ia timers). Related: SYS#6412 Change-Id: Id3eefdea889a736fd5957b80280fa45b9547b792 --- M include/osmocom/hnbgw/hnbgw.h M include/osmocom/hnbgw/hnbgw_cn.h M src/osmo-hnbgw/Makefile.am A src/osmo-hnbgw/cnlink.c M src/osmo-hnbgw/context_map.c M src/osmo-hnbgw/hnbgw_cn.c M src/osmo-hnbgw/hnbgw_vty.c M src/osmo-hnbgw/tdefs.c M tests/cnpool.vty 9 files changed, 420 insertions(+), 91 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/75/33175/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id3eefdea889a736fd5957b80280fa45b9547b792 Gerrit-Change-Number: 33175 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmo-hnbgw[master]: cnpool: return Paging Resp to the exact CN link that Paged
by neels 05 Jun '23

05 Jun '23

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33177 to look at the new patch set (#3). Change subject: cnpool: return Paging Resp to the exact CN link that Paged ...................................................................... cnpool: return Paging Resp to the exact CN link that Paged Implement Paging record, remembering which CN link paged for which mobile identity, for a set time period roundabout 15 seconds. When receiving a Paging Response from a UE, connect it to the CN link that sent the Paging. Related: SYS#6412 Change-Id: I907dbcaeb442ca5630146f8cad40601c448fc40e --- M include/osmocom/hnbgw/hnbgw.h M src/osmo-hnbgw/cnlink.c M src/osmo-hnbgw/hnbgw_cn.c M src/osmo-hnbgw/tdefs.c 4 files changed, 347 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/77/33177/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I907dbcaeb442ca5630146f8cad40601c448fc40e Gerrit-Change-Number: 33177 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-hnbgw[master]: tweak lots of logging
by Jenkins Builder 05 Jun '23

05 Jun '23

Attention is currently required from: neels. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171 ) Change subject: tweak lots of logging ...................................................................... Patch Set 2: (2 comments) File src/osmo-hnbgw/context_map.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7847): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171/comment/d7f921bd_e8d09351 PS2, Line 133: cnlink_selected->use.remote_addr_name ? " ": "", spaces required around that ':' (ctx:VxW) File src/osmo-hnbgw/hnbgw.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7847): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171/comment/6c2b1055_3b5ea3d9 PS2, Line 369: else { else should follow close brace '}' -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I41275d8c3e272177976a9302795884666c35cd06 Gerrit-Change-Number: 33171 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Jun 2023 21:01:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmo-hnbgw[master]: cnpool: return Paging Resp to the exact CN link that Paged
by Jenkins Builder 05 Jun '23

05 Jun '23

Attention is currently required from: neels. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33177 ) Change subject: cnpool: return Paging Resp to the exact CN link that Paged ...................................................................... Patch Set 2: (2 comments) File src/osmo-hnbgw/hnbgw_cn.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7839): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33177/comment/57f3e9bf_f8ca3b12 PS2, Line 283: if (cnlink_match_paging_mi(cnlink, mi, timeout)) suspect code indent for conditional statements (16, 20) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7839): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33177/comment/7407d2b2_2ded341a PS2, Line 284: return cnlink; Statements should start on a tabstop -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I907dbcaeb442ca5630146f8cad40601c448fc40e Gerrit-Change-Number: 33177 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Jun 2023 21:01:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmo-hnbgw[master]: detect in/active CN links by RANAP RESET
by Jenkins Builder 05 Jun '23

05 Jun '23

Attention is currently required from: neels. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33175 ) Change subject: detect in/active CN links by RANAP RESET ...................................................................... Patch Set 2: (5 comments) File src/osmo-hnbgw/cnlink.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7838): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33175/comment/72df2e48_05eac603 PS2, Line 175: struct hnbgw_cnlink *cnlink = (struct hnbgw_cnlink*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7838): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33175/comment/f1c36c3e_394e79d2 PS2, Line 182: struct hnbgw_cnlink *cnlink = (struct hnbgw_cnlink*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7838): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33175/comment/eb6c64e7_b2cd1e00 PS2, Line 201: struct hnbgw_cnlink *cnlink = (struct hnbgw_cnlink*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7838): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33175/comment/88f498f3_b97b0c94 PS2, Line 208: struct hnbgw_cnlink *cnlink = (struct hnbgw_cnlink*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7838): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33175/comment/6da7405f_4e0c01f5 PS2, Line 230: struct hnbgw_cnlink *cnlink = (struct hnbgw_cnlink*)fi->priv; "(foo*)" should be "(foo *)" -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id3eefdea889a736fd5957b80280fa45b9547b792 Gerrit-Change-Number: 33175 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Jun 2023 20:56:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: dist: package all .cfg files
by neels 05 Jun '23

05 Jun '23

neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33182 ) Change subject: dist: package all .cfg files ...................................................................... Abandoned nonsense -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5fbba1f005c4322a9a11879ebf3dd1d6c25d2cd5 Gerrit-Change-Number: 33182 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 0

[S] Change in osmo-hnbgw[master]: add CTRL transcript tests for cnpool rate ctrs
by neels 05 Jun '23

05 Jun '23

Attention is currently required from: neels. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33135 to look at the new patch set (#4). Change subject: add CTRL transcript tests for cnpool rate ctrs ...................................................................... add CTRL transcript tests for cnpool rate ctrs Related: SYS#6412 Change-Id: I5a9a23c10e3ac85dabbb1d367351bb7c5dfe2526 --- M tests/Makefile.am A tests/test_nodes.ctrl 2 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/35/33135/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33135 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5a9a23c10e3ac85dabbb1d367351bb7c5dfe2526 Gerrit-Change-Number: 33135 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-hnbgw[master]: cnpool: select CN link from pool by NRI or round robin
by neels 05 Jun '23

05 Jun '23

Attention is currently required from: neels. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33136 to look at the new patch set (#4). Change subject: cnpool: select CN link from pool by NRI or round robin ...................................................................... cnpool: select CN link from pool by NRI or round robin This is the bulk of the CN pooling logic but is not working properly without these future patches: - detect in/active CN links by RANAP RESET Id3eefdea889a736fd5957b80280fa45b9547b792 - return Paging Resp to the exact CN link that Paged I907dbcaeb442ca5630146f8cad40601c448fc40e Change-Id: I66fba27cfbe6e2b27ee3443718846ecfbbd8a974 --- M src/osmo-hnbgw/hnbgw_cn.c 1 file changed, 162 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/36/33136/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I66fba27cfbe6e2b27ee3443718846ecfbbd8a974 Gerrit-Change-Number: 33136 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0