Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33529 )
Change subject: cosmetic: pdch.cpp: Drop wrong comment due to copy-paste error
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33529
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I40f93473c86500f655a0a83c7816a065707e2ed9
Gerrit-Change-Number: 33529
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Jun 2023 12:18:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33529 )
Change subject: cosmetic: pdch.cpp: Drop wrong comment due to copy-paste error
......................................................................
cosmetic: pdch.cpp: Drop wrong comment due to copy-paste error
Change-Id: I40f93473c86500f655a0a83c7816a065707e2ed9
---
M src/pdch.cpp
1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/29/33529/1
diff --git a/src/pdch.cpp b/src/pdch.cpp
index 7dfd3c2..0ea4f4b 100644
--- a/src/pdch.cpp
+++ b/src/pdch.cpp
@@ -734,7 +734,6 @@
* contention resolution is done:
*/
if ((dl_tbf = ms_dl_tbf(ms))) {
- /* Get rid of previous finished UL TBF before providing a new one */
LOGPTBFDL(dl_tbf, LOGL_NOTICE,
"Got PACKET RESOURCE REQ while DL-TBF pending, killing it\n");
tbf_free(dl_tbf);
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33529
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I40f93473c86500f655a0a83c7816a065707e2ed9
Gerrit-Change-Number: 33529
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
jolly has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33445 )
Change subject: Allow 'configure <cr>' at VTY to enter config mode
......................................................................
Allow 'configure <cr>' at VTY to enter config mode
Similar to HP/Aruba, only the word or abbreviation of 'configure' is
required to enter config mode. This is the default. It is still possible
to add other configuration sources than 'terminal' if implemented in
the future.
Change-Id: I56d5d1bd5526603a397c62542e667c413f4952ca
---
M src/vty/command.c
1 file changed, 15 insertions(+), 1 deletion(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
jolly: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/vty/command.c b/src/vty/command.c
index e67fd86..a3e0e36 100644
--- a/src/vty/command.c
+++ b/src/vty/command.c
@@ -2997,7 +2997,7 @@
/* Configration from terminal */
DEFUN(config_terminal,
config_terminal_cmd,
- "configure terminal",
+ "configure [terminal]",
"Configuration from vty interface\n" "Configuration terminal\n")
{
if (vty_config_lock(vty))
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33445
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I56d5d1bd5526603a397c62542e667c413f4952ca
Gerrit-Change-Number: 33445
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
jolly has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33446 )
Change subject: ASCI: Add decoding of mobile identity in TALKER INDICATION
......................................................................
ASCI: Add decoding of mobile identity in TALKER INDICATION
gsm48.c provides a function to decode mobile identity from various
messages. TALKER INDICATION is sent by the talking subscriber of a voice
group call to idenitfy the current talker. The mobile identity is
required to distinguish between calling subscriber and other subscribers.
Related: OS#4854
Change-Id: I331fac82e3c15abb01f554b2e70576100f2eea2d
---
M src/gsm/gsm48.c
1 file changed, 26 insertions(+), 0 deletions(-)
Approvals:
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c
index 3ec7547..4f79026 100644
--- a/src/gsm/gsm48.c
+++ b/src/gsm/gsm48.c
@@ -955,6 +955,17 @@
cm2_buf = (uint8_t*)&paging_response->cm2;
goto got_cm2;
+ case GSM48_MT_RR_TALKER_IND:
+ /* Check minimum size: Header + CM2 LV + minimum MI LV */
+ if (l3_len < sizeof(*gh) + 4 + 2)
+ return -EBADMSG;
+ /* CM2 shall be always 3 bytes in length */
+ if (gh->data[0] != 3)
+ return -EBADMSG;
+ cm2_len = gh->data[0];
+ cm2_buf = gh->data + 1;
+ goto got_cm2;
+
default:
break;
}
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33446
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I331fac82e3c15abb01f554b2e70576100f2eea2d
Gerrit-Change-Number: 33446
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
