June 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: library: L1CTL: add 'start_rfn' to L1ctlGprs{Ul,Dl}TbfCfgReq
by fixeria 08 Jun '23

08 Jun '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33231 ) Change subject: library: L1CTL: add 'start_rfn' to L1ctlGprs{Ul,Dl}TbfCfgReq ...................................................................... library: L1CTL: add 'start_rfn' to L1ctlGprs{Ul,Dl}TbfCfgReq Change-Id: I0d23c93d521d2ab78fb4793c300e8b0d57732177 Related: osmocom-bb.git Ibb6a05165fe1c81268fb0e3674adae4065e78171 Related: OS#5500 --- M library/L1CTL_Types.ttcn 1 file changed, 29 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/31/33231/1 diff --git a/library/L1CTL_Types.ttcn b/library/L1CTL_Types.ttcn index fe56459..1b19ae8 100644 --- a/library/L1CTL_Types.ttcn +++ b/library/L1CTL_Types.ttcn @@ -315,7 +315,8 @@ type record L1ctlGprsUlTbfCfgReq { uint8_t tbf_ref, BIT8 slotmask, - OCT2 pad ('0000'O) + OCT2 pad ('0000'O), + uint32_t start_fn } with { variant (slotmask) "BITORDER(msb)" }; /* payload of L1CTL_GPRS_DL_TBF_CFG_REQ */ @@ -323,7 +324,8 @@ uint8_t tbf_ref, BIT8 slotmask, uint8_t dl_tfi, - OCT1 pad ('00'O) + OCT1 pad ('00'O), + uint32_t start_fn } with { variant (slotmask) "BITORDER(msb)" }; /* part of L1CTL_GPRS_{UL,DL}_BLOCK_{REQ,IND} */ @@ -863,7 +865,8 @@ template (value) L1ctlMessage ts_L1CTL_GPRS_UL_TBF_CFG_REQ(template (value) uint8_t tbf_ref, - template (value) BIT8 slotmask := '00000000'B) := { + template (value) BIT8 slotmask := '00000000'B, + template (value) uint32_t start_fn := c_UINT32_MAX) := { header := ts_L1ctlHeader(L1CTL_GPRS_UL_TBF_CFG_REQ), ul_info := omit, dl_info := omit, @@ -871,13 +874,15 @@ ul_tbf_cfg_req := { tbf_ref := tbf_ref, slotmask := slotmask, - pad := '0000'O + pad := '0000'O, + start_fn := start_fn } } }; template L1ctlMessage tr_L1CTL_GPRS_UL_TBF_CFG_REQ(template (present) uint8_t tbf_ref := ?, - template (present) BIT8 slotmask := ?) := { + template (present) BIT8 slotmask := ?, + template (present) uint32_t start_fn := ?) := { header := tr_L1ctlHeader(L1CTL_GPRS_UL_TBF_CFG_REQ), ul_info := omit, dl_info := omit, @@ -885,7 +890,8 @@ ul_tbf_cfg_req := { tbf_ref := tbf_ref, slotmask := slotmask, - pad := ? + pad := ?, + start_fn := start_fn } } }; @@ -893,6 +899,7 @@ template (value) L1ctlMessage ts_L1CTL_GPRS_DL_TBF_CFG_REQ(template (value) uint8_t tbf_ref, template (value) BIT8 slotmask := '00000000'B, + template (value) uint32_t start_fn := c_UINT32_MAX, template (value) uint5_t dl_tfi := 0) := { header := ts_L1ctlHeader(L1CTL_GPRS_DL_TBF_CFG_REQ), ul_info := omit, @@ -902,13 +909,15 @@ tbf_ref := tbf_ref, slotmask := slotmask, dl_tfi := dl_tfi, - pad := '00'O + pad := '00'O, + start_fn := start_fn } } }; template L1ctlMessage tr_L1CTL_GPRS_DL_TBF_CFG_REQ(template (present) uint8_t tbf_ref := ?, template (present) BIT8 slotmask := ?, + template (present) uint32_t start_fn := ?, template (present) uint5_t dl_tfi := ?) := { header := tr_L1ctlHeader(L1CTL_GPRS_DL_TBF_CFG_REQ), ul_info := omit, @@ -918,7 +927,8 @@ tbf_ref := tbf_ref, slotmask := slotmask, dl_tfi := dl_tfi, - pad := ? + pad := ?, + start_fn := start_fn } } }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0d23c93d521d2ab78fb4793c300e8b0d57732177 Gerrit-Change-Number: 33231 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in libosmocore[master]: ASCI: Add message definition and encoding according to 3GPP TS 48.008
by jolly 08 Jun '23

08 Jun '23

Attention is currently required from: jolly, laforge. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/32932 to look at the new patch set (#11). Change subject: ASCI: Add message definition and encoding according to 3GPP TS 48.008 ...................................................................... ASCI: Add message definition and encoding according to 3GPP TS 48.008 Change-Id: Ib94c64136c31ce4af67c314a8550d93946cc844f --- M include/osmocom/gsm/gsm0808.h M include/osmocom/gsm/protocol/gsm_08_08.h M src/gsm/bssmap_le.c M src/gsm/gsm0808.c M src/gsm/gsm0808_utils.c M src/gsm/gsm29205.c M src/gsm/libosmogsm.map M tests/gsm0808/gsm0808_test.c M tests/gsm29205/gsm29205_test.c M tests/tlv/tlv_test.c 10 files changed, 963 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/32/32932/11 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib94c64136c31ce4af67c314a8550d93946cc844f Gerrit-Change-Number: 32932 Gerrit-PatchSet: 11 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-sccp[master]: .gitignore: Ignore *.pyc
by laforge 08 Jun '23

08 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33227 ) Change subject: .gitignore: Ignore *.pyc ...................................................................... .gitignore: Ignore *.pyc vty/config tests were added recently, which use python and end up generating __pycache__/osmoappdesc.cpython-311.pyc when run. Ignore those files as done in other projects such as osmo-bsc. Change-Id: I8129a4a124457411c8163089ec2bac32f3e1c2b7 --- M .gitignore 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/.gitignore b/.gitignore index 54c432d..67685b4 100644 --- a/.gitignore +++ b/.gitignore @@ -67,6 +67,7 @@ *.pc config.* +*.pyc tags /Doxyfile -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8129a4a124457411c8163089ec2bac32f3e1c2b7 Gerrit-Change-Number: 33227 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-sccp[master]: .gitignore: Ignore *.pyc
by laforge 08 Jun '23

08 Jun '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33227 ) Change subject: .gitignore: Ignore *.pyc ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8129a4a124457411c8163089ec2bac32f3e1c2b7 Gerrit-Change-Number: 33227 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 13:44:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: stream: Update log messages
by laforge 08 Jun '23

08 Jun '23

Attention is currently required from: pespin, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33221 ) Change subject: stream: Update log messages ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: test output needs update, otherwise fine -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ife20b9d18e6ca86a06991d68165694e31052c58a Gerrit-Change-Number: 33221 Gerrit-PatchSet: 5 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 13:43:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in libosmo-netif[master]: Add osmo_io support to osmo_stream_cli and osmo_stream_srv
by laforge 08 Jun '23

08 Jun '23

Attention is currently required from: arehbein, pespin, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33193 ) Change subject: Add osmo_io support to osmo_stream_cli and osmo_stream_srv ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33193 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I2f52c7107c392b6f4b0bf2a84f8c873c084a200c Gerrit-Change-Number: 33193 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 13:42:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: stream: Properly name osmo_stream_srv read callback
by laforge 08 Jun '23

08 Jun '23

Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33228 ) Change subject: stream: Properly name osmo_stream_srv read callback ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I12d74e9b407f1ea7af83fb3ec4d03ad7228a27cf Gerrit-Change-Number: 33228 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 13:40:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in libosmocore[master]: ASCI: Add message definition and encoding according to 3GPP TS 48.008
by jolly 08 Jun '23

08 Jun '23

Attention is currently required from: jolly, laforge. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/32932 to look at the new patch set (#10). Change subject: ASCI: Add message definition and encoding according to 3GPP TS 48.008 ...................................................................... ASCI: Add message definition and encoding according to 3GPP TS 48.008 Change-Id: Ib94c64136c31ce4af67c314a8550d93946cc844f --- M include/osmocom/gsm/gsm0808.h M include/osmocom/gsm/protocol/gsm_08_08.h M src/gsm/bssmap_le.c M src/gsm/gsm0808.c M src/gsm/gsm0808_utils.c M src/gsm/gsm29205.c M src/gsm/libosmogsm.map 7 files changed, 945 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/32/32932/10 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib94c64136c31ce4af67c314a8550d93946cc844f Gerrit-Change-Number: 32932 Gerrit-PatchSet: 10 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-gprs[master]: rlcmac: l1ctl_prim: add 'start_rfn' field to cfg_{ul,dl}_tbf_req
by fixeria 08 Jun '23

08 Jun '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33230 ) Change subject: rlcmac: l1ctl_prim: add 'start_rfn' field to cfg_{ul,dl}_tbf_req ...................................................................... rlcmac: l1ctl_prim: add 'start_rfn' field to cfg_{ul,dl}_tbf_req Change-Id: I27a7a896fe3839fa4f9b8cd9500c4ab7867bbaa0 Related: OS#5500 --- M include/osmocom/gprs/rlcmac/rlcmac_prim.h M src/rlcmac/rlcmac_prim.c 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/30/33230/1 diff --git a/include/osmocom/gprs/rlcmac/rlcmac_prim.h b/include/osmocom/gprs/rlcmac/rlcmac_prim.h index fa1ee52..7b05f21 100644 --- a/include/osmocom/gprs/rlcmac/rlcmac_prim.h +++ b/include/osmocom/gprs/rlcmac/rlcmac_prim.h @@ -166,12 +166,14 @@ struct { uint8_t ul_tbf_nr; uint8_t ul_slotmask; + uint32_t start_fn; /* TBF starting time (absolute Fn) */ uint8_t ul_usf[8]; /* USF for each PDCH indicated in the slotmask */ } cfg_ul_tbf_req; /* OSMO_GPRS_RLCMAC_L1CTL_CFG_DL_TBF | Req */ struct { uint8_t dl_tbf_nr; uint8_t dl_slotmask; + uint32_t start_fn; /* TBF starting time (absolute Fn) */ uint8_t dl_tfi; /* DL TFI for all PDCHs indicated in the slotmask */ } cfg_dl_tbf_req; }; diff --git a/src/rlcmac/rlcmac_prim.c b/src/rlcmac/rlcmac_prim.c index a5f796a..1e68f41 100644 --- a/src/rlcmac/rlcmac_prim.c +++ b/src/rlcmac/rlcmac_prim.c @@ -311,6 +311,7 @@ rlcmac_prim = rlcmac_prim_l1ctl_alloc(OSMO_GPRS_RLCMAC_L1CTL_CFG_DL_TBF, PRIM_OP_REQUEST, 0); rlcmac_prim->l1ctl.cfg_dl_tbf_req.dl_tbf_nr = tbf_nr; rlcmac_prim->l1ctl.cfg_dl_tbf_req.dl_slotmask = slotmask; + rlcmac_prim->l1ctl.cfg_dl_tbf_req.start_fn = UINT32_MAX; /* invalid */ rlcmac_prim->l1ctl.cfg_dl_tbf_req.dl_tfi = dl_tfi; return rlcmac_prim; } @@ -322,6 +323,7 @@ rlcmac_prim = rlcmac_prim_l1ctl_alloc(OSMO_GPRS_RLCMAC_L1CTL_CFG_UL_TBF, PRIM_OP_REQUEST, 0); rlcmac_prim->l1ctl.cfg_ul_tbf_req.ul_tbf_nr = ul_tbf_nr; rlcmac_prim->l1ctl.cfg_ul_tbf_req.ul_slotmask = ul_slotmask; + rlcmac_prim->l1ctl.cfg_ul_tbf_req.start_fn = UINT32_MAX; /* invalid */ return rlcmac_prim; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I27a7a896fe3839fa4f9b8cd9500c4ab7867bbaa0 Gerrit-Change-Number: 33230 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmo-netif[master]: examples: Use osmo_io in {ipa-,}stream-{client,server}
by Jenkins Builder 08 Jun '23

08 Jun '23

Attention is currently required from: arehbein, daniel. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33194 ) Change subject: examples: Use osmo_io in {ipa-,}stream-{client,server} ...................................................................... Patch Set 4: (2 comments) File examples/stream-client.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8018): https://gerrit.osmocom.org/c/libosmo-netif/+/33194/comment/eaf322dc_ac805090 PS4, Line 53: static int read_cb(struct osmo_stream_cli *conn, struct msgb* msg) "foo* bar" should be "foo *bar" File examples/stream-server.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8018): https://gerrit.osmocom.org/c/libosmo-netif/+/33194/comment/d30c47df_22ec3f53 PS4, Line 45: int read_cb(struct osmo_stream_srv *conn, struct msgb* msg) "foo* bar" should be "foo *bar" -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33194 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I97a9979199c816686b32080534627f6f033e009e Gerrit-Change-Number: 33194 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 13:28:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0