June 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-netif[master]: stream: set name to sockname by default
by laforge 17 Jun '23

17 Jun '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33337 ) Change subject: stream: set name to sockname by default ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I17ef699dab72c1b613708070d22e9f040b0fe069 Gerrit-Change-Number: 33337 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Jun 2023 06:11:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: pcu_l1_if: use correct SAPI in PCUIF message PCU_IF_MSG_DATA_CNF_DT
by laforge 17 Jun '23

17 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33339 ) Change subject: pcu_l1_if: use correct SAPI in PCUIF message PCU_IF_MSG_DATA_CNF_DT ...................................................................... pcu_l1_if: use correct SAPI in PCUIF message PCU_IF_MSG_DATA_CNF_DT When we receive PCU_IF_MSG_DATA_CNF_DT, we check on PCU_IF_SAPI_PCH. This is formally not correct, we should check on PCU_IF_SAPI_PCH_DT instead. (This patch will only affect osmo-bsc but not osmo-bts. The reason for this is that osmo-bts still uses the older PCUIF v.10) Depends: osmo-bsc.git Id5c799e625c56e57f7b51cd4fb57f5bea9c973d2 Change-Id: I0883b51fc232ec0267f1511c3a37c0bcd0967a08 --- M src/pcu_l1_if.cpp 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 7437e16..686853c 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -539,7 +539,7 @@ data_cnf_dt->sapi, data_cnf_dt->fn, current_fn); switch (data_cnf_dt->sapi) { - case PCU_IF_SAPI_PCH: + case PCU_IF_SAPI_PCH_DT: bts_rcv_imm_ass_cnf(bts, NULL, data_cnf_dt->tlli, data_cnf_dt->fn); break; default: -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0883b51fc232ec0267f1511c3a37c0bcd0967a08 Gerrit-Change-Number: 33339 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-pcu[master]: pcu_l1_if: use correct SAPI in PCUIF message PCU_IF_MSG_DATA_CNF_DT
by laforge 17 Jun '23

17 Jun '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33339 ) Change subject: pcu_l1_if: use correct SAPI in PCUIF message PCU_IF_MSG_DATA_CNF_DT ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0883b51fc232ec0267f1511c3a37c0bcd0967a08 Gerrit-Change-Number: 33339 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Jun 2023 06:10:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: pcu_sock: use correct SAPI in message PCUIF PCU_IF_MSG_DATA_CNF_DT
by laforge 17 Jun '23

17 Jun '23

Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33340 ) Change subject: pcu_sock: use correct SAPI in message PCUIF PCU_IF_MSG_DATA_CNF_DT ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33340 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id5c799e625c56e57f7b51cd4fb57f5bea9c973d2 Gerrit-Change-Number: 33340 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Jun 2023 06:08:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: socket: Ensure fd is not negative in osmo_sock_get_name_buf()
by laforge 17 Jun '23

17 Jun '23

Attention is currently required from: fixeria, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33333 ) Change subject: socket: Ensure fd is not negative in osmo_sock_get_name_buf() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/33333/comment/e2ad4a7b_9a9610f4 PS1, Line 1553: fd < 0 > Use `OSMO_UNLIKELY` here maybe? not really a performance critical code path. How often do we call this? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I76727993224ef87b475c33360c24966e82e866ec Gerrit-Change-Number: 33333 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Jun 2023 06:07:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: stream: Assert that fd is valid in stream_cli_handle_connecting()
by laforge 17 Jun '23

17 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33332 ) Change subject: stream: Assert that fd is valid in stream_cli_handle_connecting() ...................................................................... stream: Assert that fd is valid in stream_cli_handle_connecting() This function should never be called if we don't have a valid fd. Change-Id: If0bed2bae556e0a8233e9e66e82c70a5c677fc3c Fixes: Coverity CID#321045 --- M src/stream.c 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/stream.c b/src/stream.c index 2ba4cde..31aa058 100644 --- a/src/stream.c +++ b/src/stream.c @@ -480,6 +480,7 @@ socklen_t len = sizeof(error); int fd = osmo_stream_cli_fd(cli); + OSMO_ASSERT(fd >= 0); if (ret < 0) { osmo_stream_cli_reconnect(cli); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: If0bed2bae556e0a8233e9e66e82c70a5c677fc3c Gerrit-Change-Number: 33332 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-netif[master]: stream: Assert that fd is valid in stream_cli_handle_connecting()
by laforge 17 Jun '23

17 Jun '23

Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33332 ) Change subject: stream: Assert that fd is valid in stream_cli_handle_connecting() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: If0bed2bae556e0a8233e9e66e82c70a5c677fc3c Gerrit-Change-Number: 33332 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Jun 2023 06:06:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: Fix typo: CCNMesurementReport
by laforge 17 Jun '23

17 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33321 ) Change subject: Fix typo: CCNMesurementReport ...................................................................... Fix typo: CCNMesurementReport There is a typo in the CSN.1 definition for CCN Measurement Report. While fixing this we can also shorten the record name to "CCNMeasReport" to make it coherent to the Utran/Eutran related definitions. Change-Id: I1e44afdbede7420299435ddb7333dd151b5da4b3 --- M library/RLCMAC_CSN1_Templates.ttcn M library/RLCMAC_CSN1_Types.ttcn 2 files changed, 18 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/RLCMAC_CSN1_Templates.ttcn b/library/RLCMAC_CSN1_Templates.ttcn index 000709d..ef8c952 100644 --- a/library/RLCMAC_CSN1_Templates.ttcn +++ b/library/RLCMAC_CSN1_Templates.ttcn @@ -142,7 +142,7 @@ } }; - const CCNMesurementReport ccn_meas_rep_def := { + const CCNMeasReport ccn_meas_rep_def := { rxlev_servig_cell := 0, zero := '0'B, num_meas := 0, @@ -153,7 +153,7 @@ template (value) RlcmacUlCtrlMsg ts_RlcMacUlCtrl_PKT_CELL_CHG_NOTIF(uint5_t tfi, GsmArfcn arfcn, uint6_t bsic, - template (value) CCNMesurementReport ccn_meas_rep := ccn_meas_rep_def) + template (value) CCNMeasReport ccn_meas_rep := ccn_meas_rep_def) := { msg_type := PACKET_CELL_CHANGE_NOTIFICATION, u := { diff --git a/library/RLCMAC_CSN1_Types.ttcn b/library/RLCMAC_CSN1_Types.ttcn index 917b5d5..a4ed307 100644 --- a/library/RLCMAC_CSN1_Types.ttcn +++ b/library/RLCMAC_CSN1_Types.ttcn @@ -1020,7 +1020,7 @@ variant (bsic) "PRESENCE(bsic_presence = '1'B)" }; type record of NCMeasurementItem NCMeasurements; - type record CCNMesurementReport { + type record CCNMeasReport { uint6_t rxlev_servig_cell, BIT1 zero ('0'B), uint3_t num_meas, @@ -1090,7 +1090,7 @@ BIT2 psi3_change_mark optional, BIT1 pmo_used, BIT1 pccn_sending, - CCNMesurementReport ccn_meas_rep, + CCNMeasReport ccn_meas_rep, /* Rel-Additions (Matrioshka) */ PktCellChgNotifAdditions rel_additions optional } with { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e44afdbede7420299435ddb7333dd151b5da4b3 Gerrit-Change-Number: 33321 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: RLCMAC_CSN1_Types: Add release 6 and release 8 additions to PacketCel...
by laforge 17 Jun '23

17 Jun '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 ) Change subject: RLCMAC_CSN1_Types: Add release 6 and release 8 additions to PacketCellChangeNotification ...................................................................... RLCMAC_CSN1_Types: Add release 6 and release 8 additions to PacketCellChangeNotification The PacketCellChangeNotification type currently lacks the release 6 and the release 8 additions. Those basically add 3G and 4g/5g compatibility to the PacketCellChangeNotification message type. Spec reference: 3gpp TS 44.060 11.2.3a Related: OS#6044 Co-authored-by: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Change-Id: I4e1c63c06fb89111765df187a93db563e77c3fc4 --- M library/RLCMAC_CSN1_Templates.ttcn M library/RLCMAC_CSN1_Types.ttcn 2 files changed, 155 insertions(+), 12 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/RLCMAC_CSN1_Templates.ttcn b/library/RLCMAC_CSN1_Templates.ttcn index 943717e..000709d 100644 --- a/library/RLCMAC_CSN1_Templates.ttcn +++ b/library/RLCMAC_CSN1_Templates.ttcn @@ -162,15 +162,20 @@ is_dl_tfi := false, tfi := tfi }, - arfcn_bsic_presence := '0'B, - arfcn := arfcn, - bsic := bsic, + u := { + u0 := { + tag := '0'B, + arfcn := arfcn, + bsic := bsic + } + }, ba_psi3_presence := '0'B, ba_used := '0'B, psi3_change_mark := omit, pmo_used := '0'B, pccn_sending := '0'B, - ccn_meas_rep := ccn_meas_rep + ccn_meas_rep := ccn_meas_rep, + rel_additions := omit } } }; diff --git a/library/RLCMAC_CSN1_Types.ttcn b/library/RLCMAC_CSN1_Types.ttcn index 2093f55..917b5d5 100644 --- a/library/RLCMAC_CSN1_Types.ttcn +++ b/library/RLCMAC_CSN1_Types.ttcn @@ -941,7 +941,76 @@ variant (sign_var) "PRESENCE(sign_var_presence = '1'B)" }; - /* 11.2.3a Packet Cell Change Notification */ + /* 11.2.3a Packet Cell Change Notification, 3G Target Cell Struct (Rel-6 extension) */ + type record UtranTargetCellFdd { + uint14_t arfcn, + BIT1 bandwidth_presence, + uint3_t bandwidth optional, + uint10_t scrambling_code + } with { + variant (bandwidth) "PRESENCE(bandwidth_presence = '1'B)" + }; + type record UtranTargetCellTdd { + uint14_t arfcn, + BIT1 bandwidth_presence, + uint3_t bandwidth optional, + uint7_t cell_parameter, + BIT1 sync_case + } with { + variant (bandwidth) "PRESENCE(bandwidth_presence = '1'B)" + }; + type record UtranTargetCell { + BIT1 fdd_presence, + UtranTargetCellFdd fdd optional, + BIT1 tdd_presence, + UtranTargetCellTdd tdd optional, + uint6_t reporting_quantity + } with { + variant (fdd) "PRESENCE(fdd_presence = '1'B)" + variant (tdd) "PRESENCE(tdd_presence = '1'B)" + }; + + /* 11.2.3a Packet Cell Change Notification, Eutran Target Cell Struct (Rel-8 extension) */ + type record EutranTargetCell { + uint16_t earfcn, + BIT1 meas_bandwidth_presence, + uint3_t meas_bandwidth optional, + uint9_t phys_layer_cell_id, + uint6_t reporting_quantity + } with { + variant (meas_bandwidth) "PRESENCE(meas_bandwidth_presence = '1'B)" + }; + + /* 11.2.3a Packet Cell Change Notification, 3G CCN Measurement Report Struct (Rel-6 extension) */ + type record of UtranCCNMeasReportItem UtranReportingQuantityList; + type record UtranCCNMeasReportItem { + uint7_t cell_list_index, + uint6_t reporting_quantity + } with { variant "" }; + type record UtranCCNMeasReport { + uint3_t n_3g, + UtranReportingQuantityList cells + } with { + variant (n_3g) "LENGTHTO(cells) - 1" + variant (n_3g) "UNIT(elements)" + }; + + /* 11.2.3a Packet Cell Change Notification, E-UTRAN CCN Measurement Report Struct (Rel-8 extension) */ + type record length(1..4) of EutranCCNMeasReportItem EutranReportingQuantityList; + type record EutranCCNMeasReportItem { + uint3_t frequency_list_index, + uint9_t cell_identity, + uint6_t reporting_quantity + } with { variant "" }; + type record EutranCCNMeasReport { + uint1_t utran_ba_used, + uint2_t n_eutran, + EutranReportingQuantityList cells + } with { + variant (n_eutran) "LENGTHTO(cells) - 1" + variant (n_eutran) "UNIT(elements)" + }; + type record NCMeasurementItem { uint6_t freq, BIT1 bsic_presence, @@ -957,22 +1026,74 @@ uint3_t num_meas, NCMeasurements meas } with { variant "" }; - type record PacketCellChangeNotification { - GlobalTfi gtfi, - /* TODO: support 3g/4g in these bits */ + + /* 11.2.3a Packet Cell Change Notification, Rel-Additions (Matrioshka) */ + private type record PktCellChgNotifAdditions { + BIT1 rel6_presence, + PktCellChgNotifR6Additions rel6 optional + } with { + variant (rel6) "PRESENCE(rel6_presence = '1'B)" + }; + private type record PktCellChgNotifR6Additions { + BIT1 utran_ba_used_presence, + uint1_t utran_ba_used optional, + UtranCCNMeasReport utran_ccn_meas_rep + } with { + variant (utran_ba_used) "PRESENCE(utran_ba_used_presence = '1'B)" + }; + + private type record PktCellChgNotifyU0 { + BIT1 tag ('0'B), + uint10_t arfcn, + uint6_t bsic + } with { variant "" }; + private type record PktCellChgNotifyU10 { + BIT2 tag ('10'B), + UtranTargetCell utran_target_cell + } with { variant "" }; + private type record PktCellChgNotifyU110 { + BIT3 tag ('110'B), BIT1 arfcn_bsic_presence, uint10_t arfcn optional, uint6_t bsic optional, + BIT1 utran_target_cell_presence, + UtranTargetCell utran_target_cell optional, + BIT1 eutran_target_cell_presence, + EutranTargetCell eutran_target_cell optional, + BIT1 eutran_ccn_meas_rep_presence, + EutranCCNMeasReport eutran_ccn_meas_rep optional + } with { + variant (arfcn) "PRESENCE(arfcn_bsic_presence = '1'B)" + variant (bsic) "PRESENCE(arfcn_bsic_presence = '1'B)" + variant (utran_target_cell) "PRESENCE(utran_target_cell_presence = '1'B)" + variant (eutran_target_cell) "PRESENCE(eutran_target_cell_presence = '1'B)" + variant (eutran_ccn_meas_rep) "PRESENCE(eutran_ccn_meas_rep_presence = '1'B)" + }; + private type union PktCellChgNotifyUnion { + PktCellChgNotifyU0 u0, + PktCellChgNotifyU10 u10, /* Rel-6 additions */ + PktCellChgNotifyU110 u110 /* Rel-8 additions */ + /* TODO: PktCellChgNotifyU1110 Rel-9 additions */ + /* TODO: Message escape : { 1111 } bit (*) = <no string> > */ + } with { + variant "TAG(u0, tag = '0'B; + u10, tag = '10'B; + u110, tag = '110'B)" + }; + + /* 11.2.3a Packet Cell Change Notification, message body */ + type record PacketCellChangeNotification { + GlobalTfi gtfi, + PktCellChgNotifyUnion u, BIT1 ba_psi3_presence, BIT1 ba_used optional, BIT2 psi3_change_mark optional, BIT1 pmo_used, BIT1 pccn_sending, - CCNMesurementReport ccn_meas_rep - /* TODO: Rel6 additions for 3G support */ + CCNMesurementReport ccn_meas_rep, + /* Rel-Additions (Matrioshka) */ + PktCellChgNotifAdditions rel_additions optional } with { - variant (arfcn) "PRESENCE(arfcn_bsic_presence = '0'B)" - variant (bsic) "PRESENCE(arfcn_bsic_presence = '0'B)" variant (ba_used) "PRESENCE(ba_psi3_presence = '0'B)" variant (psi3_change_mark) "PRESENCE(ba_psi3_presence = '1'B)" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4e1c63c06fb89111765df187a93db563e77c3fc4 Gerrit-Change-Number: 32995 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: RLCMAC_CSN1_Types: Add release 6 and release 8 additions to PacketCel...
by laforge 17 Jun '23

17 Jun '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 ) Change subject: RLCMAC_CSN1_Types: Add release 6 and release 8 additions to PacketCellChangeNotification ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4e1c63c06fb89111765df187a93db563e77c3fc4 Gerrit-Change-Number: 32995 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Jun 2023 06:06:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0