May 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: libosmogsm: Allow auth API caller to specify RES length

by laforge

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/33091 to look at the new patch set (#3). Change subject: libosmogsm: Allow auth API caller to specify RES length ...................................................................... libosmogsm: Allow auth API caller to specify RES length There are 3G algorithms which support different lengths of RES values (4, 8, 16 byte). For MILENAGE, we never really had to bother, as the 4-byte RES is simply the first 4 bytes of the 8-byte RES. However, for TUAK, the expected RES length is an input parameter to the Keccak crypto functions, so the result of all parameters (including CK, IK, ...) will be completely different for RES length 4 than RES length 8. So let's permit the caller of the osmocom auth API to specify the requested RES length via the osmo_auth_vector.res_len parameter. For backwards compatibility of callers of the old osmo_auth_gen_vec/ osmo_auth_gen_vec_auts API: Always force the res_len to 8 in this case, which was the hard-coded length before this patch. Change-Id: Ic662843fbe8b5c58e4af39ea630ad5ac13fd6bef --- M include/osmocom/crypt/auth.h M src/gsm/auth_core.c M src/gsm/auth_milenage.c M tests/osmo-auc-gen/osmo-auc-gen_test.ok M utils/osmo-auc-gen.c 5 files changed, 87 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/33091/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic662843fbe8b5c58e4af39ea630ad5ac13fd6bef Gerrit-Change-Number: 33091 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

11 months, 2 weeks

1
0
0 0

[XL] Change in libosmocore[master]: libosmogsm: Add support for TUAK authentication algorithm

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/33094 to look at the new patch set (#4). Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... libosmogsm: Add support for TUAK authentication algorithm The TUAK algorithm is specified in 3GPP TS 35.231, 232 and 233 and intended as an alternative to MILENAGE. It's based around the cryptographic function of KeccakP1600, which is part of SHA-3. This patch adds support for TUAK to the libosmogsm authentication core API via 'struct osmo_auth_impl'. Unit tests covering the test cases from the 3GPP specification are added (and are all passing). Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d --- A .checkpatch.conf M include/osmocom/crypt/auth.h M src/gsm/Makefile.am M src/gsm/auth_core.c A src/gsm/auth_tuak.c A src/gsm/tuak/KeccakP-1600-3gpp.c A src/gsm/tuak/KeccakP-1600-3gpp.h A src/gsm/tuak/tuak.c A src/gsm/tuak/tuak.h M tests/Makefile.am A tests/auth/tuak_test.c A tests/auth/tuak_test.ok 12 files changed, 1,187 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/94/33094/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

11 months, 2 weeks

1
0
0 0

[XL] Change in libosmocore[master]: libosmogsm: Add support for TUAK authentication algorithm

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33094 ) Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... Patch Set 3: (219 comments) File src/gsm/tuak/KeccakP-1600-3gpp.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ce20b9f8_ef772323 PS3, Line 22: EXPORTIT void Keccak_f_8 (uint8_t s[200]); space prohibited between function name and open parenthesis '(' File src/gsm/tuak/KeccakP-1600-3gpp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/748c59bb_d7be1b20 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8d01c63a_81117a47 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/95514046_f160e960 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/06642345_b61b0994 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0db44d3e_3dfb24f5 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3663c743_c8a2466a PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4ba53dbf_e1b5965b PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c4291ed8_a5171e50 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1a58fe50_ed31f461 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f2daf4bd_0162bfa3 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2190d884_e33de024 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e9a73afa_0d0f778c PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/79ec80a0_c413d694 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e425c2e9_c90f1bb2 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bf71cea3_49cbbc85 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2075879c_77990bf8 PS3, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/26763efe_acb5236f PS3, Line 13: 15,21,8,18,2,61,56,14}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2289a167_82d28f7b PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3bba4313_9f02ecf2 PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dd3e9c76_6bffacb6 PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c575dafb_5b8c70cb PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/693e305c_ee070c2e PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c674d0c6_4db736dd PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d81daa34_8bf8b113 PS3, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6d71866e_6b97d53e PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/54eb5ee6_5a977a2f PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5296c42f_ca9b987e PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3e4d82db_90b7875c PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a2112ffc_c5075151 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f0841add_c9662003 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d229772d_c7004f12 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/348ffd53_cb2c39ca PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2b6201a3_170c1e2c PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8aabae08_e05b3e27 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/524a5298_7f4cb226 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7df4c061_e0e05d37 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0406b5d9_c5b6328e PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1516dd28_4979f6a0 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1fa9ec0b_6de3421b PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e0c4c989_1fdb062d PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b97e0ebb_1c8434e9 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4926c8f7_f196e1f2 PS3, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5e8baea7_c45c4e25 PS3, Line 16: 23,2,8,14,15,21}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/290a2c0c_27b83e71 PS3, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/01d21db2_629d3d73 PS3, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9b0a297b_7b4a8efa PS3, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cc442ec3_ec96a88b PS3, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/522b574a_0035f84a PS3, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fe583fad_54e59355 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4340ae0e_81ca9326 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c4fe1508_a6e59171 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/158293d7_9ec57c9a PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/566f56d8_0762d193 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/40735d85_6cb42671 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2ebcfa3d_b4056e08 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/73f688fd_2d97b578 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5254767d_a7e5915b PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7fb1ebac_cc049aa4 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/89b4f977_0c2251da PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b02fd15f_9b3decc2 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/484582b1_13f1a3a3 PS3, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1c1aeb79_cdf03b9b PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0cbc3a87_56623a97 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6a752458_4a80b078 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e5d44d72_80c60fb9 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fd3a2b25_a9cf8868 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/27d981e9_37e5590c PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/80717a8c_2ed6c4a1 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/95e874a9_365335c2 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9046c63f_f7e376ae PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dc1a97d1_340138f9 PS3, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5ece5727_60e99b60 PS3, Line 32: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2edc4310_8f8121b5 PS3, Line 32: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e027587f_021920f3 PS3, Line 32: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b1f5cff2_1a1524bb PS3, Line 32: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b3fffc28_01d6b1f2 PS3, Line 34: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/20ae1865_6bbe8e9e PS3, Line 34: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6d27a703_5480306c PS3, Line 34: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c56d9382_ff8ba629 PS3, Line 36: for(i=0; i<5; ++i, s+=5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b5161f71_76ec241b PS3, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9cf72daf_058d02b3 PS3, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/74d1a8d0_f4e8f77b PS3, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/24ee9d2f_af344c04 PS3, Line 36: for(i=0; i<5; ++i, s+=5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cb75c622_1e61748c PS3, Line 46: for(i=1; i<25; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/51302a14_aca4b675 PS3, Line 46: for(i=1; i<25; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dfba9441_8a7d7542 PS3, Line 46: for(i=1; i<25; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/271742ad_16e0a1f0 PS3, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6dd05f66_970f0236 PS3, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/85c81dd0_984c8a12 PS3, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/149f5013_d35539bf PS3, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b522a2fb_814a323e PS3, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/94854510_1d772180 PS3, Line 54: for(i=0; i<5; ++i, s += 5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/89ae2e39_d16fa701 PS3, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bb8a91dd_315740ae PS3, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8a9ff5f9_d81a40c1 PS3, Line 54: for(i=0; i<5; ++i, s += 5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/636ffaf7_5f6a857c PS3, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dcfe5574_ed91d0ab PS3, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/36976244_2a3f5a7d PS3, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/beb7878a_0206cf4b PS3, Line 66: *s ^= (t[0] | (t[0]<<11) | (t[0]<<26) | (t[0]<<57)) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/990aec8e_07df7c6c PS3, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d6f7790f_f633d4f5 PS3, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d66b6c16_430c5aa8 PS3, Line 79: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c32933fa_d20b03d7 PS3, Line 79: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8fd8487e_13e15a18 PS3, Line 79: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2de93f7a_0efd3b03 PS3, Line 79: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fa3048a1_7e0474d3 PS3, Line 81: for(i=0; i<40; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/99408108_e5cf9e6a PS3, Line 81: for(i=0; i<40; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ed671200_58f27274 PS3, Line 81: for(i=0; i<40; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/78f1a705_34d3a1dc PS3, Line 82: t[i]=s[i]^s[40+i]^s[80+i]^s[120+i]^s[160+i]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9b88a33d_d7f899db PS3, Line 83: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2f1f1af3_553accf3 PS3, Line 83: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/619ec7b5_e4f7dc01 PS3, Line 83: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/87a044dc_b82c0db8 PS3, Line 83: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8d6a0662_30dd43e2 PS3, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/92a03089_6ae19636 PS3, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7f762ec1_34dd0625 PS3, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6be39f61_d338d67d PS3, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4dac51ce_8dd12616 PS3, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6f0601cf_15db1382 PS3, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6f3ed77e_5730f6f2 PS3, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3e2a6194_d3812cbc PS3, Line 87: for(j = t[i+7]>>7, k=7; k; --k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8ffeb7a7_db301145 PS3, Line 87: for(j = t[i+7]>>7, k=7; k; --k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ddc0397c_7255b61e PS3, Line 89: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6fd9269f_2ea495d8 PS3, Line 89: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e060a9e6_4930b538 PS3, Line 89: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/92ee6d7b_8cfe3bcb PS3, Line 89: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0323d9ce_068b18df PS3, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/368c323f_ab883337 PS3, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9f326a6e_1edc8883 PS3, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0fadd573_ca405dcb PS3, Line 94: for(i=8; i<200; i+=8) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1e59ee07_150f3ca4 PS3, Line 94: for(i=8; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f01ff476_b93d6fae PS3, Line 94: for(i=8; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5fbe56d3_5f2ce6c7 PS3, Line 94: for(i=8; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a21e95c2_6685533c PS3, Line 94: for(i=8; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f25226d4_8a9e9352 PS3, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/94f5cc4e_f9fff415 PS3, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1ad873d2_02bb12b9 PS3, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8126b370_f9f09b43 PS3, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5bcb408d_6ba3dbc1 PS3, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fc6d1881_ac16ce98 PS3, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f7af1db1_2d4add11 PS3, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7433de2f_c350abc4 PS3, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/146fdfd7_6b7102b2 PS3, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9ae5b900_648adeda PS3, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/da31daec_6b174bbe PS3, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c6b0ed87_7e9e6cd2 PS3, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e85b15be_6ea518c0 PS3, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bbfac5a0_7fc3480d PS3, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/586dc61c_3285c983 PS3, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d5fcc0fb_bc571515 PS3, Line 104: for(i=1; (j=Pi[i])>1; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5a79a2f6_5f56d168 PS3, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cd979f60_6f1c4557 PS3, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/257c51ed_2e5cf36b PS3, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/04eb058c_e452ef4b PS3, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7f15da48_1517e492 PS3, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0f1f4bd6_3b5709ba PS3, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/292aac30_dbb23013 PS3, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/62d72607_5c080b8a PS3, Line 111: for(i=0; i<200; i+=40) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c783976e_ab6bd6c0 PS3, Line 111: for(i=0; i<200; i+=40) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a83dd37e_f47b1069 PS3, Line 111: for(i=0; i<200; i+=40) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/73f9fef9_2b988fa5 PS3, Line 111: for(i=0; i<200; i+=40) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c04c19fb_01b2302b PS3, Line 111: for(i=0; i<200; i+=40) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2a090a97_62a737d7 PS3, Line 112: { for(j=0; j<40; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/948f51db_7b76d5d7 PS3, Line 112: { for(j=0; j<40; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/134eee35_959131ee PS3, Line 112: { for(j=0; j<40; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2c786360_637a0ace PS3, Line 113: t[j]=(~s[i+(j+8)%40]) & s[i+(j+16)%40]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c74feb92_6ab679c7 PS3, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/45cd78a7_fec505d1 PS3, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/02a38e47_469723bb PS3, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '^=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/be24c739_1edc6513 PS3, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bb182216_7d624d38 PS3, Line 135: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cb344173_2e89caad PS3, Line 135: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b39c2f3_ddfe92dd PS3, Line 135: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a91e1735_e07e6927 PS3, Line 135: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4a396235_b04ab51d PS3, Line 137: for(i=0; i<10; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f513c9d6_bd789d6c PS3, Line 137: for(i=0; i<10; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/85f8789a_aef82817 PS3, Line 137: for(i=0; i<10; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/58b08459_3a7bbc43 PS3, Line 139: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/febf481f_8ccc1cae PS3, Line 139: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/52984188_f71d7c23 PS3, Line 139: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e633b93_677e9bf5 PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d37bbdb3_3e0cf3e6 PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/88f997e4_8f53b012 PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a6327698_2977bc04 PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '%=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a0c74d97_728864ae PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0b22e178_43b4da5f PS3, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/111929ca_0b08799f PS3, Line 143: if(j==8) break; spaces required around that '==' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/79b8bec5_de8772c5 PS3, Line 143: if(j==8) break; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/834fb1d9_2b2ba057 PS3, Line 148: for(i=2; i<50; i+=2) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/954d37f4_14bc9a01 PS3, Line 148: for(i=2; i<50; i+=2) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3f34f8b4_a93db4e9 PS3, Line 148: for(i=2; i<50; i+=2) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6469555f_3dc14f45 PS3, Line 148: for(i=2; i<50; i+=2) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/34d931d8_67d0bb40 PS3, Line 148: for(i=2; i<50; i+=2) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/02d14f36_1b080792 PS3, Line 153: s[i] = t[1-k], s[i+1] = t[k]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8dfc8cb7_b81f2f75 PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/989cef25_0f909383 PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e990ba0_3aabe9ac PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fca4fe78_54e93de3 PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/925e43a9_dbcda94d PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4575adfa_86ccd7fc PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dc8be709_c38864c9 PS3, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/671f45a1_9f521cf4 PS3, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a9a85c04_5b0d1735 PS3, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9b9691cd_1ff7f5bb PS3, Line 158: s[i]=s[j], s[i+1]=s[j+1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0d847ddf_b3a27b7f PS3, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/71110cad_d06efa9f PS3, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6183f4a5_2f80ed29 PS3, Line 159: s[i]=t[0], s[i+1]=t[1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e7429dc2_3d8a7f9c PS3, Line 162: for(i=0; i<5; ++i, s+=10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5fadebb1_96137699 PS3, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d9d0272f_ec71f07a PS3, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d99e7df9_9d7b08fe PS3, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0ba0f6ca_58928afd PS3, Line 162: for(i=0; i<5; ++i, s+=10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/296d7a1e_a3d47cb1 PS3, Line 163: { for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/41fad1ae_fb37b3f9 PS3, Line 163: { for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/eb490056_44f513ce PS3, Line 163: { for(j=0; j<10; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/63630e2a_824dc03e PS3, Line 165: for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fd103c37_60c1bc98 PS3, Line 165: for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7626): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cacf47a7_25fdba5d PS3, Line 165: for(j=0; j<10; ++j) space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 May 2023 14:44:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[XL] Change in libosmocore[master]: libosmogsm: Add support for TUAK authentication algorithm

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/33094 to look at the new patch set (#3). Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... libosmogsm: Add support for TUAK authentication algorithm The TUAK algorithm is specified in 3GPP TS 35.231, 232 and 233 and intended as an alternative to MILENAGE. It's based around the cryptographic function of KeccakP1600, which is part of SHA-3. This patch adds support for TUAK to the libosmogsm authentication core API via 'struct osmo_auth_impl'. Unit tests covering the test cases from the 3GPP specification are added (and are all passing). Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d --- A .checkpatch.conf M include/osmocom/crypt/auth.h M src/gsm/Makefile.am M src/gsm/auth_core.c A src/gsm/auth_tuak.c A src/gsm/tuak/KeccakP-1600-3gpp.c A src/gsm/tuak/KeccakP-1600-3gpp.h A src/gsm/tuak/tuak.c A src/gsm/tuak/tuak.h M tests/Makefile.am A tests/auth/tuak_test.c A tests/auth/tuak_test.ok 12 files changed, 1,187 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/94/33094/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

11 months, 2 weeks

1
0
0 0

[L] Change in libosmocore[master]: libosmogsm: Add support for TUAK authentication algorithm

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33094 ) Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... Patch Set 2: (219 comments) File src/gsm/tuak/KeccakP-1600-3gpp.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/240e1648_80d6ae70 PS2, Line 22: EXPORTIT void Keccak_f_8 (uint8_t s[200]); space prohibited between function name and open parenthesis '(' File src/gsm/tuak/KeccakP-1600-3gpp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/88f84fef_6fea8600 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/82c84ca3_bd0b3afc PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2fc80263_ebcf6dc8 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/aba3f727_b7a6aa46 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f817d79b_b37b3976 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/05604d55_7dc35eaa PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/81c7e9d5_7b538030 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b0393e6_c1e3897b PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/72326f39_90400c47 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e09344a_30d0e3ea PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5a6bda17_8c146ec5 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/432695b0_4e6c1144 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7b6405cb_10580edc PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9b1704f4_adbe0df9 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/61e9fe60_6a26f3fe PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/70d3284c_0310c744 PS2, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0cb6843d_95bd5de3 PS2, Line 13: 15,21,8,18,2,61,56,14}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/56e0ccb6_a48cbc8f PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d9434946_cee1e73b PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f7b7332d_87e50212 PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9dfa1695_7e7d4d96 PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b9c4c0b3_ac183f4d PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/75bc208a_2252c219 PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a0a58572_f83f0b85 PS2, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0d5342bf_cb7edae5 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8e2d3cb3_c7584ef1 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f626e4d6_73f5ce8b PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/aec51ffb_4251917e PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6b4420d9_47151bfe PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9dec71f7_13444901 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8349a792_38616d85 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d6ae162d_9ab0b9f1 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/05acfde2_2ea9c090 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c897d60b_4b469026 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bd3e75d8_4da0e934 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b01175ce_2f5cdf4a PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/be97d1cb_0e367963 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/29236ec7_ce8d9898 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fc0c0b45_9f5ad072 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/679955aa_12a5ee48 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1d8baa2c_73af7bb2 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/48896748_28c9a452 PS2, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2632acac_c1ea7dd2 PS2, Line 16: 23,2,8,14,15,21}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d634dff2_9e80f113 PS2, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dc5de524_3926a8ad PS2, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2e4e4e1b_9d96c4c3 PS2, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c8f3c6e3_31f4b268 PS2, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a6591089_dda267da PS2, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1f6ef3c6_8212c12e PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/07429942_0ea1cb9c PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/244356a6_5daca31d PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0d0992ea_f4c7243c PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8b027066_0ca57eb8 PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f1307598_36db0dfd PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/826b37eb_e8d90d48 PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/59d40adf_b71db00e PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d32ecceb_25d9803a PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3cc786f8_49850b8b PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a347d567_f132c05e PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/85400000_9b839de1 PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/99aa6ed9_20f0555e PS2, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/efacbe8f_06ca4e75 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cddf556e_cb94809b PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/30d4e04b_0e05bc96 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d0490c03_4179ecf3 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e06eab41_459bfe78 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a827a937_667c0f46 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/efb6b032_bd3d0b74 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/221704d6_e4cc3cef PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1c72a60d_a7a22708 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a6d0f600_32118092 PS2, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bd6800f9_bfe7343d PS2, Line 32: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/caba35a1_cbb7958f PS2, Line 32: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/17eaafe3_2e5a6f27 PS2, Line 32: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/89d10163_5330d3cd PS2, Line 32: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3597b357_96754025 PS2, Line 34: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c4de6b36_d1c71848 PS2, Line 34: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/aac082f8_baf9dd07 PS2, Line 34: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/943ef6f6_3d3488fb PS2, Line 36: for(i=0; i<5; ++i, s+=5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b7992d12_b35b5211 PS2, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6e813f33_2be9bc0e PS2, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7b63f0ab_3d0b98ef PS2, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8ad13732_0df446df PS2, Line 36: for(i=0; i<5; ++i, s+=5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/047ec174_82207601 PS2, Line 46: for(i=1; i<25; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4c833b79_e55dd121 PS2, Line 46: for(i=1; i<25; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e4d7699_53f3b02f PS2, Line 46: for(i=1; i<25; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e182331b_99e0dfcf PS2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a8714010_13d016ae PS2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c7afd48b_9bcc68b7 PS2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/01f91f89_8c3ec5b0 PS2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/84786177_0f201b7d PS2, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7e2921a3_079b15bc PS2, Line 54: for(i=0; i<5; ++i, s += 5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/88d0ab86_08fa84a5 PS2, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0240b367_f4724725 PS2, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4df932f9_4bc489f4 PS2, Line 54: for(i=0; i<5; ++i, s += 5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e780e10_7178e33d PS2, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/085c54d9_dc2e5fe9 PS2, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/702c783b_22651b3a PS2, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/92820bdf_d044d057 PS2, Line 66: *s ^= (t[0] | (t[0]<<11) | (t[0]<<26) | (t[0]<<57)) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/091ac23b_42ad225d PS2, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3a81f12e_c23996f3 PS2, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5470eb05_53d71ac3 PS2, Line 79: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/da422303_6930924f PS2, Line 79: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/526e0a00_8f07601e PS2, Line 79: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5f7ddc05_83aab3c9 PS2, Line 79: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3304e8d2_24425ed7 PS2, Line 81: for(i=0; i<40; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a651cb9e_38bffca0 PS2, Line 81: for(i=0; i<40; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/36caf501_622bcb37 PS2, Line 81: for(i=0; i<40; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a8db551c_daaf0015 PS2, Line 82: t[i]=s[i]^s[40+i]^s[80+i]^s[120+i]^s[160+i]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ff6683e6_fce25677 PS2, Line 83: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7961f5eb_45794224 PS2, Line 83: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2d09fd3f_522b7d53 PS2, Line 83: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/09c72d54_cd8303d8 PS2, Line 83: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fda2215c_f836875b PS2, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b45ab20d_60cb12f4 PS2, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b97d047f_6ee75feb PS2, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fbf47e70_8cd98d41 PS2, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/daf0dea3_9c834db4 PS2, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4abe4ada_6c12696e PS2, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/df93ea00_d60b6029 PS2, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/aa50bafc_091d7410 PS2, Line 87: for(j = t[i+7]>>7, k=7; k; --k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5b3a09ca_26d659d9 PS2, Line 87: for(j = t[i+7]>>7, k=7; k; --k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ab8d1e07_01d02232 PS2, Line 89: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/957a79d6_8d4364fa PS2, Line 89: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/db8739ac_f82e16eb PS2, Line 89: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fde7574e_3a4ec8d2 PS2, Line 89: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/574b6fa6_c25ef6eb PS2, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/424c4f4a_43c7a112 PS2, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1548ee5a_41f48ad4 PS2, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/697c2f10_705bf7e6 PS2, Line 94: for(i=8; i<200; i+=8) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fa9d47ce_3cf070d8 PS2, Line 94: for(i=8; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a2570590_24c06705 PS2, Line 94: for(i=8; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/750eb819_adfa55a4 PS2, Line 94: for(i=8; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/35960919_b3e25af4 PS2, Line 94: for(i=8; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/78630f90_9c284532 PS2, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bf1e3027_c7306723 PS2, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9e178b87_2eca2e18 PS2, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c5bf1d6b_d5437783 PS2, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/da1dc8fa_6a2d2450 PS2, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/87d272a7_37e6a07a PS2, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cdf1589a_dd45289c PS2, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c41d7469_b0b0f57a PS2, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fc6f338e_dcf7c303 PS2, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f5098a61_3252776d PS2, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cd870857_4983065e PS2, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e8ff8840_c6e26d15 PS2, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3daa75cd_9646875d PS2, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a61ec466_9c8eb85b PS2, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c2004305_5a86750d PS2, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ea41fa3e_aa5d85ee PS2, Line 104: for(i=1; (j=Pi[i])>1; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3bc0fe82_8bcc6811 PS2, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e38a8ae6_b2ac2811 PS2, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7f0fa8ab_eee23cff PS2, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/de78d5b0_069004f7 PS2, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fdc7c8e7_55cee436 PS2, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b4e598b5_871f6936 PS2, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5c18ab85_dd7978c7 PS2, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0e0bc769_9ed9c8c0 PS2, Line 111: for(i=0; i<200; i+=40) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/06d566e4_89534802 PS2, Line 111: for(i=0; i<200; i+=40) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5ca87c29_d96f3a1c PS2, Line 111: for(i=0; i<200; i+=40) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1ba2daa3_039a309c PS2, Line 111: for(i=0; i<200; i+=40) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a06123a8_3127bf6e PS2, Line 111: for(i=0; i<200; i+=40) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/09df563e_101f193a PS2, Line 112: { for(j=0; j<40; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b501487d_47f6ea63 PS2, Line 112: { for(j=0; j<40; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a67502c6_fd3d13b0 PS2, Line 112: { for(j=0; j<40; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/af4bc274_8fa99ffb PS2, Line 113: t[j]=(~s[i+(j+8)%40]) & s[i+(j+16)%40]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3b47518a_3d132d8d PS2, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/52118f3f_c268a861 PS2, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/208b1348_fdd9b57c PS2, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '^=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b16f79c9_b3012c59 PS2, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b72f34e7_342c8ce8 PS2, Line 135: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3af63cad_852d5bb1 PS2, Line 135: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0c886833_3f22b9c0 PS2, Line 135: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/84f26758_cb6f166c PS2, Line 135: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5fe3ff5e_29319aa0 PS2, Line 137: for(i=0; i<10; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/23ed2218_32f0d3e6 PS2, Line 137: for(i=0; i<10; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5a4b28f9_f125e311 PS2, Line 137: for(i=0; i<10; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/488744ac_7484184d PS2, Line 139: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b380ede9_2e9d46ed PS2, Line 139: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fcd26dd0_ad4832b0 PS2, Line 139: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3f10db5b_2ae562ab PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f45e8094_03c0617d PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/74ac93b9_bfea5aa9 PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0be470b0_d81f686d PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '%=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1830c304_4c204ece PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/186787a5_8fde6515 PS2, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ba4a7986_b13a66e4 PS2, Line 143: if(j==8) break; spaces required around that '==' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1336faa7_d537c54c PS2, Line 143: if(j==8) break; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e9cc6352_2f2feee2 PS2, Line 148: for(i=2; i<50; i+=2) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a86f4d0b_5ec2e333 PS2, Line 148: for(i=2; i<50; i+=2) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b45c3d63_95aacf93 PS2, Line 148: for(i=2; i<50; i+=2) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b8314fe1_cde269a9 PS2, Line 148: for(i=2; i<50; i+=2) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ee460312_b5da22c2 PS2, Line 148: for(i=2; i<50; i+=2) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fa9c4c4e_4c344051 PS2, Line 153: s[i] = t[1-k], s[i+1] = t[k]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0a2f4171_9104aa0f PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9df74ea4_ca9e7eab PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b93f2ff_fbcc5b67 PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ca0a3dbd_68af1569 PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/211b015d_d31895f0 PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e4a1f5c5_9a75c4f6 PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/42ff7897_fd75c7f1 PS2, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/830f4ad7_8109547f PS2, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b8c223a_1c438e56 PS2, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1ba4620b_28d7878a PS2, Line 158: s[i]=s[j], s[i+1]=s[j+1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ac343b50_98e78896 PS2, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/75805e31_6bba407c PS2, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/50218401_587b5f19 PS2, Line 159: s[i]=t[0], s[i+1]=t[1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5cb226f7_075ca495 PS2, Line 162: for(i=0; i<5; ++i, s+=10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ff3004e7_ed4ad036 PS2, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bd0a0803_857e4fab PS2, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/634e65ef_508639cc PS2, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/16a1190c_7c3ee6c9 PS2, Line 162: for(i=0; i<5; ++i, s+=10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fe8eb0c3_3e78e3f9 PS2, Line 163: { for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6a60f333_68afe68c PS2, Line 163: { for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/033829a8_28d52880 PS2, Line 163: { for(j=0; j<10; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a27e6507_f5aa40b0 PS2, Line 165: for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/24c01036_9097dd69 PS2, Line 165: for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7625): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5e8eac81_d27430c5 PS2, Line 165: for(j=0; j<10; ++j) space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 May 2023 14:39:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: osmo-auc-gen: Convert over to osmo_auth_gen_vec*2 API

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33090 ) Change subject: osmo-auc-gen: Convert over to osmo_auth_gen_vec*2 API ...................................................................... Patch Set 2: (1 comment) File utils/osmo-auc-gen.c: https://gerrit.osmocom.org/c/libosmocore/+/33090/comment/2c6d3b90_6258c841 PS1, Line 117: /* 3GPP TS 33.102 6.3.7: "The authentication key (K) shall have a length of 128 bits or 256 bits." */ > thanks. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iffed02ec0fc9c9a996da6f218d67314e381cbb29 Gerrit-Change-Number: 33090 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 May 2023 14:39:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[L] Change in libosmocore[master]: libosmogsm: Add support for TUAK authentication algorithm

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/33094 to look at the new patch set (#2). Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... libosmogsm: Add support for TUAK authentication algorithm The TUAK algorithm is specified in 3GPP TS 35.231, 232 and 233 and intended as an alternative to MILENAGE. It's based around the cryptographic function of KeccakP1600, which is part of SHA-3. This patch adds support for TUAK to the libosmogsm authentication core API via 'struct osmo_auth_impl'. Unit tests covering the test cases from the 3GPP specification are added (and are all passing). Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d --- A .checkpatch.conf M include/osmocom/crypt/auth.h M src/gsm/Makefile.am M src/gsm/auth_core.c A src/gsm/auth_tuak.c A src/gsm/tuak/KeccakP-1600-3gpp.c A src/gsm/tuak/KeccakP-1600-3gpp.h A src/gsm/tuak/tuak.c A src/gsm/tuak/tuak.h M tests/Makefile.am A tests/auth/tuak_test.ok 11 files changed, 878 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/94/33094/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

11 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: libosmogsm: Support authentication with 256-bit K and/or OP/OPc

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/33087 to look at the new patch set (#2). Change subject: libosmogsm: Support authentication with 256-bit K and/or OP/OPc ...................................................................... libosmogsm: Support authentication with 256-bit K and/or OP/OPc 3GPP TS 33.102 Section 6.3.7 states that K can be 128 or 256 bits, while our 'struct osmo_sub_auth_data' had a fixed-size 128bit field. This means we cannot use our auth_core for algorithms with larger key sizes, such as TUAK. Let's introduce osmo_sub_auth_data2 for larger (and variable) sized K and OP[c]. K and OP[c] can even have diffeent sizes in TUAK, where OP[c] is always 256bit, but K can bei 128 or 256 bits. So we need separate length fields for K and OP[c]. I'm adding backwards-compatibility API wrappers, so old applications just continue to work as they always did. However, I'm not adding compatibility wrappers for the plug-in API that can be used to register additional authentication implementations at runtime. We don't know of any user of that API outside of libosmocore, so the function signatures of the 'struct osmo_auth_impl' are modified in an incompatible way. Change-Id: Ie775fedba4a3fa12314c0f7c8a369662ef6a40df --- M include/osmocom/crypt/auth.h M src/gsm/auth_comp128v1.c M src/gsm/auth_comp128v23.c M src/gsm/auth_core.c M src/gsm/auth_milenage.c M src/gsm/auth_xor.c M src/gsm/auth_xor_2g.c M src/gsm/libosmogsm.map 8 files changed, 180 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/33087/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie775fedba4a3fa12314c0f7c8a369662ef6a40df Gerrit-Change-Number: 33087 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

11 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: libosmogsm: Allow auth API caller to specify RES length

by laforge

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/33091 to look at the new patch set (#2). Change subject: libosmogsm: Allow auth API caller to specify RES length ...................................................................... libosmogsm: Allow auth API caller to specify RES length There are 3G algorithms which support different lengths of RES values (4, 8, 16 byte). For MILENAGE, we never really had to bother, as the 4-byte RES is simply the first 4 bytes of the 8-byte RES. However, for TUAK, the expected RES length is an input parameter to the Keccak crypto functions, so the result of all parameters (including CK, IK, ...) will be completely different for RES length 4 than RES length 8. So let's permit the caller of the osmocom auth API to specify the requested RES length via the osmo_auth_vector.res_len parameter. For backwards compatibility of callers of the old osmo_auth_gen_vec/ osmo_auth_gen_vec_auts API: Always force the res_len to 8 in this case, which was the hard-coded length before this patch. Change-Id: Ic662843fbe8b5c58e4af39ea630ad5ac13fd6bef --- M include/osmocom/crypt/auth.h M src/gsm/auth_core.c M src/gsm/auth_milenage.c M tests/osmo-auc-gen/osmo-auc-gen_test.ok M utils/osmo-auc-gen.c 5 files changed, 83 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/33091/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic662843fbe8b5c58e4af39ea630ad5ac13fd6bef Gerrit-Change-Number: 33091 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

11 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: osmo-auc-gen: Convert over to osmo_auth_gen_vec*2 API

by laforge

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/33090 to look at the new patch set (#2). Change subject: osmo-auc-gen: Convert over to osmo_auth_gen_vec*2 API ...................................................................... osmo-auc-gen: Convert over to osmo_auth_gen_vec*2 API This allows the tool to support K/OPc lengths != 128 bit. Let's add more length checks of command-line arguments while we're adding those checks for K/OPc. Change-Id: Iffed02ec0fc9c9a996da6f218d67314e381cbb29 --- M utils/osmo-auc-gen.c 1 file changed, 47 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/33090/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iffed02ec0fc9c9a996da6f218d67314e381cbb29 Gerrit-Change-Number: 33090 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

11 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: osmo-auc-gen: Convert over to osmo_auth_gen_vec*2 API

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33090 ) Change subject: osmo-auc-gen: Convert over to osmo_auth_gen_vec*2 API ...................................................................... Patch Set 1: (1 comment) File utils/osmo-auc-gen.c: https://gerrit.osmocom.org/c/libosmocore/+/33090/comment/38a95087_e3d29dff PS1, Line 117: /* 3GPP TS 33.102 6.3.7: "The authentication key (K) shall have a length of 128 bits or 256 bits." */ > why is this comment added here? thanks. it's left-over from a previous version of the patch, where some related code was inserted here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iffed02ec0fc9c9a996da6f218d67314e381cbb29 Gerrit-Change-Number: 33090 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 May 2023 14:25:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[L] Change in libosmocore[master]: libosmogsm: Add support for TUAK authentication algorithm

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33094 ) Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... Patch Set 1: (219 comments) File src/gsm/tuak/KeccakP-1600-3gpp.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f3b8d1e0_5e27ea52 PS1, Line 22: EXPORTIT void Keccak_f_8 (uint8_t s[200]); space prohibited between function name and open parenthesis '(' File src/gsm/tuak/KeccakP-1600-3gpp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7dc33c4a_746012e3 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/757f45a9_69c4b0af PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/07b106a2_af39c92f PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/73247bdf_839cc400 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f28ea848_f8c2586a PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/030f23d3_f9f8ef64 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c209d1a1_5fb651ea PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/21c031ce_496ee7e7 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0462ff7e_dc679892 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a3e9c299_948bb2e1 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9612e708_6dd497d4 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cf30f296_156a5e12 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/754bb38b_5d181e6a PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/404fb88e_9d6643f6 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/04324f2a_dc9bde88 PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/55928e8e_7e011d4a PS1, Line 12: const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c15449c8_ef48579a PS1, Line 13: 15,21,8,18,2,61,56,14}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6c83cd4b_0f772a1d PS1, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/51a911e3_6b2d8c9c PS1, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9d66690c_b3103aac PS1, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/112daa73_7eb19f7d PS1, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e35f7957_e22d8e93 PS1, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0953e248_f58487b7 PS1, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f8ee3625_9c3a92f8 PS1, Line 13: 15,21,8,18,2,61,56,14}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b350d859_040eae68 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c27e59ac_9014e3ef PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/89e91b72_ac90505a PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f4a329c2_6b8f48d6 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/96d22e24_812ed4fd PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e0ff439f_56a2b7b1 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3b31003b_2048937a PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3de67bd1_fc82b816 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/05eeeaba_db6f6468 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/73b40b93_f948572d PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5aa39f18_e8cd3cf0 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ff11c797_ed763063 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/674d3ed9_f143b93f PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c9759366_f2e04841 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1eeab0a2_d84d0a61 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6fae07eb_c98efb1d PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a1e4bb6b_ac2b10d5 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e35e3ec1_aa0d01f8 PS1, Line 15: const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0ac97784_db0dd849 PS1, Line 16: 23,2,8,14,15,21}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3fae5ef3_3ba20421 PS1, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dbe2128a_af19463f PS1, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5f36bdcb_749991f1 PS1, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dffa2310_dbdc1276 PS1, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9e967695_6b6205c8 PS1, Line 16: 23,2,8,14,15,21}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/58877e82_94065a53 PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/792ae0aa_7419ab64 PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e0141e27_67184e8a PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d15f42a4_4bf67ddf PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a11309b8_393f0e83 PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/609fc71a_f82c6c9d PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d5662588_7fc8b806 PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ee3c91a6_d017743f PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/73b9ff8f_923f9cbe PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/62eeec7e_56014dc9 PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2a233a4b_f4e2e703 PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/dd3bd91f_445b82eb PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0a2815fc_1786d382 PS1, Line 18: const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e9cc40f9_af742b4d PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cf725397_e1b2c095 PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8bc58c87_897c7d5d PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d819edc2_7d69f3a5 PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0e54e0d1_40197029 PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/62bbfc0b_0163f8c7 PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/598d36d7_220a498d PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6e03ae9a_bb567086 PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ed5cbe95_ade2251c PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/15bb6d5e_190482a5 PS1, Line 19: 217,83,82,192,26,106,241,208,33,120}; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c4488d2e_9c656296 PS1, Line 32: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6c70a095_18062b8f PS1, Line 32: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/03b3b082_3e8777ca PS1, Line 32: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cfb7e855_f6063c9b PS1, Line 32: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/12a43180_6aaeaf9b PS1, Line 34: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d0bad51c_2d0069eb PS1, Line 34: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f79c69a9_708a2d45 PS1, Line 34: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/382ee4ca_802e9212 PS1, Line 36: for(i=0; i<5; ++i, s+=5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/feee4265_f1ac35b6 PS1, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a3e065ef_c511acbd PS1, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/62ac3c64_6fe1b192 PS1, Line 36: for(i=0; i<5; ++i, s+=5) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d4523e41_2d5d5540 PS1, Line 36: for(i=0; i<5; ++i, s+=5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/17d6a4c1_edbd05b4 PS1, Line 46: for(i=1; i<25; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f8615300_cc054279 PS1, Line 46: for(i=1; i<25; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a96699d5_16a7f973 PS1, Line 46: for(i=1; i<25; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/897036fd_d9e22128 PS1, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/51713854_5f39733c PS1, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/61f3ca9e_722b31a4 PS1, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9841cd22_227cdc92 PS1, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/cc88af27_f9c99386 PS1, Line 50: for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/34d63388_61ecf5cb PS1, Line 54: for(i=0; i<5; ++i, s += 5) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/754a663f_92f2939c PS1, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e067fb41_e4ea4980 PS1, Line 54: for(i=0; i<5; ++i, s += 5) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2202155e_ff371bcc PS1, Line 54: for(i=0; i<5; ++i, s += 5) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/25e87938_ee5a7aae PS1, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/7273bf24_38d9d7cb PS1, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2466abce_91584bc2 PS1, Line 60: for(j=0; j<5; ++j) s[j] ^= t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4c09aee9_e8bc62f7 PS1, Line 66: *s ^= (t[0] | (t[0]<<11) | (t[0]<<26) | (t[0]<<57)) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/17c8cd28_ebddbd2f PS1, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2febb03e_ef9ab386 PS1, Line 67: & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5d763390_be25e892 PS1, Line 79: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5edf2d12_68f72728 PS1, Line 79: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a85e2a80_d6801209 PS1, Line 79: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0d553eb2_6f4d6bd7 PS1, Line 79: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/297dacf8_3f824a08 PS1, Line 81: for(i=0; i<40; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d37053f8_8cf0d428 PS1, Line 81: for(i=0; i<40; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/43043d55_ce304e5d PS1, Line 81: for(i=0; i<40; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f76cfbd9_4e8a5ef8 PS1, Line 82: t[i]=s[i]^s[40+i]^s[80+i]^s[120+i]^s[160+i]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ba9cbffc_6fb84c7b PS1, Line 83: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/639c54cf_a6b7651f PS1, Line 83: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f77935b7_06d001c0 PS1, Line 83: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2f27338b_d88926bd PS1, Line 83: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bf4c8660_71471e62 PS1, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/554f98ca_b365fc2c PS1, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d4a5420b_7063927f PS1, Line 84: for(j = (i+32)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0ad9b70e_250b0ea5 PS1, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/17d52b6a_3e324d79 PS1, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/212da08a_73df4134 PS1, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/592b45d4_ac3614cb PS1, Line 86: for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/55647a35_c004c2a0 PS1, Line 87: for(j = t[i+7]>>7, k=7; k; --k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ccbe98cf_dade123b PS1, Line 87: for(j = t[i+7]>>7, k=7; k; --k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/08055971_06e12db8 PS1, Line 89: for(i=0; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ca3c3e5e_32ab6c3b PS1, Line 89: for(i=0; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/fac373a1_aefa0152 PS1, Line 89: for(i=0; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ef606eb8_46d08af5 PS1, Line 89: for(i=0; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/923c5554_b02cdc1f PS1, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b8539003_e392e09b PS1, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0c26f48f_135cb738 PS1, Line 90: for(j = (i+8)%40, k=0; k<8; ++k) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8928e99d_2de00623 PS1, Line 94: for(i=8; i<200; i+=8) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b1baf1ca_95a9eab0 PS1, Line 94: for(i=8; i<200; i+=8) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/8742a7d7_4ff2206a PS1, Line 94: for(i=8; i<200; i+=8) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a227d888_726ce3e9 PS1, Line 94: for(i=8; i<200; i+=8) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/aedf773b_e769c1e1 PS1, Line 94: for(i=8; i<200; i+=8) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bbf17597_30234731 PS1, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f55172c8_a9c9263f PS1, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/18c3fee2_5ea2ee0e PS1, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4e2cf4c0_7e23a248 PS1, Line 95: { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/982e587b_6ccbe62b PS1, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/623b5824_accc9bf2 PS1, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/27a662a8_ef3e0a20 PS1, Line 97: for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6d81455a_b63bf564 PS1, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2476f270_7894a365 PS1, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5434ac98_93d99c9c PS1, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/1b988677_18fc8dd1 PS1, Line 103: for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c82a6b95_e469b8ff PS1, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b10fe8ad_de10bb0f PS1, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/26108463_3b88c512 PS1, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0b0161d5_8625895a PS1, Line 104: for(i=1; (j=Pi[i])>1; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f9195a92_f71af1ab PS1, Line 104: for(i=1; (j=Pi[i])>1; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/edefbc08_c78779de PS1, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/582069cd_62225ca2 PS1, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2e36acad_cbd03d04 PS1, Line 105: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2ae58c15_388565d5 PS1, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ please, no space before tabs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3edea6f8_b02f9b2b PS1, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/93f2750d_9813e0b4 PS1, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4b2a6e95_07cbb2e4 PS1, Line 107: for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/62854cff_0249a7dc PS1, Line 111: for(i=0; i<200; i+=40) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5475652e_c3c42e5d PS1, Line 111: for(i=0; i<200; i+=40) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a6560813_a77b933c PS1, Line 111: for(i=0; i<200; i+=40) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/15e9188e_9fc31d82 PS1, Line 111: for(i=0; i<200; i+=40) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/5e955ced_2cfe48e6 PS1, Line 111: for(i=0; i<200; i+=40) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f2650234_ca7d6db9 PS1, Line 112: { for(j=0; j<40; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e138cc59_5b67d1ac PS1, Line 112: { for(j=0; j<40; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e185dba1_e3c206c6 PS1, Line 112: { for(j=0; j<40; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ad1168e4_95ab44b1 PS1, Line 113: t[j]=(~s[i+(j+8)%40]) & s[i+(j+16)%40]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/22a455ad_92a46910 PS1, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d38de161_df903c57 PS1, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e25eac71_6e5a9104 PS1, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; spaces required around that '^=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/51bdfc6e_0d828d36 PS1, Line 114: for(j=0; j<40; ++j) s[i+j]^=t[j]; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/33dfc159_eddd0e41 PS1, Line 135: for(round=0; round<24; ++round) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f7eea16b_7c7a0de7 PS1, Line 135: for(round=0; round<24; ++round) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0fcba008_89ab4aa8 PS1, Line 135: for(round=0; round<24; ++round) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/2674b5d1_74c9a63c PS1, Line 135: for(round=0; round<24; ++round) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/ea8d6909_4e03a224 PS1, Line 137: for(i=0; i<10; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9fc49334_bbebf1c2 PS1, Line 137: for(i=0; i<10; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/892f45a9_3d1f137d PS1, Line 137: for(i=0; i<10; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/d5beb347_2680c591 PS1, Line 139: for(i=0; i<5; ++i) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/58d87c9e_6738b7e6 PS1, Line 139: for(i=0; i<5; ++i) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/871ecf3a_43f6fc35 PS1, Line 139: for(i=0; i<5; ++i) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4307b4b4_34d576df PS1, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/31ffb6d3_fbc0eeeb PS1, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/3d80e8ab_0f90c4f1 PS1, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9215db49_8fd6395a PS1, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '%=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/84004300_01191abb PS1, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b76a4fee_80e9269d PS1, Line 140: for(j=8, k=2; ; j%=10, k=(k+2)%10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4c346d99_3798e16b PS1, Line 143: if(j==8) break; spaces required around that '==' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/98f743f2_24e27d64 PS1, Line 143: if(j==8) break; space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/007ba90e_1ec15259 PS1, Line 148: for(i=2; i<50; i+=2) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/72940d44_6f1e2511 PS1, Line 148: for(i=2; i<50; i+=2) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b22686e0_e75e0d69 PS1, Line 148: for(i=2; i<50; i+=2) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/56441273_550037cc PS1, Line 148: for(i=2; i<50; i+=2) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/e3152604_361b505a PS1, Line 148: for(i=2; i<50; i+=2) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a3fff000_c19c75f0 PS1, Line 153: s[i] = t[1-k], s[i+1] = t[k]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/105cbb0e_7a52dfb7 PS1, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/c0f23805_fb83c81c PS1, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/863c4a96_8e987f4e PS1, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/27f560b0_e0c59992 PS1, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9917076a_8da91967 PS1, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/96d52394_9818d213 PS1, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/eeae03e8_5c0a83ee PS1, Line 157: for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/69c411da_9830e973 PS1, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/b3322a9e_6ffde01e PS1, Line 158: s[i]=s[j], s[i+1]=s[j+1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4ef71efd_6df13d8c PS1, Line 158: s[i]=s[j], s[i+1]=s[j+1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/05a6c5ec_ef657e03 PS1, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/0e52014e_4252b2fa PS1, Line 159: s[i]=t[0], s[i+1]=t[1]; spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/92dbd9b0_f92dd6c4 PS1, Line 159: s[i]=t[0], s[i+1]=t[1]; Possible comma where semicolon could be used Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/793c507a_501905bc PS1, Line 162: for(i=0; i<5; ++i, s+=10) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/f3d4bcdc_48d8688b PS1, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/92523332_d43ddd34 PS1, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/a2781d7e_5a534ccf PS1, Line 162: for(i=0; i<5; ++i, s+=10) spaces required around that '+=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/4c30890b_5e459e2a PS1, Line 162: for(i=0; i<5; ++i, s+=10) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/bb1f4286_39629ee3 PS1, Line 163: { for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/53bb6f3e_56889cc4 PS1, Line 163: { for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/50165c48_60161a18 PS1, Line 163: { for(j=0; j<10; ++j) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/41fb2922_1583ef2c PS1, Line 165: for(j=0; j<10; ++j) spaces required around that '=' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/6c0856ac_8ca6b1ca PS1, Line 165: for(j=0; j<10; ++j) spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7615): https://gerrit.osmocom.org/c/libosmocore/+/33094/comment/9e9db5b7_a7ea6a19 PS1, Line 165: for(j=0; j<10; ++j) space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 30 May 2023 14:25:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: libosmogsm: Avoid executing MILENAGE crypto twice (for UMTS and GSM)

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33093 ) Change subject: libosmogsm: Avoid executing MILENAGE crypto twice (for UMTS and GSM) ...................................................................... libosmogsm: Avoid executing MILENAGE crypto twice (for UMTS and GSM) So far, we were executing the cryptographic functions to generate MILENAGE authentication tuples *twice* for every call to milenage_gen_vec: Once for UMTS, and another time for GSM. Let's do this properly: Execute once for UMTS, an then call the computationally much simpler C2 and C3 functions to compute the SRES and Kc values from RES, and CK+IK, respectively. Change-Id: I20ecf6d32974c1ba196bf56deba5b2cd971eaffb --- M src/gsm/auth_milenage.c 1 file changed, 19 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/93/33093/1 diff --git a/src/gsm/auth_milenage.c b/src/gsm/auth_milenage.c index a439b15..2bd05a6 100644 --- a/src/gsm/auth_milenage.c +++ b/src/gsm/auth_milenage.c @@ -54,7 +54,6 @@ uint8_t sqn[6]; uint64_t ind_mask; uint64_t seq_1; - int rc; OSMO_ASSERT(aud->algo == OSMO_AUTH_ALG_MILENAGE); @@ -138,9 +137,8 @@ sqn, _rand, vec->autn, vec->ik, vec->ck, vec->res, &res_len); - rc = gsm_milenage(opc, aud->u.umts.k, _rand, vec->sres, vec->kc); - if (rc < 0) - return rc; + osmo_auth_c3(vec->kc, vec->ck, vec->ik); + osmo_auth_c2(vec->sres, vec->res, vec->res_len, 1); vec->auth_types = OSMO_AUTH_TYPE_UMTS | OSMO_AUTH_TYPE_GSM; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I20ecf6d32974c1ba196bf56deba5b2cd971eaffb Gerrit-Change-Number: 33093 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: libosmogsm: Factor out the C2 derivation function

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33092 ) Change subject: libosmogsm: Factor out the C2 derivation function ...................................................................... libosmogsm: Factor out the C2 derivation function 3GPP specifies the C2 derivation function (generating GSM SRES from UMTS XRES) independent of the MILENAGE algorithm. So instead of open-coding it in milenage.c:gsm_milenage(), let's create a separate public function osmo_auth_c2() similar to the already-existing osmo_auth_c3() function. gsm_milenage() can then simply use that function. Change-Id: I0e7cd55f5578f891cb6cc1b0442920ba5beddae4 --- M include/osmocom/crypt/auth.h M src/gsm/auth_core.c M src/gsm/libosmogsm.map M src/gsm/milenage/milenage.c 4 files changed, 47 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/92/33092/1 diff --git a/include/osmocom/crypt/auth.h b/include/osmocom/crypt/auth.h index 2f8804b..a42ad7a 100644 --- a/include/osmocom/crypt/auth.h +++ b/include/osmocom/crypt/auth.h @@ -142,5 +142,6 @@ enum osmo_auth_algo osmo_auth_alg_parse(const char *name); void osmo_auth_c3(uint8_t kc[], const uint8_t ck[], const uint8_t ik[]); +void osmo_auth_c2(uint8_t sres[4], const uint8_t *res, size_t res_len, uint8_t sres_deriv_func); /* @} */ diff --git a/src/gsm/auth_core.c b/src/gsm/auth_core.c index 1fa1d79..e99f71d 100644 --- a/src/gsm/auth_core.c +++ b/src/gsm/auth_core.c @@ -343,4 +343,32 @@ kc[i] = ck[i] ^ ck[i + 8] ^ ik[i] ^ ik[i + 8]; } +/*! Derive GSM SRES from UMTS [X]RES (auth function c2 from 3GPP TS 33.103 Section 6.8.1.2 + * \param[out] sres GSM SRES value, 4 byte target buffer + * \param[in] res UMTS XRES, 4..16 bytes input buffer + * \param[in] res_len length of res parameter (in bytes) + * \param[in] SRES derivation function (1 or 2, see 3GPP TS 55.205 Section 4 + */ +void osmo_auth_c2(uint8_t sres[4], const uint8_t *res, size_t res_len, uint8_t sres_deriv_func) +{ + uint8_t xres[16]; + + OSMO_ASSERT(sres_deriv_func == 1 || sres_deriv_func == 2); + + memcpy(xres, res, res_len); + + /* zero-pad the end, if XRES is < 16 bytes */ + if (res_len < sizeof(xres)) + memset(xres+res_len, 0, sizeof(xres)-res_len); + + if (sres_deriv_func == 1) { + /* SRES derivation function #1 */ + for (unsigned int i = 0; i < 4; i++) + sres[i] = xres[i] ^ xres[4+i] ^ xres[8+i] ^ xres[12+i]; + } else { + /* SRES derivation function #2 */ + memcpy(sres, xres, 4); + } +} + /*! @} */ diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map index 8de3b54..dc7663e 100644 --- a/src/gsm/libosmogsm.map +++ b/src/gsm/libosmogsm.map @@ -561,6 +561,7 @@ osmo_auth_load; osmo_auth_register; osmo_auth_supported; +osmo_auth_c2; osmo_auth_c3; osmo_sub_auth_type_names; diff --git a/src/gsm/milenage/milenage.c b/src/gsm/milenage/milenage.c index 3c14ab9..ba9ab33 100644 --- a/src/gsm/milenage/milenage.c +++ b/src/gsm/milenage/milenage.c @@ -244,19 +244,13 @@ int gsm_milenage(const u8 *opc, const u8 *k, const u8 *_rand, u8 *sres, u8 *kc) { u8 res[8], ck[16], ik[16]; - int i; if (milenage_f2345(opc, k, _rand, res, ck, ik, NULL, NULL)) return -1; osmo_auth_c3(kc, ck, ik); + osmo_auth_c2(sres, res, sizeof(res), 1); -#ifdef GSM_MILENAGE_ALT_SRES - os_memcpy(sres, res, 4); -#else /* GSM_MILENAGE_ALT_SRES */ - for (i = 0; i < 4; i++) - sres[i] = res[i] ^ res[i + 4]; -#endif /* GSM_MILENAGE_ALT_SRES */ return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0e7cd55f5578f891cb6cc1b0442920ba5beddae4 Gerrit-Change-Number: 33092 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: libosmogsm: Allow auth API caller to specify RES length

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33091 ) Change subject: libosmogsm: Allow auth API caller to specify RES length ...................................................................... libosmogsm: Allow auth API caller to specify RES length There are 3G algorithms which support different lengths of RES values (4, 8, 16 byte). For MILENAGE, we never really had to bother, as the 4-byte RES is simply the first 4 bytes of the 8-byte RES. However, for TUAK, the expected RES length is an input parameter to the Keccak crypto functions, so the result of all parameters (including CK, IK, ...) will be completely different for RES length 4 than RES length 8. So let's permit the caller of the osmocom auth API to specify the requested RES length via the osmo_auth_vector.res_len parameter. For backwards compatibility of callers of the old osmo_auth_gen_vec/ osmo_auth_gen_vec_auts API: Always force the res_len to 8 in this case, which was the hard-coded length before this patch. Change-Id: Ic662843fbe8b5c58e4af39ea630ad5ac13fd6bef --- M include/osmocom/crypt/auth.h M src/gsm/auth_core.c M src/gsm/auth_milenage.c M tests/osmo-auc-gen/osmo-auc-gen_test.ok M utils/osmo-auc-gen.c 5 files changed, 70 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/33091/1 diff --git a/include/osmocom/crypt/auth.h b/include/osmocom/crypt/auth.h index 2715164..2f8804b 100644 --- a/include/osmocom/crypt/auth.h +++ b/include/osmocom/crypt/auth.h @@ -91,7 +91,7 @@ uint8_t ck[OSMO_A5_MAX_KEY_LEN_BYTES]; /*!< ciphering key */ uint8_t ik[OSMO_A5_MAX_KEY_LEN_BYTES]; /*!< integrity key */ uint8_t res[16]; /*!< authentication result */ - uint8_t res_len; /*!< length (in bytes) of res: 8..16 bytes */ + uint8_t res_len; /*!< length (in bytes) of res: 4..16 bytes */ uint8_t kc[8]; /*!< Kc for GSM encryption (A5) */ uint8_t sres[4]; /*!< authentication result for GSM */ uint32_t auth_types; /*!< bitmask of OSMO_AUTH_TYPE_* */ diff --git a/src/gsm/auth_core.c b/src/gsm/auth_core.c index 7ccdbc8..1fa1d79 100644 --- a/src/gsm/auth_core.c +++ b/src/gsm/auth_core.c @@ -216,6 +216,10 @@ struct osmo_sub_auth_data2 aud2; int rc; + /* old API callers are not expected to initialize this struct field, + * and always expect an 8-byte RES value */ + vec->res_len = 8; + auth_data2auth_data2(&aud2, aud); rc = osmo_auth_gen_vec2(vec, &aud2, _rand); if (aud->type == OSMO_AUTH_TYPE_UMTS) @@ -282,6 +286,10 @@ struct osmo_sub_auth_data2 aud2; int rc; + /* old API callers are not expected to initialize this struct field, + * and always expect an 8-byte RES value */ + vec->res_len = 8; + auth_data2auth_data2(&aud2, aud); rc = osmo_auth_gen_vec_auts2(vec, &aud2, auts, rand_auts, _rand); if (aud->type == OSMO_AUTH_TYPE_UMTS) { diff --git a/src/gsm/auth_milenage.c b/src/gsm/auth_milenage.c index 9e94293..a439b15 100644 --- a/src/gsm/auth_milenage.c +++ b/src/gsm/auth_milenage.c @@ -62,6 +62,8 @@ return -EINVAL; if (aud->u.umts.opc_len != 16) return -EINVAL; + if (vec->res_len != 4 && vec->res_len != 8) + return -EINVAL; opc = gen_opc_if_needed(aud, gen_opc); if (!opc) @@ -135,7 +137,7 @@ milenage_generate(opc, aud->u.umts.amf, aud->u.umts.k, sqn, _rand, vec->autn, vec->ik, vec->ck, vec->res, &res_len); - vec->res_len = res_len; + rc = gsm_milenage(opc, aud->u.umts.k, _rand, vec->sres, vec->kc); if (rc < 0) return rc; diff --git a/tests/osmo-auc-gen/osmo-auc-gen_test.ok b/tests/osmo-auc-gen/osmo-auc-gen_test.ok index 3c41f41..2da0b02 100644 --- a/tests/osmo-auc-gen/osmo-auc-gen_test.ok +++ b/tests/osmo-auc-gen/osmo-auc-gen_test.ok @@ -1,7 +1,7 @@ > osmo-auc-gen -3 -a milenage -r 6a61050765caa32c90371370e5d6dc2d -k 1dc4f974325cce611e54f516dc1fec56 -o 2a48162ff3edca4adf0b7b5e527d6c16 -s 0 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY RAND: 6a61050765caa32c90371370e5d6dc2d @@ -18,7 +18,7 @@ > osmo-auc-gen -3 -a milenage -r 6a61050765caa32c90371370e5d6dc2d -k 1dc4f974325cce611e54f516dc1fec56 -o 2a48162ff3edca4adf0b7b5e527d6c16 -s 1 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY RAND: 6a61050765caa32c90371370e5d6dc2d @@ -35,7 +35,7 @@ > osmo-auc-gen -3 -a milenage -r 6a61050765caa32c90371370e5d6dc2d -k 1dc4f974325cce611e54f516dc1fec56 -o 2a48162ff3edca4adf0b7b5e527d6c16 -s 23 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY RAND: 6a61050765caa32c90371370e5d6dc2d @@ -52,7 +52,7 @@ > osmo-auc-gen -3 -a milenage -r 1dc4f974325cce611e54f516dc1fec56 -k 2a48162ff3edca4adf0b7b5e527d6c16 -o 6a61050765caa32c90371370e5d6dc2d -s 42 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY RAND: 1dc4f974325cce611e54f516dc1fec56 @@ -69,7 +69,7 @@ > osmo-auc-gen -3 -a milenage -r 2a48162ff3edca4adf0b7b5e527d6c16 -k 6a61050765caa32c90371370e5d6dc2d -o 1dc4f974325cce611e54f516dc1fec56 -s 99 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY RAND: 2a48162ff3edca4adf0b7b5e527d6c16 @@ -86,7 +86,7 @@ > osmo-auc-gen -3 -a milenage -r 6a61050765caa32c90371370e5d6dc2d -k 2a48162ff3edca4adf0b7b5e527d6c16 -o 1dc4f974325cce611e54f516dc1fec56 -s 281474976710655 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY RAND: 6a61050765caa32c90371370e5d6dc2d @@ -103,7 +103,7 @@ > osmo-auc-gen -3 -a milenage -r 39fa2f4e3d523d8619a73b4f65c3e14d -k EB215756028D60E3275E613320AEC880 -o FB2A3D1B360F599ABAB99DB8669F8308 -A 979498b1f72d3e28c59fa2e72f9c -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY RAND: 39fa2f4e3d523d8619a73b4f65c3e14d @@ -121,7 +121,7 @@ > osmo-auc-gen -3 -a milenage -r 39fa2f4e3d523d8619a73b4f65c3e14d -k EB215756028D60E3275E613320AEC880 -o FB2A3D1B360F599ABAB99DB8669F8308 -A 979498b1f72d3e28c59fa2e72f9c --ind 5 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY RAND: 39fa2f4e3d523d8619a73b4f65c3e14d @@ -139,7 +139,7 @@ > osmo-auc-gen -3 -a milenage -r 39fa2f4e3d523d8619a73b4f65c3e14d -k EB215756028D60E3275E613320AEC880 -o FB2A3D1B360F599ABAB99DB8669F8308 -A 979498b1f72d3e28c59fa2e72f9c --ind 23 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY RAND: 39fa2f4e3d523d8619a73b4f65c3e14d @@ -157,7 +157,7 @@ > osmo-auc-gen -3 -a milenage -r 39fa2f4e3d523d8619a73b4f65c3e14d -k EB215756028D60E3275E613320AEC880 -o FB2A3D1B360F599ABAB99DB8669F8308 -A 979498b1f72d3e28c59fa2e72f9c --ind 31 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY RAND: 39fa2f4e3d523d8619a73b4f65c3e14d @@ -175,7 +175,7 @@ > osmo-auc-gen -3 -a milenage -r 39fa2f4e3d523d8619a73b4f65c3e14d -k EB215756028D60E3275E613320AEC880 -o FB2A3D1B360F599ABAB99DB8669F8308 -A 979498b1f72d3e28c59fa2e72f9c --ind-len 0 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY RAND: 39fa2f4e3d523d8619a73b4f65c3e14d @@ -193,7 +193,7 @@ > osmo-auc-gen -3 -a milenage -r 39fa2f4e3d523d8619a73b4f65c3e14d -k EB215756028D60E3275E613320AEC880 -o FB2A3D1B360F599ABAB99DB8669F8308 -A 979498b1f72d3e28c59fa2e72f9c --ind-len 1 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY RAND: 39fa2f4e3d523d8619a73b4f65c3e14d @@ -211,7 +211,7 @@ > osmo-auc-gen -3 -a milenage -r 39fa2f4e3d523d8619a73b4f65c3e14d -k EB215756028D60E3275E613320AEC880 -o FB2A3D1B360F599ABAB99DB8669F8308 -A 979498b1f72d3e28c59fa2e72f9c --ind-len 1 --ind 1 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY RAND: 39fa2f4e3d523d8619a73b4f65c3e14d @@ -229,7 +229,7 @@ > osmo-auc-gen -3 -a milenage -r 39fa2f4e3d523d8619a73b4f65c3e14d -k EB215756028D60E3275E613320AEC880 -o FB2A3D1B360F599ABAB99DB8669F8308 -A 979498b1f72d3e28c59fa2e72f9c --ind-len 8 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY RAND: 39fa2f4e3d523d8619a73b4f65c3e14d @@ -247,7 +247,7 @@ > osmo-auc-gen -3 -a milenage -r 39fa2f4e3d523d8619a73b4f65c3e14d -k EB215756028D60E3275E613320AEC880 -o FB2A3D1B360F599ABAB99DB8669F8308 -A 979498b1f72d3e28c59fa2e72f9c --ind-len 8 --ind 1 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY RAND: 39fa2f4e3d523d8619a73b4f65c3e14d @@ -266,27 +266,27 @@ expecting error: > osmo-auc-gen -3 -a milenage -r 39fa2f4e3d523d8619a73b4f65c3e14d -k EB215756028D60E3275E613320AEC880 -o FB2A3D1B360F599ABAB99DB8669F8308 -A 979498b1f72d3e28c59fa2e72f9c --ind -1 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY expecting error: > osmo-auc-gen -3 -a milenage -r 39fa2f4e3d523d8619a73b4f65c3e14d -k EB215756028D60E3275E613320AEC880 -o FB2A3D1B360F599ABAB99DB8669F8308 -A 979498b1f72d3e28c59fa2e72f9c --ind 32 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY expecting error: > osmo-auc-gen -3 -a milenage -r 39fa2f4e3d523d8619a73b4f65c3e14d -k EB215756028D60E3275E613320AEC880 -o FB2A3D1B360F599ABAB99DB8669F8308 -A 979498b1f72d3e28c59fa2e72f9c --ind 42 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY expecting error: > osmo-auc-gen -3 -a milenage -r 39fa2f4e3d523d8619a73b4f65c3e14d -k EB215756028D60E3275E613320AEC880 -o FB2A3D1B360F599ABAB99DB8669F8308 -A 979498b1f72d3e28c59fa2e72f9c --ind-len 0 --ind 1 -osmo-auc-gen (C) 2011-2012 by Harald Welte +osmo-auc-gen (C) 2011-2023 by Harald Welte This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY diff --git a/utils/osmo-auc-gen.c b/utils/osmo-auc-gen.c index 765ca0b..f21707d 100644 --- a/utils/osmo-auc-gen.c +++ b/utils/osmo-auc-gen.c @@ -98,6 +98,7 @@ "-s --sqn\tSpecify SQN (only for 3G)\n" "-i --ind\tSpecify IND slot for new SQN after AUTS (only for 3G)\n" "-l --ind-len\tSpecify IND bit length (default=5) (only for 3G)\n" + "-L --res-len\tSpecify RES byte length (default=8) (only for 3G)\n" "-A --auts\tSpecify AUTS (only for 3G)\n" "-r --rand\tSpecify random value\n" "-I --ipsec\tOutput in triplets.dat format for strongswan\n"); @@ -124,10 +125,12 @@ int fmt_triplets_dat = 0; uint64_t ind_mask = 0; - printf("osmo-auc-gen (C) 2011-2012 by Harald Welte\n"); + printf("osmo-auc-gen (C) 2011-2023 by Harald Welte\n"); printf("This is FREE SOFTWARE with ABSOLUTELY NO WARRANTY\n\n"); memset(_auts, 0, sizeof(_auts)); + memset(vec, 0, sizeof(*vec)); + vec->res_len = 8; /* default */ while (1) { int c; @@ -142,6 +145,7 @@ { "sqn", 1, 0, 's' }, { "ind", 1, 0, 'i' }, { "ind-len", 1, 0, 'l' }, + { "res-len", 1, 0, 'L' }, { "rand", 1, 0, 'r' }, { "auts", 1, 0, 'A' }, { "help", 0, 0, 'h' }, @@ -150,7 +154,7 @@ rc = 0; - c = getopt_long(argc, argv, "23a:k:o:f:s:i:l:r:hO:A:I", long_options, + c = getopt_long(argc, argv, "23a:k:o:f:s:i:l:L:r:hO:A:I", long_options, &option_index); if (c == -1) @@ -266,6 +270,14 @@ } test_aud.u.umts.ind_bitlen = atoi(optarg); break; + case 'L': + rc = atoi(optarg); + if (rc != 4 && rc != 8 && rc != 16) { + fprintf(stderr, "Invalid RES length %u\n", rc); + exit(2); + } + vec->res_len = rc; + break; case 'r': rc = osmo_hexparse(optarg, _rand, sizeof(_rand)); if (rc != sizeof(_rand)) { @@ -314,8 +326,6 @@ exit(2); } - memset(vec, 0, sizeof(*vec)); - if (test_aud.type == OSMO_AUTH_TYPE_UMTS) { uint64_t seq_1 = 1LL << test_aud.u.umts.ind_bitlen; ind_mask = seq_1 - 1; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic662843fbe8b5c58e4af39ea630ad5ac13fd6bef Gerrit-Change-Number: 33091 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[L] Change in libosmocore[master]: libosmogsm: Add support for TUAK authentication algorithm

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33094 ) Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... libosmogsm: Add support for TUAK authentication algorithm The TUAK algorithm is specified in 3GPP TS 35.231, 232 and 233 and intended as an alternative to MILENAGE. It's based around the cryptographic function of KeccakP1600, which is part of SHA-3. This patch adds support for TUAK to the libosmogsm authentication core API via 'struct osmo_auth_impl'. Unit tests covering the test cases from the 3GPP specification are added (and are all passing). Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d --- M include/osmocom/crypt/auth.h M src/gsm/Makefile.am M src/gsm/auth_core.c A src/gsm/auth_tuak.c A src/gsm/tuak/KeccakP-1600-3gpp.c A src/gsm/tuak/KeccakP-1600-3gpp.h A src/gsm/tuak/tuak.c A src/gsm/tuak/tuak.h M tests/Makefile.am A tests/auth/tuak_test.ok 10 files changed, 877 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/94/33094/1 diff --git a/include/osmocom/crypt/auth.h b/include/osmocom/crypt/auth.h index a42ad7a..86bf02f 100644 --- a/include/osmocom/crypt/auth.h +++ b/include/osmocom/crypt/auth.h @@ -33,6 +33,7 @@ OSMO_AUTH_ALG_XOR_3G, OSMO_AUTH_ALG_MILENAGE, OSMO_AUTH_ALG_XOR_2G, + OSMO_AUTH_ALG_TUAK, _OSMO_AUTH_ALG_NUM, }; /* Backwards-compatibility. We used to call XOR-3G just "XOR" which became ambiguous when diff --git a/src/gsm/Makefile.am b/src/gsm/Makefile.am index ce0b1f4..a91fc6c 100644 --- a/src/gsm/Makefile.am +++ b/src/gsm/Makefile.am @@ -15,6 +15,8 @@ milenage/common.h milenage/crypto.h milenage/includes.h \ milenage/milenage.h +noinst_HEADERS += tuak/KeccakP-1600-3gpp.h tuak/tuak.h + noinst_LTLIBRARIES = libgsmint.la lib_LTLIBRARIES = libosmogsm.la @@ -30,6 +32,7 @@ auth_milenage.c milenage/aes-encblock.c gea.c \ milenage/aes-internal.c milenage/aes-internal-enc.c \ milenage/milenage.c gan.c ipa.c gsm0341.c apn.c \ + tuak/KeccakP-1600-3gpp.c tuak/tuak.c auth_tuak.c \ gsup.c gsup_sms.c gprs_gea.c gsm0503_conv.c oap.c gsm0808_utils.c \ gsm23003.c gsm23236.c mncc.c bts_features.c oap_client.c \ gsm29118.c gsm48_rest_octets.c cbsp.c gsm48049.c \ diff --git a/src/gsm/auth_core.c b/src/gsm/auth_core.c index e99f71d..01e0778 100644 --- a/src/gsm/auth_core.c +++ b/src/gsm/auth_core.c @@ -308,6 +308,7 @@ { OSMO_AUTH_ALG_XOR_3G, "XOR-3G" }, { OSMO_AUTH_ALG_MILENAGE, "MILENAGE" }, { OSMO_AUTH_ALG_XOR_2G, "XOR-2G" }, + { OSMO_AUTH_ALG_TUAK, "TUAK" }, { 0, NULL } }; diff --git a/src/gsm/auth_tuak.c b/src/gsm/auth_tuak.c new file mode 100644 index 0000000..32b3236 --- /dev/null +++ b/src/gsm/auth_tuak.c @@ -0,0 +1,206 @@ +/*! \file auth_tuak.c + * GSM/GPRS/3G authentication core infrastructure */ +/* + * (C) 2023 by Harald Welte <laforge(a)osmocom.org> + * + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + */ + +/* NOTE: TUAK offers a lot of size variability in terms of size of length of MAC_A, MAC_S, + * but this is not used within 3GPP. The different sizes of Kc and RES are handled via + * osmo_sub_auth_data2. */ + +#include <errno.h> +#include <osmocom/crypt/auth.h> +#include <osmocom/core/bits.h> +#include "tuak/tuak.h" + +/*! \addtogroup auth + * @{ + */ + +static const uint8_t *gen_opc_if_needed(const struct osmo_sub_auth_data2 *aud, uint8_t *gen_opc) +{ + int rc; + + /* Check if we only know OP and compute OPC if required */ + if (aud->type == OSMO_AUTH_TYPE_UMTS && aud->u.umts.opc_is_op) { + rc = tuak_opc_gen(gen_opc, aud->u.umts.k, aud->u.umts.k_len, aud->u.umts.opc); + if (rc < 0) + return NULL; + return gen_opc; + } else + return aud->u.umts.opc; +} + +static int tuak_gen_vec(struct osmo_auth_vector *vec, + struct osmo_sub_auth_data2 *aud, + const uint8_t *_rand) +{ + size_t res_len = vec->res_len; + uint64_t next_sqn; + uint8_t gen_opc[32]; + const uint8_t *opc; + uint8_t sqn[6]; + uint64_t ind_mask; + uint64_t seq_1; + + switch (vec->res_len) { + case 4: + case 8: + case 16: + break; + default: + return -EINVAL; + } + + OSMO_ASSERT(aud->algo == OSMO_AUTH_ALG_TUAK); + + if (aud->u.umts.k_len != 16 && aud->u.umts.k_len != 32) + return -EINVAL; + if (aud->u.umts.opc_len != 32) + return -EINVAL; + + opc = gen_opc_if_needed(aud, gen_opc); + if (!opc) + return -1; + + /* Determine next SQN, according to 3GPP TS 33.102: + * SQN consists of SEQ and a lower significant part of IND bits: + * + * |----------SEQ------------| + * |------------------------SQN-----------| + * |-----IND----| + * + * The IND part is used as "slots": e.g. a given HLR client will always + * get the same IND part, called ind here, with incrementing SEQ. In + * the USIM, each IND slot enforces that its SEQ are used in ascending + * order -- as long as that constraint is satisfied, the SQN may jump + * forwards and backwards. For example, for ind_bitlen == 5, asking the + * USIM for SQN = 32, 64, 33 is allowed, because 32 and 64 are + * SEQ || (ind == 0), and though 33 is below 64, it is ind == 1 and + * allowed. Not allowed would be 32, 96, 64, because 64 would go + * backwards after 96, both being ind == 0. + * + * From the last used SQN, we want to increment SEQ + 1, and then pick + * the matching IND part. + * + * IND size is suggested in TS 33.102 as 5 bits. SQN is 48 bits long. + * If ind_bitlen is passed too large here, the algorithms will break + * down. But at which point should we return an error? A sane limit + * seems to be ind_bitlen == 10, but to protect against failure, + * limiting ind_bitlen to 28 is enough, 28 being the number of bits + * suggested for the delta in 33.102, which is discussed to still + * require 2^15 > 32000 authentications to wrap the SQN back to the + * start. + * + * Note that if a caller with ind == 1 generates N vectors, the SQN + * stored after this will reflect SEQ + N. If then another caller with + * ind == 2 generates another N vectors, this will then use SEQ + N + * onwards and end up with SEQ + N + N. In other words, most of each + * SEQ's IND slots will remain unused. When looking at SQN being 48 + * bits wide, after dropping ind_bitlen (say 5) from it, we will still + * have a sequence range of 2^43 = 8.8e12, eight trillion sequences, + * which is large enough to not bother further. With the maximum + * ind_bitlen of 28 enforced below, we still get more than 1 million + * sequences, which is also sufficiently large. + * + * An ind_bitlen of zero may be passed from legacy callers that are not + * aware of the IND extension. For these, below algorithm works out as + * before, simply incrementing SQN by 1. + * + * This is also a mechanism for tools like the osmo-auc-gen to directly + * request a given SQN to be used. With ind_bitlen == 0 the caller can + * be sure that this code will increment SQN by exactly one before + * generating a tuple, thus a caller would simply pass + * { .ind_bitlen = 0, .ind = 0, .sqn = (desired_sqn - 1) } + */ + + if (aud->u.umts.ind_bitlen > OSMO_MILENAGE_IND_BITLEN_MAX) + return -2; + + seq_1 = 1LL << aud->u.umts.ind_bitlen; + ind_mask = ~(seq_1 - 1); + + /* the ind index must not affect the SEQ part */ + if (aud->u.umts.ind >= seq_1) + return -3; + + /* keep the incremented SQN local until gsm_milenage() succeeded. */ + next_sqn = ((aud->u.umts.sqn + seq_1) & ind_mask) + aud->u.umts.ind; + + osmo_store64be_ext(next_sqn, sqn, 6); + + tuak_generate(opc, aud->u.umts.amf, aud->u.umts.k, aud->u.umts.k_len, + sqn, _rand, vec->autn, vec->ik, vec->ck, vec->res, &res_len); + + /* generate the GSM Kc + SRES values using C2 + C3 functions */ + osmo_auth_c3(vec->kc, vec->ck, vec->ik); + osmo_auth_c2(vec->sres, vec->res, vec->res_len, 1); + + vec->auth_types = OSMO_AUTH_TYPE_UMTS | OSMO_AUTH_TYPE_GSM; + + /* for storage in the caller's AUC database */ + aud->u.umts.sqn = next_sqn; + + return 0; +} + +static int tuak_gen_vec_auts(struct osmo_auth_vector *vec, + struct osmo_sub_auth_data2 *aud, + const uint8_t *auts, const uint8_t *rand_auts, + const uint8_t *_rand) +{ + uint8_t sqn_out[6]; + uint8_t gen_opc[32]; + const uint8_t *opc; + int rc; + + OSMO_ASSERT(aud->algo == OSMO_AUTH_ALG_TUAK); + + if (aud->u.umts.k_len != 16 && aud->u.umts.k_len != 32) + return -EINVAL; + if (aud->u.umts.opc_len != 32) + return -EINVAL; + + opc = gen_opc_if_needed(aud, gen_opc); + + rc = tuak_auts(opc, aud->u.umts.k, sizeof(aud->u.umts.k), rand_auts, auts, sqn_out); + if (rc < 0) + return rc; + + aud->u.umts.sqn_ms = osmo_load64be_ext(sqn_out, 6) >> 16; + /* Update our "largest used SQN" from the USIM -- milenage_gen_vec() + * below will increment SQN. */ + aud->u.umts.sqn = aud->u.umts.sqn_ms; + + return tuak_gen_vec(vec, aud, _rand); +} + +static struct osmo_auth_impl tuak_alg = { + .algo = OSMO_AUTH_ALG_TUAK, + .name = "TUAK (libosmogsm built-in)", + .priority = 1000, + .gen_vec = &tuak_gen_vec, + .gen_vec_auts = &tuak_gen_vec_auts, +}; + +static __attribute__((constructor)) void on_dso_load_tuak(void) +{ + osmo_auth_register(&tuak_alg); +} + +/*! @} */ diff --git a/src/gsm/tuak/KeccakP-1600-3gpp.c b/src/gsm/tuak/KeccakP-1600-3gpp.c new file mode 100644 index 0000000..3f5e2ad --- /dev/null +++ b/src/gsm/tuak/KeccakP-1600-3gpp.c @@ -0,0 +1,176 @@ +/* ----------------------------------------------------------------------- + * code extracted from 3GPP TS 35.231, annex E for Keccak core functions + * https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.… + *-----------------------------------------------------------------------*/ + +/* This code may be freely used or adapted. +*/ + +#include "KeccakP-1600-3gpp.h" + + +const uint8_t Rho[25] = {0,1,62,28,27,36,44,6,55,20,3,10,43,25,39,41,45, + 15,21,8,18,2,61,56,14}; + +const uint8_t Pi[25] = {0,6,12,18,24,3,9,10,16,22,1,7,13,19,20,4,5,11,17, + 23,2,8,14,15,21}; + +const uint8_t Iota[24] = {1,146,218,112,155,33,241,89,138,136,57,42,187,203, + 217,83,82,192,26,106,241,208,33,120}; + +#define ROTATE64(value, n) \ +((((uint64_t)(value))<<(n)) | (((uint64_t)(value))>>(64-(n)))) + +/* --------------------------------------------------------------------- + 64-bit version of Keccak_f(1600) + --------------------------------------------------------------------- +*/ +void Keccak_f_64(uint64_t s[25]) +{ uint64_t t[5]; + uint8_t i, j, round; + + for(round=0; round<24; ++round) + { /* Theta function */ + for(i=0; i<5; ++i) + t[i] = s[i] ^ s[5+i] ^ s[10+i] ^ s[15+i] ^ s[20+i]; + for(i=0; i<5; ++i, s+=5) + { s[0] ^= t[4] ^ ROTATE64(t[1], 1); + s[1] ^= t[0] ^ ROTATE64(t[2], 1); + s[2] ^= t[1] ^ ROTATE64(t[3], 1); + s[3] ^= t[2] ^ ROTATE64(t[4], 1); + s[4] ^= t[3] ^ ROTATE64(t[0], 1); + } + s -= 25; + + /* Rho function */ + for(i=1; i<25; ++i) + s[i] = ROTATE64(s[i], Rho[i]); + + /* Pi function */ + for(t[1] = s[i=1]; (j=Pi[i]) > 1; s[i]=s[j], i=j); + s[i] = t[1]; + + /* Chi function */ + for(i=0; i<5; ++i, s += 5) + { t[0] = (~s[1]) & s[2]; + t[1] = (~s[2]) & s[3]; + t[2] = (~s[3]) & s[4]; + t[3] = (~s[4]) & s[0]; + t[4] = (~s[0]) & s[1]; + for(j=0; j<5; ++j) s[j] ^= t[j]; + } + s -= 25; + + /* Iota function */ + t[0] = Iota[round]; + *s ^= (t[0] | (t[0]<<11) | (t[0]<<26) | (t[0]<<57)) + & 0x800000008000808BULL; /* set & mask bits 0,1,3,7,15,31,63 */ + } +} + + +/* --------------------------------------------------------------------- + 8-bit version of Keccak_f(1600) + --------------------------------------------------------------------- +*/ +void Keccak_f_8(uint8_t s[200]) +{ uint8_t t[40], i, j, k, round; + + for(round=0; round<24; ++round) + { /* Theta function */ + for(i=0; i<40; ++i) + t[i]=s[i]^s[40+i]^s[80+i]^s[120+i]^s[160+i]; + for(i=0; i<200; i+=8) + for(j = (i+32)%40, k=0; k<8; ++k) + s[i+k] ^= t[j+k]; + for(i=0; i<40; t[i] = (t[i]<<1)|j, i+=8) + for(j = t[i+7]>>7, k=7; k; --k) + t[i+k] = (t[i+k]<<1)|(t[i+k-1]>>7); + for(i=0; i<200; i+=8) + for(j = (i+8)%40, k=0; k<8; ++k) + s[i+k] ^= t[j+k]; + + /* Rho function */ + for(i=8; i<200; i+=8) + { for(j = Rho[i>>3]>>3, k=0; k<8; ++k) /* j:=bytes to shift, s->t */ + t[(k+j)&7] = s[i+k]; + for(j = Rho[i>>3]&7, k=7; k; --k) /* j:=bits to shift, t->s */ + s[i+k] = (t[k]<<j) | (t[k-1]>>(8-j)); + s[i] = (t[0]<<j) | (t[7]>>(8-j)); + } + + /* Pi function */ + for(k=8; k<16; ++k) t[k] = s[k]; /* =memcpy(t+8, s+8, 8) */ + for(i=1; (j=Pi[i])>1; i=j) + for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), s+(j<<3), 8) */ + s[(i<<3)|k] = s[(j<<3)|k]; + for(k=0; k<8; ++k) /* =memcpy(s+(i<<3), t+8, 8) */ + s[(i<<3)|k] = t[k+8]; + + /* Chi function */ + for(i=0; i<200; i+=40) + { for(j=0; j<40; ++j) + t[j]=(~s[i+(j+8)%40]) & s[i+(j+16)%40]; + for(j=0; j<40; ++j) s[i+j]^=t[j]; + } + + /* Iota function */ + k = Iota[round]; + s[0] ^= k & 0x8B; /* bits 0, 1, 3, 7 */ + s[1] ^= (k<<3)&0x80; /* bit 15 */ + s[3] ^= (k<<2)&0x80; /* bit 31 */ + s[7] ^= (k<<1)&0x80; /* bit 63 */ + + } +} + +/* --------------------------------------------------------------------- + 32-bit version of Keccak_f(1600) + --------------------------------------------------------------------- +*/ +void Keccak_f_32(uint32_t s[50]) +{ uint32_t t[10]; + uint8_t i, j, round, k; + + for(round=0; round<24; ++round) + { /* Theta function */ + for(i=0; i<10; ++i) + t[i] = s[i] ^ s[10+i] ^ s[20+i] ^ s[30+i] ^ s[40+i]; + for(i=0; i<5; ++i) + for(j=8, k=2; ; j%=10, k=(k+2)%10) + { *s++ ^= t[j++] ^ ((t[k]<<1)|(t[k+1]>>31)); + *s++ ^= t[j++] ^ ((t[k+1]<<1)|(t[k]>>31)); + if(j==8) break; + } + s -= 50; + + /* Rho function */ + for(i=2; i<50; i+=2) + { k = Rho[i>>1] & 0x1f; + t[0] = (s[i+1] << k) | (s[i] >> (32-k)); + t[1] = (s[i] << k) | (s[i+1] >> (32-k)); + k = Rho[i>>1] >> 5; + s[i] = t[1-k], s[i+1] = t[k]; + } + + /* Pi function */ + for(i=2, t[0]=s[2], t[1]=s[3]; (j=(Pi[i>>1]<<1))>2; i=j) + s[i]=s[j], s[i+1]=s[j+1]; + s[i]=t[0], s[i+1]=t[1]; + + /* Chi function */ + for(i=0; i<5; ++i, s+=10) + { for(j=0; j<10; ++j) + t[j] = (~s[(j+2)%10]) & s[(j+4)%10]; + for(j=0; j<10; ++j) + s[j] ^= t[j]; + } + s -= 50; + + /* Iota function */ + t[0] = Iota[round]; + s[0] ^= (t[0] | (t[0]<<11) | (t[0]<<26)) & 0x8000808B; + s[1] ^= (t[0]<<25) & 0x80000000; + } +} + diff --git a/src/gsm/tuak/KeccakP-1600-3gpp.h b/src/gsm/tuak/KeccakP-1600-3gpp.h new file mode 100644 index 0000000..a23cc46 --- /dev/null +++ b/src/gsm/tuak/KeccakP-1600-3gpp.h @@ -0,0 +1,25 @@ +/* ----------------------------------------------------------------------- + * code extracted from 3GPP TS 35.231, annex E for Keccak core functions + * https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.… + *-----------------------------------------------------------------------*/ + +/* this is the trick to make the code cross-platform + * at least, Win32 / Linux */ + +#if defined(_WIN32) || defined(__WIN32__) +# include <windows.h> +# define EXPORTIT __declspec(dllexport) +#else +# define EXPORTIT +#endif + +#include <stdint.h> + +/*------------------------------------------------------------------------ + * KeccakP-1600-3gpp.h + *------------------------------------------------------------------------*/ + +EXPORTIT void Keccak_f_8 (uint8_t s[200]); +EXPORTIT void Keccak_f_32(uint32_t s[50]); +EXPORTIT void Keccak_f_64(uint64_t s[25]); + diff --git a/src/gsm/tuak/tuak.c b/src/gsm/tuak/tuak.c new file mode 100644 index 0000000..1e0fbeb --- /dev/null +++ b/src/gsm/tuak/tuak.c @@ -0,0 +1,356 @@ + +#include <stdint.h> +#include <string.h> +#include <string.h> +#include <errno.h> + +#include <osmocom/core/utils.h> + +#include "KeccakP-1600-3gpp.h" + +/* TUAK authentication algorithm + * as proposed by 3GPP as an alternative to Milenage + * algorithm based on SHA-3 (more exactly its KeccakP-1600 permutation) + * see 3GPP TS 35.231, 232 and 233 */ + +static unsigned int g_keccak_iterations = 1; +static const char algoname[] = "TUAK1.0"; +const uint8_t zero16[16] = { 0, }; + +void tuak_set_keccak_iterations(unsigned int i) +{ + g_keccak_iterations = i; +} + +/* append data from 'input' to 'buf' at 'idx', reversing byte order */ +#define PUSH_DATA(buf, idx, input, nbytes) \ + for (int i = nbytes-1; i >= 0; i--) { \ + buf[idx++] = input[i]; \ + } + +/* like memcpy(), but reversing they order of bytes */ +void memcpy_reverse(uint8_t *dst, const uint8_t *src, size_t len) +{ + for (size_t i = 0; i < len; i++) + dst[i] = src[len-i-1]; +} + +static void tuak_core(uint8_t buf[200], const uint8_t *opc, uint8_t instance, const uint8_t *_rand, + const uint8_t *amf, const uint8_t *sqn, const uint8_t *k, uint8_t k_len_bytes, + unsigned int keccac_iterations) +{ + unsigned int idx = 0; + + PUSH_DATA(buf, idx, opc, 32); + buf[idx++] = instance; + PUSH_DATA(buf, idx, algoname, strlen(algoname)); /* without trailing NUL */ + PUSH_DATA(buf, idx, _rand, 16); + PUSH_DATA(buf, idx, amf, 2); + PUSH_DATA(buf, idx, sqn, 6); + PUSH_DATA(buf, idx, k, k_len_bytes); + memset(buf+idx, 0, 32-k_len_bytes); idx += 32-k_len_bytes; + buf[idx++] = 0x1f; + memset(buf+idx, 0, 38); idx += 38; + buf[idx++] = 0x80; + memset(buf+idx, 0, 64); idx += 64; + OSMO_ASSERT(idx == 200); + + for (unsigned int i = 0; i < keccac_iterations; i++) + Keccak_f_64((uint64_t *) buf); +} + +/** + * tuak_f1 - TUAK f1 algorithm + * @opc: OPc = 256-bit value derived from OP and K + * @k: K = 128-bit or 256-bit subscriber key + * @_rand: RAND = 128-bit random challenge + * @sqn: SQN = 48-bit sequence number + * @amf: AMF = 16-bit authentication management field + * @mac_a: Buffer for MAC-A = 64/128/256-bit network authentication code + * Returns: 0 on success, -1 on failure + */ +int tuak_f1(const uint8_t *opc, const uint8_t *k, uint8_t k_len_bytes, const uint8_t *_rand, + const uint8_t *sqn, const uint8_t *amf, uint8_t *mac_a, uint8_t mac_a_len_bytes, + unsigned int keccac_iterations) +{ + uint8_t buf[200]; + uint8_t instance = 0x00; + + switch (mac_a_len_bytes) { + case 8: + instance |= 0x08; + break; + case 16: + instance |= 0x10; + break; + case 32: + instance |= 0x20; + break; + default: + return -EINVAL; + } + + switch (k_len_bytes) { + case 16: + break; + case 32: + instance |= 0x01; + break; + default: + return -EINVAL; + } + + tuak_core(buf, opc, instance, _rand, amf, sqn, k, k_len_bytes, keccac_iterations); + + memcpy_reverse(mac_a, buf, mac_a_len_bytes); + + return 0; +} + +/** + * tuak_f1star - TUAK f1* algorithm + * @opc: OPc = 256-bit value derived from OP and K + * @k: K = 128-bit or 256-bit subscriber key + * @_rand: RAND = 128-bit random challenge + * @sqn: SQN = 48-bit sequence number + * @amf: AMF = 16-bit authentication management field + * @mac_s: Buffer for MAC-S = 64/128/256-bit resync authentication code + * Returns: 0 on success, -1 on failure + */ +int tuak_f1star(const uint8_t *opc, const uint8_t *k, uint8_t k_len_bytes, const uint8_t *_rand, + const uint8_t *sqn, const uint8_t *amf, uint8_t *mac_s, uint8_t mac_s_len_bytes, + unsigned int keccac_iterations) +{ + uint8_t buf[200]; + uint8_t instance = 0x80; + + switch (mac_s_len_bytes) { + case 8: + instance |= 0x08; + break; + case 16: + instance |= 0x10; + break; + case 32: + instance |= 0x20; + break; + default: + return -EINVAL; + } + + switch (k_len_bytes) { + case 16: + break; + case 32: + instance |= 0x01; + break; + default: + return -EINVAL; + } + + tuak_core(buf, opc, instance, _rand, amf, sqn, k, k_len_bytes, keccac_iterations); + + memcpy_reverse(mac_s, buf, mac_s_len_bytes); + + return 0; +} + +/** + * tuak_f2345 - TUAK f2, f3, f4, f5, algorithms + * @opc: OPc = 256-bit value derived from OP and K + * @k: K = 128/256-bit subscriber key + * @_rand: RAND = 128-bit random challenge + * @res: Buffer for RES = 32/64/128/256-bit signed response (f2), or %NULL + * @ck: Buffer for CK = 128/256-bit confidentiality key (f3), or %NULL + * @ik: Buffer for IK = 128/256-bit integrity key (f4), or %NULL + * @ak: Buffer for AK = 48-bit anonymity key (f5), or %NULL + * Returns: 0 on success, -1 on failure + */ +int tuak_f2345(const uint8_t *opc, const uint8_t *k, uint8_t k_len_bytes, + const uint8_t *_rand, uint8_t *res, uint8_t res_len_bytes, + uint8_t *ck, uint8_t ck_len_bytes, + uint8_t *ik, uint8_t ik_len_bytes, uint8_t *ak, unsigned int keccac_iterations) +{ + uint8_t buf[200]; + uint8_t instance = 0x40; + + switch (res_len_bytes) { + case 4: + break; + case 8: + instance |= 0x08; + break; + case 16: + instance |= 0x10; + break; + case 32: + instance |= 0x20; + break; + default: + return -EINVAL; + } + + switch (ck_len_bytes) { + case 16: + break; + case 32: + instance |= 0x04; + break; + default: + return -EINVAL; + } + + switch (ik_len_bytes) { + case 16: + break; + case 32: + instance |= 0x02; + break; + default: + return -EINVAL; + } + + switch (k_len_bytes) { + case 16: + break; + case 32: + instance |= 0x01; + break; + default: + return -EINVAL; + } + + tuak_core(buf, opc, instance, _rand, zero16, zero16, k, k_len_bytes, keccac_iterations); + + if (res) + memcpy_reverse(res, buf, res_len_bytes); + + if (ck) + memcpy_reverse(ck, buf + 32, ck_len_bytes); + + if (ik) + memcpy_reverse(ik, buf + 64, ik_len_bytes); + + if (ak) + memcpy_reverse(ak, buf + 96, 6); + + return 0; +} + +/** + * tuak_f5star - TUAK f5* algorithm + * @opc: OPc = 256-bit value derived from OP and K + * @k: K = 128/256-bit subscriber key + * @_rand: RAND = 128-bit random challenge + * @ak: Buffer for AK = 48-bit anonymity key (f5) + * Returns: 0 on success, -1 on failure + */ +int tuak_f5star(const uint8_t *opc, const uint8_t *k, uint8_t k_len_bytes, + const uint8_t *_rand, uint8_t *ak, unsigned int keccac_iterations) +{ + uint8_t buf[200]; + uint8_t instance = 0xc0; + + switch (k_len_bytes) { + case 16: + break; + case 32: + instance += 1; + break; + default: + return -EINVAL; + } + + tuak_core(buf, opc, instance, _rand, zero16, zero16, k, k_len_bytes, keccac_iterations); + + memcpy_reverse(ak, buf + 96, 6); + + return 0; +} + +/** + * tuak_generate - Generate AKA AUTN,IK,CK,RES + * @opc: OPc = 256-bit operator variant algorithm configuration field (encr.) + * @amf: AMF = 16-bit authentication management field + * @k: K = 128/256-bit subscriber key + * @sqn: SQN = 48-bit sequence number + * @_rand: RAND = 128-bit random challenge + * @autn: Buffer for AUTN = 128-bit authentication token + * @ik: Buffer for IK = 128/256-bit integrity key (f4), or %NULL + * @ck: Buffer for CK = 128/256-bit confidentiality key (f3), or %NULL + * @res: Buffer for RES = 32/64/128-bit signed response (f2), or %NULL + * @res_len: Max length for res; set to used length or 0 on failure + */ +void tuak_generate(const uint8_t *opc, const uint8_t *amf, const uint8_t *k, uint8_t k_len_bytes, + const uint8_t *sqn, const uint8_t *_rand, uint8_t *autn, uint8_t *ik, + uint8_t *ck, uint8_t *res, size_t *res_len) +{ + int i; + uint8_t mac_a[8], ak[6]; + + if (*res_len < 4) { + *res_len = 0; + return; + } + if (tuak_f1(opc, k, k_len_bytes, _rand, sqn, amf, mac_a, sizeof(mac_a), g_keccak_iterations) || + tuak_f2345(opc, k, k_len_bytes, _rand, res, *res_len, ck, 16, ik, 16, ak, g_keccak_iterations)) { + *res_len = 0; + return; + } + + /* AUTN = (SQN ^ AK) || AMF || MAC */ + for (i = 0; i < 6; i++) + autn[i] = sqn[i] ^ ak[i]; + memcpy(autn + 6, amf, 2); + memcpy(autn + 8, mac_a, 8); +} + + +/** + * tuak_auts - Milenage AUTS validation + * @opc: OPc = 256-bit operator variant algorithm configuration field (encr.) + * @k: K = 128/256-bit subscriber key + * @_rand: RAND = 128-bit random challenge + * @auts: AUTS = 112-bit authentication token from client + * @sqn: Buffer for SQN = 48-bit sequence number + * Returns: 0 = success (sqn filled), -1 on failure + */ +int tuak_auts(const uint8_t *opc, const uint8_t *k, uint8_t k_len_bytes, + const uint8_t *_rand, const uint8_t *auts, uint8_t *sqn) +{ + uint8_t amf[2] = { 0x00, 0x00 }; /* TS 33.102 v7.0.0, 6.3.3 */ + uint8_t ak[6], mac_s[8]; + int i; + + if (tuak_f5star(opc, k, k_len_bytes, _rand, ak, g_keccak_iterations)) + return -1; + for (i = 0; i < 6; i++) + sqn[i] = auts[i] ^ ak[i]; + if (tuak_f1star(opc, k, k_len_bytes, _rand, sqn, amf, mac_s, 8, g_keccak_iterations) || + memcmp(mac_s, auts + 6, 8) != 0) + return -1; + return 0; +} + +int tuak_opc_gen(uint8_t *opc, const uint8_t *k, uint8_t k_len_bytes, const uint8_t *op) +{ + uint8_t buf[200]; + uint8_t instance; + + switch (k_len_bytes) { + case 16: + instance = 0x00; + break; + case 32: + instance = 0x01; + break; + default: + return -EINVAL; + } + + tuak_core(buf, op, instance, zero16, zero16, zero16, k, k_len_bytes, g_keccak_iterations); + + memcpy_reverse(opc, buf, 32); + + return 0; +} diff --git a/src/gsm/tuak/tuak.h b/src/gsm/tuak/tuak.h new file mode 100644 index 0000000..1a80822 --- /dev/null +++ b/src/gsm/tuak/tuak.h @@ -0,0 +1,33 @@ +#pragma once +#include <stdint.h> + +/* low-level functions */ + +int tuak_f1(const uint8_t *opc, const uint8_t *k, uint8_t k_len_bytes, const uint8_t *_rand, + const uint8_t *sqn, const uint8_t *amf, uint8_t *mac_a, uint8_t mac_a_len_bytes, + unsigned int keccac_iterations); + +int tuak_f1star(const uint8_t *opc, const uint8_t *k, uint8_t k_len_bytes, const uint8_t *_rand, + const uint8_t *sqn, const uint8_t *amf, uint8_t *mac_s, uint8_t mac_s_len_bytes, + unsigned int keccac_iterations); + +int tuak_f2345(const uint8_t *opc, const uint8_t *k, uint8_t k_len_bytes, + const uint8_t *_rand, uint8_t *res, uint8_t res_len_bytes, + uint8_t *ck, uint8_t ck_len_bytes, + uint8_t *ik, uint8_t ik_len_bytes, uint8_t *ak, unsigned int keccac_iterations); + +int tuak_f5star(const uint8_t *opc, const uint8_t *k, uint8_t k_len_bytes, + const uint8_t *_rand, uint8_t *ak, unsigned int keccac_iterations); + +/* high-level API */ + +void tuak_set_keccak_iterations(unsigned int i); + +void tuak_generate(const uint8_t *opc, const uint8_t *amf, const uint8_t *k, uint8_t k_len_bytes, + const uint8_t *sqn, const uint8_t *_rand, uint8_t *autn, uint8_t *ik, + uint8_t *ck, uint8_t *res, size_t *res_len); + +int tuak_auts(const uint8_t *opc, const uint8_t *k, uint8_t k_len_bytes, + const uint8_t *_rand, const uint8_t *auts, uint8_t *sqn); + +int tuak_opc_gen(uint8_t *opc, const uint8_t *k, uint8_t k_len_bytes, const uint8_t *op); diff --git a/tests/Makefile.am b/tests/Makefile.am index c6027a9..0f63fe0 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -10,7 +10,8 @@ check_PROGRAMS = timer/timer_test sms/sms_test ussd/ussd_test \ bits/bitrev_test a5/a5_test \ - conv/conv_test auth/milenage_test lapd/lapd_test \ + conv/conv_test auth/milenage_test auth/tuak_test \ + lapd/lapd_test \ gsm0808/gsm0808_test gsm0408/gsm0408_test \ gprs/gprs_test kasumi/kasumi_test gea/gea_test \ logging/logging_test codec/codec_test \ @@ -115,6 +116,10 @@ auth_milenage_test_SOURCES = auth/milenage_test.c auth_milenage_test_LDADD = $(top_builddir)/src/gsm/libosmogsm.la $(LDADD) +auth_tuak_test_SOURCES = auth/tuak_test.c +auth_tuak_test_LDADD = $(top_builddir)/src/gsm/libgsmint.la $(LDADD) +auth_tuak_test_CPPFLAGS = $(CPPFLAGS) -I$(top_srcdir)/src + auth_xor2g_test_SOURCES = auth/xor2g_test.c auth_xor2g_test_LDADD = $(top_builddir)/src/gsm/libosmogsm.la $(LDADD) @@ -393,6 +398,7 @@ timer/timer_test.ok sms/sms_test.ok ussd/ussd_test.ok \ bits/bitrev_test.ok a5/a5_test.ok \ conv/conv_test.ok auth/milenage_test.ok ctrl/ctrl_test.ok \ + auth/milenage_test.ok \ auth/xor2g_test.ok \ lapd/lapd_test.ok \ gsm0408/gsm0408_test.ok gsm0408/gsm0408_test.err \ @@ -535,6 +541,8 @@ >$(srcdir)/ussd/ussd_test.ok auth/milenage_test \ >$(srcdir)/auth/milenage_test.ok + auth/tuak_test \ + >$(srcdir)/auth/tuak_test.ok comp128/comp128_test \ >$(srcdir)/comp128/comp128_test.ok lapd/lapd_test \ diff --git a/tests/auth/tuak_test.ok b/tests/auth/tuak_test.ok new file mode 100644 index 0000000..976fb59 --- /dev/null +++ b/tests/auth/tuak_test.ok @@ -0,0 +1,48 @@ +==> TS 35.233 Section 6.3 Test Set 1 + TOPc: bd04d9530e87513c5d837ac2ad954623a8e2330c115305a73eb45d1f40cccbff + MAC_A: f9a54e6aeaa8618d + MAC_S: e94b4dc6c7297df3 + RES: 657acd64 + CK: d71a1e5c6caffe986a26f783e5c78be1 + IK: be849fa2564f869aecee6f62d4337e72 + AK: 719f1e9b9054 +==> TS 35.233 Section 6.4 Test Set 2 + TOPc: 305425427e18c503c8a4b294ea72c95d0c36c6c6b29d0c65de5974d5977f8524 + MAC_A: c0b8c2d4148ec7aa5f1d78a97e4d1d58 + MAC_S: ef81af7290f7842c6ceafa537fa0745b + RES: e9d749dc4eea0035 + CK: a4cb6f6529ab17f8337f27baa8234d47 + IK: 2274155ccf4199d5e2abcbf621907f90 + AK: 480a9345cc1e +==> TS 35.233 Section 6.5 Test Set 3 + TOPc: 305425427e18c503c8a4b294ea72c95d0c36c6c6b29d0c65de5974d5977f8524 + MAC_A: d97b75a1776065271b1e212bc3b1bf173f438b21e6c64a55a96c372e085e5cc5 + MAC_S: 427bbf07c6e3a86c54f8c5216499f3909a6fd4a164c9fe235b1550258111b821 + RES: 07021c73e7635c7d + CK: 4d59ac796834eb85d11fa148a5058c3c + IK: 126d47500136fdc5ddfd14f19ebf16749ce4b6435323fbb5715a3a796a6082bd + AK: 1d6622c4e59a +==> TS 35.233 Section 6.6 Test Set 4 + TOPc: 2bc16eb657a68e1f446f08f57c0efb1d493527a2e652ce281eb6ca0e4487760a + MAC_A: 749214087958dd8f58bfcdf869d8ae3f + MAC_S: 619e865afe80e382aee13063f9dfb56d + RES: 4041ce438e3e38e8aa96562eed83ac43 + CK: 3e3bc01bea0cd914c4c2c83ce2d92757 + IK: 666a8e6f577b1aa77b7fd53cebb8a3d6 + AK: 1f880d005119 +==> TS 35.233 Section 6.7 Test Set 5 + TOPc: 3c6052e41532a28a47aa3cbb89f223e8f3aaa976aecd48bc3e7d6165a55eff62 + MAC_A: d7340dad02b4cb01 + MAC_S: c6021e2e66accb15 + RES: 84d89b41db1867ffd4c7ba1d82163f4d526a20fbae5418fbb526940b1eeb905c + CK: d419676afe5ab58c1d8bee0d43523a4d2f52ef0b31a4676a0c334427a988fe65 + IK: 205533e505661b61d05cc0eac87818f4 + AK: d7b3d2d4980a +==> TS 35.233 Section 6.8 Test Set 6 + TOPc: b04a66f26c62fcd6c82de22a179ab65506ecf47f56245cd149966cfa9cec7a51 + MAC_A: 90d2289ed1ca1c3dbc2247bb480d431ac71d2e4a7677f6e997cfddb0cbad88b7 + MAC_S: 427355dbac30e825063aba61b556e87583abac638e3ab01c4c884ad9d458dc2f + RES: d67e6e64590d22eecba7324afa4af4460c93f01b24506d6e12047d789a94c867 + CK: ede57edfc57cdffe1aae75066a1b7479bbc3837438e88d37a801cccc9f972b89 + IK: 48ed9299126e5057402fe01f9201cf25249f9c5c0ed2afcf084755daff1d3999 + AK: 6aae8d18c448 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: osmo-auc-gen: Convert over to osmo_auth_gen_vec*2 API

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33090 ) Change subject: osmo-auc-gen: Convert over to osmo_auth_gen_vec*2 API ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File utils/osmo-auc-gen.c: https://gerrit.osmocom.org/c/libosmocore/+/33090/comment/2c53e989_fae4bc9c PS1, Line 117: /* 3GPP TS 33.102 6.3.7: "The authentication key (K) shall have a length of 128 bits or 256 bits." */ why is this comment added here? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iffed02ec0fc9c9a996da6f218d67314e381cbb29 Gerrit-Change-Number: 33090 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 May 2023 13:46:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: libosmogsm: Ensure MILENAGE + XOR-3G K length is 128 bit

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33089 ) Change subject: libosmogsm: Ensure MILENAGE + XOR-3G K length is 128 bit ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iae8b93cf059abda087101cdd01bbcf92d355753b Gerrit-Change-Number: 33089 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 May 2023 13:44:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: libosmogsm: Add OSMO_ASSERT() to ensure correct algorithm

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33088 ) Change subject: libosmogsm: Add OSMO_ASSERT() to ensure correct algorithm ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I22b504b6cffb4999b2f14772fffcb2f6f02c198c Gerrit-Change-Number: 33088 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 May 2023 13:44:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Fix sending msgb structures

by daniel

Attention is currently required from: arehbein. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33084 ) Change subject: osmo_io: Fix sending msgb structures ...................................................................... Patch Set 2: Code-Review-1 (1 comment) This change is ready for review. Patchset: PS2: Re-adding the comments from the private change: > > daniel: > > Can you elaborate on that? Right now the expectation is that the user calls write_enable separately. I guess we could change the behaviour if we never want to enqueue messages that should not be sent immediately. > > > > In that case we should also change the sendmsg function below to behave the same. > arehbein: > A couple of reasons which together strongly suggested to me it should be like this: > > * osmo_stream_srv_send() was broken because the 'write enable' was missing > * The doc for osmo_iofd_write_msgb() says /*! Send a message through a connected socket > * The function name suggests that the write should be caused by it. > > Maybe the last two points are also why the write enable was omitted in osmo_stream_srv_send() . > > Admittedly, I didn't check the equivalent *_cli_* function... > however I'm in favor of renaming the function ( osmo_iofd_write_msgb -> osmo_iofd_append_msgb maybe?) and fixing the doc if we stick with the current approach/the one you are mentioning. I can see that it's confusing as it is right now. Maybe the issue is that we currently require a call to read/write_enable when opening the io_fd. Instead it should probably be the default. If the user calls read/write_disable it's much more obvious that they'll need to call *_enable again. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie2a9c93f820fa372a1d527c805fd0fe2cff0eb49 Gerrit-Change-Number: 33084 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 May 2023 13:19:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: libosmogsm: Support authentication with 256-bit K and/or OP/OPc

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33087 ) Change subject: libosmogsm: Support authentication with 256-bit K and/or OP/OPc ...................................................................... Patch Set 1: (1 comment) File include/osmocom/crypt/auth.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7611): https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/ee98614f_1b49e1f0 PS1, Line 52: uint8_t k_len; /*!< K length (in bytes): 16 or 32 */ please, no space before tabs -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie775fedba4a3fa12314c0f7c8a369662ef6a40df Gerrit-Change-Number: 33087 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 30 May 2023 13:10:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: osmo-auc-gen: Convert over to osmo_auth_gen_vec*2 API

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33090 ) Change subject: osmo-auc-gen: Convert over to osmo_auth_gen_vec*2 API ...................................................................... osmo-auc-gen: Convert over to osmo_auth_gen_vec*2 API This allows the tool to support K/OPc lengths != 128 bit. Let's add more length checks of command-line arguments while we're adding those checks for K/OPc. Change-Id: Iffed02ec0fc9c9a996da6f218d67314e381cbb29 --- M utils/osmo-auc-gen.c 1 file changed, 47 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/33090/1 diff --git a/utils/osmo-auc-gen.c b/utils/osmo-auc-gen.c index e3e1b43..765ca0b 100644 --- a/utils/osmo-auc-gen.c +++ b/utils/osmo-auc-gen.c @@ -80,7 +80,7 @@ } } -static struct osmo_sub_auth_data test_aud = { +static struct osmo_sub_auth_data2 test_aud = { .type = OSMO_AUTH_TYPE_NONE, .algo = OSMO_AUTH_ALG_NONE, }; @@ -114,6 +114,7 @@ struct osmo_auth_vector *vec = &_vec; uint8_t _rand[16], _auts[14]; uint64_t sqn = 0; + /* 3GPP TS 33.102 6.3.7: "The authentication key (K) shall have a length of 128 bits or 256 bits." */ unsigned int ind = 0; int rc, option_index; int rand_is_set = 0; @@ -174,10 +175,21 @@ case OSMO_AUTH_TYPE_GSM: rc = osmo_hexparse(optarg, test_aud.u.gsm.ki, sizeof(test_aud.u.gsm.ki)); + if (rc != sizeof(test_aud.u.gsm.ki)) { + fprintf(stderr, "Invalid Ki length %d\n", rc); + exit(2); + } break; case OSMO_AUTH_TYPE_UMTS: rc = osmo_hexparse(optarg, test_aud.u.umts.k, sizeof(test_aud.u.umts.k)); + /* 3GPP TS 33.102 6.3.7: "The authentication key (K) shall have a length of + * 128 bits or 256 bits." */ + if (rc != 16 && rc != 32) { + fprintf(stderr, "Invalid K length %d\n", rc); + exit(2); + } + test_aud.u.umts.k_len = rc; break; default: fprintf(stderr, "please specify 2g/3g first!\n"); @@ -190,6 +202,11 @@ } rc = osmo_hexparse(optarg, test_aud.u.umts.opc, sizeof(test_aud.u.umts.opc)); + if (rc != 16 && rc != 32) { + fprintf(stderr, "Invalid OPC length %d\n", rc); + exit(2); + } + test_aud.u.umts.opc_len = rc; test_aud.u.umts.opc_is_op = 0; break; case 'O': @@ -199,6 +216,11 @@ } rc = osmo_hexparse(optarg, test_aud.u.umts.opc, sizeof(test_aud.u.umts.opc)); + if (rc != 16 && rc != 32) { + fprintf(stderr, "Invalid OP length %d\n", rc); + exit(2); + } + test_aud.u.umts.opc_len = rc; test_aud.u.umts.opc_is_op = 1; break; case 'A': @@ -216,6 +238,10 @@ } rc = osmo_hexparse(optarg, test_aud.u.umts.amf, sizeof(test_aud.u.umts.amf)); + if (rc != 2) { + fprintf(stderr, "Invalid AMF length %d\n", rc); + exit(2); + } break; case 's': if (test_aud.type != OSMO_AUTH_TYPE_UMTS) { @@ -242,6 +268,10 @@ break; case 'r': rc = osmo_hexparse(optarg, _rand, sizeof(_rand)); + if (rc != sizeof(_rand)) { + fprintf(stderr, "Invalid RAND length %d\n", rc); + exit(2); + } rand_is_set = 1; break; case 'I': @@ -316,9 +346,9 @@ } if (!auts_is_set) - rc = osmo_auth_gen_vec(vec, &test_aud, _rand); + rc = osmo_auth_gen_vec2(vec, &test_aud, _rand); else - rc = osmo_auth_gen_vec_auts(vec, &test_aud, _auts, _rand, _rand); + rc = osmo_auth_gen_vec_auts2(vec, &test_aud, _auts, _rand, _rand); if (rc < 0) { if (!auts_is_set) fprintf(stderr, "error generating auth vector\n"); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iffed02ec0fc9c9a996da6f218d67314e381cbb29 Gerrit-Change-Number: 33090 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: libosmogsm: Ensure MILENAGE + XOR-3G K length is 128 bit

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33089 ) Change subject: libosmogsm: Ensure MILENAGE + XOR-3G K length is 128 bit ...................................................................... libosmogsm: Ensure MILENAGE + XOR-3G K length is 128 bit Since Change-Id Ie775fedba4a3fa12314c0f7c8a369662ef6a40df we are supporting K-lengths != 128 bit. However, our existing MILENAGE and XOR-3G algorithms only support that key length, so let's add some explicit checks for that. Change-Id: Iae8b93cf059abda087101cdd01bbcf92d355753b --- M src/gsm/auth_milenage.c M src/gsm/auth_xor.c 2 files changed, 33 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/89/33089/1 diff --git a/src/gsm/auth_milenage.c b/src/gsm/auth_milenage.c index 84780c6..9e94293 100644 --- a/src/gsm/auth_milenage.c +++ b/src/gsm/auth_milenage.c @@ -19,6 +19,7 @@ * */ +#include <errno.h> #include <osmocom/crypt/auth.h> #include <osmocom/core/bits.h> #include "milenage/common.h" @@ -57,6 +58,11 @@ OSMO_ASSERT(aud->algo == OSMO_AUTH_ALG_MILENAGE); + if (aud->u.umts.k_len != 16) + return -EINVAL; + if (aud->u.umts.opc_len != 16) + return -EINVAL; + opc = gen_opc_if_needed(aud, gen_opc); if (!opc) return -1; @@ -154,6 +160,11 @@ OSMO_ASSERT(aud->algo == OSMO_AUTH_ALG_MILENAGE); + if (aud->u.umts.k_len != 16) + return -EINVAL; + if (aud->u.umts.opc_len != 16) + return -EINVAL; + opc = gen_opc_if_needed(aud, gen_opc); rc = milenage_auts(opc, aud->u.umts.k, rand_auts, auts, sqn_out); diff --git a/src/gsm/auth_xor.c b/src/gsm/auth_xor.c index c94b02f..a506a03 100644 --- a/src/gsm/auth_xor.c +++ b/src/gsm/auth_xor.c @@ -55,9 +55,11 @@ /* Step 1: xdout = (ki or k) ^ rand */ if (aud->type == OSMO_AUTH_TYPE_GSM) xor(xdout, aud->u.gsm.ki, _rand, sizeof(xdout)); - else if (aud->type == OSMO_AUTH_TYPE_UMTS) + else if (aud->type == OSMO_AUTH_TYPE_UMTS) { + if (aud->u.umts.k_len != 16) + return -EINVAL; xor(xdout, aud->u.umts.k, _rand, sizeof(xdout)); - else + } else return -ENOTSUP; /** @@ -141,9 +143,11 @@ /* Step 1: xdout = (ki or k) ^ rand */ if (aud->type == OSMO_AUTH_TYPE_GSM) xor(xdout, aud->u.gsm.ki, _rand, sizeof(xdout)); - else if (aud->type == OSMO_AUTH_TYPE_UMTS) + else if (aud->type == OSMO_AUTH_TYPE_UMTS) { + if (aud->u.umts.k_len != 16) + return -EINVAL; xor(xdout, aud->u.umts.k, _rand, sizeof(xdout)); - else + } else return -ENOTSUP; /* Step 2: ak = xdout[2-8] */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iae8b93cf059abda087101cdd01bbcf92d355753b Gerrit-Change-Number: 33089 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: libosmogsm: Add OSMO_ASSERT() to ensure correct algorithm

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33088 ) Change subject: libosmogsm: Add OSMO_ASSERT() to ensure correct algorithm ...................................................................... libosmogsm: Add OSMO_ASSERT() to ensure correct algorithm Let's make sure that nobody ever ends up calling the algo_impl call-backs with data of a non-matching algorithm. This should never happen at all, as all normal users should go through the auth_core.c:osmo_auth_gen_vec* API, which dispatches based on algorithm. Change-Id: I22b504b6cffb4999b2f14772fffcb2f6f02c198c --- M src/gsm/auth_comp128v1.c M src/gsm/auth_comp128v23.c M src/gsm/auth_milenage.c M src/gsm/auth_xor.c M src/gsm/auth_xor_2g.c 5 files changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/88/33088/1 diff --git a/src/gsm/auth_comp128v1.c b/src/gsm/auth_comp128v1.c index a314dc2..ded3f8a 100644 --- a/src/gsm/auth_comp128v1.c +++ b/src/gsm/auth_comp128v1.c @@ -30,6 +30,7 @@ struct osmo_sub_auth_data2 *aud, const uint8_t *_rand) { + OSMO_ASSERT(aud->algo == OSMO_AUTH_ALG_COMP128v1); comp128v1(aud->u.gsm.ki, _rand, vec->sres, vec->kc); vec->auth_types = OSMO_AUTH_TYPE_GSM; diff --git a/src/gsm/auth_comp128v23.c b/src/gsm/auth_comp128v23.c index 697858a..f942bc0 100644 --- a/src/gsm/auth_comp128v23.c +++ b/src/gsm/auth_comp128v23.c @@ -32,6 +32,7 @@ struct osmo_sub_auth_data2 *aud, const uint8_t *_rand) { + OSMO_ASSERT(aud->algo == OSMO_AUTH_ALG_COMP128v2); comp128v2(aud->u.gsm.ki, _rand, vec->sres, vec->kc); vec->auth_types = OSMO_AUTH_TYPE_GSM; @@ -49,6 +50,7 @@ struct osmo_sub_auth_data2 *aud, const uint8_t *_rand) { + OSMO_ASSERT(aud->algo == OSMO_AUTH_ALG_COMP128v3); comp128v3(aud->u.gsm.ki, _rand, vec->sres, vec->kc); vec->auth_types = OSMO_AUTH_TYPE_GSM; diff --git a/src/gsm/auth_milenage.c b/src/gsm/auth_milenage.c index 36fbb06..84780c6 100644 --- a/src/gsm/auth_milenage.c +++ b/src/gsm/auth_milenage.c @@ -55,6 +55,8 @@ uint64_t seq_1; int rc; + OSMO_ASSERT(aud->algo == OSMO_AUTH_ALG_MILENAGE); + opc = gen_opc_if_needed(aud, gen_opc); if (!opc) return -1; @@ -150,6 +152,8 @@ const uint8_t *opc; int rc; + OSMO_ASSERT(aud->algo == OSMO_AUTH_ALG_MILENAGE); + opc = gen_opc_if_needed(aud, gen_opc); rc = milenage_auts(opc, aud->u.umts.k, rand_auts, auts, sqn_out); diff --git a/src/gsm/auth_xor.c b/src/gsm/auth_xor.c index 3552568..c94b02f 100644 --- a/src/gsm/auth_xor.c +++ b/src/gsm/auth_xor.c @@ -50,6 +50,8 @@ uint8_t ak[6], xmac[8]; int i; + OSMO_ASSERT(aud->algo == OSMO_AUTH_ALG_XOR_3G); + /* Step 1: xdout = (ki or k) ^ rand */ if (aud->type == OSMO_AUTH_TYPE_GSM) xor(xdout, aud->u.gsm.ki, _rand, sizeof(xdout)); @@ -134,6 +136,8 @@ uint8_t ak[6], xmac[8]; uint8_t sqnms[6]; + OSMO_ASSERT(aud->algo == OSMO_AUTH_ALG_XOR_3G); + /* Step 1: xdout = (ki or k) ^ rand */ if (aud->type == OSMO_AUTH_TYPE_GSM) xor(xdout, aud->u.gsm.ki, _rand, sizeof(xdout)); diff --git a/src/gsm/auth_xor_2g.c b/src/gsm/auth_xor_2g.c index 1a96b4a..367c79d 100644 --- a/src/gsm/auth_xor_2g.c +++ b/src/gsm/auth_xor_2g.c @@ -48,6 +48,8 @@ { uint8_t res1[16]; + OSMO_ASSERT(aud->algo == OSMO_AUTH_ALG_XOR_2G); + if (aud->type != OSMO_AUTH_TYPE_GSM) return -ENOTSUP; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33088 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I22b504b6cffb4999b2f14772fffcb2f6f02c198c Gerrit-Change-Number: 33088 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: libosmogsm: Support authentication with 256-bit K and/or OP/OPc

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/33087 ) Change subject: libosmogsm: Support authentication with 256-bit K and/or OP/OPc ...................................................................... libosmogsm: Support authentication with 256-bit K and/or OP/OPc 3GPP TS 33.102 Section 6.3.7 states that K can be 128 or 256 bits, while our 'struct osmo_sub_auth_data' had a fixed-size 128bit field. This means we cannot use our auth_core for algorithms with larger key sizes, such as TUAK. Let's introduce osmo_sub_auth_data2 for larger (and variable) sized K and OP[c]. K and OP[c] can even have diffeent sizes in TUAK, where OP[c] is always 256bit, but K can bei 128 or 256 bits. So we need separate length fields for K and OP[c]. I'm adding backwards-compatibility API wrappers, so old applications just continue to work as they always did. However, I'm not adding compatibility wrappers for the plug-in API that can be used to register additional authentication implementations at runtime. We don't know of any user of that API outside of libosmocore, so the function signatures of the 'struct osmo_auth_impl' are modified in an incompatible way. Change-Id: Ie775fedba4a3fa12314c0f7c8a369662ef6a40df --- M include/osmocom/crypt/auth.h M src/gsm/auth_comp128v1.c M src/gsm/auth_comp128v23.c M src/gsm/auth_core.c M src/gsm/auth_milenage.c M src/gsm/auth_xor.c M src/gsm/auth_xor_2g.c M src/gsm/libosmogsm.map 8 files changed, 180 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/33087/1 diff --git a/include/osmocom/crypt/auth.h b/include/osmocom/crypt/auth.h index d872f64..2715164 100644 --- a/include/osmocom/crypt/auth.h +++ b/include/osmocom/crypt/auth.h @@ -40,6 +40,30 @@ #define OSMO_AUTH_ALG_XOR OSMO_AUTH_ALG_XOR_3G /*! permanent (secret) subscriber auth data */ +struct osmo_sub_auth_data2 { + enum osmo_sub_auth_type type; + enum osmo_auth_algo algo; + union { + struct { + /* See 3GPP TS 33.102 Section 9.3.7 Length of authentication parameters */ + uint8_t opc[32]; /*!< operator invariant value */ + uint8_t opc_len; /*!< OPc length (in bytes): 16 or 32 */ + uint8_t k[32]; /*!< secret key of the subscriber */ + uint8_t k_len; /*!< K length (in bytes): 16 or 32 */ + uint8_t amf[2]; + uint64_t sqn; /*!< sequence number (in: prev sqn; out: used sqn) */ + int opc_is_op; /*!< is the OPC field OPC (0) or OP (1) ? */ + unsigned int ind_bitlen; /*!< nr of bits not in SEQ, only SQN */ + unsigned int ind; /*!< which IND slot to use an SQN from */ + uint64_t sqn_ms; /*!< sqn from AUTS (output value only) */ + } umts; + struct { + uint8_t ki[OSMO_A5_MAX_KEY_LEN_BYTES]; /*!< secret key */ + } gsm; + } u; +}; + +/* deprecated older structure without support for 32-byte K/OP[c] */ struct osmo_sub_auth_data { enum osmo_sub_auth_type type; enum osmo_auth_algo algo; @@ -67,7 +91,7 @@ uint8_t ck[OSMO_A5_MAX_KEY_LEN_BYTES]; /*!< ciphering key */ uint8_t ik[OSMO_A5_MAX_KEY_LEN_BYTES]; /*!< integrity key */ uint8_t res[16]; /*!< authentication result */ - uint8_t res_len; /*!< length (in bytes) of res */ + uint8_t res_len; /*!< length (in bytes) of res: 8..16 bytes */ uint8_t kc[8]; /*!< Kc for GSM encryption (A5) */ uint8_t sres[4]; /*!< authentication result for GSM */ uint32_t auth_types; /*!< bitmask of OSMO_AUTH_TYPE_* */ @@ -82,12 +106,12 @@ /*! callback for generate authentication vectors */ int (*gen_vec)(struct osmo_auth_vector *vec, - struct osmo_sub_auth_data *aud, + struct osmo_sub_auth_data2 *aud, const uint8_t *_rand); - /* callback for generationg auth vectors + re-sync */ + /*! callback for generating auth vectors + re-sync */ int (*gen_vec_auts)(struct osmo_auth_vector *vec, - struct osmo_sub_auth_data *aud, + struct osmo_sub_auth_data2 *aud, const uint8_t *auts, const uint8_t *rand_auts, const uint8_t *_rand); }; @@ -95,11 +119,19 @@ int osmo_auth_gen_vec(struct osmo_auth_vector *vec, struct osmo_sub_auth_data *aud, const uint8_t *_rand); +int osmo_auth_gen_vec2(struct osmo_auth_vector *vec, + struct osmo_sub_auth_data2 *aud, const uint8_t *_rand); + int osmo_auth_gen_vec_auts(struct osmo_auth_vector *vec, struct osmo_sub_auth_data *aud, const uint8_t *auts, const uint8_t *rand_auts, const uint8_t *_rand); +int osmo_auth_gen_vec_auts2(struct osmo_auth_vector *vec, + struct osmo_sub_auth_data2 *aud, + const uint8_t *auts, const uint8_t *rand_auts, + const uint8_t *_rand); + int osmo_auth_register(struct osmo_auth_impl *impl); int osmo_auth_load(const char *path); diff --git a/src/gsm/auth_comp128v1.c b/src/gsm/auth_comp128v1.c index ba3cf60..a314dc2 100644 --- a/src/gsm/auth_comp128v1.c +++ b/src/gsm/auth_comp128v1.c @@ -27,7 +27,7 @@ */ static int c128v1_gen_vec(struct osmo_auth_vector *vec, - struct osmo_sub_auth_data *aud, + struct osmo_sub_auth_data2 *aud, const uint8_t *_rand) { comp128v1(aud->u.gsm.ki, _rand, vec->sres, vec->kc); diff --git a/src/gsm/auth_comp128v23.c b/src/gsm/auth_comp128v23.c index 91fb259..697858a 100644 --- a/src/gsm/auth_comp128v23.c +++ b/src/gsm/auth_comp128v23.c @@ -29,7 +29,7 @@ */ static int c128v2_gen_vec(struct osmo_auth_vector *vec, - struct osmo_sub_auth_data *aud, + struct osmo_sub_auth_data2 *aud, const uint8_t *_rand) { comp128v2(aud->u.gsm.ki, _rand, vec->sres, vec->kc); @@ -46,7 +46,7 @@ }; static int c128v3_gen_vec(struct osmo_auth_vector *vec, - struct osmo_sub_auth_data *aud, + struct osmo_sub_auth_data2 *aud, const uint8_t *_rand) { comp128v3(aud->u.gsm.ki, _rand, vec->sres, vec->kc); diff --git a/src/gsm/auth_core.c b/src/gsm/auth_core.c index ce6ba7d..7ccdbc8 100644 --- a/src/gsm/auth_core.c +++ b/src/gsm/auth_core.c @@ -1,4 +1,4 @@ -/* (C) 2010-2012 by Harald Welte <laforge(a)gnumonks.org> +/* (C) 2010-2023 by Harald Welte <laforge(a)gnumonks.org> * * All Rights Reserved * @@ -36,6 +36,35 @@ static LLIST_HEAD(osmo_auths); +/* generate auth_data2 from auth_data (for legacy API/ABI compatibility */ +static int auth_data2auth_data2(struct osmo_sub_auth_data2 *out, const struct osmo_sub_auth_data *in) +{ + out->type = in->type; + out->algo = in->algo; + switch (in->type) { + case OSMO_AUTH_TYPE_NONE: + return 0; + case OSMO_AUTH_TYPE_GSM: + memcpy(out->u.gsm.ki, in->u.gsm.ki, sizeof(out->u.gsm.ki)); + break; + case OSMO_AUTH_TYPE_UMTS: + memcpy(out->u.umts.opc, in->u.umts.opc, sizeof(in->u.umts.opc)); + out->u.umts.opc_len = sizeof(in->u.umts.opc); + memcpy(out->u.umts.k, in->u.umts.k, sizeof(in->u.umts.k)); + out->u.umts.k_len = sizeof(in->u.umts.k); + memcpy(out->u.umts.amf, in->u.umts.amf, sizeof(out->u.umts.amf)); + out->u.umts.sqn = in->u.umts.sqn; + out->u.umts.opc_is_op = in->u.umts.opc_is_op; + out->u.umts.ind_bitlen = in->u.umts.ind_bitlen; + out->u.umts.ind = in->u.umts.ind; + out->u.umts.sqn_ms = in->u.umts.sqn_ms; + break; + default: + return -EINVAL; + } + return 0; +} + static struct osmo_auth_impl *selected_auths[_OSMO_AUTH_ALG_NUM]; /*! Register an authentication algorithm implementation with the core @@ -149,9 +178,9 @@ * by the AUC via HLR and VLR to the MSC which will then be able to * invoke authentication with the MS */ -int osmo_auth_gen_vec(struct osmo_auth_vector *vec, - struct osmo_sub_auth_data *aud, - const uint8_t *_rand) +int osmo_auth_gen_vec2(struct osmo_auth_vector *vec, + struct osmo_sub_auth_data2 *aud, + const uint8_t *_rand) { struct osmo_auth_impl *impl = selected_auths[aud->algo]; int rc; @@ -168,6 +197,68 @@ return 0; } +/*! Generate authentication vector + * \param[out] vec Generated authentication vector + * \param[in] aud Subscriber-specific key material + * \param[in] _rand Random challenge to be used + * \returns 0 on success, negative error on failure + * + * This function performs the core cryptographic function of the AUC, + * computing authentication triples/quintuples based on the permanent + * subscriber data and a random value. The result is what is forwarded + * by the AUC via HLR and VLR to the MSC which will then be able to + * invoke authentication with the MS + */ +int osmo_auth_gen_vec(struct osmo_auth_vector *vec, + struct osmo_sub_auth_data *aud, + const uint8_t *_rand) +{ + struct osmo_sub_auth_data2 aud2; + int rc; + + auth_data2auth_data2(&aud2, aud); + rc = osmo_auth_gen_vec2(vec, &aud2, _rand); + if (aud->type == OSMO_AUTH_TYPE_UMTS) + aud->u.umts.sqn = aud2.u.umts.sqn; + + return rc; +} + +/*! Generate authentication vector and re-sync sequence + * \param[out] vec Generated authentication vector + * \param[in] aud Subscriber-specific key material + * \param[in] auts AUTS value sent by the SIM/MS + * \param[in] rand_auts RAND value sent by the SIM/MS + * \param[in] _rand Random challenge to be used to generate vector + * \returns 0 on success, negative error on failure + * + * This function performs a special variant of the core cryptographic + * function of the AUC: computing authentication triples/quintuples + * based on the permanent subscriber data, a random value as well as the + * AUTS and RAND values returned by the SIM/MS. This special variant is + * needed if the sequence numbers between MS and AUC have for some + * reason become different. + */ +int osmo_auth_gen_vec_auts2(struct osmo_auth_vector *vec, + struct osmo_sub_auth_data2 *aud, + const uint8_t *auts, const uint8_t *rand_auts, + const uint8_t *_rand) +{ + struct osmo_auth_impl *impl = selected_auths[aud->algo]; + int rc; + + if (!impl || !impl->gen_vec_auts) + return -ENOENT; + + rc = impl->gen_vec_auts(vec, aud, auts, rand_auts, _rand); + if (rc < 0) + return rc; + + memcpy(vec->rand, _rand, sizeof(vec->rand)); + + return 0; +} + /*! Generate authentication vector and re-sync sequence * \param[out] vec Generated authentication vector * \param[in] aud Subscriber-specific key material @@ -188,19 +279,17 @@ const uint8_t *auts, const uint8_t *rand_auts, const uint8_t *_rand) { - struct osmo_auth_impl *impl = selected_auths[aud->algo]; + struct osmo_sub_auth_data2 aud2; int rc; - if (!impl || !impl->gen_vec_auts) - return -ENOENT; + auth_data2auth_data2(&aud2, aud); + rc = osmo_auth_gen_vec_auts2(vec, &aud2, auts, rand_auts, _rand); + if (aud->type == OSMO_AUTH_TYPE_UMTS) { + aud->u.umts.sqn = aud2.u.umts.sqn; + aud->u.umts.sqn_ms = aud2.u.umts.sqn_ms; + } - rc = impl->gen_vec_auts(vec, aud, auts, rand_auts, _rand); - if (rc < 0) - return rc; - - memcpy(vec->rand, _rand, sizeof(vec->rand)); - - return 0; + return rc; } static const struct value_string auth_alg_vals[] = { diff --git a/src/gsm/auth_milenage.c b/src/gsm/auth_milenage.c index 4a430b3..36fbb06 100644 --- a/src/gsm/auth_milenage.c +++ b/src/gsm/auth_milenage.c @@ -28,7 +28,7 @@ * @{ */ -static const uint8_t *gen_opc_if_needed(const struct osmo_sub_auth_data *aud, uint8_t *gen_opc) +static const uint8_t *gen_opc_if_needed(const struct osmo_sub_auth_data2 *aud, uint8_t *gen_opc) { int rc; @@ -43,7 +43,7 @@ } static int milenage_gen_vec(struct osmo_auth_vector *vec, - struct osmo_sub_auth_data *aud, + struct osmo_sub_auth_data2 *aud, const uint8_t *_rand) { size_t res_len = sizeof(vec->res); @@ -141,7 +141,7 @@ } static int milenage_gen_vec_auts(struct osmo_auth_vector *vec, - struct osmo_sub_auth_data *aud, + struct osmo_sub_auth_data2 *aud, const uint8_t *auts, const uint8_t *rand_auts, const uint8_t *_rand) { diff --git a/src/gsm/auth_xor.c b/src/gsm/auth_xor.c index 81076bd..3552568 100644 --- a/src/gsm/auth_xor.c +++ b/src/gsm/auth_xor.c @@ -43,7 +43,7 @@ /* 3GPP TS 34.108, section 8.1.2.1 */ static int xor_gen_vec(struct osmo_auth_vector *vec, - struct osmo_sub_auth_data *aud, + struct osmo_sub_auth_data2 *aud, const uint8_t *_rand) { uint8_t xdout[16], cdout[8]; @@ -125,7 +125,7 @@ /* 3GPP TS 34.108, section 8.1.2.2 */ static int xor_gen_vec_auts(struct osmo_auth_vector *vec, - struct osmo_sub_auth_data *aud, + struct osmo_sub_auth_data2 *aud, const uint8_t *auts, const uint8_t *rand_auts, const uint8_t *_rand) diff --git a/src/gsm/auth_xor_2g.c b/src/gsm/auth_xor_2g.c index 9efe5cc..1a96b4a 100644 --- a/src/gsm/auth_xor_2g.c +++ b/src/gsm/auth_xor_2g.c @@ -43,8 +43,8 @@ /* GSM XOR-2G algorithm as specified in Annex 4 (A.4.1.2) of 3GPP TS 51.010-1. */ static int xor2g_gen_vec(struct osmo_auth_vector *vec, - struct osmo_sub_auth_data *aud, - const uint8_t *_rand) + struct osmo_sub_auth_data2 *aud, + const uint8_t *_rand) { uint8_t res1[16]; diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map index 003d6e8..8de3b54 100644 --- a/src/gsm/libosmogsm.map +++ b/src/gsm/libosmogsm.map @@ -554,7 +554,9 @@ osmo_auth_alg_name; osmo_auth_alg_parse; osmo_auth_gen_vec; +osmo_auth_gen_vec2; osmo_auth_gen_vec_auts; +osmo_auth_gen_vec_auts2; osmo_auth_3g_from_2g; osmo_auth_load; osmo_auth_register; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie775fedba4a3fa12314c0f7c8a369662ef6a40df Gerrit-Change-Number: 33087 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: Fix failing Osmocom-release-manuals job

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33086 ) Change subject: Fix failing Osmocom-release-manuals job ...................................................................... Fix failing Osmocom-release-manuals job Add a workaround that upgrades the osmocom-nightly package before installing build dependencies for the given package. This is not very elegant, it would make more sense if the docker image we use here did not have the nightly Osmocom repository configured in the first place (as this job is about creating manuals for tagged releases). But the image is used by jenkins build verification too and I don't think it's a good use of time to change this right now. Fix for: + apt-get -y build-dep /build Note, using directory '/build' to get the build dependencies Reading package lists... Building dependency tree... Reading state information... Some packages could not be installed. This may mean that you have requested an impossible situation or if you are using the unstable distribution that some required packages have not yet been created or been moved out of Incoming. The following information may help to resolve the situation: The following packages have unmet dependencies: osmo-gsm-manuals-dev : Depends: osmocom-nightly (= 202305300026) but 202305290026 is to be installed Change-Id: If28a34d3e5b07216c5310b19623fcc42692f65c3 --- M scripts/manuals/publish-manuals-for-tags.sh 1 file changed, 39 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh index 99e117c..49a3d43 100755 --- a/scripts/manuals/publish-manuals-for-tags.sh +++ b/scripts/manuals/publish-manuals-for-tags.sh @@ -354,6 +354,12 @@ sh -ex -c " apt-get update + # The docker image has the nightly repository + # configured, in which packages can't be installed from + # different build dates. Upgrade osmocom-nightly first + # to prevent errors in apt-get build-dep below. + apt-get -y upgrade osmocom-nightly + # Install dependencies case $repo in *) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If28a34d3e5b07216c5310b19623fcc42692f65c3 Gerrit-Change-Number: 33086 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: Fix failing Osmocom-release-manuals job

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/33086 ) Change subject: Fix failing Osmocom-release-manuals job ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If28a34d3e5b07216c5310b19623fcc42692f65c3 Gerrit-Change-Number: 33086 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 May 2023 12:10:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ci[master]: Fix failing Osmocom-release-manuals job

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/33086 ) Change subject: Fix failing Osmocom-release-manuals job ...................................................................... Fix failing Osmocom-release-manuals job Add a workaround that upgrades the osmocom-nightly package before installing build dependencies for the given package. This is not very elegant, it would make more sense if the docker image we use here did not have the nightly Osmocom repository configured in the first place (as this job is about creating manuals for tagged releases). But the image is used by jenkins build verification too and I don't think it's a good use of time to change this right now. Fix for: + apt-get -y build-dep /build Note, using directory '/build' to get the build dependencies Reading package lists... Building dependency tree... Reading state information... Some packages could not be installed. This may mean that you have requested an impossible situation or if you are using the unstable distribution that some required packages have not yet been created or been moved out of Incoming. The following information may help to resolve the situation: The following packages have unmet dependencies: osmo-gsm-manuals-dev : Depends: osmocom-nightly (= 202305300026) but 202305290026 is to be installed Change-Id: If28a34d3e5b07216c5310b19623fcc42692f65c3 --- M scripts/manuals/publish-manuals-for-tags.sh 1 file changed, 39 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/86/33086/1 diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh index 99e117c..49a3d43 100755 --- a/scripts/manuals/publish-manuals-for-tags.sh +++ b/scripts/manuals/publish-manuals-for-tags.sh @@ -354,6 +354,12 @@ sh -ex -c " apt-get update + # The docker image has the nightly repository + # configured, in which packages can't be installed from + # different build dates. Upgrade osmocom-nightly first + # to prevent errors in apt-get build-dep below. + apt-get -y upgrade osmocom-nightly + # Install dependencies case $repo in *) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/33086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If28a34d3e5b07216c5310b19623fcc42692f65c3 Gerrit-Change-Number: 33086 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: osmo-bts-trx: tch_dl_dequeue(): do not drop CSD frames

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33073 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: osmo-bts-trx: tch_dl_dequeue(): do not drop CSD frames ...................................................................... osmo-bts-trx: tch_dl_dequeue(): do not drop CSD frames Change-Id: I382b9994db01d58515c89c8de6250cd3239b8861 Related: OS#1572 --- M src/osmo-bts-trx/sched_lchan_tchf.c 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 7c2a05f..f065803 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -374,8 +374,8 @@ int8_t sti, cmi; bool amr_is_cmr; - if (rsl_cmode != RSL_CMOD_SPD_SPEECH) { - LOGL1SB(DL1P, LOGL_NOTICE, l1ts, br, "Dropping speech frame, " + if (OSMO_UNLIKELY(rsl_cmode == RSL_CMOD_SPD_SIGN)) { + LOGL1SB(DL1P, LOGL_NOTICE, l1ts, br, "Dropping a TCH frame, " "because we are not in speech mode\n"); goto free_bad_msg; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I382b9994db01d58515c89c8de6250cd3239b8861 Gerrit-Change-Number: 33073 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[M] Change in osmocom-bb[master]: trxcon/l1sched: rework burst buffer shifting for TCH/[FH]

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32921 ) Change subject: trxcon/l1sched: rework burst buffer shifting for TCH/[FH] ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32921 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idb6e415f37f41b8ab92a3864962dac0a40c2fbaa Gerrit-Change-Number: 32921 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 May 2023 11:06:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: measurement: suppress unsupported tch_mode warnings for CSD

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33074 ) Change subject: measurement: suppress unsupported tch_mode warnings for CSD ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33074 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If6896b420d0fa50fa6622d24ef679ca65ef2dc50 Gerrit-Change-Number: 33074 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 May 2023 11:05:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-bts[master]: osmo-bts-trx: visualize rx_tch[fh]_fn() functions

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33076 ) Change subject: osmo-bts-trx: visualize rx_tch[fh]_fn() functions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I373dbbc3d427858f76d07ff85633e07fe2600770 Gerrit-Change-Number: 33076 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 May 2023 11:05:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: osmo-bts-trx: tch_dl_dequeue(): do not drop CSD frames

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33073 ) Change subject: osmo-bts-trx: tch_dl_dequeue(): do not drop CSD frames ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33073 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I382b9994db01d58515c89c8de6250cd3239b8861 Gerrit-Change-Number: 33073 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 May 2023 11:05:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: fix UL FACCH regression in tx_tchh_fn()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33085 ) Change subject: trxcon/l1sched: fix UL FACCH regression in tx_tchh_fn() ...................................................................... trxcon/l1sched: fix UL FACCH regression in tx_tchh_fn() In ad8f7794 I introduced a regression by removing the line setting lchan->ul_facch_blocks, breaking transmission of Uplink FACCH/H. Change-Id: I4f2bbbd30c7d5dbb979b54455561df3c0cc12aac Fixes: ad8f7794 "trxcon/l1sched: remove redundant TCH/[FH] prim length checks" --- M src/host/trxcon/src/sched_lchan_tchh.c 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/host/trxcon/src/sched_lchan_tchh.c b/src/host/trxcon/src/sched_lchan_tchh.c index acf362e..3832deb 100644 --- a/src/host/trxcon/src/sched_lchan_tchh.c +++ b/src/host/trxcon/src/sched_lchan_tchh.c @@ -456,6 +456,9 @@ goto send_burst; } + if (msgb_l2len(lchan->prim) == GSM_MACBLOCK_LEN) + lchan->ul_facch_blocks = 6; + /* populate the buffer with bursts */ switch (lchan->tch_mode) { case GSM48_CMODE_SIGN: -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4f2bbbd30c7d5dbb979b54455561df3c0cc12aac Gerrit-Change-Number: 33085 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: do not align Tx burst transmission

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33006 ) Change subject: trxcon/l1sched: do not align Tx burst transmission ...................................................................... trxcon/l1sched: do not align Tx burst transmission This is no longer needed thanks to recent patch b0be904b. Change-Id: Ia397cbe16f719729a814b7ef0b7035c7fe8ba165 Related: b0be904b "trxcon: do not call l1sched_prim_dequeue() at ul_bid != 0" --- M src/host/trxcon/src/sched_lchan_pdtch.c M src/host/trxcon/src/sched_lchan_tchf.c M src/host/trxcon/src/sched_lchan_tchh.c M src/host/trxcon/src/sched_lchan_xcch.c 4 files changed, 18 insertions(+), 25 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/host/trxcon/src/sched_lchan_pdtch.c b/src/host/trxcon/src/sched_lchan_pdtch.c index b6c3b4c..4b5ffdf 100644 --- a/src/host/trxcon/src/sched_lchan_pdtch.c +++ b/src/host/trxcon/src/sched_lchan_pdtch.c @@ -114,13 +114,8 @@ mask = &lchan->tx_burst_mask; bursts_p = lchan->tx_bursts; - if (br->bid > 0) { - /* If we have encoded bursts */ - if (*mask) - goto send_burst; - else - return 0; - } + if (br->bid > 0) + goto send_burst; /* Encode payload */ rc = gsm0503_pdtch_encode(bursts_p, msgb_l2(lchan->prim), msgb_l2len(lchan->prim)); diff --git a/src/host/trxcon/src/sched_lchan_tchf.c b/src/host/trxcon/src/sched_lchan_tchf.c index f38c82a..691ad5a 100644 --- a/src/host/trxcon/src/sched_lchan_tchf.c +++ b/src/host/trxcon/src/sched_lchan_tchf.c @@ -224,13 +224,8 @@ mask = &lchan->tx_burst_mask; bursts_p = lchan->tx_bursts; - /* If we have encoded bursts */ - if (*mask) - goto send_burst; - - /* Wait until a first burst in period */ if (br->bid > 0) - return 0; + goto send_burst; /* Shift buffer by 4 bursts back for interleaving */ memcpy(bursts_p, bursts_p + 464, 464); diff --git a/src/host/trxcon/src/sched_lchan_tchh.c b/src/host/trxcon/src/sched_lchan_tchh.c index f3b7877..bff9b1b 100644 --- a/src/host/trxcon/src/sched_lchan_tchh.c +++ b/src/host/trxcon/src/sched_lchan_tchh.c @@ -431,12 +431,8 @@ mask = &lchan->tx_burst_mask; bursts_p = lchan->tx_bursts; - if (br->bid > 0) { - /* Align to the first burst */ - if (*mask == 0x00) - return 0; + if (br->bid > 0) goto send_burst; - } if (*mask == 0x00) { /* Align transmission of the first FACCH/H frame */ diff --git a/src/host/trxcon/src/sched_lchan_xcch.c b/src/host/trxcon/src/sched_lchan_xcch.c index b246a17..f76d518 100644 --- a/src/host/trxcon/src/sched_lchan_xcch.c +++ b/src/host/trxcon/src/sched_lchan_xcch.c @@ -110,13 +110,8 @@ mask = &lchan->tx_burst_mask; bursts_p = lchan->tx_bursts; - if (br->bid > 0) { - /* If we have encoded bursts */ - if (*mask) - goto send_burst; - else - return 0; - } + if (br->bid > 0) + goto send_burst; /* Check the prim payload length */ if (msgb_l2len(lchan->prim) != GSM_MACBLOCK_LEN) { -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33006 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia397cbe16f719729a814b7ef0b7035c7fe8ba165 Gerrit-Change-Number: 33006 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[M] Change in osmocom-bb[master]: trxcon/l1sched: cosmetic: use variable names like in osmo-bts-trx

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32920 ) Change subject: trxcon/l1sched: cosmetic: use variable names like in osmo-bts-trx ...................................................................... trxcon/l1sched: cosmetic: use variable names like in osmo-bts-trx This way it's easier to keep trxcon in sync with osmo-bts-trx. Change-Id: I8138a45cca4e9063bf7d36ebc920b20b755138dd Related: OS#4396 --- M src/host/trxcon/src/sched_lchan_pdtch.c M src/host/trxcon/src/sched_lchan_tchf.c M src/host/trxcon/src/sched_lchan_tchh.c M src/host/trxcon/src/sched_lchan_xcch.c 4 files changed, 93 insertions(+), 79 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/host/trxcon/src/sched_lchan_pdtch.c b/src/host/trxcon/src/sched_lchan_pdtch.c index 6702d9d..b6c3b4c 100644 --- a/src/host/trxcon/src/sched_lchan_pdtch.c +++ b/src/host/trxcon/src/sched_lchan_pdtch.c @@ -38,12 +38,12 @@ { uint8_t l2[GPRS_L2_MAX_LEN], *mask; int n_errors, n_bits_total, rc; - sbit_t *buffer, *offset; + sbit_t *bursts_p, *burst; size_t l2_len; /* Set up pointers */ mask = &lchan->rx_burst_mask; - buffer = lchan->rx_bursts; + bursts_p = lchan->rx_bursts; LOGP_LCHAND(lchan, LOGL_DEBUG, "Packet data received: fn=%u bid=%u\n", bi->fn, bi->bid); @@ -59,9 +59,9 @@ l1sched_lchan_meas_push(lchan, bi); /* Copy burst to buffer of 4 bursts */ - offset = buffer + bi->bid * 116; - memcpy(offset, bi->burst + 3, 58); - memcpy(offset + 58, bi->burst + 87, 58); + burst = bursts_p + bi->bid * 116; + memcpy(burst, bi->burst + 3, 58); + memcpy(burst + 58, bi->burst + 87, 58); /* Wait until complete set of bursts */ if (bi->bid != 3) @@ -84,7 +84,7 @@ *mask = *mask << 4; /* Attempt to decode */ - rc = gsm0503_pdtch_decode(l2, buffer, + rc = gsm0503_pdtch_decode(l2, bursts_p, NULL, &n_errors, &n_bits_total); if (rc < 0) { LOGP_LCHAND(lchan, LOGL_ERROR, @@ -105,14 +105,14 @@ int tx_pdtch_fn(struct l1sched_lchan_state *lchan, struct l1sched_burst_req *br) { - ubit_t *buffer, *offset; + ubit_t *bursts_p, *burst; const uint8_t *tsc; uint8_t *mask; int rc; /* Set up pointers */ mask = &lchan->tx_burst_mask; - buffer = lchan->tx_bursts; + bursts_p = lchan->tx_bursts; if (br->bid > 0) { /* If we have encoded bursts */ @@ -123,7 +123,7 @@ } /* Encode payload */ - rc = gsm0503_pdtch_encode(buffer, msgb_l2(lchan->prim), msgb_l2len(lchan->prim)); + rc = gsm0503_pdtch_encode(bursts_p, msgb_l2(lchan->prim), msgb_l2len(lchan->prim)); if (rc < 0) { LOGP_LCHAND(lchan, LOGL_ERROR, "Failed to encode L2 payload (len=%u): %s\n", msgb_l2len(lchan->prim), msgb_hexdump_l2(lchan->prim)); @@ -133,7 +133,7 @@ send_burst: /* Determine which burst should be sent */ - offset = buffer + br->bid * 116; + burst = bursts_p + br->bid * 116; /* Update mask */ *mask |= (1 << br->bid); @@ -143,9 +143,9 @@ /* Compose a new burst */ memset(br->burst, 0, 3); /* TB */ - memcpy(br->burst + 3, offset, 58); /* Payload 1/2 */ + memcpy(br->burst + 3, burst, 58); /* Payload 1/2 */ memcpy(br->burst + 61, tsc, 26); /* TSC */ - memcpy(br->burst + 87, offset + 58, 58); /* Payload 2/2 */ + memcpy(br->burst + 87, burst + 58, 58); /* Payload 2/2 */ memset(br->burst + 145, 0, 3); /* TB */ br->burst_len = GSM_NBITS_NB_GMSK_BURST; diff --git a/src/host/trxcon/src/sched_lchan_tchf.c b/src/host/trxcon/src/sched_lchan_tchf.c index 3674bb7..f38c82a 100644 --- a/src/host/trxcon/src/sched_lchan_tchf.c +++ b/src/host/trxcon/src/sched_lchan_tchf.c @@ -61,15 +61,16 @@ const struct l1sched_burst_ind *bi) { int n_errors = -1, n_bits_total = 0, rc; - sbit_t *buffer, *offset; - uint8_t l2[128], *mask; - size_t l2_len; + sbit_t *bursts_p, *burst; + uint8_t tch_data[128]; + size_t tch_data_len; + uint8_t *mask; int amr = 0; uint8_t ft; /* Set up pointers */ mask = &lchan->rx_burst_mask; - buffer = lchan->rx_bursts; + bursts_p = lchan->rx_bursts; LOGP_LCHAND(lchan, LOGL_DEBUG, "Traffic received: fn=%u bid=%u\n", bi->fn, bi->bid); @@ -85,9 +86,9 @@ l1sched_lchan_meas_push(lchan, bi); /* Copy burst to end of buffer of 8 bursts */ - offset = buffer + bi->bid * 116 + 464; - memcpy(offset, bi->burst + 3, 58); - memcpy(offset + 58, bi->burst + 87, 58); + burst = bursts_p + bi->bid * 116 + 464; + memcpy(burst, bi->burst + 3, 58); + memcpy(burst + 58, bi->burst + 87, 58); /* Wait until complete set of bursts */ if (bi->bid != 3) @@ -113,11 +114,11 @@ switch (lchan->tch_mode) { case GSM48_CMODE_SIGN: case GSM48_CMODE_SPEECH_V1: /* FR */ - rc = gsm0503_tch_fr_decode(l2, buffer, + rc = gsm0503_tch_fr_decode(&tch_data[0], bursts_p, 1, 0, &n_errors, &n_bits_total); break; case GSM48_CMODE_SPEECH_EFR: /* EFR */ - rc = gsm0503_tch_fr_decode(l2, buffer, + rc = gsm0503_tch_fr_decode(&tch_data[0], bursts_p, 1, 1, &n_errors, &n_bits_total); break; case GSM48_CMODE_SPEECH_AMR: /* AMR */ @@ -126,7 +127,7 @@ * receive an FACCH frame instead of a voice frame (we do not * know this before we actually decode the frame) */ amr = 2; - rc = gsm0503_tch_afs_decode_dtx(l2 + amr, buffer, + rc = gsm0503_tch_afs_decode_dtx(&tch_data[amr], bursts_p, !sched_tchf_dl_amr_cmi_map[bi->fn % 26], lchan->amr.codec, lchan->amr.codecs, @@ -143,9 +144,9 @@ /* SID frames will always get Frame Type Index 8 (AMR_SID) */ ft = AMR_SID; } - rc = osmo_amr_rtp_enc(l2, - lchan->amr.codec[lchan->amr.dl_cmr], - ft, AMR_GOOD); + rc = osmo_amr_rtp_enc(&tch_data[0], + lchan->amr.codec[lchan->amr.dl_cmr], + ft, AMR_GOOD); if (rc < 0) LOGP_LCHAND(lchan, LOGL_ERROR, "osmo_amr_rtp_enc() returned rc=%d\n", rc); @@ -157,7 +158,7 @@ } /* Shift buffer by 4 bursts for interleaving */ - memcpy(buffer, buffer + 464, 464); + memcpy(bursts_p, bursts_p + 464, 464); /* Check decoding result */ if (rc < 4) { @@ -169,7 +170,7 @@ goto bfi; } else if (rc == GSM_MACBLOCK_LEN) { /* FACCH received, forward it to the higher layers */ - l1sched_lchan_emit_data_ind(lchan, l2 + amr, GSM_MACBLOCK_LEN, + l1sched_lchan_emit_data_ind(lchan, &tch_data[amr], GSM_MACBLOCK_LEN, n_errors, n_bits_total, false); /* Send BFI substituting a stolen TCH frame */ @@ -177,11 +178,11 @@ goto bfi; } else { /* A good TCH frame received */ - l2_len = rc; + tch_data_len = rc; } /* Send a traffic frame to the higher layers */ - return l1sched_lchan_emit_data_ind(lchan, l2, l2_len, + return l1sched_lchan_emit_data_ind(lchan, &tch_data[0], tch_data_len, n_errors, n_bits_total, true); bfi: @@ -204,24 +205,24 @@ } /* Bad frame indication */ - l2_len = l1sched_bad_frame_ind(l2, lchan); + tch_data_len = l1sched_bad_frame_ind(&tch_data[0], lchan); /* Send a BFI frame to the higher layers */ - return l1sched_lchan_emit_data_ind(lchan, l2, l2_len, + return l1sched_lchan_emit_data_ind(lchan, &tch_data[0], tch_data_len, n_errors, n_bits_total, true); } int tx_tchf_fn(struct l1sched_lchan_state *lchan, struct l1sched_burst_req *br) { - ubit_t *buffer, *offset; + ubit_t *bursts_p, *burst; const uint8_t *tsc; uint8_t *mask; int rc; /* Set up pointers */ mask = &lchan->tx_burst_mask; - buffer = lchan->tx_bursts; + bursts_p = lchan->tx_bursts; /* If we have encoded bursts */ if (*mask) @@ -232,14 +233,14 @@ return 0; /* Shift buffer by 4 bursts back for interleaving */ - memcpy(buffer, buffer + 464, 464); + memcpy(bursts_p, bursts_p + 464, 464); /* populate the buffer with bursts */ switch (lchan->tch_mode) { case GSM48_CMODE_SIGN: case GSM48_CMODE_SPEECH_V1: case GSM48_CMODE_SPEECH_EFR: - rc = gsm0503_tch_fr_encode(buffer, + rc = gsm0503_tch_fr_encode(bursts_p, msgb_l2(lchan->prim), msgb_l2len(lchan->prim), 1); break; @@ -290,7 +291,7 @@ } else { lchan->amr.ul_cmr = cmr; } - rc = gsm0503_tch_afs_encode(buffer, + rc = gsm0503_tch_afs_encode(bursts_p, msgb_l2(lchan->prim) + 2, msgb_l2len(lchan->prim) - 2, amr_fn_is_cmr, @@ -317,7 +318,7 @@ send_burst: /* Determine which burst should be sent */ - offset = buffer + br->bid * 116; + burst = bursts_p + br->bid * 116; /* Update mask */ *mask |= (1 << br->bid); @@ -327,9 +328,9 @@ /* Compose a new burst */ memset(br->burst, 0, 3); /* TB */ - memcpy(br->burst + 3, offset, 58); /* Payload 1/2 */ + memcpy(br->burst + 3, burst, 58); /* Payload 1/2 */ memcpy(br->burst + 61, tsc, 26); /* TSC */ - memcpy(br->burst + 87, offset + 58, 58); /* Payload 2/2 */ + memcpy(br->burst + 87, burst + 58, 58); /* Payload 2/2 */ memset(br->burst + 145, 0, 3); /* TB */ br->burst_len = GSM_NBITS_NB_GMSK_BURST; diff --git a/src/host/trxcon/src/sched_lchan_tchh.c b/src/host/trxcon/src/sched_lchan_tchh.c index 3832deb..f3b7877 100644 --- a/src/host/trxcon/src/sched_lchan_tchh.c +++ b/src/host/trxcon/src/sched_lchan_tchh.c @@ -238,15 +238,16 @@ const struct l1sched_burst_ind *bi) { int n_errors = -1, n_bits_total = 0, rc; - sbit_t *buffer, *offset; - uint8_t l2[128], *mask; - size_t l2_len; + sbit_t *bursts_p, *burst; + uint8_t tch_data[128]; + size_t tch_data_len; + uint8_t *mask; int amr = 0; uint8_t ft; /* Set up pointers */ mask = &lchan->rx_burst_mask; - buffer = lchan->rx_bursts; + bursts_p = lchan->rx_bursts; LOGP_LCHAND(lchan, LOGL_DEBUG, "Traffic received: fn=%u bid=%u\n", bi->fn, bi->bid); @@ -273,9 +274,9 @@ l1sched_lchan_meas_push(lchan, bi); /* Copy burst to the end of buffer of 6 bursts */ - offset = buffer + bi->bid * 116 + 464; - memcpy(offset, bi->burst + 3, 58); - memcpy(offset + 58, bi->burst + 87, 58); + burst = bursts_p + bi->bid * 116 + 464; + memcpy(burst, bi->burst + 3, 58); + memcpy(burst + 58, bi->burst + 87, 58); /* Wait until the second burst */ if (bi->bid != 1) @@ -301,14 +302,14 @@ switch (lchan->tch_mode) { case GSM48_CMODE_SIGN: case GSM48_CMODE_SPEECH_V1: /* HR */ - rc = gsm0503_tch_hr_decode(l2, buffer, + rc = gsm0503_tch_hr_decode(&tch_data[0], bursts_p, !sched_tchh_dl_facch_map[bi->fn % 26], &n_errors, &n_bits_total); break; case GSM48_CMODE_SPEECH_AMR: /* AMR */ /* See comment in function rx_tchf_fn() */ amr = 2; - rc = gsm0503_tch_ahs_decode_dtx(l2 + amr, buffer, + rc = gsm0503_tch_ahs_decode_dtx(&tch_data[amr], bursts_p, !sched_tchh_dl_facch_map[bi->fn % 26], !sched_tchh_dl_amr_cmi_map[bi->fn % 26], lchan->amr.codec, @@ -326,7 +327,7 @@ /* SID frames will always get Frame Type Index 8 (AMR_SID) */ ft = AMR_SID; } - rc = osmo_amr_rtp_enc(l2, + rc = osmo_amr_rtp_enc(&tch_data[0], lchan->amr.codec[lchan->amr.dl_cmr], ft, AMR_GOOD); if (rc < 0) @@ -340,8 +341,8 @@ } /* Shift buffer by 4 bursts for interleaving */ - memcpy(buffer, buffer + 232, 232); - memcpy(buffer + 232, buffer + 464, 232); + memcpy(bursts_p, bursts_p + 232, 232); + memcpy(bursts_p + 232, bursts_p + 464, 232); /* Shift burst mask */ *mask = *mask << 2; @@ -365,7 +366,7 @@ l1sched_lchan_meas_avg(lchan, 6); /* FACCH/H received, forward to the higher layers */ - l1sched_lchan_emit_data_ind(lchan, l2 + amr, GSM_MACBLOCK_LEN, + l1sched_lchan_emit_data_ind(lchan, &tch_data[amr], GSM_MACBLOCK_LEN, n_errors, n_bits_total, false); /* Send BFI substituting 1/2 stolen TCH frames */ @@ -373,20 +374,20 @@ goto bfi; } else { /* A good TCH frame received */ - l2_len = rc; + tch_data_len = rc; /* Calculate AVG of the measurements (traffic takes 4 bursts) */ l1sched_lchan_meas_avg(lchan, 4); } /* Send a traffic frame to the higher layers */ - return l1sched_lchan_emit_data_ind(lchan, l2, l2_len, + return l1sched_lchan_emit_data_ind(lchan, &tch_data[0], tch_data_len, n_errors, n_bits_total, true); bfi_shift: /* Shift buffer */ - memcpy(buffer, buffer + 232, 232); - memcpy(buffer + 232, buffer + 464, 232); + memcpy(bursts_p, bursts_p + 232, 232); + memcpy(bursts_p + 232, bursts_p + 464, 232); /* Shift burst mask */ *mask = *mask << 2; @@ -411,24 +412,24 @@ } /* Bad frame indication */ - l2_len = l1sched_bad_frame_ind(l2, lchan); + tch_data_len = l1sched_bad_frame_ind(&tch_data[0], lchan); /* Send a BFI frame to the higher layers */ - return l1sched_lchan_emit_data_ind(lchan, l2, l2_len, + return l1sched_lchan_emit_data_ind(lchan, &tch_data[0], tch_data_len, n_errors, n_bits_total, true); } int tx_tchh_fn(struct l1sched_lchan_state *lchan, struct l1sched_burst_req *br) { - ubit_t *buffer, *offset; + ubit_t *bursts_p, *burst; const uint8_t *tsc; uint8_t *mask; int rc; /* Set up pointers */ mask = &lchan->tx_burst_mask; - buffer = lchan->tx_bursts; + bursts_p = lchan->tx_bursts; if (br->bid > 0) { /* Align to the first burst */ @@ -445,14 +446,14 @@ } /* Shift buffer by 2 bursts back for interleaving */ - memcpy(buffer, buffer + 232, 232); + memcpy(bursts_p, bursts_p + 232, 232); /* Also shift TX burst mask */ *mask = *mask << 2; /* If FACCH/H blocks are still pending */ if (lchan->ul_facch_blocks > 2) { - memcpy(buffer + 232, buffer + 464, 232); + memcpy(bursts_p + 232, bursts_p + 464, 232); goto send_burst; } @@ -463,7 +464,7 @@ switch (lchan->tch_mode) { case GSM48_CMODE_SIGN: case GSM48_CMODE_SPEECH_V1: - rc = gsm0503_tch_hr_encode(buffer, + rc = gsm0503_tch_hr_encode(bursts_p, msgb_l2(lchan->prim), msgb_l2len(lchan->prim)); break; @@ -514,7 +515,7 @@ } else { lchan->amr.ul_cmr = cmr; } - rc = gsm0503_tch_ahs_encode(buffer, + rc = gsm0503_tch_ahs_encode(bursts_p, msgb_l2(lchan->prim) + 2, msgb_l2len(lchan->prim) - 2, amr_fn_is_cmr, @@ -541,7 +542,7 @@ send_burst: /* Determine which burst should be sent */ - offset = buffer + br->bid * 116; + burst = bursts_p + br->bid * 116; /* Update mask */ *mask |= (1 << br->bid); @@ -551,9 +552,9 @@ /* Compose a new burst */ memset(br->burst, 0, 3); /* TB */ - memcpy(br->burst + 3, offset, 58); /* Payload 1/2 */ + memcpy(br->burst + 3, burst, 58); /* Payload 1/2 */ memcpy(br->burst + 61, tsc, 26); /* TSC */ - memcpy(br->burst + 87, offset + 58, 58); /* Payload 2/2 */ + memcpy(br->burst + 87, burst + 58, 58); /* Payload 2/2 */ memset(br->burst + 145, 0, 3); /* TB */ br->burst_len = GSM_NBITS_NB_GMSK_BURST; diff --git a/src/host/trxcon/src/sched_lchan_xcch.c b/src/host/trxcon/src/sched_lchan_xcch.c index 0dca098..b246a17 100644 --- a/src/host/trxcon/src/sched_lchan_xcch.c +++ b/src/host/trxcon/src/sched_lchan_xcch.c @@ -38,11 +38,11 @@ { uint8_t l2[GSM_MACBLOCK_LEN], *mask; int n_errors, n_bits_total, rc; - sbit_t *buffer, *offset; + sbit_t *bursts_p, *burst; /* Set up pointers */ mask = &lchan->rx_burst_mask; - buffer = lchan->rx_bursts; + bursts_p = lchan->rx_bursts; LOGP_LCHAND(lchan, LOGL_DEBUG, "Data received: fn=%u bid=%u\n", bi->fn, bi->bid); @@ -58,9 +58,9 @@ l1sched_lchan_meas_push(lchan, bi); /* Copy burst to buffer of 4 bursts */ - offset = buffer + bi->bid * 116; - memcpy(offset, bi->burst + 3, 58); - memcpy(offset + 58, bi->burst + 87, 58); + burst = bursts_p + bi->bid * 116; + memcpy(burst, bi->burst + 3, 58); + memcpy(burst + 58, bi->burst + 87, 58); /* Wait until complete set of bursts */ if (bi->bid != 3) @@ -86,7 +86,7 @@ *mask = *mask << 4; /* Attempt to decode */ - rc = gsm0503_xcch_decode(l2, buffer, &n_errors, &n_bits_total); + rc = gsm0503_xcch_decode(l2, bursts_p, &n_errors, &n_bits_total); if (rc) { LOGP_LCHAND(lchan, LOGL_ERROR, "Received bad frame (rc=%d, ber=%d/%d) at fn=%u\n", @@ -101,14 +101,14 @@ int tx_data_fn(struct l1sched_lchan_state *lchan, struct l1sched_burst_req *br) { - ubit_t *buffer, *offset; + ubit_t *bursts_p, *burst; const uint8_t *tsc; uint8_t *mask; int rc; /* Set up pointers */ mask = &lchan->tx_burst_mask; - buffer = lchan->tx_bursts; + bursts_p = lchan->tx_bursts; if (br->bid > 0) { /* If we have encoded bursts */ @@ -128,7 +128,7 @@ } /* Encode payload */ - rc = gsm0503_xcch_encode(buffer, msgb_l2(lchan->prim)); + rc = gsm0503_xcch_encode(bursts_p, msgb_l2(lchan->prim)); if (rc) { LOGP_LCHAND(lchan, LOGL_ERROR, "Failed to encode L2 payload (len=%u): %s\n", msgb_l2len(lchan->prim), msgb_hexdump_l2(lchan->prim)); @@ -138,7 +138,7 @@ send_burst: /* Determine which burst should be sent */ - offset = buffer + br->bid * 116; + burst = bursts_p + br->bid * 116; /* Update mask */ *mask |= (1 << br->bid); @@ -148,9 +148,9 @@ /* Compose a new burst */ memset(br->burst, 0, 3); /* TB */ - memcpy(br->burst + 3, offset, 58); /* Payload 1/2 */ + memcpy(br->burst + 3, burst, 58); /* Payload 1/2 */ memcpy(br->burst + 61, tsc, 26); /* TSC */ - memcpy(br->burst + 87, offset + 58, 58); /* Payload 2/2 */ + memcpy(br->burst + 87, burst + 58, 58); /* Payload 2/2 */ memset(br->burst + 145, 0, 3); /* TB */ br->burst_len = GSM_NBITS_NB_GMSK_BURST; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8138a45cca4e9063bf7d36ebc920b20b755138dd Gerrit-Change-Number: 32920 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[M] Change in osmocom-bb[master]: trxcon/l1sched: rework burst buffer shifting for TCH/[FH]

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32921 ) Change subject: trxcon/l1sched: rework burst buffer shifting for TCH/[FH] ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32921 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idb6e415f37f41b8ab92a3864962dac0a40c2fbaa Gerrit-Change-Number: 32921 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 May 2023 11:04:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in osmocom-bb[master]: trxcon/l1sched: cosmetic: use variable names like in osmo-bts-trx

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32920 ) Change subject: trxcon/l1sched: cosmetic: use variable names like in osmo-bts-trx ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8138a45cca4e9063bf7d36ebc920b20b755138dd Gerrit-Change-Number: 32920 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 May 2023 11:03:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: fix UL FACCH regression in tx_tchh_fn()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33085 ) Change subject: trxcon/l1sched: fix UL FACCH regression in tx_tchh_fn() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4f2bbbd30c7d5dbb979b54455561df3c0cc12aac Gerrit-Change-Number: 33085 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 May 2023 11:03:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: do not align Tx burst transmission

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33006 ) Change subject: trxcon/l1sched: do not align Tx burst transmission ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33006 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia397cbe16f719729a814b7ef0b7035c7fe8ba165 Gerrit-Change-Number: 33006 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 May 2023 11:03:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: HR1 codec: validate ToC header in RFC5993 RTP input

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33081 ) Change subject: HR1 codec: validate ToC header in RFC5993 RTP input ...................................................................... HR1 codec: validate ToC header in RFC5993 RTP input osmo-bts-trx always accepted (and previously required) HR1 codec RTP input in RFC 5993 format; currently we accept this RTP format as input for all BTS models, but no longer require it. However, we have never applied any checks to this format's ToC header, even when we previously required it in osmo-bts-trx. Check this header and reject invalid payloads that just happen to have the same octet length as valid ones. Change-Id: If16d38641913bb46bcd7cc11685407ed17136bfe --- M src/common/rtp_input_preen.c 1 file changed, 31 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/common/rtp_input_preen.c b/src/common/rtp_input_preen.c index e5cef6f..dd526fd 100644 --- a/src/common/rtp_input_preen.c +++ b/src/common/rtp_input_preen.c @@ -89,6 +89,20 @@ /* RTP input matches our internal format - we are good */ return PL_DECISION_ACCEPT; case GSM_HR_BYTES_RTP_RFC5993: + /* Validate ToC octet: for payload of this length to be valid, + * the F bit must be 0 and the FT field must be either 0 (good + * speech) or 2 (good SID). */ + switch (rtp_pl[0] & 0xF0) { + case 0x00: + break; + case 0x20: + /* TODO (next patch): signal this SID to the + * fr_hr_efr_dtxd_input() handler in l1sap. */ + break; + default: + /* invalid payload */ + return PL_DECISION_DROP; + } /* Strip ToC octet, leaving only "pure" TS 101 318 payload. */ return PL_DECISION_STRIP_HDR_OCTET; default: -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If16d38641913bb46bcd7cc11685407ed17136bfe Gerrit-Change-Number: 33081 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-bts[master]: HR1 codec: act on SID indication in RFC5993 RTP input

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33082 ) Change subject: HR1 codec: act on SID indication in RFC5993 RTP input ...................................................................... HR1 codec: act on SID indication in RFC5993 RTP input Suppose we receive RTP from the uplink of another BTS, and the UL-handling BTS has channel-decoded an HR1 frame which it deems (per GSM 06.41 section 6.1.1) to be a valid SID, even though it is not a perfect, error-free SID. How will this SID frame be represented in RFC 5993 transport? My reading of the RFC tells me that the UL-handling BTS will need to apply an operation like our osmo_hr_sid_reset() to the payload before sending it out in RTP - but because the text of the RFC does not explicitly address this scenario, others may have interpreted it differently. If we receive an RFC 5993 RTP payload in which FT is set to 2, indicating good SID, but the actual HR payload is not a perfect SID (the SID field is not all 1s), the only reasonable interpretation of such occurrence is that the sender of this payload was another BTS whose implementors interpreted the RFC as not requiring them to rejuvenate the SID codeword prior to RTP output. Therefore, let's treat such payloads as valid SID for our DTXd logic, and rejuvenate the SID codeword ourselves. Change-Id: Ife00de6220a8ca7cc180a61734497f1acb7f5b83 --- M include/osmo-bts/msg_utils.h M include/osmo-bts/rtp_input_preen.h M src/common/l1sap.c M src/common/rtp_input_preen.c 4 files changed, 52 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmo-bts/msg_utils.h b/include/osmo-bts/msg_utils.h index 7ddbe88..fb8e11a 100644 --- a/include/osmo-bts/msg_utils.h +++ b/include/osmo-bts/msg_utils.h @@ -22,6 +22,9 @@ /* Access 3rd part of msgb control buffer */ #define rtpmsg_ts(x) ((x)->cb[2]) +/* Access 4th part of msgb control buffer */ +#define rtpmsg_is_rfc5993_sid(x) ((x)->cb[3]) + /** * Classification of OML message. ETSI for plain GSM 12.21 * messages and IPA/Osmo for manufacturer messages. diff --git a/include/osmo-bts/rtp_input_preen.h b/include/osmo-bts/rtp_input_preen.h index 822ee4a..744ae2a 100644 --- a/include/osmo-bts/rtp_input_preen.h +++ b/include/osmo-bts/rtp_input_preen.h @@ -17,4 +17,4 @@ enum pl_input_decision rtp_payload_input_preen(struct gsm_lchan *lchan, const uint8_t *rtp_pl, - unsigned rtp_pl_len); + unsigned rtp_pl_len, bool *rfc5993_sid_flag); diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 75177a5..9d824e3 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1314,9 +1314,17 @@ * directly coupled to the GSM 05.03 channel decoder, * and cannot be reconstructed downstream from frame * payload bits. The only kind of SID we can detect - * here is the perfect, error-free kind. */ - is_sid = osmo_hr_check_sid(msgb_l2(resp_msg), - msgb_l2len(resp_msg)); + * here is the perfect, error-free kind. However, + * if we received RFC 5993 payload and the sender + * told us it is valid SID, honor that indication + * and rejuvenate the SID codeword. */ + if (rtpmsg_is_rfc5993_sid(resp_msg)) { + is_sid = true; + osmo_hr_sid_reset(msgb_l2(resp_msg)); + } else { + is_sid = osmo_hr_check_sid(msgb_l2(resp_msg), + msgb_l2len(resp_msg)); + } } break; case GSM48_CMODE_SPEECH_EFR: @@ -2152,6 +2160,7 @@ { struct gsm_lchan *lchan = rs->priv; struct msgb *msg; + bool rfc5993_sid = false; /* if we're in loopback mode, we don't accept frames from the * RTP socket anymore */ @@ -2159,7 +2168,7 @@ return; /* initial preen */ - switch (rtp_payload_input_preen(lchan, rtp_pl, rtp_pl_len)) { + switch (rtp_payload_input_preen(lchan, rtp_pl, rtp_pl_len, &rfc5993_sid)) { case PL_DECISION_DROP: return; case PL_DECISION_ACCEPT: @@ -2184,6 +2193,8 @@ rtpmsg_seq(msg) = seq_number; /* Store RTP header Timestamp in control buffer */ rtpmsg_ts(msg) = timestamp; + /* Store RFC 5993 SID flag likewise */ + rtpmsg_is_rfc5993_sid(msg) = rfc5993_sid; /* make sure the queue doesn't get too long */ lchan_dl_tch_queue_enqueue(lchan, msg, 1); diff --git a/src/common/rtp_input_preen.c b/src/common/rtp_input_preen.c index dd526fd..c418e80 100644 --- a/src/common/rtp_input_preen.c +++ b/src/common/rtp_input_preen.c @@ -82,7 +82,8 @@ } static enum pl_input_decision -input_preen_hr(const uint8_t *rtp_pl, unsigned rtp_pl_len) +input_preen_hr(const uint8_t *rtp_pl, unsigned rtp_pl_len, + bool *rfc5993_sid_flag) { switch (rtp_pl_len) { case GSM_HR_BYTES: @@ -96,8 +97,7 @@ case 0x00: break; case 0x20: - /* TODO (next patch): signal this SID to the - * fr_hr_efr_dtxd_input() handler in l1sap. */ + *rfc5993_sid_flag = true; break; default: /* invalid payload */ @@ -113,7 +113,7 @@ enum pl_input_decision rtp_payload_input_preen(struct gsm_lchan *lchan, const uint8_t *rtp_pl, - unsigned rtp_pl_len) + unsigned rtp_pl_len, bool *rfc5993_sid_flag) { /* If rtp continuous-streaming is enabled, we shall emit RTP packets * with zero-length payloads as BFI markers. In a TrFO scenario such @@ -132,7 +132,7 @@ if (lchan->type == GSM_LCHAN_TCH_F) return input_preen_fr(rtp_pl, rtp_pl_len); else - return input_preen_hr(rtp_pl, rtp_pl_len); + return input_preen_hr(rtp_pl, rtp_pl_len, rfc5993_sid_flag); case GSM48_CMODE_SPEECH_EFR: return input_preen_efr(rtp_pl, rtp_pl_len); case GSM48_CMODE_SPEECH_AMR: -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ife00de6220a8ca7cc180a61734497f1acb7f5b83 Gerrit-Change-Number: 33082 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-bts[master]: HR1 codec: act on SID indication in RFC5993 RTP input

by laforge

Attention is currently required from: falconia. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33082 ) Change subject: HR1 codec: act on SID indication in RFC5993 RTP input ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ife00de6220a8ca7cc180a61734497f1acb7f5b83 Gerrit-Change-Number: 33082 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 30 May 2023 11:00:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: HR1 codec: validate ToC header in RFC5993 RTP input

by laforge

Attention is currently required from: falconia. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33081 ) Change subject: HR1 codec: validate ToC header in RFC5993 RTP input ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If16d38641913bb46bcd7cc11685407ed17136bfe Gerrit-Change-Number: 33081 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 30 May 2023 11:00:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Fix sending msgb structures

by laforge

Attention is currently required from: arehbein, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33084 ) Change subject: osmo_io: Fix sending msgb structures ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie2a9c93f820fa372a1d527c805fd0fe2cff0eb49 Gerrit-Change-Number: 33084 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 May 2023 10:58:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in libosmo-netif[arehbein/osmo_io_ipa]: stream: Add IPA send function/IPA-mode read to srv

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/32907 ) Change subject: stream: Add IPA send function/IPA-mode read to srv ...................................................................... Patch Set 3: (2 comments) File include/osmocom/netif/stream.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7605): https://gerrit.osmocom.org/c/libosmo-netif/+/32907/comment/dabb1e4f_0b198775 PS3, Line 75: enum ipaccess_proto_ext pe, struct msgb *msg); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7605): https://gerrit.osmocom.org/c/libosmo-netif/+/32907/comment/92640130_f8d9df08 PS3, Line 75: enum ipaccess_proto_ext pe, struct msgb *msg); please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/32907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: arehbein/osmo_io_ipa Gerrit-Change-Id: I61e1fe59166c46595efe8c1f32b8f2607cb6c529 Gerrit-Change-Number: 32907 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 May 2023 10:56:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in libosmo-netif[arehbein/osmo_io_ipa]: examples: Add extension header octet to example

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/32908 ) Change subject: examples: Add extension header octet to example ...................................................................... examples: Add extension header octet to example Mainly to make data/packets look (pseudo-)correct in Wireshark Change-Id: I962b9edcba65cdc98da00d2f8753dc5acd481502 --- M examples/ipa-stream-client.c M src/stream.c 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/examples/ipa-stream-client.c b/examples/ipa-stream-client.c index 48421b7..c3bb2a3 100644 --- a/examples/ipa-stream-client.c +++ b/examples/ipa-stream-client.c @@ -74,7 +74,7 @@ char *ptr; int x; - msg = osmo_ipa_msg_alloc(0); + msg = osmo_ipa_msg_alloc(sizeof(struct ipa_head_ext)); if (msg == NULL) { LOGP(DLINP, LOGL_ERROR, "cannot alloc msg\n"); return -1; @@ -93,6 +93,7 @@ msg_sent->num = i; llist_add(&msg_sent->head, &msg_sent_list); + ipa_prepend_header_ext(msg, IPAC_PROTO_EXT_MGCP); osmo_ipa_msg_push_header(msg, IPAC_PROTO_OSMO); osmo_stream_cli_send(conn, msg); @@ -115,7 +116,7 @@ int num; struct msg_sent *cur, *tmp, *found = NULL; - num = ntohl(*((int *)(msg->data + sizeof(struct ipa_head)))); + num = ntohl(*((int *)(msg->data + sizeof(struct ipa_head) + sizeof(struct ipa_head_ext)))); LOGP(DLINP, LOGL_DEBUG, "received msg number %d\n", num); llist_for_each_entry_safe(cur, tmp, &msg_sent_list, head) { diff --git a/src/stream.c b/src/stream.c index 4e57e03..150b85f 100644 --- a/src/stream.c +++ b/src/stream.c @@ -688,8 +688,11 @@ case STREAM_CLI_STATE_CONNECTED: if (res == 0) osmo_stream_cli_reconnect(cli); - else if (cli->iofd_read_cb) + else if (cli->iofd_read_cb) { + // if (cli->stream_proto == OSMO_STREAM_IPAC) + // ipa_check_pull_headers( cli->iofd_read_cb(cli, msg); + } break; default: osmo_panic("osmo_stream_cli_write_cb() called with unexpected state %d\n", cli->state); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/32908 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: arehbein/osmo_io_ipa Gerrit-Change-Id: I962b9edcba65cdc98da00d2f8753dc5acd481502 Gerrit-Change-Number: 32908 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[M] Change in libosmo-netif[arehbein/osmo_io_ipa]: stream: Move helper functions

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/32974 ) Change subject: stream: Move helper functions ...................................................................... stream: Move helper functions Prepare for next commits Change-Id: I318965538e5329c44d0910694621b5e1f1db0626 --- M src/stream.c 1 file changed, 32 insertions(+), 21 deletions(-) diff --git a/src/stream.c b/src/stream.c index 150b85f..d1682c2 100644 --- a/src/stream.c +++ b/src/stream.c @@ -1184,6 +1184,27 @@ osmo_stream_cli_open(cli); } +/* msgb_l1(msg) is expected to be set */ +static inline enum ipaccess_proto msg_get_ipa_proto(struct msgb *msg) +{ + struct ipa_head *ih = msgb_l1(msg); + OSMO_ASSERT(ih); + return ih->proto; +} + +/* msgb->l1h is expected to be set, msgb->l2h is expected to be set if + * we have IPAC_PROTO_OSMO specified in the header. + * Returns the protocol extension (enum ipaccess_proto) or -ENOPROTOOPT if + * we don't have IPAC_PROTO_OSMO specified in the IPA header */ +static inline int msg_get_ipa_proto_ext(struct msgb *msg) +{ + if (msg_get_ipa_proto(msg) != IPAC_PROTO_OSMO) + return -ENOPROTOOPT; + struct ipa_head_ext *ihe = msgb_l2(msg); + OSMO_ASSERT(ihe); + return ihe->proto; +} + /*! \brief Enqueue data to be sent via an Osmocom stream client * \param[in] cli Stream Client through which we want to send * \param[in] msg Message buffer to enqueue in transmit queue */ @@ -1937,27 +1958,6 @@ talloc_free(conn); } -/* msgb_l1(msg) is expected to be set */ -static inline enum ipaccess_proto msg_get_ipa_proto(struct msgb *msg) -{ - struct ipa_head *ih = msgb_l1(msg); - OSMO_ASSERT(ih); - return ih->proto; -} - -/* msgb->l1h is expected to be set, msgb->l2h is expected to be set if - * we have IPAC_PROTO_OSMO specified in the header. - * Returns the protocol extension (enum ipaccess_proto) or -ENOPROTOOPT if - * we don't have IPAC_PROTO_OSMO specified in the IPA header */ -static inline int msg_get_ipa_proto_ext(struct msgb *msg) -{ - if (msg_get_ipa_proto(msg) != IPAC_PROTO_OSMO) - return -ENOPROTOOPT; - struct ipa_head_ext *ihe = msgb_l2(msg); - OSMO_ASSERT(ihe); - return ihe->proto; -} - /*! \brief Enqueue IPA data to be sent via an Osmocom stream server * \param[in] conn Stream Server through which we want to send * \param[in] p Protocol transported by IPA. When set to IPAC_PROTO_UNSPECIFIED, the protocol will be -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/32974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: arehbein/osmo_io_ipa Gerrit-Change-Id: I318965538e5329c44d0910694621b5e1f1db0626 Gerrit-Change-Number: 32974 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[S] Change in libosmo-netif[arehbein/osmo_io_ipa]: stream: Add IPA send function/IPA-mode read to cli

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/32975 ) Change subject: stream: Add IPA send function/IPA-mode read to cli ...................................................................... stream: Add IPA send function/IPA-mode read to cli - Also: Adapt ipa-stream-client example to work alongside new change Related: OS#5753 Change-Id: I042700af6614dd1879514dca0482e05b5ff22cb7 --- M examples/ipa-stream-client.c M include/osmocom/netif/stream.h M src/stream.c 3 files changed, 39 insertions(+), 9 deletions(-) diff --git a/examples/ipa-stream-client.c b/examples/ipa-stream-client.c index c3bb2a3..6aa7d5f 100644 --- a/examples/ipa-stream-client.c +++ b/examples/ipa-stream-client.c @@ -93,10 +93,8 @@ msg_sent->num = i; llist_add(&msg_sent->head, &msg_sent_list); - ipa_prepend_header_ext(msg, IPAC_PROTO_EXT_MGCP); - osmo_ipa_msg_push_header(msg, IPAC_PROTO_OSMO); - - osmo_stream_cli_send(conn, msg); + osmo_stream_cli_send_ipa(conn, IPAC_PROTO_OSMO, + IPAC_PROTO_EXT_MGCP, msg); LOGP(DIPATEST, LOGL_DEBUG, "enqueueing msg %d of " "%d bytes to be sent\n", i, msg->len); @@ -106,7 +104,7 @@ static int read_cb(struct osmo_stream_cli *conn, struct msgb *msg) { - LOGP(DIPATEST, LOGL_DEBUG, "received message from stream (len=%d)\n", msgb_length(msg)); + LOGP(DIPATEST, LOGL_DEBUG, "received message from stream (payload len=%d)\n", msgb_length(msg)); if (osmo_ipa_process_msg(msg) < 0) { LOGP(DIPATEST, LOGL_ERROR, "bad IPA message\n"); @@ -116,7 +114,7 @@ int num; struct msg_sent *cur, *tmp, *found = NULL; - num = ntohl(*((int *)(msg->data + sizeof(struct ipa_head) + sizeof(struct ipa_head_ext)))); + num = ntohl(*((int *)(msg->data))); LOGP(DLINP, LOGL_DEBUG, "received msg number %d\n", num); llist_for_each_entry_safe(cur, tmp, &msg_sent_list, head) { diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h index 16940dc..5c8cea3 100644 --- a/include/osmocom/netif/stream.h +++ b/include/osmocom/netif/stream.h @@ -113,6 +113,8 @@ void osmo_stream_cli_close(struct osmo_stream_cli *cli); void osmo_stream_cli_send(struct osmo_stream_cli *cli, struct msgb *msg); +void osmo_stream_cli_send_ipa(struct osmo_stream_cli *cli, int ipaccess_proto, + enum ipaccess_proto_ext pe, struct msgb *msg); int osmo_stream_cli_recv(struct osmo_stream_cli *cli, struct msgb *msg); void osmo_stream_cli_clear_tx_queue(struct osmo_stream_cli *cli); diff --git a/src/stream.c b/src/stream.c index d1682c2..00ea33d 100644 --- a/src/stream.c +++ b/src/stream.c @@ -689,8 +689,8 @@ if (res == 0) osmo_stream_cli_reconnect(cli); else if (cli->iofd_read_cb) { - // if (cli->stream_proto == OSMO_STREAM_IPAC) - // ipa_check_pull_headers( + if (cli->stream_proto == OSMO_STREAM_IPAC) + ipa_check_pull_headers(msg, cli); cli->iofd_read_cb(cli, msg); } break; @@ -868,7 +868,6 @@ client_ops.segmentation_cb = segmentation_cbs[osp]; osmo_iofd_set_ioops(cli->iofd, &client_ops); cli->flags |= OSMO_STREAM_CLI_F_RECONF; - osmo_iofd_set_ioops(cli->iofd, &osmo_stream_cli_ioops); } /*! \brief Set the socket type for the stream server link @@ -1207,6 +1206,25 @@ /*! \brief Enqueue data to be sent via an Osmocom stream client * \param[in] cli Stream Client through which we want to send + * \param[in] p Protocol transported by IPA. When set to IPAC_PROTO_UNSPECIFIED, the protocol will be + * read from the msgb structure's l1 and possibly l2 headers. + * \param[in] pe Ignored, unless p == IPAC_PROTO_OSMO, in which case this specifies the + * Osmocom protocol extension + * \param[in] msg Message buffer to enqueue in transmit queue */ +void osmo_stream_cli_send_ipa(struct osmo_stream_cli *cli, int ipaccess_proto, + enum ipaccess_proto_ext pe, struct msgb *msg) +{ + OSMO_ASSERT(msg); + if (ipaccess_proto == IPAC_PROTO_UNSPECIFIED) { + ipaccess_proto = msg_get_ipa_proto(msg); + pe = msg_get_ipa_proto_ext(msg); + } + ipa_push_headers(ipaccess_proto, pe, msg); + osmo_stream_cli_send(cli, msg); +} + +/*! \brief Enqueue data to be sent via an Osmocom stream client + * \param[in] cli Stream Client through which we want to send * \param[in] msg Message buffer to enqueue in transmit queue */ void osmo_stream_cli_send(struct osmo_stream_cli *cli, struct msgb *msg) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/32975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: arehbein/osmo_io_ipa Gerrit-Change-Id: I042700af6614dd1879514dca0482e05b5ff22cb7 Gerrit-Change-Number: 32975 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[S] Change in libosmo-netif[arehbein/osmo_io_ipa]: example: Remove call to osmo_ipa_process_msg()

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/32976 ) Change subject: example: Remove call to osmo_ipa_process_msg() ...................................................................... example: Remove call to osmo_ipa_process_msg() That call now happens up the call stack in IPA mode Change-Id: I53283ec7bd7f07dfa612681ae84af93d5cd098b9 --- M examples/ipa-stream-client.c 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/examples/ipa-stream-client.c b/examples/ipa-stream-client.c index 6aa7d5f..61292a3 100644 --- a/examples/ipa-stream-client.c +++ b/examples/ipa-stream-client.c @@ -106,11 +106,6 @@ { LOGP(DIPATEST, LOGL_DEBUG, "received message from stream (payload len=%d)\n", msgb_length(msg)); - if (osmo_ipa_process_msg(msg) < 0) { - LOGP(DIPATEST, LOGL_ERROR, "bad IPA message\n"); - return 0; - } - int num; struct msg_sent *cur, *tmp, *found = NULL; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/32976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: arehbein/osmo_io_ipa Gerrit-Change-Id: I53283ec7bd7f07dfa612681ae84af93d5cd098b9 Gerrit-Change-Number: 32976 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

2024

2023

2022

gerrit-log May 2023