Attention is currently required from: laforge, fixeria, pespin, dexter.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 )
Change subject: RLCMAC_CSN1_Types: Add release 6 additions to PacketCellChangeNotification
......................................................................
Patch Set 2:
(7 comments)
File library/RLCMAC_CSN1_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/ecff3a0c_dffa…
PS1, Line 166: utran_target_cell_presence := omit,
> the PRESENCE is used during decoding, not during encoding afaik. […]
Done
File library/RLCMAC_CSN1_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/4252a098_0aec…
PS1, Line 946: fdd_arfcn_presence
> This definition is not entirely correct. Below is my understanding of TS 44.060: […]
I think you are right, there is no closing curly brace after the FDD-ARFCN field. Then everything looks different.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/2793cb7b_28f8…
PS1, Line 969: utran_cell_list_index
> Actually, this field should also be part of the list. […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/2d721537_ae76…
PS1, Line 972: "LENGTHTO(reporting_quantity)"
> Note that `n_3g := 0` means that `reporting_quantity` contains 1 element. […]
Ack
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/17a48fab_4444…
PS1, Line 1001: utran_ba_used
> missing `optional`
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/797716ca_2855…
PS1, Line 1016: BIT1 ba_psi3_presence,
> Add a /* TODO: Rel-8 addition */ here
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/f942bc69_5bd1…
PS1, Line 1030: variant (utran_target_cell) "PRESENCE(arfcn_bsic_presence = '1'B, utran_target_cell_presence = '0'B)"
> I think it may make sense to have the ARFCN+BSIC CSN. […]
Essentially you mean something like in GSM_Types.ttcn:type union RslChanNrU. We would add a union and in that union we would pack a newly added record for geran_target_cell (arfcn,bsic) and utran_target_cell. Each of those records gets a tag field. geran_target_cell gets has a one bit tag, and utran_target_cell a two bit tag field.
And then in
variant "TAG(geran_target_cell, tag = '0'B; utran_target_cell, tag = '01)
Is this what you have in mind?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4e1c63c06fb89111765df187a93db563e77c3fc4
Gerrit-Change-Number: 32995
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 31 May 2023 18:03:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin, fixeria, dexter.
Hello Jenkins Builder, fixeria, pespin, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/33069
to look at the new patch set (#3).
Change subject: trx TCH DL: transmit invalid speech blocks instead of dummy FACCH
......................................................................
trx TCH DL: transmit invalid speech blocks instead of dummy FACCH
In speech TCH operation, there will always be times when a speech frame
needs to be transmitted on the downlink, but there is no frame available
to transmit (gap in the incoming RTP stream), or the logic of DTXd says
that no frame shall be transmitted at this FN, but we are not doing
physical DTXd. Previous osmo-bts-trx code sent dummy FACCH during such
conditions, but this approach is bad for TCH/HS where we would like to
transmit good speech frames or speech frame gaps one 20 ms frame at a
time, rather than take out pairs of frames for dummy FACCH/H. Other
BTS models (sysmoBTS PHY) send out invalid speech blocks with inverted
CRC3 under the conditions in question - do the same in osmo-bts-trx.
The present change modifies osmo-bts-trx TCH DL frame gap behavior
only for TCH/FS, TCH/HS and TCH/EFS; for all other channel modes,
including AMR speech, the previous behavior of sending dummy FACCH
is left unchanged.
Depends: Iade3310e16b906efb6892d28f474a0d15204e861 (libosmocore)
Change-Id: I78106802a0aa4af39859c75d29fe0e77037899fe
---
M src/osmo-bts-trx/sched_lchan_tchf.c
M src/osmo-bts-trx/sched_lchan_tchh.c
2 files changed, 62 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/69/33069/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33069
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I78106802a0aa4af39859c75d29fe0e77037899fe
Gerrit-Change-Number: 33069
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin, fixeria, dexter.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33069 )
Change subject: trx TCH DL: transmit invalid speech blocks instead of dummy FACCH
......................................................................
Patch Set 2:
(2 comments)
File src/osmo-bts-trx/sched_lchan_tchf.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33069/comment/1c694982_19da4cc7
PS1, Line 500: what is the correct BTS Tx behavior for frame
: * gaps in TCH/AFS
> What we could do though is to add a task in redmine and put the OS#xxxx number next to the fixme.
I just created OS#6049, and will reference it in the next revision of the present patch.
File src/osmo-bts-trx/sched_lchan_tchf.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33069/comment/b4c069c0_fe111d41
PS2, Line 479: * speech frame with inverted CRC3, designed to induce a BFI
> Wouldn't it be more clear to call it "speech block"?
I'll change it in the next revision of this patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33069
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I78106802a0aa4af39859c75d29fe0e77037899fe
Gerrit-Change-Number: 33069
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 31 May 2023 16:56:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33111 )
Change subject: cosmetic: tbf_ul_ack_fsm: Clean up use of ul_tbf and tbf pointers
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33111
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I51ebe8174006380821eb978bbd78f600c10b02e7
Gerrit-Change-Number: 33111
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 31 May 2023 16:29:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33110 )
Change subject: modem: do not send RTS.ind if we got PTCCH/D
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33110
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Idcdf56de7fc6279d8b942f3670ecdc6f88c3dfd1
Gerrit-Change-Number: 33110
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 31 May 2023 16:27:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33111 )
Change subject: cosmetic: tbf_ul_ack_fsm: Clean up use of ul_tbf and tbf pointers
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33111
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I51ebe8174006380821eb978bbd78f600c10b02e7
Gerrit-Change-Number: 33111
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 31 May 2023 16:19:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
