May 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[master]: stream: (typo) Change callback param name of struct osmo_stream_cli f...

by laforge

Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33103 ) Change subject: stream: (typo) Change callback param name of struct osmo_stream_cli from srv to cli ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I742db401165477f85e66bb428f156ecbbd5d6665 Gerrit-Change-Number: 33103 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 16:14:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in libosmo-netif[master]: stream: Introduce and use osmo_stream_cli_fd() to get the fd

by laforge

Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33102 ) Change subject: stream: Introduce and use osmo_stream_cli_fd() to get the fd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7e964dea0adee8edbb9b75d2d17e7d0c5d8917d5 Gerrit-Change-Number: 33102 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 16:14:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: OTA: Fix padding of AES CMAC

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/33116 ) Change subject: OTA: Fix padding of AES CMAC ...................................................................... OTA: Fix padding of AES CMAC When using AES CMAC for authentication of OTA messages, we must not pad the user data before calling the CMAC function. This is unlike the DES MAC, where padding to the DES block size is mandatory. This bug was discovered when trying to talk OTA with AES to a sysmoISIM-SJA5. This patch makes the OTA AES interoperate with the card. Also, with this patch the cryptographic results of pySim/ota.py are identical to those of the java code org.opentelecoms.gsm0348.impl.crypto.CipheringManager Change-Id: I4b40b5857f95ccb21c35795abe7a1995e368bac3 --- M pySim/ota.py 1 file changed, 21 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/16/33116/1 diff --git a/pySim/ota.py b/pySim/ota.py index 80c823e..83303a6 100644 --- a/pySim/ota.py +++ b/pySim/ota.py @@ -1,6 +1,6 @@ """Code related to SIM/UICC OTA according to TS 102 225 + TS 31.115.""" -# (C) 2021-2022 by Harald Welte <laforge(a)osmocom.org> +# (C) 2021-2023 by Harald Welte <laforge(a)osmocom.org> # # This program is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -305,7 +305,7 @@ class OtaAlgoAuthAES(OtaAlgoAuth): name = 'AES' enum_name = 'aes_cmac' - blocksize = 16 # TODO: is this needed? + blocksize = 1 # AES CMAC doesn't need any padding by us def _sign(self, data:bytes) -> bytes: cmac = CMAC.new(self.otak.kid, ciphermod=AES, mac_len=8) cmac.update(data) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4b40b5857f95ccb21c35795abe7a1995e368bac3 Gerrit-Change-Number: 33116 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: cosmetic: fix wrong altstep name in a comment

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33114 ) Change subject: BTS_Tests: cosmetic: fix wrong altstep name in a comment ...................................................................... BTS_Tests: cosmetic: fix wrong altstep name in a comment Change-Id: I4e63f309f2a7d22752f7991ebd7e672939d4e52b --- M bts/BTS_Tests.ttcn 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/33114/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index e715996..d03843d 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -7966,7 +7966,7 @@ } -/* Callback function to be called by as_TC_ms_pwr_ctrl_constant(). +/* Callback function to be called by as_TC_ms_pwr_ctrl(). * Return value: Measurement Report to be sent (encoded octetstring). */ type function f_TC_ms_pwr_ctrl_cb(inout SacchL1Header l1h, integer num_blocks) runs on ConnHdlr return octetstring; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4e63f309f2a7d22752f7991ebd7e672939d4e52b Gerrit-Change-Number: 33114 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: properly release DCCH in f_TC_acch_overpower()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33115 ) Change subject: BTS_Tests: properly release DCCH in f_TC_acch_overpower() ...................................................................... BTS_Tests: properly release DCCH in f_TC_acch_overpower() Currently the TC_acch_overpower_* testcases are all passing without any sporadic failures. However, most of them start failing due to a DTE (some RSLEM related race condition) if I apply a patch [1] to trxcon removing its internal TDMA clock module. I don't know why this happens, but releasing the DCCH after executing all testcase steps in f_TC_acch_overpower() makes that DTE go away. Change-Id: I658e78ad8d4dc86403d22b5380ddd9a140f8c71c Related: [1] osmocom-bb.git Ic8a5b6277c6b16392026e0557376257d71c9d230 Related: OS#5500 --- M bts/BTS_Tests.ttcn 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/15/33115/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index d03843d..8d02c40 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -8656,6 +8656,10 @@ setverdict(pass); } + + f_rsl_chan_deact(); + f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr); + f_rslem_unregister(g_pars.trx_nr, g_chan_nr); } testcase TC_acch_overpower_rxqual_thresh() runs on test_CT { var ConnHdlrPars pars; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I658e78ad8d4dc86403d22b5380ddd9a140f8c71c Gerrit-Change-Number: 33115 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: modem: do not send RTS.ind if we got PTCCH/D

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33110 ) Change subject: modem: do not send RTS.ind if we got PTCCH/D ...................................................................... modem: do not send RTS.ind if we got PTCCH/D Change-Id: Idcdf56de7fc6279d8b942f3670ecdc6f88c3dfd1 Related: OS#5500 --- M src/host/layer23/src/modem/rlcmac.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/10/33110/1 diff --git a/src/host/layer23/src/modem/rlcmac.c b/src/host/layer23/src/modem/rlcmac.c index e030299..a0a22ad 100644 --- a/src/host/layer23/src/modem/rlcmac.c +++ b/src/host/layer23/src/modem/rlcmac.c @@ -183,6 +183,10 @@ }; osmo_gprs_rlcmac_prim_lower_up(prim); + /* Do not send RTS.ind if we got PTCCH/D */ + if (fn % 104 == 12) + return 0; + /* Every fn % 13 == 12 we have either a PTCCH or an IDLE slot, thus * every fn % 13 == 8 we add 5 frames, or 4 frames othrwise. The * resulting value is first fn of the next block. */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idcdf56de7fc6279d8b942f3670ecdc6f88c3dfd1 Gerrit-Change-Number: 33110 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-pcu[master]: cosmetic: tbf_ul_ack_fsm: Clean up use of ul_tbf and tbf pointers

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33111 ) Change subject: cosmetic: tbf_ul_ack_fsm: Clean up use of ul_tbf and tbf pointers ...................................................................... cosmetic: tbf_ul_ack_fsm: Clean up use of ul_tbf and tbf pointers Change-Id: I51ebe8174006380821eb978bbd78f600c10b02e7 --- M src/tbf_ul_ack_fsm.c 1 file changed, 15 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/11/33111/1 diff --git a/src/tbf_ul_ack_fsm.c b/src/tbf_ul_ack_fsm.c index 5e5586b..ad6ad02 100644 --- a/src/tbf_ul_ack_fsm.c +++ b/src/tbf_ul_ack_fsm.c @@ -64,11 +64,11 @@ int rc; unsigned int rrbp = 0; uint32_t new_poll_fn = 0; - struct gprs_rlcmac_ul_tbf *tbf = ctx->tbf; - struct GprsMs *ms = tbf_ms(ul_tbf_as_tbf(tbf)); + struct gprs_rlcmac_tbf *tbf = ul_tbf_as_tbf(ctx->tbf); + struct GprsMs *ms = tbf_ms(tbf); if (final) { - rc = tbf_check_polling(ul_tbf_as_tbf(tbf), d->pdch, d->fn, &new_poll_fn, &rrbp); + rc = tbf_check_polling(tbf, d->pdch, d->fn, &new_poll_fn, &rrbp); if (rc < 0) return NULL; } @@ -99,11 +99,11 @@ * PACKET UPLINK ACK/NACK" */ if (ms_tlli(ms) != GSM_RESERVED_TMSI && !ul_tbf_contention_resolution_done(ctx->tbf)) - osmo_fsm_inst_dispatch(tbf_state_fi(ul_tbf_as_tbf(ctx->tbf)), TBF_EV_CONTENTION_RESOLUTION_MS_SUCCESS, NULL); + osmo_fsm_inst_dispatch(tbf_state_fi(tbf), TBF_EV_CONTENTION_RESOLUTION_MS_SUCCESS, NULL); if (final) { - tbf_set_polling(ul_tbf_as_tbf(tbf), d->pdch, new_poll_fn, PDCH_ULC_POLL_UL_ACK); - LOGPTBFUL(tbf, LOGL_DEBUG, + tbf_set_polling(tbf, d->pdch, new_poll_fn, PDCH_ULC_POLL_UL_ACK); + LOGPTBFUL(ctx->tbf, LOGL_DEBUG, "Scheduled UL Acknowledgement polling on PACCH (FN=%d, TS=%d)\n", new_poll_fn, d->pdch->ts_no); } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I51ebe8174006380821eb978bbd78f600c10b02e7 Gerrit-Change-Number: 33111 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Avoid submitting GMMSM-Release.ind if no session was requested

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33113 ) Change subject: gmm: Avoid submitting GMMSM-Release.ind if no session was requested ...................................................................... gmm: Avoid submitting GMMSM-Release.ind if no session was requested Change-Id: I2fecfd122fc4be863be184f1ff08d9a31e07b956 --- M src/gmm/gmm_ms_fsm.c M tests/gmm/gmm_prim_test.ok 2 files changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/13/33113/1 diff --git a/src/gmm/gmm_ms_fsm.c b/src/gmm/gmm_ms_fsm.c index ff26dfa..770ede7 100644 --- a/src/gmm/gmm_ms_fsm.c +++ b/src/gmm/gmm_ms_fsm.c @@ -97,8 +97,9 @@ gprs_gmm_gmme_t3312_stop(ctx->gmme); gprs_gmm_gmme_t3316_stop(ctx->gmme); - /* TS 24.007 9.5.1.4: informs SM layerthat the MS has been GPRS detached, e.g. by timer expiry */ - if (prev_state != GPRS_GMM_MS_ST_NULL) + /* TS 24.007 9.5.1.4: informs SM layer that the MS has been GPRS detached, e.g. by timer expiry */ + if (prev_state != GPRS_GMM_MS_ST_NULL && + ctx->gmme->sess_id != GPRS_GMM_SESS_ID_UNASSIGNED) gprs_gmm_submit_gmmsm_release_ind(ctx->gmme); } diff --git a/tests/gmm/gmm_prim_test.ok b/tests/gmm/gmm_prim_test.ok index 2ff27f6..6cf672a 100644 --- a/tests/gmm/gmm_prim_test.ok +++ b/tests/gmm/gmm_prim_test.ok @@ -23,7 +23,6 @@ test_gmm_prim_llc_down_cb(): Rx LL-UNITDATA.request TLLI=0xec999002 SAPI=GMM l3=[08 05 20 0a 00 05 f4 ec 99 90 02 ] test_gmm_prim_llc_down_cb(): Rx LLGMM-ASSIGN.request old_TLLI=0xec999002 new_TLLI=0xffffffff test_gmm_prim_up_cb(): Rx GMMREG-DETACH.confirm detach_type='GPRS detach' -test_gmm_prim_up_cb(): Rx GMMSM-RELEASE.indication sess_id=4294967295 ==== test_gmm_prim_ms_gmmreg() [end] ==== ==== test_gmm_prim_ms_gmmsm() [start] ==== sys={0.000000}, mono={0.000000}: clock_override_set -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33113 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2fecfd122fc4be863be184f1ff08d9a31e07b956 Gerrit-Change-Number: 33113 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[M] Change in libosmo-gprs[master]: sm: Handle GMMSM-Release.ind

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33112 ) Change subject: sm: Handle GMMSM-Release.ind ...................................................................... sm: Handle GMMSM-Release.ind Change-Id: Ia2ac9dbffe29c3509f1088ceb327569a331ec598 --- M include/osmocom/gprs/sm/sm_ms_fsm.h M include/osmocom/gprs/sm/sm_prim.h M src/sm/sm_ms_fsm.c M src/sm/sm_prim.c 4 files changed, 54 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/12/33112/1 diff --git a/include/osmocom/gprs/sm/sm_ms_fsm.h b/include/osmocom/gprs/sm/sm_ms_fsm.h index d1d4689..2ea9bd8 100644 --- a/include/osmocom/gprs/sm/sm_ms_fsm.h +++ b/include/osmocom/gprs/sm/sm_ms_fsm.h @@ -29,6 +29,7 @@ GPRS_SM_MS_EV_TX_MOD_PDP_CTX_REQ, GPRS_SM_MS_EV_RX_MOD_PDP_CTX_REJ, GPRS_SM_MS_EV_RX_MOD_PDP_CTX_ACC, + GPRS_SM_MS_EV_GMM_RELEASE_IND, /* TS 24.007 9.5.1.4 GMMSM-RELEASE-IND */ }; struct gprs_sm_ms_fsm_ctx { diff --git a/include/osmocom/gprs/sm/sm_prim.h b/include/osmocom/gprs/sm/sm_prim.h index d4e17a4..127dd35 100644 --- a/include/osmocom/gprs/sm/sm_prim.h +++ b/include/osmocom/gprs/sm/sm_prim.h @@ -128,7 +128,7 @@ uint8_t pco[OSMO_GPRS_SM_PCO_MAXLEN]; uint8_t pco_len; /* TODO: MBMS protocol configuration options*/ - } deact_req; + } pdp_deact_req; /* OSMO_GPRS_SM_SMREG_PDP_DEACTIVATE | Cnf, 6.5.1.6 */ @@ -138,7 +138,7 @@ uint8_t pco[OSMO_GPRS_SM_PCO_MAXLEN]; uint8_t pco_len; /* TODO: MBMS protocol configuration options*/ - } deact_cnf; + } pdp_deact_cnf; /* OSMO_GPRS_SM_SMREG_PDP_DEACTIVATE | Ind, 6.5.1.7 */ struct { @@ -149,7 +149,7 @@ uint8_t pco[OSMO_GPRS_SM_PCO_MAXLEN]; uint8_t pco_len; /* TODO: MBMS protocol configuration options */ - } deact_ind; + } pdp_deact_ind; /* OSMO_GPRS_SM_SMREG_PDP_MODIFY | Ind, 6.5.1.8 */ struct { diff --git a/src/sm/sm_ms_fsm.c b/src/sm/sm_ms_fsm.c index aaaa008..dc063b9 100644 --- a/src/sm/sm_ms_fsm.c +++ b/src/sm/sm_ms_fsm.c @@ -98,6 +98,9 @@ sm_ms_fsm_state_chg(fi, GPRS_SM_MS_ST_PDP_ACTIVE); gprs_sm_submit_smreg_pdp_act_cnf(ctx->sme, (enum gsm48_gsm_cause)0); break; + case GPRS_SM_MS_EV_GMM_RELEASE_IND: + sm_ms_fsm_state_chg(fi, GPRS_SM_MS_ST_PDP_INACTIVE); + break; default: OSMO_ASSERT(0); } @@ -116,6 +119,9 @@ case GPRS_SM_MS_EV_TX_MOD_PDP_CTX_REQ: sm_ms_fsm_state_chg(fi, GPRS_SM_MS_ST_PDP_MODIFY_PENDING); break; + case GPRS_SM_MS_EV_GMM_RELEASE_IND: + sm_ms_fsm_state_chg(fi, GPRS_SM_MS_ST_PDP_INACTIVE); + break; default: OSMO_ASSERT(0); } @@ -134,6 +140,9 @@ case GPRS_SM_MS_EV_RX_MOD_PDP_CTX_ACC: sm_ms_fsm_state_chg(fi, GPRS_SM_MS_ST_PDP_ACTIVE); break; + case GPRS_SM_MS_EV_GMM_RELEASE_IND: + sm_ms_fsm_state_chg(fi, GPRS_SM_MS_ST_PDP_INACTIVE); + break; default: OSMO_ASSERT(0); } @@ -145,6 +154,9 @@ case GPRS_SM_MS_EV_RX_DEACT_PDP_CTX_ACC: sm_ms_fsm_state_chg(fi, GPRS_SM_MS_ST_PDP_INACTIVE); break; + case GPRS_SM_MS_EV_GMM_RELEASE_IND: + sm_ms_fsm_state_chg(fi, GPRS_SM_MS_ST_PDP_INACTIVE); + break; default: OSMO_ASSERT(0); } @@ -201,7 +213,8 @@ X(GPRS_SM_MS_EV_RX_GMM_ESTABLISH_REJ) | X(GPRS_SM_MS_EV_RX_ACT_PDP_CTX_REJ) | X(GPRS_SM_MS_EV_RX_ACT_PDP_CTX_ACC) | - X(GPRS_SM_MS_EV_NSAPI_ACTIVATED), + X(GPRS_SM_MS_EV_NSAPI_ACTIVATED) | + X(GPRS_SM_MS_EV_GMM_RELEASE_IND), .out_state_mask = X(GPRS_SM_MS_ST_PDP_INACTIVE) | X(GPRS_SM_MS_ST_PDP_ACTIVE_PENDING) | @@ -214,7 +227,8 @@ .in_event_mask = X(GPRS_SM_MS_EV_RX_DEACT_PDP_CTX_REQ) | X(GPRS_SM_MS_EV_TX_DEACT_PDP_CTX_REQ)| - X(GPRS_SM_MS_EV_TX_MOD_PDP_CTX_REQ), + X(GPRS_SM_MS_EV_TX_MOD_PDP_CTX_REQ) | + X(GPRS_SM_MS_EV_GMM_RELEASE_IND), .out_state_mask = X(GPRS_SM_MS_ST_PDP_INACTIVE) | X(GPRS_SM_MS_ST_PDP_INACTIVE_PENDING) | @@ -226,7 +240,8 @@ .in_event_mask = X(GPRS_SM_MS_EV_RX_DEACT_PDP_CTX_REQ) | X(GPRS_SM_MS_EV_RX_MOD_PDP_CTX_REJ) | - X(GPRS_SM_MS_EV_RX_MOD_PDP_CTX_ACC), + X(GPRS_SM_MS_EV_RX_MOD_PDP_CTX_ACC) | + X(GPRS_SM_MS_EV_GMM_RELEASE_IND), .out_state_mask = X(GPRS_SM_MS_ST_PDP_INACTIVE) | X(GPRS_SM_MS_ST_PDP_ACTIVE) | @@ -236,7 +251,8 @@ }, [GPRS_SM_MS_ST_PDP_INACTIVE_PENDING] = { .in_event_mask = - X(GPRS_SM_MS_EV_RX_DEACT_PDP_CTX_ACC), + X(GPRS_SM_MS_EV_RX_DEACT_PDP_CTX_ACC) | + X(GPRS_SM_MS_EV_GMM_RELEASE_IND), .out_state_mask = X(GPRS_SM_MS_ST_PDP_INACTIVE), .name = "PDP_INACTIVE_PENDING", @@ -257,6 +273,7 @@ { GPRS_SM_MS_EV_TX_MOD_PDP_CTX_REQ, "TX_MOD_PDP_CTX_REQ" }, { GPRS_SM_MS_EV_RX_MOD_PDP_CTX_REJ, "RX_MOD_PDP_CTX_REJ" }, { GPRS_SM_MS_EV_RX_MOD_PDP_CTX_ACC, "RX_MOD_PDP_CTX_ACC" }, + { GPRS_SM_MS_EV_GMM_RELEASE_IND, "GMM_RELEASE_IND"}, { 0, NULL } }; diff --git a/src/sm/sm_prim.c b/src/sm/sm_prim.c index 158959e..b513aa7 100644 --- a/src/sm/sm_prim.c +++ b/src/sm/sm_prim.c @@ -493,6 +493,23 @@ return rc; } +/* TS 24.007 9.5.1.2 GMMSM-RELEASE-IND */ +static int gprs_sm_prim_handle_gmmsm_release_ind(struct osmo_gprs_gmm_prim *gmm_prim) +{ + struct osmo_gprs_gmm_gmmsm_prim *gmmsm = &gmm_prim->gmmsm; + struct gprs_sm_entity *sme; + int rc; + + sme = gprs_sm_find_sme_by_sess_id(gmmsm->sess_id); + if (!sme) { + LOGSM(LOGL_ERROR, "Rx GMMSM-RELEASE.ind for non existing SM Entity sess_id=%u\n", gmmsm->sess_id); + return -EINVAL; + } + rc = osmo_fsm_inst_dispatch(sme->ms_fsm.fi, GPRS_SM_MS_EV_GMM_RELEASE_IND, NULL); + + return rc; +} + /* TS 24.007 9.5.1.6 GMMSM-UNITDATA-IND */ static int gprs_sm_prim_handle_gmmsm_unitdata_ind(struct osmo_gprs_gmm_prim *gmm_prim) { @@ -520,6 +537,9 @@ case OSMO_PRIM(OSMO_GPRS_GMM_GMMSM_ESTABLISH, PRIM_OP_CONFIRM): rc = gprs_sm_prim_handle_gmmsm_establish_cnf(gmm_prim); break; + case OSMO_PRIM(OSMO_GPRS_GMM_GMMSM_RELEASE, PRIM_OP_INDICATION): + rc = gprs_sm_prim_handle_gmmsm_release_ind(gmm_prim); + break; case OSMO_PRIM(OSMO_GPRS_GMM_GMMSM_UNITDATA, PRIM_OP_INDICATION): rc = gprs_sm_prim_handle_gmmsm_unitdata_ind(gmm_prim); break; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ia2ac9dbffe29c3509f1088ceb327569a331ec598 Gerrit-Change-Number: 33112 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[XL] Change in osmo-pcu[master]: tbf: Improve TBF name description in logs

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33105 ) Change subject: tbf: Improve TBF name description in logs ...................................................................... tbf: Improve TBF name description in logs Change format to print the state at the end, to resemble more the same format used by FSMs. Furthermore, by moving it at the end, print it only when "enclousure" is requested, aka when not requested by FSM to update its internal name. The consequence of this logc is that log lines printed from FSM don't end up with the same state string printed twice in different places. While at it, shorten the EGPRS/GPRS indicator to one character, which should be understandable enough since it matches what's usually seen in mobile phones to signal one or another. Change-Id: I86b5f042fae77721b22fc026228677bd56768ba9 --- M src/tbf.cpp M tests/alloc/AllocTest.err M tests/app_info/AppInfoTest.err M tests/ms/MsTest.err M tests/tbf/TbfTest.err M tests/types/TypesTest.err M tests/ulc/PdchUlcTest.err 7 files changed, 446,018 insertions(+), 445,999 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/05/33105/1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I86b5f042fae77721b22fc026228677bd56768ba9 Gerrit-Change-Number: 33105 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in libosmo-netif[master]: ipa-stream-server: Return -EBADF in read_cb after osmo_stream_srv_des...

by daniel

Attention is currently required from: daniel. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/33104 to look at the new patch set (#2). Change subject: ipa-stream-server: Return -EBADF in read_cb after osmo_stream_srv_destroy() ...................................................................... ipa-stream-server: Return -EBADF in read_cb after osmo_stream_srv_destroy() This fixes a potential heap-use-after-free error. When there is still data to be written the osmo_stream_srv_cb() will call osmo_stream_srv_write() which will try to dereference conn even though it has already been freed. Change-Id: I5ac1920b8d4ce3b0205f00d253e7ed878fb745e3 --- M examples/ipa-stream-server.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/04/33104/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5ac1920b8d4ce3b0205f00d253e7ed878fb745e3 Gerrit-Change-Number: 33104 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests.TC_pcu_data_ind_lqual_cb: properly send UL BLOCK.req

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33108 ) Change subject: BTS_Tests.TC_pcu_data_ind_lqual_cb: properly send UL BLOCK.req ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33108/comment/70042e6a_5a47… PS1, Line 10: so wait for a DL BLOCK.ind, take the current Fn from there and > so so Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0fb615a4136a76a939588af0131ddcfb7acd877 Gerrit-Change-Number: 33108 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 11:12:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests.TC_pcu_data_ind_lqual_cb: remove lqual threshold

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33109 to look at the new patch set (#2). Change subject: BTS_Tests.TC_pcu_data_ind_lqual_cb: remove lqual threshold ...................................................................... BTS_Tests.TC_pcu_data_ind_lqual_cb: remove lqual threshold Since recently [1], osmo-bts does submit all PCUIF DATA.ind regardless of the Uplink link quality (C/I ratio in case of osmo-bts-trx). Change-Id: If801e9112c1207ccdc40f9e675c52fadccdd1411 Related: [1] osmo-bts.git I8f1856dd9061c1bfca8b15be30df7a51760231b0 --- M bts/BTS_Tests.ttcn 1 file changed, 20 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/09/33109/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33109 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If801e9112c1207ccdc40f9e675c52fadccdd1411 Gerrit-Change-Number: 33109 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests.TC_pcu_data_ind_lqual_cb: properly send UL BLOCK.req

by fixeria

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33108 to look at the new patch set (#2). Change subject: BTS_Tests.TC_pcu_data_ind_lqual_cb: properly send UL BLOCK.req ...................................................................... BTS_Tests.TC_pcu_data_ind_lqual_cb: properly send UL BLOCK.req We must be using a valid TDMA Fn when scheduling UL BLOCK.req, so wait for a DL BLOCK.ind, take the current Fn from there and calculate a proper TDMA Fn for the next UL block. Change-Id: If0fb615a4136a76a939588af0131ddcfb7acd877 Related: OS#5954 --- M bts/BTS_Tests.ttcn 1 file changed, 79 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/08/33108/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0fb615a4136a76a939588af0131ddcfb7acd877 Gerrit-Change-Number: 33108 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests.TC_pcu_data_ind_lqual_cb: remove lqual threshold

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33109 ) Change subject: BTS_Tests.TC_pcu_data_ind_lqual_cb: remove lqual threshold ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33109 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If801e9112c1207ccdc40f9e675c52fadccdd1411 Gerrit-Change-Number: 33109 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 11:09:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests.TC_pcu_data_ind_lqual_cb: properly send UL BLOCK.req

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33108 ) Change subject: BTS_Tests.TC_pcu_data_ind_lqual_cb: properly send UL BLOCK.req ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33108/comment/77ede2a3_f34e… PS1, Line 10: so wait for a DL BLOCK.ind, take the current Fn from there and so so -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0fb615a4136a76a939588af0131ddcfb7acd877 Gerrit-Change-Number: 33108 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 11:09:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests.TC_pcu_data_ind_lqual_cb: log lqual values

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33107 ) Change subject: BTS_Tests.TC_pcu_data_ind_lqual_cb: log lqual values ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33107 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia8cb340005b58331e1e032a53c0a93163a517fb0 Gerrit-Change-Number: 33107 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 11:08:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: cosmetic: add as_pcuif_msg() for convenience

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33106 ) Change subject: BTS_Tests: cosmetic: add as_pcuif_msg() for convenience ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iabefddd54a4a2e2183feea04fdb8526e74efc7ac Gerrit-Change-Number: 33106 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 11:06:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in libosmo-netif[master]: ipa-stream-server: Return -EBADF in read_cb after osmo_stream_srv_des...

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33104 ) Change subject: ipa-stream-server: Return -EBADF in read_cb after osmo_stream_srv_destroy() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5ac1920b8d4ce3b0205f00d253e7ed878fb745e3 Gerrit-Change-Number: 33104 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 11:05:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in libosmo-netif[master]: stream: (typo) Change callback param name of struct osmo_stream_cli f...

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33103 ) Change subject: stream: (typo) Change callback param name of struct osmo_stream_cli from srv to cli ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I742db401165477f85e66bb428f156ecbbd5d6665 Gerrit-Change-Number: 33103 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 11:04:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[XL] Change in osmo-pcu[master]: tbf: Improve TBF name description in logs

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33105 ) Change subject: tbf: Improve TBF name description in logs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I86b5f042fae77721b22fc026228677bd56768ba9 Gerrit-Change-Number: 33105 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 11:04:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in libosmo-netif[master]: stream: Introduce and use osmo_stream_cli_fd() to get the fd

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33102 ) Change subject: stream: Introduce and use osmo_stream_cli_fd() to get the fd ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7e964dea0adee8edbb9b75d2d17e7d0c5d8917d5 Gerrit-Change-Number: 33102 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 11:04:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests.TC_pcu_data_ind_lqual_cb: properly send UL BLOCK.req

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33108 ) Change subject: BTS_Tests.TC_pcu_data_ind_lqual_cb: properly send UL BLOCK.req ...................................................................... BTS_Tests.TC_pcu_data_ind_lqual_cb: properly send UL BLOCK.req We must be using a valid TDMA Fn when scheduling UL BLOCK.req, so so wait for a DL BLOCK.ind, take the current Fn from there and calculate a proper TDMA Fn for the next UL block. Change-Id: If0fb615a4136a76a939588af0131ddcfb7acd877 Related: OS#5954 --- M bts/BTS_Tests.ttcn 1 file changed, 79 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/08/33108/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 0a044e7..192338b 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -5326,6 +5326,66 @@ } } +/* Catch a L1CTL DL BLOCK.ind with the given parameters */ +private altstep as_l1ctl_dl_block_ind(out L1ctlGprsDlBlockInd block_ind, + template (present) GsmFrameNumber fn := ?, + template (present) uint3_t tn := ?, + template (present) uint3_t usf := ?, + template (present) octetstring data := ?) +runs on test_CT { + var L1ctlMessage l1_dl; + + [] L1CTL.receive(tr_L1CTL_GPRS_DL_BLOCK_IND(fn, tn, usf, data)) -> value l1_dl { + block_ind := l1_dl.payload.dl_block_ind; + } +} + +/* tuple of TDMA frame number and timeslot number */ +private type record TdmaFnTn { + GsmFrameNumber fn, + uint3_t tn +} + +/* Wait for a L1CTL DL BLOCK.ind and send an UL BLOCK.req */ +private function f_TC_pcu_tx_ul_block_req(octetstring data, + template (present) uint3_t tn := ?, + template (present) uint3_t usf := ?) +runs on test_CT return TdmaFnTn { + var L1ctlGprsDlBlockInd block_ind; + timer T; + + T.start(1.0); + alt { + [] as_l1ctl_dl_block_ind(block_ind, tn := tn, usf := usf) { + var integer fn := block_ind.hdr.fn; + + /* Ignore PTCCH/D blocks, their Fn is too far away */ + if (fn mod 104 == 12) { + repeat; + } + + /* Every fn % 13 == 12 we have either a PTCCH or an IDLE slot, thus + * every fn % 13 == 8 we add 5 frames, or 4 frames othrwise. The + * resulting value is first fn of the next block. */ + if (fn mod 13 == 8) { + fn := (fn + 5) mod (2048 * 51 * 26); + } else { + fn := (fn + 4) mod (2048 * 51 * 26); + } + + L1CTL.send(ts_L1CTL_GPRS_UL_BLOCK_REQ(fn, block_ind.hdr.tn, data)); + return {fn, block_ind.hdr.tn}; + } + [] L1CTL.receive { repeat; } + [] T.timeout { + setverdict(fail, "Timeout waiting for DL BLOCK.ind (RTS)"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + } + + return {0, 0}; /* make TITAN happy */ +} + /* Tune the L1 to PDCH on the given timeslot number */ private function f_TC_pcu_l1ctl_est_pdch(uint3_t tn) runs on test_CT { var ConnHdlrPars pars := valueof(t_Pars(ts_RslChanNr_PDCH(tn), ts_RSL_ChanMode_SIGN)); @@ -5890,9 +5950,11 @@ var int16_t lqual_cb; timer T := 1.0; - /* Send a random PDTCH frame over Um - * FIXME: we need to wait for a DL block and user Fn from there. */ - L1CTL.send(ts_L1CTL_GPRS_UL_BLOCK_REQ(0, 7, '0000'O & f_rnd_octstring(21))); + L1CTL.clear; + PCU.clear; + + /* Send a random Uplink block over the Um */ + f_TC_pcu_tx_ul_block_req('0000'O & f_rnd_octstring(21), tn := 7); T.start; alt { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0fb615a4136a76a939588af0131ddcfb7acd877 Gerrit-Change-Number: 33108 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests.TC_pcu_data_ind_lqual_cb: remove lqual threshold

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33109 ) Change subject: BTS_Tests.TC_pcu_data_ind_lqual_cb: remove lqual threshold ...................................................................... BTS_Tests.TC_pcu_data_ind_lqual_cb: remove lqual threshold Since recently [1], osmo-bts does submit all PCUIF DATA.ind regardless of the Uplink link quality (C/I ratio in case of osmo-bts-trx). Change-Id: If801e9112c1207ccdc40f9e675c52fadccdd1411 Related: [1] osmo-bts.git I8f1856dd9061c1bfca8b15be30df7a51760231b0 --- M bts/BTS_Tests.ttcn 1 file changed, 20 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/09/33109/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 192338b..7a24889 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -5944,23 +5944,22 @@ setverdict(pass); } -private function f_TC_pcu_data_ind_lqual_cb(int16_t lqual_cb_exp, int16_t thresh) +private function f_TC_pcu_data_ind_lqual_cb(int16_t lqual_cb_exp) runs on test_CT { var PCUIF_Message msg; - var int16_t lqual_cb; timer T := 1.0; L1CTL.clear; PCU.clear; /* Send a random Uplink block over the Um */ - f_TC_pcu_tx_ul_block_req('0000'O & f_rnd_octstring(21), tn := 7); + var octetstring data := '0000'O & f_rnd_octstring(21); + f_TC_pcu_tx_ul_block_req(data, tn := 7); T.start; alt { - /* If expected link quality is above the threshold */ - [lqual_cb_exp >= thresh] as_pcuif_msg(msg, tr_PCUIF_DATA_IND) { - lqual_cb := msg.u.data_ind.lqual_cb; + [] as_pcuif_msg(msg, tr_PCUIF_DATA_IND(data := data)) { + var integer lqual_cb := msg.u.data_ind.lqual_cb; log("Rx PCUIF_DATA.ind (lqual_cb=", lqual_cb, ")"); /* Make sure the actual link quality matches the expected value */ @@ -5971,18 +5970,9 @@ setverdict(pass); } } - /* If expected link quality is below the threshold */ - [lqual_cb_exp < thresh] as_pcuif_msg(msg, tr_PCUIF_DATA_IND) { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, - log2str("Rx unexpected PCUIF_DATA.ind: ", msg)); - } /* Ignore PCUIF_RTS.req and PCUIF_TIME.ind */ [] PCU.receive { repeat; } - [lqual_cb_exp < thresh] T.timeout { - log("Rx nothing, as expected"); - setverdict(pass); - } - [lqual_cb_exp >= thresh] T.timeout { + [] T.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for PCUIF_DATA.ind"); } @@ -6010,9 +6000,8 @@ ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, ts_TRXC_FAKE_CI(i)); - /* FIXME: OsmoBTS may have different threshold (see MIN_QUAL_NORM) */ log("Testing C/I=", i, " cB"); - f_TC_pcu_data_ind_lqual_cb(i, thresh := 0); + f_TC_pcu_data_ind_lqual_cb(i); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33109 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If801e9112c1207ccdc40f9e675c52fadccdd1411 Gerrit-Change-Number: 33109 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests.TC_pcu_data_ind_lqual_cb: log lqual values

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33107 ) Change subject: BTS_Tests.TC_pcu_data_ind_lqual_cb: log lqual values ...................................................................... BTS_Tests.TC_pcu_data_ind_lqual_cb: log lqual values Change-Id: Ia8cb340005b58331e1e032a53c0a93163a517fb0 Related: OS#5954 --- M bts/BTS_Tests.ttcn 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/07/33107/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 4d52e49..0a044e7 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -5949,6 +5949,7 @@ ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, ts_TRXC_FAKE_CI(i)); /* FIXME: OsmoBTS may have different threshold (see MIN_QUAL_NORM) */ + log("Testing C/I=", i, " cB"); f_TC_pcu_data_ind_lqual_cb(i, thresh := 0); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33107 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia8cb340005b58331e1e032a53c0a93163a517fb0 Gerrit-Change-Number: 33107 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: cosmetic: add as_pcuif_msg() for convenience

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33106 ) Change subject: BTS_Tests: cosmetic: add as_pcuif_msg() for convenience ...................................................................... BTS_Tests: cosmetic: add as_pcuif_msg() for convenience This altstep eliminates the need to wrap the actual PCUIF message template into another (port specific) template t_SD_PCUIF. Change-Id: Iabefddd54a4a2e2183feea04fdb8526e74efc7ac --- M bts/BTS_Tests.ttcn 1 file changed, 80 insertions(+), 59 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/33106/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index e715996..4d52e49 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -5315,6 +5315,17 @@ * PCU Socket related tests ***********************************************************************/ +/* Catch a PCUIF message (without having to use t_SD_PCUIF) */ +private altstep as_pcuif_msg(out PCUIF_Message msg, + template (present) PCUIF_Message tr_msg := ?) +runs on test_CT { + var PCUIF_send_data sd; + + [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_msg)) -> value sd { + msg := sd.data; + } +} + /* Tune the L1 to PDCH on the given timeslot number */ private function f_TC_pcu_l1ctl_est_pdch(uint3_t tn) runs on test_CT { var ConnHdlrPars pars := valueof(t_Pars(ts_RslChanNr_PDCH(tn), ts_RSL_ChanMode_SIGN)); @@ -5326,12 +5337,13 @@ /* Verify no RTS before ACT_REQ; verify RTS after ACT_REQ */ friend function f_TC_pcu_act_req(uint8_t bts_nr, uint8_t trx_nr, uint8_t ts_nr, boolean exp_success) runs on test_CT { + var PCUIF_Message msg; timer T := 3.0; /* we don't expect any RTS.req before PDCH are active */ T.start; alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RTS_REQ(bts_nr))) { + [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(bts_nr)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "PCU RTS.req before PDCH active?"); } [] PCU.receive { repeat; } @@ -5344,14 +5356,13 @@ /* we now expect RTS.req for this timeslot (only) */ T.start; alt { - [exp_success] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RTS_REQ(bts_nr, trx_nr, ts_nr))) { + [exp_success] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(bts_nr, trx_nr, ts_nr)) { setverdict(pass); } - [not exp_success] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, - tr_PCUIF_RTS_REQ(bts_nr, trx_nr, ts_nr))) { + [not exp_success] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(bts_nr, trx_nr, ts_nr)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected RTS.req for supposedly failing activation"); } - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RTS_REQ)) { + [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "RTS.req for wrong TRX/TS"); } [] PCU.receive { repeat; } @@ -5367,6 +5378,7 @@ /* verify no more RTS after DEACT_REQ */ friend function f_TC_pcu_deact_req(uint8_t bts_nr, uint8_t trx_nr, uint8_t ts_nr) runs on test_CT { + var PCUIF_Message msg; timer T := 3.0; /* Send PDCH activate request for known PDCH timeslot */ @@ -5378,7 +5390,7 @@ /* we now expect no RTS.req for this timeslot */ T.start; alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RTS_REQ(bts_nr, trx_nr, ts_nr))) { + [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(bts_nr, trx_nr, ts_nr)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Received unexpected PCU RTS.req"); } [] PCU.receive { repeat; } @@ -5443,8 +5455,9 @@ /* Test the PCU->BTS Version and BTS->PCU SI13 handshake */ function f_TC_pcu_ver_siXX(octetstring si, RSL_IE_SysinfoType rsl_si_type) runs on test_CT { - var PCUIF_send_data sd; - timer T:= 3.0; + var PCUIF_Message msg; + timer T := 3.0; + f_init_with_pcuif(); /* Set SI13 via RSL */ @@ -5452,8 +5465,8 @@ T.start; alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_DATA_IND(0, 0, 0, ?, PCU_IF_SAPI_BCCH))) -> value sd { - if (substr(sd.data.u.data_ind.data, 0, lengthof(si)) == si) { + [] as_pcuif_msg(msg, tr_PCUIF_DATA_IND(0, 0, 0, sapi := PCU_IF_SAPI_BCCH)) { + if (substr(msg.u.data_ind.data, 0, lengthof(si)) == si) { setverdict(pass); } else { repeat; @@ -5500,15 +5513,14 @@ PCUIF_Sapi sapi, octetstring data) runs on test_CT { - var PCUIF_send_data sd; - + var PCUIF_Message msg; timer T := 3.0; + T.start; alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, - tr_PCUIF_RTS_REQ(bts_nr, trx_nr, ts_nr, sapi))) -> value sd { - f_pcu_data_req(bts_nr, trx_nr, ts_nr, sd.data.u.rts_req.block_nr, - sd.data.u.rts_req.fn, sapi, data); + [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(bts_nr, trx_nr, ts_nr, sapi)) { + f_pcu_data_req(bts_nr, trx_nr, ts_nr, msg.u.rts_req.block_nr, + msg.u.rts_req.fn, sapi, data); } [] PCU.receive { repeat; } [] T.timeout { @@ -5638,7 +5650,7 @@ private function f_TC_pcu_ptcch_ul(uint16_t ra) runs on test_CT { var template PCUIF_Message pcu_rach_ind; - var PCUIF_send_data sd; + var PCUIF_Message msg; var GsmFrameNumber fn; timer T; @@ -5653,8 +5665,8 @@ /* Expect a RACH.ind on the PCU interface (timeout is one multi-frame) */ T.start(52.0 * 4.615 / 1000.0); alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, pcu_rach_ind)) -> value sd { - log("Rx an Access Burst on the PCU interface: ", sd.data); + [] as_pcuif_msg(msg, pcu_rach_ind) { + log("Rx an Access Burst on the PCU interface: ", msg); setverdict(pass); T.stop; } @@ -5787,6 +5799,7 @@ var GsmFrameNumber fn_last := 0; for (var integer i := 0; i < 1000; i := i+1) { + var PCUIF_Message msg; var OCT1 ra := f_rnd_ra_ps(); var GsmFrameNumber fn := f_L1CTL_RACH(L1CTL, oct2int(ra)); if (fn == fn_last) { @@ -5797,10 +5810,10 @@ timer T := 2.0; T.start; alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RACH_IND(0, 0, 0, oct2int(ra), 0, ?, fn))) { + [] as_pcuif_msg(msg, tr_PCUIF_RACH_IND(0, 0, 0, oct2int(ra), 0, ?, fn)) { T.stop; } - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RACH_IND)) { + [] as_pcuif_msg(msg, tr_PCUIF_RACH_IND) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected RACH IND"); } [] PCU.receive { repeat; } @@ -5819,7 +5832,7 @@ var GsmFrameNumber fn_last := 0; var L1ctlRachSynchSeq synch_seq; var PCUIF_BurstType pcu_bt; - var GsmFrameNumber fn; + var GsmFrameNumber fn var BIT11 ra11; f_init_with_pcuif(); @@ -5852,13 +5865,14 @@ burst_type := pcu_bt, fn := fn); + var PCUIF_Message msg; timer T := 2.0; T.start; alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, pcu_rach_ind)) { + [] as_pcuif_msg(msg, pcu_rach_ind) { T.stop; } - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RACH_IND)) { + [] as_pcuif_msg(msg, tr_PCUIF_RACH_IND) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected RACH IND"); } [] PCU.receive { repeat; } @@ -5872,14 +5886,10 @@ private function f_TC_pcu_data_ind_lqual_cb(int16_t lqual_cb_exp, int16_t thresh) runs on test_CT { - var template PCUIF_send_data sdt; - var PCUIF_send_data sd; + var PCUIF_Message msg; var int16_t lqual_cb; timer T := 1.0; - /* PCUIF_DATA.ind is encapsulated into a supplementary record */ - sdt := t_SD_PCUIF_MSGT(g_pcu_conn_id, PCU_IF_MSG_DATA_IND); - /* Send a random PDTCH frame over Um * FIXME: we need to wait for a DL block and user Fn from there. */ L1CTL.send(ts_L1CTL_GPRS_UL_BLOCK_REQ(0, 7, '0000'O & f_rnd_octstring(21))); @@ -5887,8 +5897,8 @@ T.start; alt { /* If expected link quality is above the threshold */ - [lqual_cb_exp >= thresh] PCU.receive(sdt) -> value sd { - lqual_cb := sd.data.u.data_ind.lqual_cb; + [lqual_cb_exp >= thresh] as_pcuif_msg(msg, tr_PCUIF_DATA_IND) { + lqual_cb := msg.u.data_ind.lqual_cb; log("Rx PCUIF_DATA.ind (lqual_cb=", lqual_cb, ")"); /* Make sure the actual link quality matches the expected value */ @@ -5900,9 +5910,9 @@ } } /* If expected link quality is below the threshold */ - [lqual_cb_exp < thresh] PCU.receive(sdt) -> value sd { + [lqual_cb_exp < thresh] as_pcuif_msg(msg, tr_PCUIF_DATA_IND) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, - log2str("Rx unexpected PCUIF_DATA.ind: ", sd.data)); + log2str("Rx unexpected PCUIF_DATA.ind: ", msg)); } /* Ignore PCUIF_RTS.req and PCUIF_TIME.ind */ [] PCU.receive { repeat; } @@ -5951,6 +5961,7 @@ var MobileIdentityLV mi_lv; var octetstring mi_lv_enc; var MobileIdentityV mi; + var PCUIF_Message msg; timer T := 3.0; if (i < 50) { @@ -5968,9 +5979,9 @@ RSL_CCHAN.send(ts_ASP_RSL_UD(ts_RSL_PAGING_CMD(mi, i mod 4))); T.start; alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_PAG_REQ(0, mi_lv_enc))) { + [] as_pcuif_msg(msg, tr_PCUIF_PAG_REQ(0, mi_lv_enc)) { } - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_PAG_REQ)) { + [] as_pcuif_msg(msg, tr_PCUIF_PAG_REQ) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected PAGING REQ"); } [] PCU.receive { repeat; } @@ -5984,10 +5995,10 @@ /* test for periodic TIME_IND; check number of FN expired and number of TIME_IND within frames */ testcase TC_pcu_time_ind() runs on test_CT { - var PCUIF_send_data pcu_sd; var integer num_time_ind := 0; var integer first_fn, last_fn; var float test_duration := 5.0; + var PCUIF_Message msg; timer T; f_init_with_pcuif(); @@ -5996,16 +6007,16 @@ PCU.clear; T.start(test_duration); alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_TIME_IND(0, ?))) -> value pcu_sd { + [] as_pcuif_msg(msg, tr_PCUIF_TIME_IND(0, ?)) { num_time_ind := num_time_ind + 1; if (not isbound(first_fn)) { - first_fn := pcu_sd.data.u.time_ind.fn; + first_fn := msg.u.time_ind.fn; } - last_fn := pcu_sd.data.u.time_ind.fn; + last_fn := msg.u.time_ind.fn; repeat; } - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_TIME_IND(?, ?))) -> value pcu_sd { - setverdict(fail, "Received unexpected PCUIF_TIME_IND: ", pcu_sd.data); + [] as_pcuif_msg(msg, tr_PCUIF_TIME_IND(?, ?)) { + setverdict(fail, "Received unexpected PCUIF_TIME_IND: ", msg); repeat; } [] PCU.receive { @@ -6037,11 +6048,11 @@ /* test for periodic RTS_REQ; check number of FN expired and number of RTS_IND per SAPI */ testcase TC_pcu_rts_req() runs on test_CT { - var PCUIF_send_data pcu_sd; var integer first_fn, last_fn; var integer num_rts_pdtch := 0; var integer num_rts_ptcch := 0; var float test_duration := 5.0; + var PCUIF_Message msg; timer T; f_init_with_pcuif(); @@ -6050,26 +6061,24 @@ PCU.clear; T.start(test_duration); alt { - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RTS_REQ(0, 0, 7, PCU_IF_SAPI_PDTCH, ?, ?))) - -> value pcu_sd { + [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(0, 0, 7, PCU_IF_SAPI_PDTCH, ?, ?)) { num_rts_pdtch := num_rts_pdtch + 1; if (not isbound(first_fn)) { - first_fn := pcu_sd.data.u.rts_req.fn; + first_fn := msg.u.rts_req.fn; } - last_fn := pcu_sd.data.u.rts_req.fn; + last_fn := msg.u.rts_req.fn; repeat; } - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RTS_REQ(0, 0, 7, PCU_IF_SAPI_PTCCH, ?, ?))) - -> value pcu_sd { + [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ(0, 0, 7, PCU_IF_SAPI_PTCCH, ?, ?)) { num_rts_ptcch := num_rts_ptcch + 1; if (not isbound(first_fn)) { - first_fn := pcu_sd.data.u.rts_req.fn; + first_fn := msg.u.rts_req.fn; } - last_fn := pcu_sd.data.u.rts_req.fn; + last_fn := msg.u.rts_req.fn; repeat; } - [] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_RTS_REQ)) -> value pcu_sd { - setverdict(fail, "Received unexpected PCUIF_RTS_REQ: ", pcu_sd.data); + [] as_pcuif_msg(msg, tr_PCUIF_RTS_REQ) { + setverdict(fail, "Received unexpected PCUIF_RTS_REQ: ", msg); repeat; } [] PCU.receive { @@ -6540,7 +6549,7 @@ var template PCUIF_Message tr_interf_ind; var integer interf_ind_num := 0; var boolean first := true; - var PCUIF_send_data sd; + var PCUIF_Message msg; timer T; /* Set the averaging/reporting period to 480ms */ @@ -6566,25 +6575,25 @@ T.start(0.480 * 1.5); alt { /* The first interference report may contain unreliable values, so we ignore it */ - [first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_INTERF_IND(0, 0))) { + [first] as_pcuif_msg(msg, tr_PCUIF_INTERF_IND(0, 0)) { /* 4 SACCH periods => 4 reports (plus some guard time) */ T.start(0.480 * 4.0 + 0.480 / 2.0); first := false; repeat; } /* Subsequent interference reports shall match our expectations */ - [not first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_interf_ind)) -> value sd { + [not first] as_pcuif_msg(msg, tr_interf_ind) { /* Check TDMA frame number period */ - if (sd.data.u.interf_ind.fn mod 104 != 0) { + if (msg.u.interf_ind.fn mod 104 != 0) { setverdict(fail, "Odd TDMA frame number := ", - sd.data.u.interf_ind.fn); + msg.u.interf_ind.fn); } interf_ind_num := interf_ind_num + 1; if (interf_ind_num < 4) { repeat; } } - [not first] PCU.receive(t_SD_PCUIF(g_pcu_conn_id, tr_PCUIF_INTERF_IND(0, 0))) -> value sd { - setverdict(fail, "Received unexpected interference report: ", sd.data); + [not first] as_pcuif_msg(msg, tr_PCUIF_INTERF_IND(0, 0)) { + setverdict(fail, "Received unexpected interference report: ", msg); } [] PCU.receive { repeat; } [] T.timeout { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iabefddd54a4a2e2183feea04fdb8526e74efc7ac Gerrit-Change-Number: 33106 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-bts[master]: trx TCH DL: transmit invalid speech frames instead of dummy FACCH

by dexter

Attention is currently required from: falconia, pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33069 ) Change subject: trx TCH DL: transmit invalid speech frames instead of dummy FACCH ...................................................................... Patch Set 2: Code-Review+1 (3 comments) Patchset: PS2: This patch sounds reasonable for me. File src/osmo-bts-trx/sched_lchan_tchf.c: https://gerrit.osmocom.org/c/osmo-bts/+/33069/comment/b36d97a9_b17b32d0 PS1, Line 500: what is the correct BTS Tx behavior for frame : * gaps in TCH/AFS > I hear you - I just don't have the needed AMR expertise to implement proper BFI transmission for AMR […] What we could do though is to add a task in redmine and put the OS#xxxx number next to the fixme. File src/osmo-bts-trx/sched_lchan_tchf.c: https://gerrit.osmocom.org/c/osmo-bts/+/33069/comment/9820ac66_4a9ee9c6 PS2, Line 479: * speech frame with inverted CRC3, designed to induce a BFI Wouldn't it be more clear to call it "speech block"? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I78106802a0aa4af39859c75d29fe0e77037899fe Gerrit-Change-Number: 33069 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 10:58:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in libosmo-netif[master]: stream: (typo) Change callback param name of struct osmo_stream_cli f...

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33103 ) Change subject: stream: (typo) Change callback param name of struct osmo_stream_cli from srv to cli ...................................................................... stream: (typo) Change callback param name of struct osmo_stream_cli from srv to cli Change-Id: I742db401165477f85e66bb428f156ecbbd5d6665 --- M src/stream.c 1 file changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/03/33103/1 diff --git a/src/stream.c b/src/stream.c index b3721c5..6afb7ca 100644 --- a/src/stream.c +++ b/src/stream.c @@ -261,10 +261,10 @@ int sk_domain; int sk_type; uint16_t proto; - int (*connect_cb)(struct osmo_stream_cli *srv); - int (*disconnect_cb)(struct osmo_stream_cli *srv); - int (*read_cb)(struct osmo_stream_cli *srv); - int (*write_cb)(struct osmo_stream_cli *srv); + int (*connect_cb)(struct osmo_stream_cli *cli); + int (*disconnect_cb)(struct osmo_stream_cli *cli); + int (*read_cb)(struct osmo_stream_cli *cli); + int (*write_cb)(struct osmo_stream_cli *cli); void *data; int flags; int reconnect_timeout; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I742db401165477f85e66bb428f156ecbbd5d6665 Gerrit-Change-Number: 33103 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in libosmo-netif[master]: stream: Introduce and use osmo_stream_cli_fd() to get the fd

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33102 ) Change subject: stream: Introduce and use osmo_stream_cli_fd() to get the fd ...................................................................... stream: Introduce and use osmo_stream_cli_fd() to get the fd This will become useful once osmo_io can be used as a backend. Change-Id: I7e964dea0adee8edbb9b75d2d17e7d0c5d8917d5 --- M libosmo-netif.pc.in M src/stream.c 2 files changed, 25 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/02/33102/1 diff --git a/libosmo-netif.pc.in b/libosmo-netif.pc.in index 7f1335e..1a925f6 100644 --- a/libosmo-netif.pc.in +++ b/libosmo-netif.pc.in @@ -7,5 +7,5 @@ Description: C Utility Library Version: @VERSION@ Libs: -L${libdir} -losmonetif -Libs.private: @LIBSCTP_LIBS@ +Libs.private: @LIBSCTP_LIBS@ @LIBOSMOCORE_LIBS@ Cflags: -I${includedir}/ diff --git a/src/stream.c b/src/stream.c index cbf0b27..b3721c5 100644 --- a/src/stream.c +++ b/src/stream.c @@ -321,6 +321,11 @@ cli->state = STREAM_CLI_STATE_CLOSED; } +static inline int osmo_stream_cli_fd(const struct osmo_stream_cli *cli) +{ + return cli->ofd.fd; +} + static void osmo_stream_cli_read(struct osmo_stream_cli *cli) { LOGSCLI(cli, LOGL_DEBUG, "message received\n"); @@ -406,7 +411,7 @@ #ifdef SO_NOSIGPIPE int ret; int val = 1; - ret = setsockopt(cli->ofd.fd, SOL_SOCKET, SO_NOSIGPIPE, (void *)&val, sizeof(val)); + ret = setsockopt(osmo_stream_cli_fd(cli), SOL_SOCKET, SO_NOSIGPIPE, (void *)&val, sizeof(val)); if (ret < 0) LOGSCLI(cli, LOGL_DEBUG, "Failed setting SO_NOSIGPIPE: %s\n", strerror(errno)); return ret; @@ -678,7 +683,7 @@ { static char buf[OSMO_SOCK_NAME_MAXLEN]; - osmo_sock_get_name_buf(buf, OSMO_SOCK_NAME_MAXLEN, cli->ofd.fd); + osmo_sock_get_name_buf(buf, OSMO_SOCK_NAME_MAXLEN, osmo_stream_cli_fd(cli)); return buf; } @@ -811,10 +816,10 @@ * \return negative on error, 0 on success */ int osmo_stream_cli_open(struct osmo_stream_cli *cli) { - int ret; + int ret, fd = -1; /* we are reconfiguring this socket, close existing first. */ - if ((cli->flags & OSMO_STREAM_CLI_F_RECONF) && cli->ofd.fd >= 0) + if ((cli->flags & OSMO_STREAM_CLI_F_RECONF) && osmo_stream_cli_fd(cli) >= 0) osmo_stream_cli_close(cli); cli->flags &= ~OSMO_STREAM_CLI_F_RECONF; @@ -850,14 +855,16 @@ osmo_stream_cli_reconnect(cli); return ret; } - osmo_fd_setup(&cli->ofd, ret, OSMO_FD_READ | OSMO_FD_WRITE, cli->ofd.cb, cli->ofd.data, cli->ofd.priv_nr); + + fd = ret; if (cli->flags & OSMO_STREAM_CLI_F_NODELAY) { - ret = setsockopt_nodelay(cli->ofd.fd, cli->proto, 1); + ret = setsockopt_nodelay(fd, cli->proto, 1); if (ret < 0) goto error_close_socket; } + osmo_fd_setup(&cli->ofd, fd, OSMO_FD_READ | OSMO_FD_WRITE, cli->ofd.cb, cli->ofd.data, cli->ofd.priv_nr); if (osmo_fd_register(&cli->ofd) < 0) goto error_close_socket; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7e964dea0adee8edbb9b75d2d17e7d0c5d8917d5 Gerrit-Change-Number: 33102 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in libosmo-netif[master]: ipa-stream-server: Return -EBADF in read_cb after osmo_stream_srv_des...

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33104 ) Change subject: ipa-stream-server: Return -EBADF in read_cb after osmo_stream_srv_destroy() ...................................................................... ipa-stream-server: Return -EBADF in read_cb after osmo_stream_srv_destroy() This fixes a potential heap-use-after-free error. When there is still data to be written the osmo_stream_srv_cb() will call osmo_stream_srv_write() which will try to dereference conn even though it has already been freed. Change-Id: I5ac1920b8d4ce3b0205f00d253e7ed878fb745e3 --- M examples/ipa-stream-server.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/04/33104/1 diff --git a/examples/ipa-stream-server.c b/examples/ipa-stream-server.c index c311697..e01a3cb 100644 --- a/examples/ipa-stream-server.c +++ b/examples/ipa-stream-server.c @@ -61,7 +61,7 @@ LOGP(DSTREAMTEST, LOGL_ERROR, "cannot receive message\n"); osmo_stream_srv_destroy(conn); msgb_free(msg); - return 0; + return -EBADF; } if (osmo_ipa_process_msg(msg) < 0) { LOGP(DSTREAMTEST, LOGL_ERROR, "Bad IPA message\n"); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5ac1920b8d4ce3b0205f00d253e7ed878fb745e3 Gerrit-Change-Number: 33104 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-mgw[master]: mgcp_codec: be sensitive about IuFP when checking codecs

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32926 ) Change subject: mgcp_codec: be sensitive about IuFP when checking codecs ...................................................................... mgcp_codec: be sensitive about IuFP when checking codecs When two codecs are checked for convertibility we insist that subtype_name and rate are equal since normally when those are different, we assume a completely different codec that will require a transcoder, which we do not have yet. However when IuFP is used, the call agent will always negotiate IuFP as VND.3GPP.IUFP with a rate of 16000, even though the IuFP payloads contain regular AMR at a rate of 8000. This means that if we detect IuFP on one side of the call leg and AMR on the other side of the call leg, we must not insist on equal subtype_name and rate. This fixes the following TTCN3 testcases: MGCP_Test.TC_two_crcx_mdcx_and_iuup_rtp MGCP_Test.TC_two_crcx_mdcx_and_iuup_rtp_rfci_unordered Related: OS#5461 Change-Id: I6bc1e6022efe21cb893ef213f3da35017960357d --- M src/libosmo-mgcp/mgcp_codec.c 1 file changed, 37 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_codec.c b/src/libosmo-mgcp/mgcp_codec.c index 905795c..d340e11 100644 --- a/src/libosmo-mgcp/mgcp_codec.c +++ b/src/libosmo-mgcp/mgcp_codec.c @@ -330,10 +330,20 @@ /* OsmoMGW currently has no ability to transcode from one codec to another. However OsmoMGW is still able to * translate between different payload formats as long as the encoded voice data itself does not change. * Therefore we must insist on equal codecs but still allow different payload formatting. */ + + /* In 3G IuUP, AMR may be encapsulated in IuFP, this means even though the codec name and negotiated rate is + * different, the formatting can still be converted by OsmoMGW. Therefore we won't insist on equal + * subtype_name and rate if we detect IuFP and AMR is used on the same tandem. */ + if (strcmp(codec_a->subtype_name, "AMR") == 0 && strcmp(codec_b->subtype_name, "VND.3GPP.IUFP") == 0) + goto iufp; + if (strcmp(codec_a->subtype_name, "VND.3GPP.IUFP") == 0 && strcmp(codec_b->subtype_name, "AMR") == 0) + goto iufp; + if (strcmp(codec_a->subtype_name, codec_b->subtype_name)) return false; if (codec_a->rate != codec_b->rate) return false; +iufp: if (codec_a->channels != codec_b->channels) return false; if (codec_a->frame_duration_num != codec_b->frame_duration_num) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6bc1e6022efe21cb893ef213f3da35017960357d Gerrit-Change-Number: 32926 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[L] Change in osmo-hnbgw[master]: add startup config tests

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32991 ) Change subject: add startup config tests ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32991 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic8bb30e1dd73753c2ff255566382e241918414f7 Gerrit-Change-Number: 32991 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 09:23:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-hnbgw[master]: immediately SCCP RLSD on HNB re-register

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915 ) Change subject: immediately SCCP RLSD on HNB re-register ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I4e78617ad39bb73fe92097c8a1a8069da6a7f6a1 Gerrit-Change-Number: 32915 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 09:23:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-hlr[master]: Introduce support for XOR-2G algorithm

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33096 ) Change subject: Introduce support for XOR-2G algorithm ...................................................................... Patch Set 3: (1 comment) File src/hlr_vty_subscr.c: https://gerrit.osmocom.org/c/osmo-hlr/+/33096/comment/a17ae70a_5573e3d1 PS3, Line 665: SUBSCR_UPDATE "aud3g xor-3g k K" > this is not a configuration command, but one from the ENABLE node. […] ACK -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I039a1f84fda54a908a82fe621e7fd078cb85e4c6 Gerrit-Change-Number: 33096 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 31 May 2023 09:22:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: libosmogsm: Support authentication with 256-bit K and/or OP/OPc

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33087 ) Change subject: libosmogsm: Support authentication with 256-bit K and/or OP/OPc ...................................................................... Patch Set 4: (1 comment) File include/osmocom/crypt/auth.h: https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/495baebf_768c7ef3 PS4, Line 121: OSMO_DEPRECATED_OUTSIDE("Use osmo_auth_gen_vec2 instead"); > yes, we are. On the one hand there is osmo-auc-gen, which is ported in a follow-up patch. […] good then. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie775fedba4a3fa12314c0f7c8a369662ef6a40df Gerrit-Change-Number: 33087 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 31 May 2023 09:22:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-hlr[master]: Introduce support for XOR-2G algorithm

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33096 ) Change subject: Introduce support for XOR-2G algorithm ...................................................................... Patch Set 3: (1 comment) File src/hlr_vty_subscr.c: https://gerrit.osmocom.org/c/osmo-hlr/+/33096/comment/3817790e_9d75f621 PS3, Line 665: SUBSCR_UPDATE "aud3g xor-3g k K" > you are breaking old configs here. You may want to add a deprecated entry linking to this new one. this is not a configuration command, but one from the ENABLE node. So I'm breaking "only" the user interface, but not any old configs. Given that I doubt there ever were many users of XOR, and it's just one step to look into the vty reference manual (or even just tab completion) to find the new command, I think we are fine here. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I039a1f84fda54a908a82fe621e7fd078cb85e4c6 Gerrit-Change-Number: 33096 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 09:21:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: Support (optional) indication of NCH position in SI1 rest octets

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32655 ) Change subject: Support (optional) indication of NCH position in SI1 rest octets ...................................................................... Support (optional) indication of NCH position in SI1 rest octets This adds the vty commands and respective logic to allow the user to specify the NCH (notification channel) position in the SI1 rests octets. Change-Id: Iefde0af44a663f22462a54d68a58caa560eceb2f Related: OS#5781 Requires: libosmocore.git I24a0095ac6eee0197f9d9ef9895c7795df6cdc49 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts_vty.c M src/osmo-bsc/osmo_bsc_main.c M src/osmo-bsc/system_information.c 4 files changed, 93 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved jolly: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index d6bf758..a2b84c6 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -568,6 +568,11 @@ uint16_t scramble_list[MAX_EARFCN_LIST]; } data; } si_common; + /* NCH (Notification Channel) related parameters */ + struct { + uint8_t num_blocks; /* NCH number of CCCH blocks (0 = no NCH) */ + uint8_t first_block; /* NCH first block number */ + } nch; bool early_classmark_allowed; bool early_classmark_allowed_3g; /* for testing only: Have an infinitely long radio link timeout */ diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index e37cfd4..040f2ed 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -1107,6 +1107,46 @@ return CMD_SUCCESS; } +DEFUN_USRATTR(cfg_bts_nch_position, + cfg_bts_nch_position_cmd, + X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), + "nch-position num-blocks <1-7> first-block <0-6>", + "NCH (Notification Channel) position within CCCH\n" + "Number of blocks reserved for NCH\n" + "Number of blocks reserved for NCH\n" + "First block reserved for NCH\n" + "First block reserved for NCH\n") +{ + struct gsm_bts *bts = vty->index; + int num_blocks = atoi(argv[0]); + int first_block = atoi(argv[1]); + + if (osmo_gsm48_si1ro_nch_pos_encode(num_blocks, first_block)) { + vty_out(vty, "num-blocks %u first-block %u is not permitted by 3GPP TS 44.010 Table 10.5.2.32.1b%s", + num_blocks, first_block, VTY_NEWLINE); + return CMD_WARNING; + } + + bts->nch.num_blocks = num_blocks; + bts->nch.first_block = first_block; + + return CMD_SUCCESS; +} + +DEFUN_USRATTR(cfg_bts_no_nch_position, + cfg_bts_no_nch_position_cmd, + X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), + "no nch-position", + NO_STR "Disable NCH in this BTS\n") +{ + struct gsm_bts *bts = vty->index; + + bts->nch.num_blocks = 0; + bts->nch.first_block = 0; + + return CMD_SUCCESS; +} + DEFUN_USRATTR(cfg_bts_cell_barred, cfg_bts_cell_barred_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), @@ -4405,6 +4445,12 @@ bts->si_common.chan_desc.bs_pa_mfrms + 2, VTY_NEWLINE); vty_out(vty, " channel-description bs-ag-blks-res %u%s", bts->si_common.chan_desc.bs_ag_blks_res, VTY_NEWLINE); + if (bts->nch.num_blocks) { + vty_out(vty, " nch-position num-blocks %u first-block %u%s", + bts->nch.num_blocks, bts->nch.first_block, VTY_NEWLINE); + } else { + vty_out(vty, " no nch-position%s", VTY_NEWLINE); + } if (bts->ccch_load_ind_thresh != 10) vty_out(vty, " ccch load-indication-threshold %u%s", @@ -4851,6 +4897,8 @@ install_element(BTS_NODE, &cfg_bts_interf_meas_level_bounds_cmd); install_element(BTS_NODE, &cfg_bts_srvcc_fast_return_cmd); install_element(BTS_NODE, &cfg_bts_immediate_assignment_cmd); + install_element(BTS_NODE, &cfg_bts_nch_position_cmd); + install_element(BTS_NODE, &cfg_bts_no_nch_position_cmd); neighbor_ident_vty_init(); /* See also handover commands added on bts level from handover_vty.c */ diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index b1a7631..f3f9cd2 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -393,6 +393,12 @@ bts->si_common.chan_desc.bs_ag_blks_res); bts->si_common.chan_desc.bs_ag_blks_res = 2; } + + if (!(bts->nch.num_blocks == 1 && (bts->nch.first_block == 0 || bts->nch.first_block == 1)) && + !(bts->nch.num_blocks == 2 && bts->nch.first_block == 0)) { + LOG_BTS(bts, DNM, LOGL_ERROR, "CCCH is combined with SDCCHs, but NCH position/size is " + "incompatible with that. Please fix your config!\n"); + } } else { /* Non-combined TS0/C0 configuration */ /* There can be additional CCCHs on even timeslot numbers */ n += (bts->c0->ts[2].pchan_from_config == GSM_PCHAN_CCCH); @@ -401,6 +407,13 @@ bts->si_common.chan_desc.ccch_conf = (n << 1); } + if (bts->nch.first_block + bts->nch.num_blocks > bts->si_common.chan_desc.bs_ag_blks_res) { + LOG_BTS(bts, DNM, LOGL_ERROR, "Position/Number of NCH blocks (%u..%u) exceeds AGCH (%u)." + "Please fix your config!\n", bts->nch.first_block, + bts->nch.first_block + bts->nch.num_blocks - 1, + bts->si_common.chan_desc.bs_ag_blks_res); + } + bts_setup_ramp_init_bts(bts); /* ACC ramping is initialized from vty/config */ diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index 6e82c56..35fce68 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -771,7 +771,19 @@ * SI1 Rest Octets (10.5.2.32), contains NCH position and band * indicator but that is not in the 04.08. */ - rc = osmo_gsm48_rest_octets_si1_encode(si1->rest_octets, NULL, is_dcs_net(bts)); + if (bts->nch.num_blocks) { + rc = osmo_gsm48_si1ro_nch_pos_encode(bts->nch.num_blocks, bts->nch.first_block); + if (rc < 0) { + LOGP(DRR, LOGL_ERROR, "Unable to encode NCH position (num_blocks=%u, first_block=%u)\n", + bts->nch.num_blocks, bts->nch.first_block); + rc = osmo_gsm48_rest_octets_si1_encode(si1->rest_octets, NULL, is_dcs_net(bts)); + } else { + uint8_t nch_pos = rc; + rc = osmo_gsm48_rest_octets_si1_encode(si1->rest_octets, &nch_pos, is_dcs_net(bts)); + } + } else { + rc = osmo_gsm48_rest_octets_si1_encode(si1->rest_octets, NULL, is_dcs_net(bts)); + } return sizeof(*si1) + rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iefde0af44a663f22462a54d68a58caa560eceb2f Gerrit-Change-Number: 32655 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: libosmogsm: Support authentication with 256-bit K and/or OP/OPc

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33087 ) Change subject: libosmogsm: Support authentication with 256-bit K and/or OP/OPc ...................................................................... Patch Set 4: (1 comment) File include/osmocom/crypt/auth.h: https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/86bc710a_a904bdfd PS4, Line 121: OSMO_DEPRECATED_OUTSIDE("Use osmo_auth_gen_vec2 instead"); > OSMO_DEPRECATED_OUTSIDE vs OSMO_DEPRECATED. […] yes, we are. On the one hand there is osmo-auc-gen, which is ported in a follow-up patch. Then there is the IPA based OAP (osmo auth protocol), which even has static_assert around sizes of fields in the old sub_auth_data structures. This code is not use by anyone in ages and I have no interest in porting it. Last, but not least, there are all the authentication related unit tests which use the old API. I actually consider that a good thing, as that way we can be reasonably sure that this changeset doesn't break old users. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie775fedba4a3fa12314c0f7c8a369662ef6a40df Gerrit-Change-Number: 33087 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 09:19:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-mgw[master]: mgcp_codec: be sensitive about IuFP when checking codecs

by pespin

Attention is currently required from: laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32926 ) Change subject: mgcp_codec: be sensitive about IuFP when checking codecs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6bc1e6022efe21cb893ef213f3da35017960357d Gerrit-Change-Number: 32926 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 09:07:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[L] Change in osmo-hnbgw[master]: cnpool: allow separate cs7 for IuPS and IuCS

by pespin

Attention is currently required from: neels, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32323 ) Change subject: cnpool: allow separate cs7 for IuPS and IuCS ...................................................................... Patch Set 8: Code-Review+1 (2 comments) File include/osmocom/hnbgw/hnbgw.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/32323/comment/715a8070_694fca97 PS8, Line 87: DECLARE_HASHTABLE(hnbgw_context_map_by_conn_id, 6); maybe add a comment what's going to be added in here (struct hnbgw_cnlink?). https://gerrit.osmocom.org/c/osmo-hnbgw/+/32323/comment/fc066f56_0b15aa32 PS8, Line 133: if (!cnlink->hnbgw_sccp_user) can this really happen? Is it expected to happen? I find it confusing when seeing all these checks when learning a code base because I then don't know if it is expected from the author that the cnlink will have no sccp_user at times, or it's simply over-protecting code. If this should not happen, in general I'd go for OSMO_ASSERT, to avoid confusing others. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iea1824f1c586723d989c80a909bae16bd2866e08 Gerrit-Change-Number: 32323 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 09:06:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-hnbgw[master]: add separate cfg file only for VTY tests

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32990 ) Change subject: add separate cfg file only for VTY tests ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idcdf0e8660e8180fbe02282bc94e623ff89e848a Gerrit-Change-Number: 32990 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 08:45:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: add doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32989 ) Change subject: add doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg: https://gerrit.osmocom.org/c/osmo-hnbgw/+/32989/comment/24349460_bca6ee18 PS2, Line 13: hnbap-allow-tmsi 1 this line shows as not really interesting in this example? Why not using the default? https://gerrit.osmocom.org/c/osmo-hnbgw/+/32989/comment/702feaa0_4487f303 PS2, Line 19: log stderr usually we put log sections at the top. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32989 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I42c3b434a7339cc3efb27b43c893cfb734de9ca4 Gerrit-Change-Number: 32989 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 08:44:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[L] Change in osmo-hnbgw[master]: add startup config tests

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32991 ) Change subject: add startup config tests ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File tests/Makefile.am: https://gerrit.osmocom.org/c/osmo-hnbgw/+/32991/comment/362cce0c_c0aee433 PS5, Line 69: $(srcdir)/config/run_tests.sh "$(top_builddir)/src/osmo-hnbgw/osmo-hnbgw" "$(srcdir)/config/" $U I fail to see why cannot you add the for loop directly here, I would expect the entire target is run by only 1 executor and be done sequentially. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32991 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic8bb30e1dd73753c2ff255566382e241918414f7 Gerrit-Change-Number: 32991 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 08:43:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: do not check TDMA Fn of PTCCH/U prims

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33101 ) Change subject: trxcon/l1sched: do not check TDMA Fn of PTCCH/U prims ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33101 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I54ba9b5d9c3eba4aeabf9ed6fcf1e8d09f21cce1 Gerrit-Change-Number: 33101 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 08:39:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: l1gprs: properly handle (forward) PTCCH/D blocks

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33100 ) Change subject: l1gprs: properly handle (forward) PTCCH/D blocks ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifcc53d442426c8bfdacd3d179e20bb45c43f4644 Gerrit-Change-Number: 33100 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 May 2023 08:38:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-hlr[master]: Introduce support for XOR-2G algorithm

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/33096 ) Change subject: Introduce support for XOR-2G algorithm ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/hlr_vty_subscr.c: https://gerrit.osmocom.org/c/osmo-hlr/+/33096/comment/cb151dc1_b626f0d6 PS3, Line 665: SUBSCR_UPDATE "aud3g xor-3g k K" you are breaking old configs here. You may want to add a deprecated entry linking to this new one. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/33096 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I039a1f84fda54a908a82fe621e7fd078cb85e4c6 Gerrit-Change-Number: 33096 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 31 May 2023 08:37:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[XL] Change in libosmocore[master]: libosmogsm: Add support for TUAK authentication algorithm

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33094 ) Change subject: libosmogsm: Add support for TUAK authentication algorithm ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib905b8d8bdf248e8299bf50666ee1bca8298433d Gerrit-Change-Number: 33094 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 31 May 2023 08:33:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: libosmogsm: Factor out the C2 derivation function

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33092 ) Change subject: libosmogsm: Factor out the C2 derivation function ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0e7cd55f5578f891cb6cc1b0442920ba5beddae4 Gerrit-Change-Number: 33092 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 31 May 2023 08:32:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: libosmogsm: Support authentication with 256-bit K and/or OP/OPc

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33087 ) Change subject: libosmogsm: Support authentication with 256-bit K and/or OP/OPc ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File include/osmocom/crypt/auth.h: https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/5fc7b944_f5701fe5 PS4, Line 121: OSMO_DEPRECATED_OUTSIDE("Use osmo_auth_gen_vec2 instead"); OSMO_DEPRECATED_OUTSIDE vs OSMO_DEPRECATED. Are we still using the old one someone internally? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie775fedba4a3fa12314c0f7c8a369662ef6a40df Gerrit-Change-Number: 33087 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 31 May 2023 08:31:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[M] Change in libosmocore[master]: libosmogsm: Allow auth API caller to specify RES length

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33091 ) Change subject: libosmogsm: Allow auth API caller to specify RES length ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/gsm/auth_core.c: https://gerrit.osmocom.org/c/libosmocore/+/33091/comment/077b38f4_cfd837ac PS3, Line 224: if (aud->type == OSMO_AUTH_TYPE_UMTS) { > note this is modifying the *vec*, not the *aud*. […] Ah I see, fine then. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic662843fbe8b5c58e4af39ea630ad5ac13fd6bef Gerrit-Change-Number: 33091 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 31 May 2023 08:29:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

2024

2023

2022

gerrit-log May 2023