May 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-hnbgw[master]: add non-installed libhnbgw.la for test linkage

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32621 ) Change subject: add non-installed libhnbgw.la for test linkage ...................................................................... Patch Set 3: (1 comment) File src/osmo-hnbgw/Makefile.am: https://gerrit.osmocom.org/c/osmo-hnbgw/+/32621/comment/a5c6836b_91867340 PS2, Line 67: LIBOSMOGTLV_CFLAGS > Just to clarify: `LIBOSMOGTLV_{CFLAGS,LIBS}` will be added automatically by libtool because libosmo- […] that's right, this patch also fixes this bug ... maybe should have been a separate patch but i have +2 now =) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32621 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id2a706a30fb459005c676bb29c196cf3a582fa01 Gerrit-Change-Number: 32621 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 May 2023 20:10:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: virt_phy: fix TDMA Fn math in l1ctl_rx_rach_req()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32675 ) Change subject: virt_phy: fix TDMA Fn math in l1ctl_rx_rach_req() ...................................................................... virt_phy: fix TDMA Fn math in l1ctl_rx_rach_req() Change-Id: I7922dd2d3257257b3bf8711ec859dd99463adc39 Related: OS#5500 --- M src/host/virt_phy/src/virt_prim_rach.c 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/75/32675/1 diff --git a/src/host/virt_phy/src/virt_prim_rach.c b/src/host/virt_phy/src/virt_prim_rach.c index 547e8f1..d12e63c 100644 --- a/src/host/virt_phy/src/virt_prim_rach.c +++ b/src/host/virt_phy/src/virt_prim_rach.c @@ -26,6 +26,7 @@ #include <osmocom/core/msgb.h> #include <osmocom/gsm/rsl.h> #include <osmocom/gsm/gsm_utils.h> +#include <osmocom/gsm/gsm0502.h> #include <osmocom/gsm/protocol/gsm_08_58.h> #include <osmocom/bb/virtphy/l1ctl_sap.h> @@ -97,11 +98,12 @@ /* add elapsed RACH slots to offset */ offset += t3_to_rach_comb[l1s->current_time.t3]; /* offset is the number of RACH slots in the future */ - fn_sched = l1s->current_time.fn - l1s->current_time.t3; + fn_sched = GSM_TDMA_FN_SUB(l1s->current_time.fn, l1s->current_time.t3); fn_sched += offset / 27 * 51; fn_sched += rach_to_t3_comb[offset % 27]; + fn_sched %= GSM_TDMA_HYPERFRAME; } else - fn_sched = l1s->current_time.fn + offset; + fn_sched = GSM_TDMA_FN_SUM(l1s->current_time.fn, offset); virt_l1_sched_schedule(ms, msg, fn_sched, ul->chan_nr & 0x07, &virt_l1_sched_handler_cb); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7922dd2d3257257b3bf8711ec859dd99463adc39 Gerrit-Change-Number: 32675 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: virt_phy: l1ctl_rx_rach_req(): remove TDMA Fn hack

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32674 ) Change subject: virt_phy: l1ctl_rx_rach_req(): remove TDMA Fn hack ...................................................................... virt_phy: l1ctl_rx_rach_req(): remove TDMA Fn hack This looks like a debugging leftover. Change-Id: Id794c76aea48a171f0c5f4604892a82c1a2d3ed4 --- M src/host/virt_phy/src/virt_prim_rach.c 1 file changed, 11 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/74/32674/1 diff --git a/src/host/virt_phy/src/virt_prim_rach.c b/src/host/virt_phy/src/virt_prim_rach.c index f6cb496..547e8f1 100644 --- a/src/host/virt_phy/src/virt_prim_rach.c +++ b/src/host/virt_phy/src/virt_prim_rach.c @@ -80,9 +80,6 @@ LOGPMS(DL1C, LOGL_INFO, ms, "Rx L1CTL_RACH_REQ (ra=0x%02x, offset=%d combined=%d)\n", rach_req->ra, offset, rach_req->combined); - if (rach_req->ra == 0x03) - fn_sched = 42; - /* set ra data to msg (8bits, the 11bit option is not used for GSM) */ msg->l2h = msgb_put(msg, sizeof(uint8_t)); *msg->l2h = rach_req->ra; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id794c76aea48a171f0c5f4604892a82c1a2d3ed4 Gerrit-Change-Number: 32674 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: virt_phy: l1ctl_rx_rach_req(): use the indicated chan_nr/link_id

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32673 ) Change subject: virt_phy: l1ctl_rx_rach_req(): use the indicated chan_nr/link_id ...................................................................... virt_phy: l1ctl_rx_rach_req(): use the indicated chan_nr/link_id Change-Id: I820f32851f1c7a39695270cc246964a3e212118f --- M src/host/virt_phy/src/virt_prim_rach.c 1 file changed, 18 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/73/32673/1 diff --git a/src/host/virt_phy/src/virt_prim_rach.c b/src/host/virt_phy/src/virt_prim_rach.c index 5a3b61a..f6cb496 100644 --- a/src/host/virt_phy/src/virt_prim_rach.c +++ b/src/host/virt_phy/src/virt_prim_rach.c @@ -87,10 +87,13 @@ msg->l2h = msgb_put(msg, sizeof(uint8_t)); *msg->l2h = rach_req->ra; - /* chan_nr need to be encoded here, as it is not set by l23 for - * the rach request, but needed by virt um */ - ul->chan_nr = RSL_CHAN_RACH; - ul->link_id = LID_DEDIC; + /* use the indicated RSL chan_nr/link_id, if provided */ + if (ul->chan_nr == 0x00) { + LOGPMS(DL1C, LOGL_NOTICE, ms, + "The UL info header is empty, assuming RACH is on TS0\n"); + ul->chan_nr = RSL_CHAN_RACH; + ul->link_id = LID_DEDIC; + } /* sched fn calculation if we have a combined ccch channel configuration */ if (rach_req->combined) { @@ -103,7 +106,8 @@ } else fn_sched = l1s->current_time.fn + offset; - virt_l1_sched_schedule(ms, msg, fn_sched, 0, &virt_l1_sched_handler_cb); + virt_l1_sched_schedule(ms, msg, fn_sched, ul->chan_nr & 0x07, + &virt_l1_sched_handler_cb); } /** -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32673 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I820f32851f1c7a39695270cc246964a3e212118f Gerrit-Change-Number: 32673 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: virt_phy: fix l1ctl_rx_rach_req(): send RACH on TS0, not TS1

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32672 ) Change subject: virt_phy: fix l1ctl_rx_rach_req(): send RACH on TS0, not TS1 ...................................................................... virt_phy: fix l1ctl_rx_rach_req(): send RACH on TS0, not TS1 Change-Id: I096e377de9e74893e9eb1927707d5e1a44b15ad9 --- M src/host/virt_phy/src/virt_prim_rach.c 1 file changed, 11 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/72/32672/1 diff --git a/src/host/virt_phy/src/virt_prim_rach.c b/src/host/virt_phy/src/virt_prim_rach.c index 22b8e29..5a3b61a 100644 --- a/src/host/virt_phy/src/virt_prim_rach.c +++ b/src/host/virt_phy/src/virt_prim_rach.c @@ -75,7 +75,6 @@ struct l1ctl_info_ul *ul = (struct l1ctl_info_ul *) l1h->data; struct l1ctl_rach_req *rach_req = (struct l1ctl_rach_req *) ul->payload; uint32_t fn_sched; - uint8_t ts = 1; /* FIXME mostly, ts 1 is used for rach, where can i get that info? System info? */ uint16_t offset = ntohs(rach_req->offset); LOGPMS(DL1C, LOGL_INFO, ms, "Rx L1CTL_RACH_REQ (ra=0x%02x, offset=%d combined=%d)\n", @@ -90,7 +89,7 @@ /* chan_nr need to be encoded here, as it is not set by l23 for * the rach request, but needed by virt um */ - ul->chan_nr = rsl_enc_chan_nr(RSL_CHAN_RACH, 0, ts); + ul->chan_nr = RSL_CHAN_RACH; ul->link_id = LID_DEDIC; /* sched fn calculation if we have a combined ccch channel configuration */ @@ -104,7 +103,7 @@ } else fn_sched = l1s->current_time.fn + offset; - virt_l1_sched_schedule(ms, msg, fn_sched, ts, &virt_l1_sched_handler_cb); + virt_l1_sched_schedule(ms, msg, fn_sched, 0, &virt_l1_sched_handler_cb); } /** -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I096e377de9e74893e9eb1927707d5e1a44b15ad9 Gerrit-Change-Number: 32672 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: codec: add osmo_{fr,efr}_is_any_sid() inline functions

by falconia

falconia has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32670 ) Change subject: codec: add osmo_{fr,efr}_is_any_sid() inline functions ...................................................................... codec: add osmo_{fr,efr}_is_any_sid() inline functions Recently added osmo_{fr,efr}_sid_classify() functions classify FR (EFR) codec frames according to the rules of GSM 06.31 (06.81) section 6.1.1. Both of these specs also define the term "accepted SID frame", encompassing both valid and invalid SID frames, but not regular speech frames. A boolean check for this wider category of "accepted SID frame" is a useful function - many existing calls to legacy osmo_{fr,efr}_check_sid() functions should be converted to this "accepted SID frame" check for full correctness. Add wrapper functions for convenience, and to allow this transition to be made without adding bloat to every use instance. Change-Id: I5e6e91baf18440af01dccc6ac0171476a8a5c71c --- M include/osmocom/codec/codec.h 1 file changed, 47 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve falconia: Looks good to me, approved diff --git a/include/osmocom/codec/codec.h b/include/osmocom/codec/codec.h index a656bcf..7f82432 100644 --- a/include/osmocom/codec/codec.h +++ b/include/osmocom/codec/codec.h @@ -98,6 +98,33 @@ enum osmo_gsm631_sid_class osmo_fr_sid_classify(const uint8_t *rtp_payload); enum osmo_gsm631_sid_class osmo_efr_sid_classify(const uint8_t *rtp_payload); + +/*! Check if given FR codec frame is any kind of SID, valid or invalid + * \param[in] rtp_payload Buffer with RTP payload + * \returns true if the frame is an "accepted SID frame" in GSM 06.31 + * definition, false otherwise. + */ +static inline bool osmo_fr_is_any_sid(const uint8_t *rtp_payload) +{ + enum osmo_gsm631_sid_class sidc; + + sidc = osmo_fr_sid_classify(rtp_payload); + return sidc != OSMO_GSM631_SID_CLASS_SPEECH; +} + +/*! Check if given EFR codec frame is any kind of SID, valid or invalid + * \param[in] rtp_payload Buffer with RTP payload + * \returns true if the frame is an "accepted SID frame" in GSM 06.81 + * definition, false otherwise. + */ +static inline bool osmo_efr_is_any_sid(const uint8_t *rtp_payload) +{ + enum osmo_gsm631_sid_class sidc; + + sidc = osmo_efr_sid_classify(rtp_payload); + return sidc != OSMO_GSM631_SID_CLASS_SPEECH; +} + bool osmo_fr_sid_preen(uint8_t *rtp_payload); bool osmo_efr_sid_preen(uint8_t *rtp_payload); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5e6e91baf18440af01dccc6ac0171476a8a5c71c Gerrit-Change-Number: 32670 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: codec: add osmo_{fr,efr}_is_any_sid() inline functions

by falconia

falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32670 ) Change subject: codec: add osmo_{fr,efr}_is_any_sid() inline functions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5e6e91baf18440af01dccc6ac0171476a8a5c71c Gerrit-Change-Number: 32670 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 May 2023 16:41:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: codec: add osmo_{fr,efr}_is_any_sid() inline functions

by dexter

Attention is currently required from: falconia. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32670 ) Change subject: codec: add osmo_{fr,efr}_is_any_sid() inline functions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5e6e91baf18440af01dccc6ac0171476a8a5c71c Gerrit-Change-Number: 32670 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 09 May 2023 15:27:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[XL] Change in libosmocore[master]: Add osmo_io with initial poll backend

by dexter

Attention is currently required from: osmith, neels, laforge, fixeria, pespin, daniel. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30934 ) Change subject: Add osmo_io with initial poll backend ...................................................................... Patch Set 17: Code-Review+1 (1 comment) Patchset: PS17: looks very clean to me, but unfortunately I can not say too much since I do not have the full background. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I50d73cf550d6ce8154bf827bf47408131cf5b0a0 Gerrit-Change-Number: 30934 Gerrit-PatchSet: 17 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 May 2023 15:24:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: gbproxy: Reduce timeout to fix flaky test

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32570 ) Change subject: gbproxy: Reduce timeout to fix flaky test ...................................................................... gbproxy: Reduce timeout to fix flaky test The individual timeouts in TC_BVC_bringup_conflicting add up to almost 15.0s (the Tguard timeout) which causes the test to sometimes fail. Decrease the time waiting for all BVCs to be unblocked from 10s to 5s, in reality this should be plenty time. Change-Id: I620ce90f9e6b54cc94b4d36ac123f43d8d809f47 --- M gbproxy/GBProxy_Tests.ttcn 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn index ac81580..e5bec7d 100644 --- a/gbproxy/GBProxy_Tests.ttcn +++ b/gbproxy/GBProxy_Tests.ttcn @@ -1114,7 +1114,7 @@ } /* wait until all BVC are unblocked on both sides */ - timer T := 10.0; + timer T := 5.0; T.start; alt { [] SGSN_MGMT.receive(BssgpStatusIndication:{*, ?, ?}) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I620ce90f9e6b54cc94b4d36ac123f43d8d809f47 Gerrit-Change-Number: 32570 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023