March 2023 - gerrit-log - lists.osmocom.org

[XL] Change in osmo-msc[master]: [codecs filter] msc_vlr_test_call: test codecs resolution
by Jenkins Builder 07 Mar '23

07 Mar '23

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31702 ) Change subject: [codecs filter] msc_vlr_test_call: test codecs resolution ...................................................................... Patch Set 1: (10 comments) File tests/msc_vlr/msc_vlr_test_call.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/8646de3b_93ee705f PS1, Line 167: static void lu_geran_noauth() Bad function definition - void lu_geran_noauth() should probably be void lu_geran_noauth(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/8c3166c1_952b1287 PS1, Line 1013: OSMO_STRBUF_PRINTF(sb, " %s", m? m->sdp.subtype_name : "NULL"); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/7956d0d0_e4f98640 PS1, Line 1025: for (pos = perm_speech; *pos != LIST_END; pos++) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/66b6572a_7447f1d1 PS1, Line 1031: static const char *strlist_name(const char *const* strs) "foo *const* bar" should be "foo *const*bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/3cc4bf6b_3d76f557 PS1, Line 1121: }\ space required after that close brace '}' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/3a286f59_e20ed63f PS1, Line 1160: for (pos = ms_bcap; *pos != LIST_END; pos++) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/5e1b8e98_b7dcf51c PS1, Line 1176: struct gsm_mncc_rtp *mncc_rtp = (void*)&mncc; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/070373af_41d06996 PS1, Line 1288: struct gsm_mncc_rtp *mncc_rtp = (void*)&mncc; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/c9b87b3b_54f47e4c PS1, Line 1428: static void test_codecs() Bad function definition - void test_codecs() should probably be void test_codecs(void) File tests/msc_vlr/msc_vlr_tests.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4548): https://gerrit.osmocom.org/c/osmo-msc/+/31702/comment/7207f117_7cf7134a PS1, Line 767: struct gsm_mncc_rtp *rtp = (void*)msg->data; "(foo*)" should be "(foo *)" -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I879ec61f523ad4ffc69a0b02810591f7c0261ff9 Gerrit-Change-Number: 31702 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 07 Mar 2023 00:40:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmo-msc[master]: add codec_mapping.h,c
by Jenkins Builder 07 Mar '23

07 Mar '23

Attention is currently required from: neels, fixeria. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30114 ) Change subject: add codec_mapping.h,c ...................................................................... Patch Set 2: (1 comment) File src/libmsc/codec_mapping.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4547): https://gerrit.osmocom.org/c/osmo-msc/+/30114/comment/a32e01e4_4289f2f0 PS2, Line 335: for (i = 0; i < m->speech_ver_count; i++) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaa307be6a8487aa8d4ba7cd59d5c5ef04818a744 Gerrit-Change-Number: 30114 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 00:40:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: mobile: allow configuring local GSMTAP address
by fixeria 07 Mar '23

07 Mar '23

Attention is currently required from: pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31661 ) Change subject: mobile: allow configuring local GSMTAP address ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/host/layer23/src/common/vty.c: https://gerrit.osmocom.org/c/osmocom-bb/+/31661/comment/a6365546_ba824558 PS3, Line 197: SOURCE btw, we may want to use `VTY_IPV46_CMD` here. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia1555db653cf0bb20af74617f33aad31c971bfdb Gerrit-Change-Number: 31661 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 00:29:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm_08_58: Document IPAC RTP CSD modes in at least a few words
by fixeria 07 Mar '23

07 Mar '23

Attention is currently required from: osmith, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31690 ) Change subject: gsm_08_58: Document IPAC RTP CSD modes in at least a few words ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31690 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77fc7b24ccd387f54a7c7edad666737252af6bd9 Gerrit-Change-Number: 31690 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 07 Mar 2023 00:26:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in libosmocore[master]: gsm: TS 44.021 modified V.110 frame encoding/decoding support
by fixeria 07 Mar '23

07 Mar '23

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31668 ) Change subject: gsm: TS 44.021 modified V.110 frame encoding/decoding support ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/gsm/gsm44021.c: https://gerrit.osmocom.org/c/libosmocore/+/31668/comment/1af9fae6_c70c1cdb PS4, Line 1: Missing license header. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31668 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I60a2f2690459359437df20cf4da9043fa7c3ad11 Gerrit-Change-Number: 31668 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 07 Mar 2023 00:25:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: .gitignore: sms.db-shm sbs.db-wal (when db is open)
by neels 07 Mar '23

07 Mar '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31705 ) Change subject: .gitignore: sms.db-shm sbs.db-wal (when db is open) ...................................................................... .gitignore: sms.db-shm sbs.db-wal (when db is open) Change-Id: I788ebf15a1569584dd2f158be901bc6e9f7de177 --- M .gitignore 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/31705/1 diff --git a/.gitignore b/.gitignore index 9d48551..e77dfa7 100644 --- a/.gitignore +++ b/.gitignore @@ -20,3 +20,5 @@ *.d *.merged sms.db +sms.db-shm +sms.db-wal -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I788ebf15a1569584dd2f158be901bc6e9f7de177 Gerrit-Change-Number: 31705 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc fix log typo
by neels 07 Mar '23

07 Mar '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31706 ) Change subject: msc fix log typo ...................................................................... msc fix log typo Change-Id: Id6767c5e7f00ad7e44c569dcba1a56e2717d2e1a --- M msc/MSC_Tests.ttcn 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/31706/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 36fe1eb..a571fc0 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -1816,7 +1816,7 @@ } [] MNCC.receive(tr_MNCC_DISC_ind(cpars.mncc_callref)) { MNCC.send(ts_MNCC_REL_req(cpars.mncc_callref, valueof(ts_MNCC_cause(23)))); - log("Rx MNCC DISC.ind, T310.read yelds ", T310.read); + log("Rx MNCC DISC.ind, T310.read yields ", T310.read); setverdict(pass); } [] MNCC.receive(MNCC_PDU:?) -> value mncc_rx { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31706 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id6767c5e7f00ad7e44c569dcba1a56e2717d2e1a Gerrit-Change-Number: 31706 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: TC_mt_t310: fix an interleave
by neels 07 Mar '23

07 Mar '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31707 ) Change subject: msc: TC_mt_t310: fix an interleave ...................................................................... msc: TC_mt_t310: fix an interleave the MNCC.receive doesn't depend on the MGCP really. Change-Id: If29e755c2c061836ce2ba472e44a621eadba4fc6 --- M msc/MSC_Tests.ttcn 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/07/31707/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index a571fc0..0372ec7 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -1797,8 +1797,9 @@ /* MSC->MGW: CRCX (second) */ [] MGCP.receive(tr_CRCX) -> value mgcp_cmd { f_handle_crcx(cpars, mgcp_cmd); /* MSC<-MGW: OK */ - MNCC.receive(tr_MNCC_RTP_CREATE(cpars.mncc_callref)); } + + [] MNCC.receive(tr_MNCC_RTP_CREATE(cpars.mncc_callref)); } /* Reschedule the guard timeout */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If29e755c2c061836ce2ba472e44a621eadba4fc6 Gerrit-Change-Number: 31707 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: TC_mt_t310: avoid sporadic failure from X2 timeout
by neels 07 Mar '23

07 Mar '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31710 ) Change subject: msc: TC_mt_t310: avoid sporadic failure from X2 timeout ...................................................................... msc: TC_mt_t310: avoid sporadic failure from X2 timeout Change-Id: Ic23cbca5775031dcb0ea1744454e20cda090701c --- M msc/MSC_Tests.ttcn 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/10/31710/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index a0c86d1..b4fc4a0 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -1766,6 +1766,10 @@ f_init_handler(pars); + /* Make sure X2 does not fire in this test. This test does not send a CN RTP port to osmo-msc, which will + * trigger X2 timeout. We want to test T310, so make X2 significantly longer than T310=30s. */ + f_vty_config(MSCVTY, "msc", "timer mgw X2 40"); + /* Initiate a MT call, establish connection */ f_mt_call_start(cpars); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic23cbca5775031dcb0ea1744454e20cda090701c Gerrit-Change-Number: 31710 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: CC Re-Est: allow MNCC_RTP_CREATE upon Assgmt
by neels 07 Mar '23

07 Mar '23

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31708 ) Change subject: msc: CC Re-Est: allow MNCC_RTP_CREATE upon Assgmt ...................................................................... msc: CC Re-Est: allow MNCC_RTP_CREATE upon Assgmt In f_tc_call_re_establishment_2(), after Assignment Complete, optionally allow an MNCC_RTP_CREATE. When Re-Establishing a call, the Assignment Complete usually affects codec and RTP address, so an MNCC_RTP_CREATE should happen after the Assignment Complete message. Current osmo-msc master does not send this MNCC_RTP_CREATE. This is is unlikely to be correct (would be ok if no RTP port changes), likely omitted due to a bug. An upcoming patch adds the MNCC_RTP_CREATE in Call Re-Establishment to osmo-msc. Related: Ie433db1ba0c46d4b97538a969233c155cefac21c (osmo-msc) Change-Id: I06d19947ba2e9b6696269db0e4f3d47d4b98bde6 --- M msc/MSC_Tests.ttcn 1 file changed, 31 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/08/31708/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 0372ec7..1767761 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -6670,6 +6670,10 @@ vc_conn.done; } +private altstep as_mncc_rx_rtp_create(CallParameters cpars) runs on BSC_ConnHdlr { + [] MNCC.receive(tr_MNCC_RTP_CREATE(cpars.mncc_callref)); +} + const charstring REEST_LOST_CONNECTION := "REEST_LOST_CONNECTION"; const charstring REEST_CLEARED := "REEST_CLEARED"; @@ -6734,12 +6738,15 @@ * Apparently osmo-msc currently also sends an MDCX to the CN side, just repeating the same configuration that * is already in use. This test accepts any number of or even lack of MDCX. */ var default ack_mdcx := activate(as_mgcp_ack_all_mdcx(cpars)); + var default optional_rtp_create := activate(as_mncc_rx_rtp_create(cpars)); BSSAP.send(ts_BSSMAP_AssignmentComplete(omit, tla, codec)); + /* The call has been fully re-established. * Let a bit of time pass before hanging up, for everything to settle. */ f_sleep(3.0); + deactivate(optional_rtp_create); deactivate(ack_mdcx); /* Hang up the call and clear the new, second A connection */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I06d19947ba2e9b6696269db0e4f3d47d4b98bde6 Gerrit-Change-Number: 31708 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0