March 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: fix coverity (false) warning in codec-list vty
by neels 07 Mar '23

07 Mar '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31712 ) Change subject: fix coverity (false) warning in codec-list vty ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31712/comment/538437c8_53269a6b PS1, Line 2749: support > oh damn, this should say 'codec-list' -- that was missed in CR to my previous patch here Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I96cd5d88ec6808a2915c6bccd0c0140216f328f2 Gerrit-Change-Number: 31712 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 04:57:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: fix coverity (false) warning in codec-list vty
by neels 07 Mar '23

07 Mar '23

Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31712 to look at the new patch set (#2). Change subject: fix coverity (false) warning in codec-list vty ...................................................................... fix coverity (false) warning in codec-list vty Since there were complaints about this old parsing code during recent code review in Ifdc9e04bf1d623da65bfb8a2fddea765601f6d9b, and now also coverity finds something odd in it, just rewrite this. Related: CID#310912 Change-Id: I96cd5d88ec6808a2915c6bccd0c0140216f328f2 --- M src/osmo-bsc/bsc_vty.c M tests/msc.vty 2 files changed, 43 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/12/31712/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I96cd5d88ec6808a2915c6bccd0c0140216f328f2 Gerrit-Change-Number: 31712 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bsc[master]: fix coverity (false) warning in codec-list vty
by neels 07 Mar '23

07 Mar '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31712 ) Change subject: fix coverity (false) warning in codec-list vty ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31712/comment/aa6e2cfb_a06d4410 PS1, Line 2749: support oh damn, this should say 'codec-list' -- that was missed in CR to my previous patch here -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I96cd5d88ec6808a2915c6bccd0c0140216f328f2 Gerrit-Change-Number: 31712 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 04:54:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in osmo-msc[master]: [codecs filter] msc_vlr_test_call: test codecs resolution
by neels 07 Mar '23

07 Mar '23

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/31702 to look at the new patch set (#4). Change subject: [codecs filter] msc_vlr_test_call: test codecs resolution ...................................................................... [codecs filter] msc_vlr_test_call: test codecs resolution Show that the codecs filter now works as expected in call messaging. Related: SYS#5066 Change-Id: I879ec61f523ad4ffc69a0b02810591f7c0261ff9 --- M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_call.err M tests/msc_vlr/msc_vlr_tests.c M tests/msc_vlr/msc_vlr_tests.h 4 files changed, 3,728 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/02/31702/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I879ec61f523ad4ffc69a0b02810591f7c0261ff9 Gerrit-Change-Number: 31702 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmo-msc[master]: add codec_mapping.h,c
by neels 07 Mar '23

07 Mar '23

Attention is currently required from: laforge, fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30114 ) Change subject: add codec_mapping.h,c ...................................................................... Patch Set 4: (2 comments) File src/libmsc/codec_mapping.c: https://gerrit.osmocom.org/c/osmo-msc/+/30114/comment/d7d9f3bd_1e78e937 PS1, Line 8: * SPDX-License-Identifier: GPL-2.0+ > AGPL-3. […] Done https://gerrit.osmocom.org/c/osmo-msc/+/30114/comment/ecafb3bd_3a147881 PS1, Line 29: FIXME: I'm not sure about OFR, OHR -- O means octet-aligned?? > in any case, just to be clear: OFR/OHR are not supported in our stack so far. just noting some half knowledge i came across; Related: 3GPP TS 26.103 Mention in 3GPP TS 48.058 9.3.6 Channel Mode and 3GPP TS 48.008 3.2.2.11 Channel Type I wasn't aware yet of this relation: GSM speech full rate version 1: GSM FR. GSM speech full rate version 2: GSM EFR. GSM speech full rate version 3: FR AMR. GSM speech full rate version 4: OFR AMR-WB. GSM speech full rate version 5: FR AMR-WB. GSM speech half rate version 1: GSM HR. GSM speech half rate version 2: not defined in this version of the protocol. GSM speech half rate version 3: HR AMR. GSM speech half rate version 4: OHR AMR-WB. GSM speech half rate version 6: OHR AMR. interesting how "half rate version 5" is skipped without a mention. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaa307be6a8487aa8d4ba7cd59d5c5ef04818a744 Gerrit-Change-Number: 30114 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Mar 2023 04:42:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[XL] Change in osmo-msc[master]: [NOT FOR MERGE] push to debug test error
by neels 07 Mar '23

07 Mar '23

neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31713 ) Change subject: [NOT FOR MERGE] push to debug test error ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I20a1f2d8ad4721eaf3dbc9c82ed9cbb5e5323bb0 Gerrit-Change-Number: 31713 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 0

[XL] Change in osmo-msc[master]: [NOT FOR MERGE] push to debug test error
by neels 07 Mar '23

07 Mar '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31713 ) Change subject: [NOT FOR MERGE] push to debug test error ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: there was a bug in bearer_cap_set_radio(), which failed to stop at the speech_ver=-1 end marker, and picked a different bcap->radio value depending on uninitialized/random memory. It was giving different results based on with or without -fsanitize: succeeded with -fsanitize and failed without. hence the initial build with sanitize succeeded, and 'make distcheck' without sanitize failed. the fix is https://gerrit.osmocom.org/c/osmo-msc/+/30114/3..4 (patch set 4 of 'add codec_mapping.h,.c') -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I20a1f2d8ad4721eaf3dbc9c82ed9cbb5e5323bb0 Gerrit-Change-Number: 31713 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 07 Mar 2023 04:31:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in osmo-msc[master]: [codecs filter] msc_vlr_test_call: test codecs resolution
by neels 07 Mar '23

07 Mar '23

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/31702 to look at the new patch set (#3). Change subject: [codecs filter] msc_vlr_test_call: test codecs resolution ...................................................................... [codecs filter] msc_vlr_test_call: test codecs resolution Show that the codecs filter now works as expected in call messaging. Related: SYS#5066 Change-Id: I879ec61f523ad4ffc69a0b02810591f7c0261ff9 --- M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_call.err M tests/msc_vlr/msc_vlr_tests.c M tests/msc_vlr/msc_vlr_tests.h 4 files changed, 3,728 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/02/31702/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I879ec61f523ad4ffc69a0b02810591f7c0261ff9 Gerrit-Change-Number: 31702 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-msc[master]: HO Req: include IE Codec List (MSC Preferred)
by neels 07 Mar '23

07 Mar '23

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/31704 to look at the new patch set (#2). Change subject: HO Req: include IE Codec List (MSC Preferred) ...................................................................... HO Req: include IE Codec List (MSC Preferred) This will make the 10 inter-MSC HO tests in MSC_Tests.ttcn pass again. Related: OS#5529 Change-Id: Ifcf719c5fc9e11749aafbd97bafda7f6f50973ea --- M src/libmsc/msc_ho.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/04/31704/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ifcf719c5fc9e11749aafbd97bafda7f6f50973ea Gerrit-Change-Number: 31704 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in osmo-msc[master]: add codec_mapping.h,c
by neels 07 Mar '23

07 Mar '23

Attention is currently required from: neels, fixeria. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/30114 to look at the new patch set (#4). Change subject: add codec_mapping.h,c ...................................................................... add codec_mapping.h,c Converting between different codec representations is confusing. This codec mapping provides a consolidated overview of all our codec representations, and how they match up. In particular, it adds the SDP codec representation repertoire, preparing the use of full SDP on the MNCC interface. Related: SYS#5066 Change-Id: Iaa307be6a8487aa8d4ba7cd59d5c5ef04818a744 --- M include/osmocom/msc/Makefile.am A include/osmocom/msc/codec_mapping.h M src/libmsc/Makefile.am A src/libmsc/codec_mapping.c 4 files changed, 605 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/14/30114/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaa307be6a8487aa8d4ba7cd59d5c5ef04818a744 Gerrit-Change-Number: 30114 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0