March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-gprs[master]: llc: Avoid propagating rc=1
by fixeria 10 Mar '23

10 Mar '23

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31809 ) Change subject: llc: Avoid propagating rc=1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31809 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Icdee1cac4df970ae2ee7539d72c5a82667016160 Gerrit-Change-Number: 31809 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Mar 2023 14:27:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: select: Optimize osmo_fd_get_by_fd
by pespin 10 Mar '23

10 Mar '23

Attention is currently required from: osmith, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31808 ) Change subject: select: Optimize osmo_fd_get_by_fd ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > ACK I'll submit a backport for osmo-mgw patch. The osmo-mgw fix was backported and a new release 1.11.1 has been released. This patch can be merged now. File src/core/select.c: https://gerrit.osmocom.org/c/libosmocore/+/31808/comment/a18e2c36_305ad100 PS2, Line 78: 1024B > yes, 1024 bytes = 128 fds in 64bit systems. The idea is to allocate mem blocks which are power of 2. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8b71547df8bed84192cb160479fa3debf9b7eade Gerrit-Change-Number: 31808 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 10 Mar 2023 14:11:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[pespin/1.10.0]: Bump version: 1.11.0.1-ef3e5 → 1.11.1
by pespin 10 Mar '23

10 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31821 ) Change subject: Bump version: 1.11.0.1-ef3e5 → 1.11.1 ...................................................................... Bump version: 1.11.0.1-ef3e5 → 1.11.1 Change-Id: I45b2d09948bb6666c52466b59beb301d8da972c1 --- M debian/changelog 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index bac901e..8b10b49 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +osmo-mgw (1.11.1) unstable; urgency=medium + + * mgcp_network: Unregister osmo_fd before closing fd + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Fri, 10 Mar 2023 14:55:21 +0100 + osmo-mgw (1.11.0) unstable; urgency=medium [ Pau Espin Pedrol ] -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: pespin/1.10.0 Gerrit-Change-Id: I45b2d09948bb6666c52466b59beb301d8da972c1 Gerrit-Change-Number: 31821 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-mgw[pespin/1.10.0]: mgcp_network: Unregister osmo_fd before closing fd
by pespin 10 Mar '23

10 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31820 ) Change subject: mgcp_network: Unregister osmo_fd before closing fd ...................................................................... mgcp_network: Unregister osmo_fd before closing fd (cherry picked from commit 6c303664f5154f22a881f450a7d6d3bbae0ccacc) Change-Id: Id03011a11be17e9c0a53b01444754dd633232d2e --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index d6028a2..af9ae99 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1676,14 +1676,14 @@ void mgcp_free_rtp_port(struct mgcp_rtp_end *end) { if (end->rtp.fd != -1) { + osmo_fd_unregister(&end->rtp); close(end->rtp.fd); end->rtp.fd = -1; - osmo_fd_unregister(&end->rtp); } if (end->rtcp.fd != -1) { + osmo_fd_unregister(&end->rtcp); close(end->rtcp.fd); end->rtcp.fd = -1; - osmo_fd_unregister(&end->rtcp); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31820 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: pespin/1.10.0 Gerrit-Change-Id: Id03011a11be17e9c0a53b01444754dd633232d2e Gerrit-Change-Number: 31820 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-mgw[pespin/1.10.0]: Bump version: 1.11.0.1-ef3e5 → 1.11.1
by pespin 10 Mar '23

10 Mar '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31821 ) Change subject: Bump version: 1.11.0.1-ef3e5 → 1.11.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: pespin/1.10.0 Gerrit-Change-Id: I45b2d09948bb6666c52466b59beb301d8da972c1 Gerrit-Change-Number: 31821 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Mar 2023 14:09:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[pespin/1.10.0]: Bump version: 1.11.0.1-ef3e5 → 1.11.1
by laforge 10 Mar '23

10 Mar '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31821 ) Change subject: Bump version: 1.11.0.1-ef3e5 → 1.11.1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: pespin/1.10.0 Gerrit-Change-Id: I45b2d09948bb6666c52466b59beb301d8da972c1 Gerrit-Change-Number: 31821 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Mar 2023 13:59:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[pespin/1.10.0]: mgcp_network: Unregister osmo_fd before closing fd
by laforge 10 Mar '23

10 Mar '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31820 ) Change subject: mgcp_network: Unregister osmo_fd before closing fd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31820 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: pespin/1.10.0 Gerrit-Change-Id: Id03011a11be17e9c0a53b01444754dd633232d2e Gerrit-Change-Number: 31820 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Mar 2023 13:58:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[pespin/1.10.0]: Bump version: 1.11.0.1-ef3e5 → 1.11.1
by pespin 10 Mar '23

10 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31821 ) Change subject: Bump version: 1.11.0.1-ef3e5 → 1.11.1 ...................................................................... Bump version: 1.11.0.1-ef3e5 → 1.11.1 Change-Id: I45b2d09948bb6666c52466b59beb301d8da972c1 --- M debian/changelog 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/21/31821/1 diff --git a/debian/changelog b/debian/changelog index bac901e..8b10b49 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +osmo-mgw (1.11.1) unstable; urgency=medium + + * mgcp_network: Unregister osmo_fd before closing fd + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Fri, 10 Mar 2023 14:55:21 +0100 + osmo-mgw (1.11.0) unstable; urgency=medium [ Pau Espin Pedrol ] -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: pespin/1.10.0 Gerrit-Change-Id: I45b2d09948bb6666c52466b59beb301d8da972c1 Gerrit-Change-Number: 31821 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-mgw[pespin/1.10.0]: mgcp_network: Unregister osmo_fd before closing fd
by pespin 10 Mar '23

10 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31820 ) Change subject: mgcp_network: Unregister osmo_fd before closing fd ...................................................................... mgcp_network: Unregister osmo_fd before closing fd (cherry picked from commit 6c303664f5154f22a881f450a7d6d3bbae0ccacc) Change-Id: Id03011a11be17e9c0a53b01444754dd633232d2e --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/20/31820/1 diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index d6028a2..af9ae99 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1676,14 +1676,14 @@ void mgcp_free_rtp_port(struct mgcp_rtp_end *end) { if (end->rtp.fd != -1) { + osmo_fd_unregister(&end->rtp); close(end->rtp.fd); end->rtp.fd = -1; - osmo_fd_unregister(&end->rtp); } if (end->rtcp.fd != -1) { + osmo_fd_unregister(&end->rtcp); close(end->rtcp.fd); end->rtcp.fd = -1; - osmo_fd_unregister(&end->rtcp); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31820 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: pespin/1.10.0 Gerrit-Change-Id: Id03011a11be17e9c0a53b01444754dd633232d2e Gerrit-Change-Number: 31820 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bsc[master]: bscc_sccp: Small optimiztion in bsc_sccp_inst_next_conn_id()
by pespin 10 Mar '23

10 Mar '23

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31811 ) Change subject: bscc_sccp: Small optimiztion in bsc_sccp_inst_next_conn_id() ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bsc_sccp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31811/comment/c84d8de7_aa055288 PS1, Line 55: next_id = (next_id + 1) & 0x00FFFFFF; > Looks like you can simply do: `(next_id + 1) % 0x00FFFFFF`? […] I'm not sure doing thousands of modulo operations is actually better than doing an bitwise AND plus a CMP. I could add OSMO_UNLIKELY() around "if (next_id == 0x00FFFFFF)" It is totally possible, since i is range 0..0x00FFFFFE, but next_id may start being any number in that range, so most of the times it will wrap around. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic32b1eeb201fc51110e1ee130110824845f81e82 Gerrit-Change-Number: 31811 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Mar 2023 13:47:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0