March 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: select: Optimize osmo_fd_get_by_fd
by pespin 10 Mar '23

10 Mar '23

Attention is currently required from: osmith, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31808 ) Change subject: select: Optimize osmo_fd_get_by_fd ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Oh sorry I missed that part, I'll do that now. I merged and pushed 1.10.1 now. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8b71547df8bed84192cb160479fa3debf9b7eade Gerrit-Change-Number: 31808 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 10 Mar 2023 15:08:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[pespin/1.10.0]: mgcp_network: Unregister osmo_fd before closing fd
by pespin 10 Mar '23

10 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31823 ) Change subject: mgcp_network: Unregister osmo_fd before closing fd ...................................................................... mgcp_network: Unregister osmo_fd before closing fd (cherry picked from commit 6c303664f5154f22a881f450a7d6d3bbae0ccacc) Change-Id: I2f58dc825de1604fb464858c9cb3b87d029cb4ad --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index bcc6652..31c58c3 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1668,14 +1668,14 @@ void mgcp_free_rtp_port(struct mgcp_rtp_end *end) { if (end->rtp.fd != -1) { + osmo_fd_unregister(&end->rtp); close(end->rtp.fd); end->rtp.fd = -1; - osmo_fd_unregister(&end->rtp); } if (end->rtcp.fd != -1) { + osmo_fd_unregister(&end->rtcp); close(end->rtcp.fd); end->rtcp.fd = -1; - osmo_fd_unregister(&end->rtcp); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31823 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: pespin/1.10.0 Gerrit-Change-Id: I2f58dc825de1604fb464858c9cb3b87d029cb4ad Gerrit-Change-Number: 31823 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-mgw[pespin/1.10.0]: Bump version: 1.10.0.1-fffe → 1.10.1
by pespin 10 Mar '23

10 Mar '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31824 ) Change subject: Bump version: 1.10.0.1-fffe → 1.10.1 ...................................................................... Bump version: 1.10.0.1-fffe → 1.10.1 Change-Id: I727c89731369cc4f1a15b4f6ee9c85ba6b14536a --- M debian/changelog 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index 668c77f..aa18cad 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +osmo-mgw (1.10.1) unstable; urgency=medium + + * mgcp_network: Unregister osmo_fd before closing fd + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Fri, 10 Mar 2023 16:04:04 +0100 + osmo-mgw (1.10.0) unstable; urgency=medium [ Eric ] -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31824 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: pespin/1.10.0 Gerrit-Change-Id: I727c89731369cc4f1a15b4f6ee9c85ba6b14536a Gerrit-Change-Number: 31824 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-mgw[pespin/1.10.0]: Bump version: 1.10.0.1-fffe → 1.10.1
by pespin 10 Mar '23

10 Mar '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31824 ) Change subject: Bump version: 1.10.0.1-fffe → 1.10.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31824 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: pespin/1.10.0 Gerrit-Change-Id: I727c89731369cc4f1a15b4f6ee9c85ba6b14536a Gerrit-Change-Number: 31824 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Mar 2023 15:07:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[pespin/1.10.0]: mgcp_network: Unregister osmo_fd before closing fd
by pespin 10 Mar '23

10 Mar '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31823 ) Change subject: mgcp_network: Unregister osmo_fd before closing fd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31823 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: pespin/1.10.0 Gerrit-Change-Id: I2f58dc825de1604fb464858c9cb3b87d029cb4ad Gerrit-Change-Number: 31823 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Mar 2023 15:07:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[pespin/1.10.0]: mgcp_network: Unregister osmo_fd before closing fd
by pespin 10 Mar '23

10 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31823 ) Change subject: mgcp_network: Unregister osmo_fd before closing fd ...................................................................... mgcp_network: Unregister osmo_fd before closing fd (cherry picked from commit 6c303664f5154f22a881f450a7d6d3bbae0ccacc) Change-Id: I2f58dc825de1604fb464858c9cb3b87d029cb4ad --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/23/31823/1 diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index bcc6652..31c58c3 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1668,14 +1668,14 @@ void mgcp_free_rtp_port(struct mgcp_rtp_end *end) { if (end->rtp.fd != -1) { + osmo_fd_unregister(&end->rtp); close(end->rtp.fd); end->rtp.fd = -1; - osmo_fd_unregister(&end->rtp); } if (end->rtcp.fd != -1) { + osmo_fd_unregister(&end->rtcp); close(end->rtcp.fd); end->rtcp.fd = -1; - osmo_fd_unregister(&end->rtcp); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31823 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: pespin/1.10.0 Gerrit-Change-Id: I2f58dc825de1604fb464858c9cb3b87d029cb4ad Gerrit-Change-Number: 31823 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-mgw[pespin/1.10.0]: Bump version: 1.10.0.1-fffe → 1.10.1
by pespin 10 Mar '23

10 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31824 ) Change subject: Bump version: 1.10.0.1-fffe → 1.10.1 ...................................................................... Bump version: 1.10.0.1-fffe → 1.10.1 Change-Id: I727c89731369cc4f1a15b4f6ee9c85ba6b14536a --- M debian/changelog 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/24/31824/1 diff --git a/debian/changelog b/debian/changelog index 668c77f..aa18cad 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +osmo-mgw (1.10.1) unstable; urgency=medium + + * mgcp_network: Unregister osmo_fd before closing fd + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Fri, 10 Mar 2023 16:04:04 +0100 + osmo-mgw (1.10.0) unstable; urgency=medium [ Eric ] -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31824 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: pespin/1.10.0 Gerrit-Change-Id: I727c89731369cc4f1a15b4f6ee9c85ba6b14536a Gerrit-Change-Number: 31824 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmocore[master]: select: Optimize osmo_fd_get_by_fd
by pespin 10 Mar '23

10 Mar '23

Attention is currently required from: osmith, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31808 ) Change subject: select: Optimize osmo_fd_get_by_fd ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > *for at least the last two releases.* - 1.11.1 is just one. Oh sorry I missed that part, I'll do that now. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8b71547df8bed84192cb160479fa3debf9b7eade Gerrit-Change-Number: 31808 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 10 Mar 2023 14:59:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: constify bsc_conn_by_bsub() ptr param
by pespin 10 Mar '23

10 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31822 ) Change subject: constify bsc_conn_by_bsub() ptr param ...................................................................... constify bsc_conn_by_bsub() ptr param Change-Id: I44b1397e7771c803efdca6bf59750ca5568df365 --- M include/osmocom/bsc/osmo_bsc_sigtran.h M src/osmo-bsc/osmo_bsc_sigtran.c 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/22/31822/1 diff --git a/include/osmocom/bsc/osmo_bsc_sigtran.h b/include/osmocom/bsc/osmo_bsc_sigtran.h index df37cf4..9cc2cfc 100644 --- a/include/osmocom/bsc/osmo_bsc_sigtran.h +++ b/include/osmocom/bsc/osmo_bsc_sigtran.h @@ -26,7 +26,7 @@ /* Allocate resources to make a new connection oriented sigtran connection * (not the connection ittself!) */ enum bsc_con osmo_bsc_sigtran_new_conn(struct gsm_subscriber_connection *conn, struct bsc_msc_data *msc); -struct gsm_subscriber_connection *bsc_conn_by_bsub(struct bsc_subscr *bsub); +struct gsm_subscriber_connection *bsc_conn_by_bsub(const struct bsc_subscr *bsub); /* Open a new connection oriented sigtran connection */ int osmo_bsc_sigtran_open_conn(struct gsm_subscriber_connection *conn, struct msgb *msg); diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index 04c2e99..88ee01c 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -59,7 +59,7 @@ return NULL; } -struct gsm_subscriber_connection *bsc_conn_by_bsub(struct bsc_subscr *bsub) +struct gsm_subscriber_connection *bsc_conn_by_bsub(const struct bsc_subscr *bsub) { struct gsm_subscriber_connection *conn; if (!bsub) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31822 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I44b1397e7771c803efdca6bf59750ca5568df365 Gerrit-Change-Number: 31822 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bsc[master]: Clarify type and values of sccp.conn_id
by pespin 10 Mar '23

10 Mar '23

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31796 to look at the new patch set (#3). Change subject: Clarify type and values of sccp.conn_id ...................................................................... Clarify type and values of sccp.conn_id Currently, the conn_id is allocated in a range 0..0xffffff by bsc_sccp_inst_next_conn_id(), and -1 means it is unset. This means allocation expects "int" to be at least 32 bits integer, in order to fit 24 bits for 0..0xffffff plus the -1. Hence, let's define the variable as uint32_t, as already done in libosmo-sccp. Use last value 0xFFFFFFFF ((uint32_t)-1) and avoid playing with the value being unsigned sometimes and signed only for "unset" value. The value is actually already handled as unsigned (printed with %u) in most places. Change-Id: If019bcbc1e28929fe8d981fef9103835fc6ead2e --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bsc_sccp.c M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/lb.c M src/osmo-bsc/osmo_bsc_sigtran.c 5 files changed, 52 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/96/31796/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31796 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If019bcbc1e28929fe8d981fef9103835fc6ead2e Gerrit-Change-Number: 31796 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0