March 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmocom-bb[master]: layer23: modem: Depend on libosmo-gprs-gmm
by fixeria 15 Mar '23

15 Mar '23

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31923 ) Change subject: layer23: modem: Depend on libosmo-gprs-gmm ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/host/layer23/src/common/Makefile.am: https://gerrit.osmocom.org/c/osmocom-bb/+/31923/comment/0f3bb5ab_1a80d580 PS1, Line 13: LIBOSMOGPRSGMM_CFLAGS > not sure if it's needed here Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I82a2b9c043eae42435ca781689fc3381e7a31bea Gerrit-Change-Number: 31923 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Mar 2023 14:39:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: layer23: modem: Depend on libosmo-gprs-gmm
by pespin 15 Mar '23

15 Mar '23

Attention is currently required from: osmith, pespin, fixeria. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/31923 to look at the new patch set (#2). Change subject: layer23: modem: Depend on libosmo-gprs-gmm ...................................................................... layer23: modem: Depend on libosmo-gprs-gmm Related: OS#5501 Change-Id: I82a2b9c043eae42435ca781689fc3381e7a31bea --- M src/host/layer23/configure.ac M src/host/layer23/include/osmocom/bb/common/logging.h M src/host/layer23/include/osmocom/bb/modem/Makefile.am A src/host/layer23/include/osmocom/bb/modem/gmm.h M src/host/layer23/src/modem/Makefile.am M src/host/layer23/src/modem/app_modem.c A src/host/layer23/src/modem/gmm.c 7 files changed, 125 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/23/31923/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I82a2b9c043eae42435ca781689fc3381e7a31bea Gerrit-Change-Number: 31923 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bts[master]: PCU IF: Update NSE timer field
by arehbein 15 Mar '23

15 Mar '23

Attention is currently required from: pespin, fixeria, dexter. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31885 ) Change subject: PCU IF: Update NSE timer field ...................................................................... Patch Set 1: (1 comment) File include/osmo-bts/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-bts/+/31885/comment/494bf964_a4d25729 PS1, Line 156: PCU_IF_NUM_NSE_TIMERS > Yes let's make this part of the same PCUIF version bump (0x0a->0x0b iirc). Ah of course, didn't think of that @fixeria. Alright @pespin, I'll send dexter a mail and CC you -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7385574ef4bd4529d2e7e3d2000b7a1551ef1fcb Gerrit-Change-Number: 31885 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Mar 2023 14:37:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: layer23: modem: Depend on libosmo-gprs-gmm
by fixeria 15 Mar '23

15 Mar '23

Attention is currently required from: osmith, pespin, fixeria. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31923 ) Change subject: layer23: modem: Depend on libosmo-gprs-gmm ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/common/Makefile.am: https://gerrit.osmocom.org/c/osmocom-bb/+/31923/comment/0bfd2617_f2df40f6 PS1, Line 13: LIBOSMOGPRSGMM_CFLAGS not sure if it's needed here -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I82a2b9c043eae42435ca781689fc3381e7a31bea Gerrit-Change-Number: 31923 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Mar 2023 14:30:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: layer23: modem: Depend on libosmo-gprs-gmm
by pespin 15 Mar '23

15 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31923 ) Change subject: layer23: modem: Depend on libosmo-gprs-gmm ...................................................................... layer23: modem: Depend on libosmo-gprs-gmm Related: OS#5501 Change-Id: I82a2b9c043eae42435ca781689fc3381e7a31bea --- M src/host/layer23/configure.ac M src/host/layer23/include/osmocom/bb/common/logging.h M src/host/layer23/include/osmocom/bb/modem/Makefile.am A src/host/layer23/include/osmocom/bb/modem/gmm.h M src/host/layer23/src/common/Makefile.am M src/host/layer23/src/modem/Makefile.am M src/host/layer23/src/modem/app_modem.c A src/host/layer23/src/modem/gmm.c 8 files changed, 126 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/23/31923/1 diff --git a/src/host/layer23/configure.ac b/src/host/layer23/configure.ac index 459065c..1434fbf 100644 --- a/src/host/layer23/configure.ac +++ b/src/host/layer23/configure.ac @@ -49,6 +49,7 @@ PKG_CHECK_MODULES(LIBOSMOGPRSRLCMAC, libosmo-gprs-rlcmac) PKG_CHECK_MODULES(LIBOSMOGPRSLLC, libosmo-gprs-llc) PKG_CHECK_MODULES(LIBOSMOGPRSSNDCP, libosmo-gprs-sndcp) +PKG_CHECK_MODULES(LIBOSMOGPRSGMM, libosmo-gprs-gmm) AC_CHECK_LIB(gps, gps_waiting, LIBGPS_CFLAGS=" -D_HAVE_GPSD" LIBGPS_LIBS=" -lgps ",,) AC_SUBST([LIBGPS_CFLAGS]) AC_SUBST([LIBGPS_LIBS]) diff --git a/src/host/layer23/include/osmocom/bb/common/logging.h b/src/host/layer23/include/osmocom/bb/common/logging.h index 818b149..fc0861e 100644 --- a/src/host/layer23/include/osmocom/bb/common/logging.h +++ b/src/host/layer23/include/osmocom/bb/common/logging.h @@ -30,6 +30,7 @@ DRLCMAC, DLLC, DSNDCP, + DGMM, }; extern const struct log_info log_info; diff --git a/src/host/layer23/include/osmocom/bb/modem/Makefile.am b/src/host/layer23/include/osmocom/bb/modem/Makefile.am index b2e3059..6dfc98e 100644 --- a/src/host/layer23/include/osmocom/bb/modem/Makefile.am +++ b/src/host/layer23/include/osmocom/bb/modem/Makefile.am @@ -1,5 +1,6 @@ noinst_HEADERS = \ modem.h \ + gmm.h \ grr.h \ llc.h \ rlcmac.h \ diff --git a/src/host/layer23/include/osmocom/bb/modem/gmm.h b/src/host/layer23/include/osmocom/bb/modem/gmm.h new file mode 100644 index 0000000..4ec3e8e --- /dev/null +++ b/src/host/layer23/include/osmocom/bb/modem/gmm.h @@ -0,0 +1,7 @@ +#pragma once + +#include <stdbool.h> + +struct osmocom_ms; + +int modem_gmm_init(struct osmocom_ms *ms); diff --git a/src/host/layer23/src/common/Makefile.am b/src/host/layer23/src/common/Makefile.am index 60af3b8..79a80a1 100644 --- a/src/host/layer23/src/common/Makefile.am +++ b/src/host/layer23/src/common/Makefile.am @@ -10,6 +10,7 @@ $(LIBOSMOGPRSRLCMAC_CFLAGS) \ $(LIBOSMOGPRSLLC_CFLAGS) \ $(LIBOSMOGPRSSNDCP_CFLAGS) \ + $(LIBOSMOGPRSGMM_CFLAGS) \ $(LIBGPS_CFLAGS) \ $(NULL) diff --git a/src/host/layer23/src/modem/Makefile.am b/src/host/layer23/src/modem/Makefile.am index 500b031..086c2f3 100644 --- a/src/host/layer23/src/modem/Makefile.am +++ b/src/host/layer23/src/modem/Makefile.am @@ -11,6 +11,7 @@ $(LIBOSMOGPRSRLCMAC_CFLAGS) \ $(LIBOSMOGPRSLLC_CFLAGS) \ $(LIBOSMOGPRSSNDCP_CFLAGS) \ + $(LIBOSMOGPRSGMM_CFLAGS) \ $(NULL) bin_PROGRAMS = modem @@ -18,6 +19,7 @@ modem_SOURCES = \ $(top_srcdir)/src/common/main.c \ app_modem.c \ + gmm.c \ grr.c \ llc.c \ rlcmac.c \ @@ -32,4 +34,5 @@ $(LIBOSMOGPRSRLCMAC_LIBS) \ $(LIBOSMOGPRSLLC_LIBS) \ $(LIBOSMOGPRSSNDCP_LIBS) \ + $(LIBOSMOGPRSGMM_LIBS) \ $(NULL) diff --git a/src/host/layer23/src/modem/app_modem.c b/src/host/layer23/src/modem/app_modem.c index e33ad6a..58328c2 100644 --- a/src/host/layer23/src/modem/app_modem.c +++ b/src/host/layer23/src/modem/app_modem.c @@ -50,6 +50,7 @@ #include <osmocom/bb/modem/rlcmac.h> #include <osmocom/bb/modem/llc.h> #include <osmocom/bb/modem/sndcp.h> +#include <osmocom/bb/modem/gmm.h> #include <osmocom/bb/modem/vty.h> #include <osmocom/bb/modem/grr.h> @@ -174,6 +175,11 @@ return rc; } + if ((rc = modem_gmm_init(app_data.ms))) { + LOGP(DGMM, LOGL_FATAL, "Failed initializing GMM layer\n"); + return rc; + } + osmo_signal_register_handler(SS_L1CTL, &signal_cb, NULL); lapdm_channel_set_l3(&app_data.ms->lapdm_channel, &modem_grr_rslms_cb, app_data.ms); return 0; diff --git a/src/host/layer23/src/modem/gmm.c b/src/host/layer23/src/modem/gmm.c new file mode 100644 index 0000000..6a84909 --- /dev/null +++ b/src/host/layer23/src/modem/gmm.c @@ -0,0 +1,96 @@ +/* GPRS GMM interfaces as per 3GPP TS 24.008, TS 24.007 */ +/* (C) 2023 by sysmocom - s.m.f.c. GmbH <info(a)sysmocom.de> + * All Rights Reserved + * Author: Pau Espin Pedrol <pespin(a)sysmocom.de> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/lienses/>. + * + */ + +#include <stdbool.h> +#include <string.h> +#include <stdint.h> +#include <errno.h> +#include <stdio.h> + +#include <osmocom/core/msgb.h> +#include <osmocom/core/prim.h> +#include <osmocom/core/utils.h> +#include <osmocom/core/linuxlist.h> +#include <osmocom/core/talloc.h> +#include <osmocom/core/tun.h> + +#include <osmocom/gprs/llc/llc.h> +#include <osmocom/gprs/llc/llc_prim.h> +#include <osmocom/gprs/gmm/gmm_prim.h> +#include <osmocom/gprs/gmm/gmm.h> + +#include <osmocom/bb/common/settings.h> +#include <osmocom/bb/common/logging.h> +#include <osmocom/bb/common/apn.h> +#include <osmocom/bb/common/ms.h> +#include <osmocom/bb/modem/gmm.h> + + +static int modem_gmm_prim_up_cb(struct osmo_gprs_gmm_prim *gmm_prim, void *user_data) +{ + const char *pdu_name = osmo_gprs_gmm_prim_name(gmm_prim); + int rc = 0; + + switch (gmm_prim->oph.sap) { + case OSMO_GPRS_GMM_SAP_GMMREG: + switch (OSMO_PRIM_HDR(&gmm_prim->oph)) { + case OSMO_PRIM(OSMO_GPRS_GMM_GMMREG_ATTACH, PRIM_OP_CONFIRM): + case OSMO_PRIM(OSMO_GPRS_GMM_GMMREG_DETACH, PRIM_OP_CONFIRM): + case OSMO_PRIM(OSMO_GPRS_GMM_GMMREG_DETACH, PRIM_OP_INDICATION): + default: + LOGP(DGMM, LOGL_ERROR, "%s(): Rx %s UNIMPLEMENTED\n", __func__, pdu_name); + break; + }; + default: + LOGP(DGMM, LOGL_ERROR, "%s(): Unexpected Rx %s\n", __func__, pdu_name); + OSMO_ASSERT(0); + } + + return rc; +} + +static int modem_gmm_prim_down_cb(struct osmo_gprs_gmm_prim *gmm_prim, void *user_data) +{ + const char *pdu_name = osmo_gprs_gmm_prim_name(gmm_prim); + int rc = 0; + + switch (gmm_prim->oph.sap) { + case OSMO_GPRS_GMM_SAP_GMMREG: + default: + LOGP(DGMM, LOGL_ERROR, "%s(): Unexpected Rx %s\n", __func__, pdu_name); + OSMO_ASSERT(0); + } + + return rc; +} + +int modem_gmm_init(struct osmocom_ms *ms) +{ + int rc; + rc = osmo_gprs_gmm_init(OSMO_GPRS_GMM_LOCATION_MS); + if (rc != 0) + return rc; + + osmo_gprs_gmm_set_log_cat(OSMO_GPRS_GMM_LOGC_GMM, DGMM); + + osmo_gprs_gmm_prim_set_up_cb(modem_gmm_prim_up_cb, ms); + osmo_gprs_gmm_prim_set_down_cb(modem_gmm_prim_down_cb, ms); + return rc; +} -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I82a2b9c043eae42435ca781689fc3381e7a31bea Gerrit-Change-Number: 31923 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-upf[master]: scale: faster lookup whether local TEID is in use
by neels 15 Mar '23

15 Mar '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31485 ) Change subject: scale: faster lookup whether local TEID is in use ...................................................................... Patch Set 2: (1 comment) File include/osmocom/upf/up_session.h: https://gerrit.osmocom.org/c/osmo-upf/+/31485/comment/b99d7221_917ce56e PS2, Line 105: /* hashtable entry for g_upf->pdr_by_local_teid */ g_upf->gtp.pdr_by_local_teid -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I920bb14da434ac29fcd49d95d207081bacb3d661 Gerrit-Change-Number: 31485 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 15 Mar 2023 14:02:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-upf[master]: scale: tunmap: faster lookup of used nft chain_id
by neels 15 Mar '23

15 Mar '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31484 ) Change subject: scale: tunmap: faster lookup of used nft chain_id ...................................................................... Patch Set 2: (3 comments) File include/osmocom/upf/up_gtp_action.h: https://gerrit.osmocom.org/c/osmo-upf/+/31484/comment/a6e72ede_1465b501 PS2, Line 51: /* entry in hash table up_endpoint->gtp_actions_by_chain_id */ nope, it's g_upf->tunmap.nft_tun_by_chain_id ... and this hlist_node is a stray leftover from an earlier patch version and should not be here at all File src/osmo-upf/upf.c: https://gerrit.osmocom.org/c/osmo-upf/+/31484/comment/437721d0_ea98213f PS2, Line 178: taken = true; break; File src/osmo-upf/upf_nft.c: https://gerrit.osmocom.org/c/osmo-upf/+/31484/comment/100694ba_b82e27c1 PS2, Line 372: hlist_del(&tun->node_by_chain_id); tun->chain_id = 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I36a75ec4698cd83558185c1f202400eb53ae8ff6 Gerrit-Change-Number: 31484 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 15 Mar 2023 13:58:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in osmo-upf[master]: add unique_ids_test.c
by neels 15 Mar '23

15 Mar '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31482 ) Change subject: add unique_ids_test.c ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > hmm after the retriggers all failed, i guess just include libosmogsm in the Makefile. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I36acff15f22d23ade4d281c2af3eb117dfc10359 Gerrit-Change-Number: 31482 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 15 Mar 2023 13:45:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-upf[master]: build: drop LIBOSMO_GTLV
by neels 15 Mar '23

15 Mar '23

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31919 ) Change subject: build: drop LIBOSMO_GTLV ...................................................................... build: drop LIBOSMO_GTLV After libosmo-gtlv was dropped from configure.ac in 22006ba039b26514ce194ccae924ecaa50bea89e, these $(LIBOSMO_GTLV_*) are empty anyway. Since we depend on libosmo-pfcp, there is no need to list libosmo-gtlv, which should be implicitly included. Change-Id: I3acd3d674e226b004101d65d47beacbbdeed0466 --- M src/osmo-pfcp-tool/Makefile.am M src/osmo-upf/Makefile.am 2 files changed, 16 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-pfcp-tool/Makefile.am b/src/osmo-pfcp-tool/Makefile.am index 6c23d9f..a35c59a 100644 --- a/src/osmo-pfcp-tool/Makefile.am +++ b/src/osmo-pfcp-tool/Makefile.am @@ -10,7 +10,6 @@ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOVTY_CFLAGS) \ $(LIBOSMOCTRL_CFLAGS) \ - $(LIBOSMOGTLV_CFLAGS) \ $(LIBOSMOPFCP_CFLAGS) \ $(COVERAGE_CFLAGS) \ $(NULL) @@ -19,7 +18,6 @@ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOVTY_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOGTLV_LIBS) \ $(LIBOSMOPFCP_LIBS) \ $(COVERAGE_LDFLAGS) \ $(NULL) diff --git a/src/osmo-upf/Makefile.am b/src/osmo-upf/Makefile.am index 403fb06..d5e392b 100644 --- a/src/osmo-upf/Makefile.am +++ b/src/osmo-upf/Makefile.am @@ -10,7 +10,6 @@ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOVTY_CFLAGS) \ $(LIBOSMOCTRL_CFLAGS) \ - $(LIBOSMOGTLV_CFLAGS) \ $(LIBOSMOPFCP_CFLAGS) \ $(LIBGTPNL_CFLAGS) \ $(LIBNFTNL_CFLAGS) \ @@ -47,7 +46,6 @@ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOVTY_LIBS) \ $(LIBOSMOCTRL_LIBS) \ - $(LIBOSMOGTLV_LIBS) \ $(LIBOSMOPFCP_LIBS) \ $(LIBGTPNL_LIBS) \ $(LIBNFTNL_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31919 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3acd3d674e226b004101d65d47beacbbdeed0466 Gerrit-Change-Number: 31919 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[XL] Change in osmo-upf[master]: add unique_ids_test.c
by neels 15 Mar '23

15 Mar '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31482 ) Change subject: add unique_ids_test.c ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: heureka and thank goodness that this rabbit hole is finally mended -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I36acff15f22d23ade4d281c2af3eb117dfc10359 Gerrit-Change-Number: 31482 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 15 Mar 2023 13:42:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0