neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31484 ) Change subject: scale: tunmap: faster lookup of used nft chain_id ...................................................................... Patch Set 2: (3 comments) File include/osmocom/upf/up_gtp_action.h: https://gerrit.osmocom.org/c/osmo-upf/+/31484/comment/a6e72ede_1465b501 PS2, Line 51: /* entry in hash table up_endpoint->gtp_actions_by_chain_id */ nope, it's g_upf->tunmap.nft_tun_by_chain_id ... and this hlist_node is a stray leftover from an earlier patch version and should not be here at all File src/osmo-upf/upf.c: https://gerrit.osmocom.org/c/osmo-upf/+/31484/comment/437721d0_ea98213f PS2, Line 178: taken = true; break; File src/osmo-upf/upf_nft.c: https://gerrit.osmocom.org/c/osmo-upf/+/31484/comment/100694ba_b82e27c1 PS2, Line 372: hlist_del(&tun->node_by_chain_id); tun->chain_id = 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I36a75ec4698cd83558185c1f202400eb53ae8ff6 Gerrit-Change-Number: 31484 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Wed, 15 Mar 2023 13:58:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment