March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: mgw_fsm: fix log line
by dexter 20 Mar '23

20 Mar '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31988 to look at the new patch set (#2). Change subject: mgw_fsm: fix log line ...................................................................... mgw_fsm: fix log line The function name mentioned in the log line does not match the actual function name. Change-Id: Iefc005f10e3c8f165c5686781747460a10ada1e0 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/88/31988/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31988 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iefc005f10e3c8f165c5686781747460a10ada1e0 Gerrit-Change-Number: 31988 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-hnbgw[master]: mgw_fsm: fix typo
by dexter 20 Mar '23

20 Mar '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31987 to look at the new patch set (#2). Change subject: mgw_fsm: fix typo ...................................................................... mgw_fsm: fix typo Change-Id: I16ee37bbfda01b541ad7a6f5269689c4b9e92c8c --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/87/31987/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31987 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I16ee37bbfda01b541ad7a6f5269689c4b9e92c8c Gerrit-Change-Number: 31987 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-hnbgw[master]: mgw_fsm: refactor helper function handle_rab_release()
by dexter 20 Mar '23

20 Mar '23

Attention is currently required from: neels. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31989 to look at the new patch set (#3). Change subject: mgw_fsm: refactor helper function handle_rab_release() ...................................................................... mgw_fsm: refactor helper function handle_rab_release() the function handle_rab_release() is difficult to read and it is not immediately clear what happens and why. Lets split this up and add some comments to improve this. Related: OS#5916 Change-Id: I3595502b98ea5febbde7f2fab3999e2533766b48 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 47 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/89/31989/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31989 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3595502b98ea5febbde7f2fab3999e2533766b48 Gerrit-Change-Number: 31989 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: gsm_bts_check_ny1: Prevent possible division by zero
by dexter 20 Mar '23

20 Mar '23

Attention is currently required from: arehbein. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31972 ) Change subject: gsm_bts_check_ny1: Prevent possible division by zero ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1fd0b92ab507a58fed6e9649eaa4770f1ad1cbad Gerrit-Change-Number: 31972 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Mar 2023 15:43:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: gsm_bts_check_ny1: Prevent possible division by zero
by arehbein 20 Mar '23

20 Mar '23

Attention is currently required from: arehbein. Hello Jenkins Builder, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31972 to look at the new patch set (#2). Change subject: gsm_bts_check_ny1: Prevent possible division by zero ...................................................................... gsm_bts_check_ny1: Prevent possible division by zero Do this by setting the minimal value for T3105 to 1 in its timer definition. Fixes: Coverity scan CID#307389 Change-Id: I1fd0b92ab507a58fed6e9649eaa4770f1ad1cbad --- M src/osmo-bsc/net_init.c M tests/timer.vty 2 files changed, 16 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/72/31972/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1fd0b92ab507a58fed6e9649eaa4770f1ad1cbad Gerrit-Change-Number: 31972 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-hnbgw[master]: mgw_fsm: refactor helper function handle_rab_release()
by dexter 20 Mar '23

20 Mar '23

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31989 to look at the new patch set (#2). Change subject: mgw_fsm: refactor helper function handle_rab_release() ...................................................................... mgw_fsm: refactor helper function handle_rab_release() the function handle_rab_release() is difficult to read and it is not immediately clear what happens and why. Lets split this up and add some comments to improve this. Related: OS#5916 Change-Id: I3595502b98ea5febbde7f2fab3999e2533766b48 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 47 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/89/31989/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31989 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3595502b98ea5febbde7f2fab3999e2533766b48 Gerrit-Change-Number: 31989 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-upf[master]: up_session: Silence coverity warning
by arehbein 20 Mar '23

20 Mar '23

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31971 ) Change subject: up_session: Silence coverity warning ...................................................................... up_session: Silence coverity warning Coverity complains about a supposedly missing NULL check for the pointer 'pdr', that check however happens before the function in question is called. It makes sense to be consistent inside the function, so remove the NULL check before calling 'pdr_del', because we don't NULL check anywhere else in the function either. Fixes: Coverity scan CID#307494 Change-Id: Ia33e4211b4a24abc87c3c2ceffe807ca3322f29d --- M src/osmo-upf/up_session.c 1 file changed, 17 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve arehbein: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-upf/up_session.c b/src/osmo-upf/up_session.c index 1438cce..928db0b 100644 --- a/src/osmo-upf/up_session.c +++ b/src/osmo-upf/up_session.c @@ -556,8 +556,7 @@ return pdr; nack_resp: - if (pdr) - pdr_del(pdr); + pdr_del(pdr); if (!*offending_ie_present) { *offending_ie = OSMO_PFCP_IEI_UPD_PDR; *offending_ie_present = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ia33e4211b4a24abc87c3c2ceffe807ca3322f29d Gerrit-Change-Number: 31971 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-upf[master]: up_session: Silence coverity warning
by arehbein 20 Mar '23

20 Mar '23

Attention is currently required from: neels. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31971 ) Change subject: up_session: Silence coverity warning ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ia33e4211b4a24abc87c3c2ceffe807ca3322f29d Gerrit-Change-Number: 31971 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Mar 2023 15:17:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-upf[master]: osmo-pfcp-tool: Fix call to strerror
by arehbein 20 Mar '23

20 Mar '23

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/31970 ) Change subject: osmo-pfcp-tool: Fix call to strerror ...................................................................... osmo-pfcp-tool: Fix call to strerror Fixes: Coverity scan CID#307499 Change-Id: I91a4116e7cf3721771cea3af82328cf02f1cfc14 --- M src/osmo-pfcp-tool/pfcp_tool_vty.c 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-pfcp-tool/pfcp_tool_vty.c b/src/osmo-pfcp-tool/pfcp_tool_vty.c index dd76f9e..57968ef 100644 --- a/src/osmo-pfcp-tool/pfcp_tool_vty.c +++ b/src/osmo-pfcp-tool/pfcp_tool_vty.c @@ -99,7 +99,7 @@ if (rc) { vty_out(vty, "Failed to bind PFCP endpoint on %s: %s%s\n", osmo_sockaddr_to_str_c(OTC_SELECT, osmo_pfcp_endpoint_get_local_addr(g_pfcp_tool->ep)), - strerror(rc), VTY_NEWLINE); + strerror(-rc), VTY_NEWLINE); return CMD_WARNING; } return CMD_SUCCESS; -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/31970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I91a4116e7cf3721771cea3af82328cf02f1cfc14 Gerrit-Change-Number: 31970 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-hnbgw[master]: mgw_fsm: refactor helper function handle_rab_release()
by Jenkins Builder 20 Mar '23

20 Mar '23

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31989 ) Change subject: mgw_fsm: refactor helper function handle_rab_release() ...................................................................... Patch Set 1: (1 comment) File src/osmo-hnbgw/mgw_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5274): https://gerrit.osmocom.org/c/osmo-hnbgw/+/31989/comment/d78fac68_1f2e48ab PS1, Line 656: static bool is_our_rab_release(struct hnbgw_context_map *map, ranap_message *message) { open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31989 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3595502b98ea5febbde7f2fab3999e2533766b48 Gerrit-Change-Number: 31989 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 20 Mar 2023 15:11:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0