March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: osmo-bts-virtual: properly handle dynamic TS in vbts_set_ts()
by osmith 20 Mar '23

20 Mar '23

Attention is currently required from: laforge, fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31977 ) Change subject: osmo-bts-virtual: properly handle dynamic TS in vbts_set_ts() ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31977 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5db5b7dd6a8e84cf9a0d84f04a650c2ed8a4e368 Gerrit-Change-Number: 31977 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)gnumonks.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)gnumonks.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Mar 2023 16:17:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: scheduler: log pchan value in trx_sched_set_pchan()
by osmith 20 Mar '23

20 Mar '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31976 ) Change subject: scheduler: log pchan value in trx_sched_set_pchan() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia31e53552208a9d57e2fc5473440840d38945d00 Gerrit-Change-Number: 31976 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Mar 2023 16:14:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: osmo-bts-virtual: properly handle dynamic TS in vbts_set_ts()
by fixeria 20 Mar '23

20 Mar '23

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31977 ) Change subject: osmo-bts-virtual: properly handle dynamic TS in vbts_set_ts() ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/31977/comment/a0245120_48e50bec PS3, Line 9: fixes support of dynamic timeslots in osmo-bts-virtual > This might sound way too optimistic. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31977 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5db5b7dd6a8e84cf9a0d84f04a650c2ed8a4e368 Gerrit-Change-Number: 31977 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 20 Mar 2023 16:09:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: osmo-bts-virtual: properly handle dynamic TS in vbts_set_ts()
by fixeria 20 Mar '23

20 Mar '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/31977 to look at the new patch set (#4). Change subject: osmo-bts-virtual: properly handle dynamic TS in vbts_set_ts() ...................................................................... osmo-bts-virtual: properly handle dynamic TS in vbts_set_ts() This change fixes a problem that prevents osmo-bts-virtual from starting when dynamic (ipa/osmo) timeslots are in use. Change-Id: I5db5b7dd6a8e84cf9a0d84f04a650c2ed8a4e368 --- M src/osmo-bts-virtual/bts_model.c 1 file changed, 35 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/77/31977/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31977 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5db5b7dd6a8e84cf9a0d84f04a650c2ed8a4e368 Gerrit-Change-Number: 31977 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmocom-bb[master]: l1gprs: fix NULL pointer dereference in l1gprs_unregister_tbf()
by fixeria 20 Mar '23

20 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31969 ) Change subject: l1gprs: fix NULL pointer dereference in l1gprs_unregister_tbf() ...................................................................... l1gprs: fix NULL pointer dereference in l1gprs_unregister_tbf() Change-Id: Ie3e7b5a8a205d4410de458dec2fde466493d31ce Related: CID#311449 --- M src/shared/l1gprs.c 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/shared/l1gprs.c b/src/shared/l1gprs.c index 3babd2b..5874b48 100644 --- a/src/shared/l1gprs.c +++ b/src/shared/l1gprs.c @@ -136,7 +136,7 @@ if (tbf == NULL) { LOGP_GPRS(gprs, LOGL_ERROR, "%s(): " LOG_TBF_FMT " not found\n", - __func__, LOG_TBF_ARGS(tbf)); + __func__, uplink ? 'U' : 'D', tbf_ref); return; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie3e7b5a8a205d4410de458dec2fde466493d31ce Gerrit-Change-Number: 31969 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[L] Change in osmo-msc[master]: [codecs filter] send + receive SDP via MNCC
by dexter 20 Mar '23

20 Mar '23

Attention is currently required from: neels, laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31698 ) Change subject: [codecs filter] send + receive SDP via MNCC ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31698 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie0668c0e079ec69da1532b52d00621efe114fc2c Gerrit-Change-Number: 31698 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 20 Mar 2023 16:03:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: l1gprs: fix NULL pointer dereference in l1gprs_unregister_tbf()
by osmith 20 Mar '23

20 Mar '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31969 ) Change subject: l1gprs: fix NULL pointer dereference in l1gprs_unregister_tbf() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie3e7b5a8a205d4410de458dec2fde466493d31ce Gerrit-Change-Number: 31969 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Mar 2023 16:03:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: l1ctl_proto: fix unpacked struct in l1ctl_gprs_dl_block_ind
by fixeria 20 Mar '23

20 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31968 ) Change subject: l1ctl_proto: fix unpacked struct in l1ctl_gprs_dl_block_ind ...................................................................... l1ctl_proto: fix unpacked struct in l1ctl_gprs_dl_block_ind The __attribute__((packed)) does not apply to inner structures. I found this problem when testing the new TTCN-3 message definitions. Change-Id: I90e74330073a9090c2638fc3175ff0216b0da5ec Related: OS#5500 --- M include/l1ctl_proto.h 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve dexter: Looks good to me, approved diff --git a/include/l1ctl_proto.h b/include/l1ctl_proto.h index 9bf40d2..3512424 100644 --- a/include/l1ctl_proto.h +++ b/include/l1ctl_proto.h @@ -376,7 +376,7 @@ /* payload of L1CTL_GPRS_DL_BLOCK_IND */ struct l1ctl_gprs_dl_block_ind { struct l1ctl_gprs_block_hdr hdr; - struct { + struct __attribute__((packed)) { uint16_t ber10k; /* Bit Error Rate */ int16_t ci_cb; /* C/I in centiBels */ uint8_t rx_lev; /* RxLev 0..63 */ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31968 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I90e74330073a9090c2638fc3175ff0216b0da5ec Gerrit-Change-Number: 31968 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[L] Change in osmo-bts[master]: contrib: Add BER testing tool
by fixeria 20 Mar '23

20 Mar '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31967 ) Change subject: contrib: Add BER testing tool ...................................................................... Patch Set 4: (2 comments) File contrib/ber/Makefile.am: https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/45a0e367_45a1dde3 PS3, Line 23: codec_bit_class.h > You need to add this file to `DISTCLEANFILES` and `BUILT_SOURCES`. […] Done https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/56997488_cf2667be PS3, Line 24: ./$< > $@ > cosmetic: prefix with `$(AM_V_GEN)` like we do in libosmocore. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1cffa0ae959e29ec61775b13185fd1057ed7485a Gerrit-Change-Number: 31967 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: tnt <tnt(a)246tNt.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 20 Mar 2023 15:59:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: l1ctl_proto: fix unpacked struct in l1ctl_gprs_dl_block_ind
by dexter 20 Mar '23

20 Mar '23

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31968 ) Change subject: l1ctl_proto: fix unpacked struct in l1ctl_gprs_dl_block_ind ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31968 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I90e74330073a9090c2638fc3175ff0216b0da5ec Gerrit-Change-Number: 31968 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Mar 2023 15:49:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0