February 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: add API for generating Session-Id AVP

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31455 ) Change subject: library/DIAMETER_Emulation: add API for generating Session-Id AVP ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0fbd271ad123e9663aab5163915e1edbf5915bb6 Gerrit-Change-Number: 31455 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 22 Feb 2023 12:25:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[M] Change in osmo-mgw[master]: mgcp_e1: be more frugal withe E1 line resources

by osmith

Attention is currently required from: pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31269 ) Change subject: mgcp_e1: be more frugal withe E1 line resources ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie6a32abbc5cd984f6d72a384e3b47c1b82ce7058 Gerrit-Change-Number: 31269 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Feb 2023 12:15:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: deps/Makefile: replace git://git.osmocom.org urls

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31447 ) Change subject: deps/Makefile: replace git://git.osmocom.org urls ...................................................................... deps/Makefile: replace git://git.osmocom.org urls Change-Id: I49d4ee141eb97ac58c0aff493531f120b21bb22d --- M deps/Makefile 1 file changed, 21 insertions(+), 7 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/deps/Makefile b/deps/Makefile index 83ce761..d7e3dd4 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -15,7 +15,8 @@ ECLIPSEGITLAB:=https://gitlab.eclipse.org/eclipse/titan OSMOGITHUB:=https://github.com/osmocom -OSMOGIT:=git://git.osmocom.org +OSMOGERRIT:=https://gerrit.osmocom.org +OSMOGITEA:=https://gitea.osmocom.org/ttcn3 ECLIPSEGITLAB_REPOS= titan.Libraries.TCCUsefulFunctions \ titan.ProtocolEmulations.M3UA \ @@ -66,12 +67,13 @@ titan.ProtocolEmulations.SCCP \ titan.ProtocolModules.BSSGP_v13.0.0 -OSMOGIT_REPOS= titan.ProtocolModules.MAP \ - titan.ProtocolModules.BSSMAP \ - titan.TestPorts.USB \ - titan.TestPorts.AF_PACKET \ +OSMOGERRIT_REPOS= titan.ProtocolModules.BSSMAP \ osmo-uecups +OSMOGITEA_REPOS= titan.ProtocolModules.MAP \ + titan.TestPorts.USB \ + titan.TestPorts.AF_PACKET + ALL_REPOS=$(ECLIPSEGITLAB_REPOS) $(OSMOGITHUB_REPOS) $(OSMOGIT_REPOS) $(FORKEDGITLAB_REPOS) # Tag names from 'git-describe --tags'; if not available, a commit hash may be used instead. @@ -187,8 +189,11 @@ $(foreach dir,$(OSMOGITHUB_REPOS), \ $(eval $(call GIT_template,$(dir),$(OSMOGITHUB)))) -$(foreach dir,$(OSMOGIT_REPOS), \ - $(eval $(call GIT_template,$(dir),$(OSMOGIT)))) +$(foreach dir,$(OSMOGERRIT_REPOS), \ + $(eval $(call GIT_template,$(dir),$(OSMOGERRIT)))) + +$(foreach dir,$(OSMOGITEA_REPOS), \ + $(eval $(call GIT_template,$(dir),$(OSMOGITEA)))) $(foreach dir,$(FORKEDGITLAB_REPOS), \ $(eval $(call GIT_template,$(dir),$(FORKEDGITLAB)))) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49d4ee141eb97ac58c0aff493531f120b21bb22d Gerrit-Change-Number: 31447 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[M] Change in osmo-mgw[master]: mgcp_e1: be more frugal withe E1 line resources

by dexter

Attention is currently required from: osmith, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31269 ) Change subject: mgcp_e1: be more frugal withe E1 line resources ...................................................................... Patch Set 6: (1 comment) File include/osmocom/mgcp/mgcp_trunk.h: https://gerrit.osmocom.org/c/osmo-mgw/+/31269/comment/0057b4db_5e8639b6 PS5, Line 69: uint8_t ts_in_use[NUM_E1_TS-1]; > I first thought this was holding a ts_nr on each array field. It's actually a counter. […] I have renamed it now to "ts_usecount". I think that matches the reality best. The name "ts_in_use" is from the time where we didn't count the number of used. It was just a flag to know that this timeslot is already set up so we won't go through the initialization twice. This is now changed and we properly count the uses of the TS. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie6a32abbc5cd984f6d72a384e3b47c1b82ce7058 Gerrit-Change-Number: 31269 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Feb 2023 12:03:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[M] Change in osmo-mgw[master]: mgcp_e1: be more frugal withe E1 line resources

by dexter

Attention is currently required from: osmith, pespin. Hello osmith, Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/31269 to look at the new patch set (#6). Change subject: mgcp_e1: be more frugal withe E1 line resources ...................................................................... mgcp_e1: be more frugal withe E1 line resources At the moment we open an E1 timeslot when needed, but we never close it even when it is not needed anymore. This may block other entities from using it. Lets add some logic to detect whether the E1 timeslot is still needed and make sure that it is closed when it is no longer needed. Depends: libosmo-abis.git I073cfaba0d5073447842f22665e213135ea3f635 Change-Id: Ie6a32abbc5cd984f6d72a384e3b47c1b82ce7058 Related: OS#5198 --- M include/osmocom/mgcp/mgcp_e1.h M include/osmocom/mgcp/mgcp_trunk.h M src/libosmo-mgcp/mgcp_e1.c M src/libosmo-mgcp/mgcp_endp.c 4 files changed, 95 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/69/31269/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie6a32abbc5cd984f6d72a384e3b47c1b82ce7058 Gerrit-Change-Number: 31269 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: deps/Makefile: replace git://git.osmocom.org urls

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31447 ) Change subject: deps/Makefile: replace git://git.osmocom.org urls ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31447 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49d4ee141eb97ac58c0aff493531f120b21bb22d Gerrit-Change-Number: 31447 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Feb 2023 11:59:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: bts_features: Add features for HR formats (TS 101813 vs. RFC5993)

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/31415 to look at the new patch set (#2). Change subject: bts_features: Add features for HR formats (TS 101813 vs. RFC5993) ...................................................................... bts_features: Add features for HR formats (TS 101813 vs. RFC5993) Related: OS#5688 Change-Id: I05e4ed7a85f3a0451de7cd07380503a7ac76d043 --- M include/osmocom/gsm/bts_features.h 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/15/31415/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I05e4ed7a85f3a0451de7cd07380503a7ac76d043 Gerrit-Change-Number: 31415 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: i460_mux: add define constant for maximum number of subchannels

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31456 ) Change subject: i460_mux: add define constant for maximum number of subchannels ...................................................................... i460_mux: add define constant for maximum number of subchannels Lets get rid of the magic number in struct osmo_i460_timeslot and replace it with a define constant. Change-Id: Id3a3782927c7dcbc873223d56129f291c04fee26 Related: OS#5198 --- M include/osmocom/isdn/i460_mux.h 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/56/31456/1 diff --git a/include/osmocom/isdn/i460_mux.h b/include/osmocom/isdn/i460_mux.h index ad9cb24..537e325 100644 --- a/include/osmocom/isdn/i460_mux.h +++ b/include/osmocom/isdn/i460_mux.h @@ -22,6 +22,8 @@ #include <osmocom/core/linuxlist.h> #include <osmocom/core/msgb.h> +#define OSMO_I460_NUM_SUBCHAN 8 + /* I.460 sub-slot rate */ enum osmo_i460_rate { OSMO_I460_RATE_NONE, /* disabled */ @@ -69,7 +71,7 @@ }; struct osmo_i460_timeslot { - struct osmo_i460_subchan schan[8]; + struct osmo_i460_subchan schan[OSMO_I460_NUM_SUBCHAN]; }; /*! description of a sub-channel; passed by caller */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31456 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id3a3782927c7dcbc873223d56129f291c04fee26 Gerrit-Change-Number: 31456 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/DIAMETER_Emulation: add API for generating Session-Id AVP

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31455 ) Change subject: library/DIAMETER_Emulation: add API for generating Session-Id AVP ...................................................................... library/DIAMETER_Emulation: add API for generating Session-Id AVP Change-Id: I0fbd271ad123e9663aab5163915e1edbf5915bb6 Related: SYS#6343, SYS#5602 --- M library/DIAMETER_Emulation.ttcn 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/55/31455/1 diff --git a/library/DIAMETER_Emulation.ttcn b/library/DIAMETER_Emulation.ttcn index 6eb72ad..2a7bbd0 100644 --- a/library/DIAMETER_Emulation.ttcn +++ b/library/DIAMETER_Emulation.ttcn @@ -86,6 +86,10 @@ /* test port for unit data messages */ port DIAMETER_PT DIAMETER_UNIT; + /* monotonically increasing 64-bit value for Session-Id AVP */ + var uint32_t g_sess_id_seed_h32; + var uint32_t g_sess_id_seed_l32; + var charstring g_diameter_id; var integer g_diameter_conn_id := -1; } @@ -307,6 +311,10 @@ DIAMETER_UNIT.send(DiameterCapabilityExchgInd:{rx := rsp, tx := valueof(req)}); } + /* Init seed for Session-Id AVP: randomize the high 32 bits */ + g_sess_id_seed_h32 := f_rnd_int(c_UINT32_MAX); + g_sess_id_seed_l32 := 0; + while (true) { var DIAMETER_ConnHdlr vc_conn; var template IMSI imsi_t; @@ -314,6 +322,7 @@ var DIAMETER_RecvFrom mrf; var PDU_DIAMETER msg; var charstring vlr_name, mme_name; + var charstring identity; var PortEvent port_evt; alt { @@ -381,6 +390,14 @@ f_create_expect(imsi, vc_conn); DIAMETER_PROC.reply(DIAMETEREM_register:{imsi, vc_conn}) to vc_conn; } + [] DIAMETER_PROC.getcall(DIAMETEREM_gen_sess_id:{?,?}) -> param(identity) { + var charstring sess_id := identity & ";" & int2str(g_sess_id_seed_h32) + & ";" & int2str(g_sess_id_seed_l32); + if (g_sess_id_seed_l32 == c_UINT32_MAX) + { g_sess_id_seed_h32 := g_sess_id_seed_h32 + 1; } + g_sess_id_seed_l32 := g_sess_id_seed_l32 + 1; + DIAMETER_PROC.reply(DIAMETEREM_gen_sess_id:{identity, sess_id}); + } } @@ -395,9 +412,11 @@ } signature DIAMETEREM_register(in hexstring imsi, in DIAMETER_ConnHdlr hdlr); +signature DIAMETEREM_gen_sess_id(in charstring identity, out charstring sess_id); type port DIAMETEREM_PROC_PT procedure { inout DIAMETEREM_register; + inout DIAMETEREM_gen_sess_id; } with { extension "internal" }; /* Function that can be used as create_cb and will use the expect table */ @@ -452,6 +471,14 @@ } } +function f_diameter_gen_sess_id(DIAMETEREM_PROC_PT pt, charstring identity) return charstring { + var charstring sess_id; + pt.call(DIAMETEREM_gen_sess_id:{identity,-}) { + [] pt.getreply(DIAMETEREM_gen_sess_id:{?,?}) -> param (sess_id) {}; + } + return sess_id; +} + private function f_expect_table_init() runs on DIAMETER_Emulation_CT { var integer i; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0fbd271ad123e9663aab5163915e1edbf5915bb6 Gerrit-Change-Number: 31455 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in libosmo-abis[master]: trau_pcu_ericsson: fix log line

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31442 ) Change subject: trau_pcu_ericsson: fix log line ...................................................................... trau_pcu_ericsson: fix log line The log line contains the wrong E bit range. Change-Id: I3687e131a29160a32e37c7546a820808b3c19c9a Related: OS#5198 --- M src/trau/trau_pcu_ericsson.c 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/trau/trau_pcu_ericsson.c b/src/trau/trau_pcu_ericsson.c index 2f2bf0e..585e847 100644 --- a/src/trau/trau_pcu_ericsson.c +++ b/src/trau/trau_pcu_ericsson.c @@ -1871,7 +1871,7 @@ ind->est_acc_del_dev = -2; break; default: - LOGP(DLINP, LOGL_ERROR, "CCU-DATA-IND-64: invalid estimated access delay (E11-E13)\n"); + LOGP(DLINP, LOGL_ERROR, "CCU-DATA-IND-64: invalid estimated access delay (E8-E10)\n"); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3687e131a29160a32e37c7546a820808b3c19c9a Gerrit-Change-Number: 31442 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023