February 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-gsm-manuals[master]: SIGTRAN: fix typo

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31514 ) Change subject: SIGTRAN: fix typo ...................................................................... SIGTRAN: fix typo Change-Id: Ieea85e57be0dc3526234d40af3708839af38908c --- M common/chapters/sigtran-osmocom.adoc 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/common/chapters/sigtran-osmocom.adoc b/common/chapters/sigtran-osmocom.adoc index 3fbaac2..fa8e128 100644 --- a/common/chapters/sigtran-osmocom.adoc +++ b/common/chapters/sigtran-osmocom.adoc @@ -50,7 +50,7 @@ BSSAP * introduction of an A interface in OsmoMSC (which so far offered Iu only) -* port of the existing SUA-baesd IuCS and IuPS over to the SCCP User +* port of the existing SUA-based IuCS and IuPS over to the SCCP User SAP of libosmo-sigtran. * Implementation of ETSI M3UA as preferred/primary transport layer for SCCP -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/31514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ieea85e57be0dc3526234d40af3708839af38908c Gerrit-Change-Number: 31514 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-pgw-test: make the testsuite dir writable by all users

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31424 ) Change subject: ttcn3-pgw-test: make the testsuite dir writable by all users ...................................................................... ttcn3-pgw-test: make the testsuite dir writable by all users When running jenkins.sh as root or any other user with UID different than UID=1000 of the 'osmocom' user we have in open5gs-{master,latest} images, programs spawned by osmo-uecups-daemon (e.g. ping) may fail to start. In such cases, osmo-uecups-daemon reports unexpected program termination with exit code=512. This is happening because the stdout and stderr of a spawned program are being redirected to "$VOL_BASE_DIR/pgw-tester/TESTCASE.prog.std{out,err}", for which the 'osmocom' user needs to have write permissions. Change-Id: Icb6b30e618e290d974a919fef34c6b5cb7eeb648 Related: OS#5913 --- M ttcn3-pgw-test/jenkins.sh 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/ttcn3-pgw-test/jenkins.sh b/ttcn3-pgw-test/jenkins.sh index 58cfbbd..8311bac 100755 --- a/ttcn3-pgw-test/jenkins.sh +++ b/ttcn3-pgw-test/jenkins.sh @@ -19,6 +19,9 @@ cp upfd.sh $VOL_BASE_DIR/pgw/ cp upfd-setup.sh $VOL_BASE_DIR/pgw/ +# make the testsuite dir writable by all users +chmod 777 $VOL_BASE_DIR/pgw-tester/ + network_create network_replace_subnet_in_configs -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icb6b30e618e290d974a919fef34c6b5cb7eeb648 Gerrit-Change-Number: 31424 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in osmo-ggsn[master]: lib/icmpv6.h: run struct_endianness.py to make Jenkins happy

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31532 ) Change subject: lib/icmpv6.h: run struct_endianness.py to make Jenkins happy ...................................................................... Patch Set 1: (1 comment) File lib/icmpv6.h: https://gerrit.osmocom.org/c/osmo-ggsn/+/31532/comment/a1a35b3e_b5333622 PS1, Line 48: uint8_t m:1, > also fixes wrong order for big endian, good to say so in the commit log; maybe also TODO-RELEASE? Good point, I didn't notice the order was wrong. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ifaa63bb5496e056805bd13b964c8b430fb11c24c Gerrit-Change-Number: 31532 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Feb 2023 08:31:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-pgw-test: make the testsuite dir writable by all users

by osmith

Attention is currently required from: fixeria, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31424 ) Change subject: ttcn3-pgw-test: make the testsuite dir writable by all users ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icb6b30e618e290d974a919fef34c6b5cb7eeb648 Gerrit-Change-Number: 31424 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Feb 2023 08:30:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in libosmocore[master]: debian/control: make libosmocore-doc depend on libosmo{ctrl,gb}-doc

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31508 ) Change subject: debian/control: make libosmocore-doc depend on libosmo{ctrl,gb}-doc ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > is the same thing required in the RPM spec? We don't seem to have any -doc packages in the RPM spec. at all, so I think no. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31508 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icd84afcd035bdca9aabb4ea2b91c1227c4786da7 Gerrit-Change-Number: 31508 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Feb 2023 08:30:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-mgw[master]: mgcp_client: mgcp_msg_gen: add more error logs

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31457 ) Change subject: mgcp_client: mgcp_msg_gen: add more error logs ...................................................................... mgcp_client: mgcp_msg_gen: add more error logs While adding CSD, this failed for me in add_lco without a descriptive log message, so add more error messages. Related: OS#4393 Change-Id: I4873a2db95525aab3e13046b645dd8f90e951466 --- M src/libosmo-mgcp-client/mgcp_client.c M tests/mgcp_client/mgcp_client_test.err 2 files changed, 20 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index c3ecc9f..0434e70 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -1392,8 +1392,10 @@ if (!use_sdp && (mgcp_msg->verb == MGCP_VERB_CRCX || mgcp_msg->verb == MGCP_VERB_MDCX)) { - if (add_lco(msg, mgcp_msg) < 0) + if (add_lco(msg, mgcp_msg) < 0) { + LOGPMGW(mgcp, LOGL_ERROR, "Failed to add LCO, can not generate MGCP message\n"); return NULL; + } } /* Add mode */ @@ -1428,8 +1430,10 @@ if (use_sdp && (mgcp_msg->verb == MGCP_VERB_CRCX || mgcp_msg->verb == MGCP_VERB_MDCX)) { - if (add_sdp(msg, mgcp_msg, mgcp) < 0) + if (add_sdp(msg, mgcp_msg, mgcp) < 0) { + LOGPMGW(mgcp, LOGL_ERROR, "Failed to add SDP, can not generate MGCP message\n"); return NULL; + } } if (rc != 0) { diff --git a/tests/mgcp_client/mgcp_client_test.err b/tests/mgcp_client/mgcp_client_test.err index 4a73f7f..d666cba 100644 --- a/tests/mgcp_client/mgcp_client_test.err +++ b/tests/mgcp_client/mgcp_client_test.err @@ -1,5 +1,6 @@ DLMGCP MGW(mgw) MGCP client: using endpoint domain '@mgw' DLMGCP MGW(mgw) Message buffer to small, can not generate MGCP message (SDP) +DLMGCP MGW(mgw) Failed to add SDP, can not generate MGCP message test_mgcp_client_cancel(): DLMGCP MGW(mgw) MGCP client: using endpoint domain '@mgw' -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31457 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4873a2db95525aab3e13046b645dd8f90e951466 Gerrit-Change-Number: 31457 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in libosmo-netif[master]: rtp.h: add RTP_PT_CSDATA

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/31405 ) Change subject: rtp.h: add RTP_PT_CSDATA ...................................................................... rtp.h: add RTP_PT_CSDATA Related: OS#4393 Change-Id: I2ea378ba4d17e977da25ef9e6e86b3de2ccd0ad7 --- M include/osmocom/netif/rtp.h 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/netif/rtp.h b/include/osmocom/netif/rtp.h index 756ce90..7f5ecae 100644 --- a/include/osmocom/netif/rtp.h +++ b/include/osmocom/netif/rtp.h @@ -82,4 +82,6 @@ #define RTP_PT_AMR 98 +#define RTP_PT_CSDATA 120 /* 3GPP TS 48.103 table 5.4.2.2.1 */ + #endif -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/31405 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I2ea378ba4d17e977da25ef9e6e86b3de2ccd0ad7 Gerrit-Change-Number: 31405 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in osmo-ggsn[master]: lib/icmpv6.h: run struct_endianness.py to make Jenkins happy

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31532 ) Change subject: lib/icmpv6.h: run struct_endianness.py to make Jenkins happy ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ifaa63bb5496e056805bd13b964c8b430fb11c24c Gerrit-Change-Number: 31532 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Feb 2023 08:28:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp: use OSMO_ASSERT() in gtp_new()

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/31511 ) Change subject: gtp: use OSMO_ASSERT() in gtp_new() ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Note that this needs to be backported to the last releases (it seems we usually do the last 2 releases), otherwise it can't build against new libosmocore after https://gerrit.osmocom.org/c/libosmocore/+/31496 is merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/31511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ia8af1736b63d501661046fe70befe5bbabc1045a Gerrit-Change-Number: 31511 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Feb 2023 08:26:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/gerrit-pipeline-endianness: ignore submodules

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/31535 ) Change subject: jobs/gerrit-pipeline-endianness: ignore submodules ...................................................................... jobs/gerrit-pipeline-endianness: ignore submodules Let the check only run on the main repository, not on any submodules. This fixes that it would currently fail in osmo-trx: the osmocom-bb submodule has a copy of libosmocore where the endianness check is known to be failing (see https://gerrit.osmocom.org/c/osmocom-bb/+/31403). Change-Id: I795a64a66b4a2e316a99e6b523cc33a9ed364272 --- M jobs/gerrit-pipeline-endianness.yml 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/35/31535/1 diff --git a/jobs/gerrit-pipeline-endianness.yml b/jobs/gerrit-pipeline-endianness.yml index 1b0f423..809cce6 100644 --- a/jobs/gerrit-pipeline-endianness.yml +++ b/jobs/gerrit-pipeline-endianness.yml @@ -69,8 +69,7 @@ choosing-strategy: gerrit wipe-workspace: true skip-tag: true - submodule: - recursive: false + disable-submodules: true builders: - shell: | -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I795a64a66b4a2e316a99e6b523cc33a9ed364272 Gerrit-Change-Number: 31535 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023