February 2023 - gerrit-log - lists.osmocom.org

Change in libosmo-sccp[master]: sccp_scmg: ignore PCSTATE.indication

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31363 ) Change subject: sccp_scmg: ignore PCSTATE.indication ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I5fd38afea94f48ed2f2fcd2d9baa8ec22a571b6b Gerrit-Change-Number: 31363 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 18 Feb 2023 08:20:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in libosmo-sccp[master]: sccp_scmg: ignore PCSTATE.indication

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31363 ) Change subject: sccp_scmg: ignore PCSTATE.indication ...................................................................... sccp_scmg: ignore PCSTATE.indication Silence the error log for PCSTATE.indication prims. When running the HNBGW_Tests.ttcn suite, the osmo-hnbgw LOGL_ERROR is spammed with messages like: DLSCCP ERROR unsupported SCCP user primitive N-PCSTATE.indication (sccp_scmg.c:298) Add this prim to scmg_prim_cb() to just log on DEBUG that it is ignored. Related: OS#5679 Change-Id: I5fd38afea94f48ed2f2fcd2d9baa8ec22a571b6b --- M src/sccp_scmg.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/63/31363/1 diff --git a/src/sccp_scmg.c b/src/sccp_scmg.c index ef3a0b3..a8ac766 100644 --- a/src/sccp_scmg.c +++ b/src/sccp_scmg.c @@ -294,6 +294,9 @@ scmg->affected_pc = osmo_load16le(&scmg->affected_pc); rc = scmg_rx(scu, &param->calling_addr, &param->called_addr, scmg); break; + case OSMO_PRIM(OSMO_SCU_PRIM_N_PCSTATE, PRIM_OP_INDICATION): + LOGP(DLSCCP, LOGL_DEBUG, "Ignoring SCCP user primitive %s\n", osmo_scu_prim_name(oph)); + break; default: LOGP(DLSCCP, LOGL_ERROR, "unsupported SCCP user primitive %s\n", osmo_scu_prim_name(oph)); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I5fd38afea94f48ed2f2fcd2d9baa8ec22a571b6b Gerrit-Change-Number: 31363 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in libosmo-sccp[master]: add osmo_scu_prim_name_c() / _buf()

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31364 ) Change subject: add osmo_scu_prim_name_c() / _buf() ...................................................................... add osmo_scu_prim_name_c() / _buf() Add non-legacy string functions for osmo_scu_prim_name in the form of _buf() and _c() signatures. So far there is only osmo_scu_prim_name() using a static buffer. Implement that using osmo_scu_prim_name_buf(). Change-Id: I4c1998fd7fee7282d107846dae2cff4b5ceb3a7b --- M include/osmocom/sigtran/sccp_sap.h M src/sccp_sap.c 2 files changed, 22 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/64/31364/1 diff --git a/include/osmocom/sigtran/sccp_sap.h b/include/osmocom/sigtran/sccp_sap.h index 5624d33..3930111 100644 --- a/include/osmocom/sigtran/sccp_sap.h +++ b/include/osmocom/sigtran/sccp_sap.h @@ -274,6 +274,8 @@ #define msgb_scu_prim(msg) ((struct osmo_scu_prim *)(msg)->l1h) char *osmo_scu_prim_name(const struct osmo_prim_hdr *oph); +int osmo_scu_prim_name_buf(char *buf, size_t buflen, const struct osmo_prim_hdr *oph); +char *osmo_scu_prim_name_c(void *ctx, const struct osmo_prim_hdr *oph); struct osmo_ss7_instance; struct osmo_sccp_instance; diff --git a/src/sccp_sap.c b/src/sccp_sap.c index cdf0acc..c0a42c6 100644 --- a/src/sccp_sap.c +++ b/src/sccp_sap.c @@ -45,14 +45,29 @@ char *osmo_scu_prim_name(const struct osmo_prim_hdr *oph) { - const char *name = get_value_string(osmo_scu_prim_names, oph->primitive); - - snprintf(prim_name_buf, sizeof(prim_name_buf), "%s.%s", name, - get_value_string(osmo_prim_op_names, oph->operation)); - + osmo_scu_prim_name_buf(prim_name_buf, sizeof(prim_name_buf), oph); return prim_name_buf; } +int osmo_scu_prim_name_buf(char *buf, size_t buflen, const struct osmo_prim_hdr *oph) +{ + struct osmo_strbuf sb = { .buf = buf, .len = buflen }; + + if (!oph) { + OSMO_STRBUF_PRINTF(sb, "null"); + return sb.chars_needed; + } + + OSMO_STRBUF_PRINTF(sb, "%s.%s", + get_value_string(osmo_scu_prim_names, oph->primitive), + get_value_string(osmo_prim_op_names, oph->operation)); + return sb.chars_needed; +} + +char *osmo_scu_prim_name_c(void *ctx, const struct osmo_prim_hdr *oph) +{ + OSMO_NAME_C_IMPL(ctx, 32, "ERROR", osmo_scu_prim_name_buf, oph) +} #include <osmocom/sigtran/sigtran_sap.h> -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4c1998fd7fee7282d107846dae2cff4b5ceb3a7b Gerrit-Change-Number: 31364 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: pcu_l1_if_phy: flexible phy access

by dexter

Attention is currently required from: pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31341 ) Change subject: pcu_l1_if_phy: flexible phy access ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: There is one open question: How do we want to select the PHY. The simple way would be just adding an info indication flag but I am tending more towards adding a new indication type that is sent only once on startup by the BTS or the BSC. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8692d1bd5d137a17cf596ee2914722f419c9978d Gerrit-Change-Number: 31341 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Feb 2023 17:19:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: pcu_l1_if: receive E1 connection parameters

by dexter

Attention is currently required from: pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31174 ) Change subject: pcu_l1_if: receive E1 connection parameters ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: I am tending to merge this into the follow up patch (the one that is currently WIP) since this patch already depends on libosmo-abis but does not add any functionality that is usable without the full ericsson support. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1f926b023205a9ecf78d8a8586d6ac21cc73eb0a Gerrit-Change-Number: 31174 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Feb 2023 17:17:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: pcu_l1_if_phy: flexible phy access

by dexter

Attention is currently required from: pespin, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31341 ) Change subject: pcu_l1_if_phy: flexible phy access ...................................................................... Patch Set 8: (2 comments) File src/osmobts_sock.c: https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/e88a4bad_0a0ff8b0 PS5, Line 115: bts->trx[trx].fl1h = NULL; > If you want to make it mandatory for any driver to implement that function then yes it's fine One could argue if there may be a driver in the future that does not require to be closed but I think this is mandatory. At least at the moment all drivers implement such a function. File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31341/comment/bc5b8af9_e09cf835 PS5, Line 218: the_pcu->phy_ops->l1if_pdch_req(bts->trx[trx].fl1h, ts, 0, fn, arfcn, block_nr, > Again, this makes this function mandatory to be implemented by the driver. l1if_pdch_req() is an integral part of the driver concept, its definitely needed by every driver. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8692d1bd5d137a17cf596ee2914722f419c9978d Gerrit-Change-Number: 31341 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Feb 2023 16:58:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: pcu_l1_if_phy: flexible phy access

by dexter

Attention is currently required from: pespin, fixeria. Hello Jenkins Builder, pespin, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/31341 to look at the new patch set (#8). Change subject: pcu_l1_if_phy: flexible phy access ...................................................................... pcu_l1_if_phy: flexible phy access At the moment we have three different platform specific PHY interfaces, which can be selected using a compile time option. Since those three all are intended to be used on embedded platforms this works fine. However, in the future we plan to add E1 phy support (PHY/CCU is attached via an E1 line), which shall not be a compiletime distinction. It might be also thinkable that we might even add multiple E1 phys in the future, so multiple phy implementations must be able to co-exist. This patch adds a generic interface that allows for the creation of PHY modules that are able to register themselves so that they can be selected dynamically. The "legacy" PHY implementations are not intended to co-exist next to other PHYs, so it is possible to register them as "singleton" modules (only one at a time, via compiletime option). For the moment only "singleton" modules are supported. The selection mechanism (pcu_sock, pcu_l1_if.cpp) will be introduced with the first resident PHY implementation (Ericsson E1 CCU support) Change-Id: I8692d1bd5d137a17cf596ee2914722f419c9978d Related: OS#5198 --- M src/Makefile.am M src/gprs_pcu.h M src/gprs_rlcmac_sched.cpp M src/osmo-bts-litecell15/lc15_l1_if.c M src/osmo-bts-oc2g/oc2g_l1_if.c M src/osmo-bts-sysmo/sysmo_l1_if.c M src/osmobts_sock.c M src/pcu_l1_if.cpp A src/pcu_l1_if_phy.c M src/pcu_l1_if_phy.h M src/pcu_main.cpp 11 files changed, 256 insertions(+), 71 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/41/31341/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8692d1bd5d137a17cf596ee2914722f419c9978d Gerrit-Change-Number: 31341 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: pcu_l1_if: use only the term "direct PHY access"

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31361 ) Change subject: pcu_l1_if: use only the term "direct PHY access" ...................................................................... pcu_l1_if: use only the term "direct PHY access" The log messages and code comments sometimes refer to the direct PHY access feature as "direct DSP access". Lets use only the term "direct PHY access" Change-Id: I121ad85cd8581c40f390dbaad0d6a028d68b095e --- M src/pcu_l1_if.cpp 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/61/31361/1 diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 2384600..a5ab081 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -613,7 +613,7 @@ return rc; } -/* C -> C++ adapter for direct DSP access code (e.g. osmo-bts-sysmo) */ +/* C -> C++ adapter for direct PHY access code (e.g. osmo-bts-sysmo) */ extern "C" int pcu_rx_rach_ind_ptcch(struct gprs_rlcmac_bts *bts, uint8_t trx_nr, uint8_t ts_nr, uint32_t fn, int16_t qta) { struct rach_ind_params rip = { @@ -873,11 +873,11 @@ the_pcu->gsmtap); if (!bts->trx[trx_nr].fl1h) { LOGP(DL1IF, LOGL_FATAL, "Failed to open direct " - "DSP access for PDCH.\n"); + "PHY access for PDCH.\n"); exit(0); } } else { - LOGP(DL1IF, LOGL_FATAL, "Compiled without direct DSP " + LOGP(DL1IF, LOGL_FATAL, "Compiled without direct PHY " "access for PDCH, but enabled at " "BTS. Please deactivate it!\n"); exit(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I121ad85cd8581c40f390dbaad0d6a028d68b095e Gerrit-Change-Number: 31361 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: pcu_l1_if: get rid of l1if checks

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31362 ) Change subject: pcu_l1_if: get rid of l1if checks ...................................................................... pcu_l1_if: get rid of l1if checks At the moment we check for the presence of l1if and skip calling the driver related function. Instead, the driver function should check the presence of l1if. Change-Id: I54c5de04382e0bd0dbbf233eaffb403fc492d070 --- M src/osmo-bts-litecell15/lc15_l1_if.c M src/osmo-bts-oc2g/oc2g_l1_if.c M src/osmo-bts-sysmo/sysmo_l1_if.c M src/osmobts_sock.c M src/pcu_l1_if.cpp 5 files changed, 39 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/62/31362/1 diff --git a/src/osmo-bts-litecell15/lc15_l1_if.c b/src/osmo-bts-litecell15/lc15_l1_if.c index 18e9c17..0a53120 100644 --- a/src/osmo-bts-litecell15/lc15_l1_if.c +++ b/src/osmo-bts-litecell15/lc15_l1_if.c @@ -135,9 +135,15 @@ static int l1if_connect_pdch(void *obj, uint8_t ts) { struct lc15l1_hdl *fl1h = obj; - struct msgb *msg = l1p_msgb_alloc(); + struct msgb *msg; GsmL1_MphConnectReq_t *cr; + if (!fl1h) { + LOGP(DL1IF, LOGL_ERROR, "no fl1h context, cannot open PDCH for TS=%u yet...\n", ts); + return -EINVAL; + } + + msg = l1p_msgb_alloc(); cr = prim_init(msgb_l1prim(msg), GsmL1_PrimId_MphConnectReq, fl1h); cr->u8Tn = ts; cr->logChComb = GsmL1_LogChComb_XIII; @@ -333,6 +339,11 @@ GsmL1_MsgUnitParam_t *msu_param; struct gsm_time g_time; + if (!fl1h) { + LOGP(DL1IF, LOGL_ERROR, "no fl1h context, tosseing mac block for TS=%u...\n", ts); + return -EINVAL; + } + gsm_fn2gsmtime(&g_time, fn); DEBUGP(DL1IF, "TX packet data %02u/%02u/%02u is_ptcch=%d ts=%d " diff --git a/src/osmo-bts-oc2g/oc2g_l1_if.c b/src/osmo-bts-oc2g/oc2g_l1_if.c index ded3a3e..4d5b865 100644 --- a/src/osmo-bts-oc2g/oc2g_l1_if.c +++ b/src/osmo-bts-oc2g/oc2g_l1_if.c @@ -136,9 +136,15 @@ static int l1if_connect_pdch(void *obj, uint8_t ts) { struct oc2gl1_hdl *fl1h = obj; - struct msgb *msg = l1p_msgb_alloc(); + struct msgb *msg; GsmL1_MphConnectReq_t *cr; + if (!fl1h) { + LOGP(DL1IF, LOGL_ERROR, "no fl1h context, cannot open PDCH for TS=%u yet...\n", ts); + return -EINVAL; + } + + msg = l1p_msgb_alloc(); cr = prim_init(msgb_l1prim(msg), GsmL1_PrimId_MphConnectReq, fl1h); cr->u8Tn = ts; cr->logChComb = GsmL1_LogChComb_XIII; @@ -332,6 +338,11 @@ GsmL1_MsgUnitParam_t *msu_param; struct gsm_time g_time; + if (!fl1h) { + LOGP(DL1IF, LOGL_ERROR, "no fl1h context, tosseing mac block for TS=%u...\n", ts); + return -EINVAL; + } + gsm_fn2gsmtime(&g_time, fn); DEBUGP(DL1IF, "TX packet data %02u/%02u/%02u is_ptcch=%d ts=%d " diff --git a/src/osmo-bts-sysmo/sysmo_l1_if.c b/src/osmo-bts-sysmo/sysmo_l1_if.c index 625c5b1..3ada98b 100644 --- a/src/osmo-bts-sysmo/sysmo_l1_if.c +++ b/src/osmo-bts-sysmo/sysmo_l1_if.c @@ -118,9 +118,15 @@ static int l1if_connect_pdch(void *obj, uint8_t ts) { struct femtol1_hdl *fl1h = obj; - struct msgb *msg = l1p_msgb_alloc(); + struct msgb *msg; GsmL1_MphConnectReq_t *cr; + if (!fl1h) { + LOGP(DL1IF, LOGL_ERROR, "no fl1h context, cannot open PDCH for TS=%u yet...\n", ts); + return -EINVAL; + } + + msg = l1p_msgb_alloc(); cr = prim_init(msgb_l1prim(msg), GsmL1_PrimId_MphConnectReq, fl1h); cr->u8Tn = ts; cr->logChComb = GsmL1_LogChComb_XIII; @@ -318,6 +324,11 @@ GsmL1_MsgUnitParam_t *msu_param; struct gsm_time g_time; + if (!fl1h) { + LOGP(DL1IF, LOGL_ERROR, "no fl1h context, tosseing mac block for TS=%u...\n", ts); + return -EINVAL; + } + gsm_fn2gsmtime(&g_time, fn); DEBUGP(DL1IF, "TX packet data %02u/%02u/%02u is_ptcch=%d ts=%d " diff --git a/src/osmobts_sock.c b/src/osmobts_sock.c index d6fedb5..b4cf9aa 100644 --- a/src/osmobts_sock.c +++ b/src/osmobts_sock.c @@ -110,7 +110,7 @@ /* disable all slots, kick all TBFs */ for (trx = 0; trx < 8; trx++) { /* Direct PHY access */ - if (the_pcu->phy_ops && bts->trx[trx].fl1h) { + if (the_pcu->phy_ops) { the_pcu->phy_ops->l1if_close_pdch(bts->trx[trx].fl1h); bts->trx[trx].fl1h = NULL; } diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index a5ab081..6706283 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -212,7 +212,7 @@ uint32_t fn, uint8_t block_nr) { /* Direct PHY access */ - if (the_pcu->phy_ops && bts->trx[trx].fl1h) { + if (the_pcu->phy_ops) { if (!msg) /* Simply skip sending idle frames to L1 */ return; the_pcu->phy_ops->l1if_pdch_req(bts->trx[trx].fl1h, ts, 0, fn, arfcn, block_nr, @@ -241,7 +241,7 @@ gsmtap_send(the_pcu->gsmtap, arfcn, ts, GSMTAP_CHANNEL_PTCCH, 0, fn, 0, 0, data, data_len); /* Direct PHY access */ - if (the_pcu->phy_ops && bts->trx[trx].fl1h) { + if (the_pcu->phy_ops) { if (!data_len) /* Simply skip sending idle frames to L1 */ return; the_pcu->phy_ops->l1if_pdch_req(bts->trx[trx].fl1h, ts, 1, fn, arfcn, block_nr, data, data_len); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I54c5de04382e0bd0dbbf233eaffb403fc492d070 Gerrit-Change-Number: 31362 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in meta-telephony[201705]: osmo-*: Fix systemd services to run against old systemd

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/31358 ) Change subject: osmo-*: Fix systemd services to run against old systemd ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/meta-telephony/+/31358/comment/60644a8f_6ff528… PS1, Line 7: -{bts,pcu}: > * Done -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/31358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I821249615c7bc593cd5a68b1a9c48fe787016e87 Gerrit-Change-Number: 31358 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Feb 2023 16:12:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023