Attention is currently required from: jolly, neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31296 )
Change subject: Rework mi_e1_line_update() and some of its sub routines
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31296
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iab0776fce6921661b39e9e53376cf01a80bcd42c
Gerrit-Change-Number: 31296
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 18 Feb 2023 13:01:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: jolly, neels, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/31032 )
Change subject: Add function to set Sa bits to common part
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31032
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I4f5f975f0e5f708ae573a1e1ce41c6a08c207fad
Gerrit-Change-Number: 31032
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 18 Feb 2023 13:00:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
Hello Jenkins Builder, neels, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-abis/+/31319
to look at the new patch set (#3).
Change subject: misdn driver: replace printf and fprintf by logging functions
......................................................................
misdn driver: replace printf and fprintf by logging functions
Change-Id: I313c0bf2b8a93febed73b4ea447f6552216095b6
---
M src/input/misdn.c
1 file changed, 28 insertions(+), 37 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/19/31319/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31319
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I313c0bf2b8a93febed73b4ea447f6552216095b6
Gerrit-Change-Number: 31319
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: jolly, neels, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-abis/+/31032
to look at the new patch set (#5).
Change subject: Add function to set Sa bits to common part
......................................................................
Add function to set Sa bits to common part
Change-Id: I4f5f975f0e5f708ae573a1e1ce41c6a08c207fad
---
M TODO-RELEASE
M include/osmocom/abis/e1_input.h
M src/e1_input.c
3 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/32/31032/5
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31032
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I4f5f975f0e5f708ae573a1e1ce41c6a08c207fad
Gerrit-Change-Number: 31032
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: neels.
Hello Jenkins Builder, neels, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-abis/+/31296
to look at the new patch set (#4).
Change subject: Rework mi_e1_line_update() and some of its sub routines
......................................................................
Rework mi_e1_line_update() and some of its sub routines
Close file descriptor and free lapd resources, if time slot
type changes or if it is released. Also, reset local states.
Change-Id: Iab0776fce6921661b39e9e53376cf01a80bcd42c
---
M src/input/misdn.c
1 file changed, 60 insertions(+), 21 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/96/31296/4
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/31296
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iab0776fce6921661b39e9e53376cf01a80bcd42c
Gerrit-Change-Number: 31296
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: neels, msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31295 )
Change subject: SS7: do not attempt transfer if AS is down
......................................................................
Patch Set 3: Code-Review-1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31295
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I0d5f3b6265e7fdaa79e32fbc30f829ef79e7dad1
Gerrit-Change-Number: 31295
Gerrit-PatchSet: 3
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 18 Feb 2023 08:38:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31324 )
Change subject: i460_mux: make osmo_i460_subchan_count public
......................................................................
i460_mux: make osmo_i460_subchan_count public
There may be situations where we must check if there are still I.460
subchannels active, so lets make the function osmo_i460_subchan_count
public
Change-Id: I0454ffe5809f21504c1e263a781c06596d452d4b
Related: OS#5198
---
M include/osmocom/isdn/i460_mux.h
M src/isdn/i460_mux.c
M src/isdn/libosmoisdn.map
3 files changed, 7 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/include/osmocom/isdn/i460_mux.h b/include/osmocom/isdn/i460_mux.h
index 770b1e1..ad9cb24 100644
--- a/include/osmocom/isdn/i460_mux.h
+++ b/include/osmocom/isdn/i460_mux.h
@@ -113,4 +113,6 @@
void osmo_i460_subchan_del(struct osmo_i460_subchan *schan);
+int osmo_i460_subchan_count(struct osmo_i460_timeslot *ts);
+
/*! @} */
diff --git a/src/isdn/i460_mux.c b/src/isdn/i460_mux.c
index 18a807d..9e9489a 100644
--- a/src/isdn/i460_mux.c
+++ b/src/isdn/i460_mux.c
@@ -23,8 +23,10 @@
#include <osmocom/core/msgb.h>
#include <osmocom/isdn/i460_mux.h>
-/* count the number of sub-channels in this I460 slot */
-static int osmo_i460_subchan_count(struct osmo_i460_timeslot *ts)
+/*! count the number of sub-channels in this I.460 slot.
+ * \param[in] ts timeslot that holds the I.460 subchannels.
+ * \return number of subchannels. */
+int osmo_i460_subchan_count(struct osmo_i460_timeslot *ts)
{
int i, num_used = 0;
diff --git a/src/isdn/libosmoisdn.map b/src/isdn/libosmoisdn.map
index 76e8c81..5ac65c9 100644
--- a/src/isdn/libosmoisdn.map
+++ b/src/isdn/libosmoisdn.map
@@ -18,6 +18,7 @@
osmo_i460_mux_out;
osmo_i460_subchan_add;
osmo_i460_subchan_del;
+osmo_i460_subchan_count;
osmo_i460_ts_init;
local: *;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31324
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0454ffe5809f21504c1e263a781c06596d452d4b
Gerrit-Change-Number: 31324
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged