February 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: Run struct_endianness.py

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31403 ) Change subject: Run struct_endianness.py ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31403 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I617c967c5f34c0be2cf6fd43ceb1af17897f2bf1 Gerrit-Change-Number: 31403 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 10:43:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-pcu[master]: osmo-pcu: Transition to use of 'telnet_init_default'

by pespin

Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31092 ) Change subject: osmo-pcu: Transition to use of 'telnet_init_default' ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > I don't know (I didn't merge it). […] Not anymore, I already made a release... -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9559486ce64a9ccf348b4ee0e1d09141dbc1ae8f Gerrit-Change-Number: 31092 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 10:42:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[M] Change in libosmocore[master]: Update multiaddr helper

by pespin

Attention is currently required from: neels, laforge, fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28993 ) Change subject: Update multiaddr helper ...................................................................... Patch Set 16: Code-Review-1 (3 comments) File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/668177da_4b64655d PS16, Line 216: size_t count = use_hosts ? host_count : addrs_count; what? why do you reuse the same function with 2 sets of different parameters? this is utterly confusing. Have 2 functions with different parameter set instead. https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/ed0b0257_75b5e3f2 PS16, Line 263: static void multiaddr_log_helper(uint8_t loglevel, const char *fmt, uint16_t port, const char **hosts, size_t host_cnt) I see no point in having this helper, with a formatting string which then anyway implies a given order of parameters. Simply use the 3 lines this function has. https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/1e5b48a8_cb793df0 PS16, Line 831: multiaddr_log_helper(LOGL_ERROR, "cannot setsockopt socket: %s:%u: %s\n", This looks really weird, you are passing a formatted string with parameters which are not matching the format... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icef53fe4b6e51563d97a1bc48001d67679b3b6e9 Gerrit-Change-Number: 28993 Gerrit-PatchSet: 16 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 10:40:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-ci[master]: jenkins-gerrit: make links clickable again

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/31404 ) Change subject: jenkins-gerrit: make links clickable again ...................................................................... jenkins-gerrit: make links clickable again After gerrit was upgraded, the comment formatting changed. Links inside blocks indented with two spaces cannot be clicked anymore, so change it to a listing. Change-Id: I4dc338c22e9afe4b9d9df845c6f5d9b3a91f93d9 --- M scripts/jenkins-gerrit/comment_generate.py 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/04/31404/1 diff --git a/scripts/jenkins-gerrit/comment_generate.py b/scripts/jenkins-gerrit/comment_generate.py index dc69f8f..0bd08dc 100755 --- a/scripts/jenkins-gerrit/comment_generate.py +++ b/scripts/jenkins-gerrit/comment_generate.py @@ -153,7 +153,7 @@ def get_jobs_list_str(jobs): ret = "" for job in jobs: - ret += f" [{get_job_short_name(job)}] {job['url']}/consoleFull\n" + ret += f"* [{get_job_short_name(job)}] {job['url']}/consoleFull\n" return ret -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31404 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4dc338c22e9afe4b9d9df845c6f5d9b3a91f93d9 Gerrit-Change-Number: 31404 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: Add osmo_sockaddr_to_str_buf3()

by pespin

Attention is currently required from: neels, laforge, fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28995 ) Change subject: Add osmo_sockaddr_to_str_buf3() ...................................................................... Patch Set 11: Code-Review-1 (1 comment) Patchset: PS11: I'm still not following why do we need this function. This function gets 1 struct osmo_sockaddr as input, so it cannot really handle multiaddress, because osmo_sockaddr holds only address. Hence, if you simply want to get the string representation of 1 IP address, you already have: const char *osmo_sockaddr_ntop(const struct sockaddr *sa, char *dst); In case you want to print the port too, the osmo_sockaddr_to-str_buf2 already makes the job. Am I missing something? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I36f20701663c3c7eae7fedc6551da44800b325bf Gerrit-Change-Number: 28995 Gerrit-PatchSet: 11 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 10:33:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[L] Change in libosmocore[master]: Move libosmogsm TS 44.060 declarations under include/osmocom/gsm/

by pespin

Attention is currently required from: laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31356 ) Change subject: Move libosmogsm TS 44.060 declarations under include/osmocom/gsm/ ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/31356/comment/312bc85c_57a09ccf PS2, Line 9: Currently there's a big mess where include dir osmocom/gprs/ is used by : both libosmogsm and libosmogb. > Well it's a mess every time I need to release a new version of libosmocore, since I have to first re […] Regarding collision with libosmo-gprs, I think it's not going to be a big issue making stuff fail since libosmo-gprs puts everything under subdirectories: gprs/rlcmac, gprs/llc, gprs/sndcp, etc. But this doesn't mean it's still confusing that 2 libraries (actually 3 now couting libgsm) put stuff under the same subdir. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I70cc21bf25a7081070738abacb409ed19094c3b2 Gerrit-Change-Number: 31356 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 10:25:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[L] Change in libosmocore[master]: Move libosmogsm TS 44.060 declarations under include/osmocom/gsm/

by pespin

Attention is currently required from: laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31356 ) Change subject: Move libosmogsm TS 44.060 declarations under include/osmocom/gsm/ ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: And just to clarify, this is already fixing the fact that spec.in files from libosmogb are stealing some files from libosmogsm, which is basically causing problems building libosmo-gprs since it depends on libosmogsm but doesn't need libosmogb. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I70cc21bf25a7081070738abacb409ed19094c3b2 Gerrit-Change-Number: 31356 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 10:23:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[L] Change in libosmocore[master]: Move libosmogsm TS 44.060 declarations under include/osmocom/gsm/

by pespin

Attention is currently required from: laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31356 ) Change subject: Move libosmogsm TS 44.060 declarations under include/osmocom/gsm/ ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/31356/comment/78c79e65_f400ee34 PS2, Line 9: Currently there's a big mess where include dir osmocom/gprs/ is used by : both libosmogsm and libosmogb. > I don't think that by itself constitues any mess. […] Well it's a mess every time I need to release a new version of libosmocore, since I have to first remember and handle the specific case of gprs/ dir being libosmogb (LIBVERSION), and furthermore trying to find out that actually some headers there are part of libosmogsm. And yes, I can say that before I submitted these patches I wasn't even aware of that mess, so I may have modified LIBVERSION of libosmogsm and libosmogb in the wrong way on some ocassion due to that fact, because this current status is totally unexpected IMHO. https://gerrit.osmocom.org/c/libosmocore/+/31356/comment/b93c6d68_159a9a08 PS2, Line 30: can eventually get rid of them. > and eventuall break building old applications, which we generally try not to, unless it's really imp […] Then keep the dummy headers for as long as you wish (eg whenever we find in the long future that anyway we have to break the ABI to solve some problem). But even if we keep them forever, imho this patch already fixes a situation which I'm sure provoked problems in the past, and which I'm sure will provoke more in the future. This way all new development happens under osmocom/gb/ and osmocom/gsm/ which is way clearer, and avoid dependency mess like it happened. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I70cc21bf25a7081070738abacb409ed19094c3b2 Gerrit-Change-Number: 31356 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 10:21:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmocom-bb[master]: Run struct_endianness.py

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31403 ) Change subject: Run struct_endianness.py ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > The local copy of libosmocore (src/shared/libosmocore) should be kept unchanged. […] Patch updated so the copy of libosmocore is unchanged. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31403 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I617c967c5f34c0be2cf6fd43ceb1af17897f2bf1 Gerrit-Change-Number: 31403 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 10:20:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmocom-bb[master]: Run struct_endianness.py

by osmith

Attention is currently required from: osmith, fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/31403 to look at the new patch set (#3). Change subject: Run struct_endianness.py ...................................................................... Run struct_endianness.py Ensure there is no diff to prepare to run this in CI. Related: OS#5884 Change-Id: I617c967c5f34c0be2cf6fd43ceb1af17897f2bf1 --- M src/host/gprsdecode/rlcmac.h M src/host/layer23/include/osmocom/bb/common/sim.h 2 files changed, 49 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/03/31403/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31403 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I617c967c5f34c0be2cf6fd43ceb1af17897f2bf1 Gerrit-Change-Number: 31403 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023