February 2023 - gerrit-log - lists.osmocom.org

[XL] Change in libosmocore[master]: Move include osmocom/gprs -> osmocom/gb, deprecate osmocom/gprs/

by laforge

Attention is currently required from: pespin, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31360 ) Change subject: Move include osmocom/gprs -> osmocom/gb, deprecate osmocom/gprs/ ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This is not breaking API of old applications. […] To me, the intention of DEPRECATED is to make people aware that they are using an inferior/obsolete API with some problems and they should switch to a new one. Like recently the change with telnet_init_dynif where the old API resulted in vty-configured port numbers not to be used. I agree we could potentially remove old API, if it really has *significant* advantages for us, but I would say it's more in a >= 5 year cycle than a 2 year cycle. We have to think of our users, and every time we break something, it creates fall-out downstream. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6e826775552766e34e4c06fe2390084596dfc286 Gerrit-Change-Number: 31360 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 10:53:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in libosmocore[master]: Includes: Add gprs/rlc related enums

by pespin

Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31303 ) Change subject: Includes: Add gprs/rlc related enums ...................................................................... Patch Set 7: Code-Review-1 (1 comment) Patchset: PS7: why are these still kept here? I think we already agreed that those are not really enums specified in those protocols? The enums are specified/used by ip.access Abis OML probably? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31303 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1ec2e52ad7fa625c08fe9df04d4a4f5323bf609c Gerrit-Change-Number: 31303 Gerrit-PatchSet: 7 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 10:51:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-pcu[master]: Run struct_endianness.py

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31398 ) Change subject: Run struct_endianness.py ...................................................................... Run struct_endianness.py Ensure there is no diff to prepare to run this in CI. Related: OS#5884 Change-Id: I1c82acd09497371938a2d9ae12a80382d20189ff --- M src/llc.h M src/rlc.h 2 files changed, 17 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/llc.h b/src/llc.h index 58b169e..d12daac 100644 --- a/src/llc.h +++ b/src/llc.h @@ -41,7 +41,7 @@ uint8_t address; uint8_t sapi:4, unused:2, c_r:1, pd:1; #elif OSMO_IS_BIG_ENDIAN -/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ union { uint8_t address; uint8_t pd:1, c_r:1, unused:2, sapi:4; diff --git a/src/rlc.h b/src/rlc.h index a9d5d0b..5c6930c 100644 --- a/src/rlc.h +++ b/src/rlc.h @@ -386,7 +386,7 @@ uint8_t e:1, bsn:7; #elif OSMO_IS_BIG_ENDIAN -/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ uint8_t pt:2, cv:4, si:1, r:1; uint8_t spare:1, pi:1, tfi:5, ti:1; uint8_t bsn:7, e:1; @@ -405,7 +405,7 @@ uint8_t e:1, bsn:7; #elif OSMO_IS_BIG_ENDIAN -/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ uint8_t pt:2, rrbp:2, s_p:1, usf:3; uint8_t pr:2, tfi:5, fbi:1; uint8_t bsn:7, e:1; @@ -418,7 +418,7 @@ m:1, li:6; #elif OSMO_IS_BIG_ENDIAN -/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ uint8_t li:6, m:1, e:1; #endif } __attribute__ ((packed)); @@ -428,7 +428,7 @@ uint8_t e:1, li:7; #elif OSMO_IS_BIG_ENDIAN -/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */ +/* auto-generated from the little endian part above (libosmocore/contrib/struct_endianness.py) */ uint8_t li:7, e:1; #endif } __attribute__ ((packed)); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1c82acd09497371938a2d9ae12a80382d20189ff Gerrit-Change-Number: 31398 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmo-pcu[master]: Run struct_endianness.py

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31398 ) Change subject: Run struct_endianness.py ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1c82acd09497371938a2d9ae12a80382d20189ff Gerrit-Change-Number: 31398 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 10:50:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmocom-bb[master]: Run struct_endianness.py

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31403 ) Change subject: Run struct_endianness.py ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31403 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I617c967c5f34c0be2cf6fd43ceb1af17897f2bf1 Gerrit-Change-Number: 31403 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 10:49:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmocom-bb[master]: mobile: add vty statsd support

by pespin

Attention is currently required from: laforge, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31298 ) Change subject: mobile: add vty statsd support ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Not sure what we accomplish with this patch given that there's no stats nor short plans to have them there, but ok... -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7905b44478dcb9bcf0a1a68fde95f470c07edca3 Gerrit-Change-Number: 31298 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 10:48:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-ci[master]: jenkins-gerrit: make links clickable again

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31404 ) Change subject: jenkins-gerrit: make links clickable again ...................................................................... jenkins-gerrit: make links clickable again After gerrit was upgraded, the comment formatting changed. Links inside blocks indented with two spaces cannot be clicked anymore, so change it to a listing. Change-Id: I4dc338c22e9afe4b9d9df845c6f5d9b3a91f93d9 --- M scripts/jenkins-gerrit/comment_generate.py 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/scripts/jenkins-gerrit/comment_generate.py b/scripts/jenkins-gerrit/comment_generate.py index dc69f8f..0bd08dc 100755 --- a/scripts/jenkins-gerrit/comment_generate.py +++ b/scripts/jenkins-gerrit/comment_generate.py @@ -153,7 +153,7 @@ def get_jobs_list_str(jobs): ret = "" for job in jobs: - ret += f" [{get_job_short_name(job)}] {job['url']}/consoleFull\n" + ret += f"* [{get_job_short_name(job)}] {job['url']}/consoleFull\n" return ret -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31404 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4dc338c22e9afe4b9d9df845c6f5d9b3a91f93d9 Gerrit-Change-Number: 31404 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmo-ci[master]: jenkins-gerrit: make links clickable again

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31404 ) Change subject: jenkins-gerrit: make links clickable again ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: IIRC the changelog stated that they now use markdown. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31404 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4dc338c22e9afe4b9d9df845c6f5d9b3a91f93d9 Gerrit-Change-Number: 31404 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 10:47:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-ci[master]: jenkins-gerrit: make links clickable again

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31404 ) Change subject: jenkins-gerrit: make links clickable again ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31404 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4dc338c22e9afe4b9d9df845c6f5d9b3a91f93d9 Gerrit-Change-Number: 31404 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 10:47:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in ...osmo-python-tests[master]: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on...

by pespin

Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 ) Change subject: scripts/osmotestconfig.py: Fix tests failing due to attempted copy on socket files ...................................................................... Patch Set 5: Code-Review-1 (1 comment) Patchset: PS5: I personally vote for fixing it the proper way instead of having file names in one project god knows where they come from. Let's see what others think. -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/30980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I3a3cc7ed135b60b97eb901cfc20fdcb924e4f664 Gerrit-Change-Number: 30980 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Feb 2023 10:43:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2023