December 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: coding: gsm0503_pdtch_decode(): implement USF decoding for CS1

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35258?usp=email ) Change subject: coding: gsm0503_pdtch_decode(): implement USF decoding for CS1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I61a3628741c0ac68374fc7f077cf3a07e51277c3 Gerrit-Change-Number: 35258 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Dec 2023 22:35:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in libosmocore[master]: coding: clarify the USF decoding for PDCH blocks

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35257?usp=email ) Change subject: coding: clarify the USF decoding for PDCH blocks ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I43e8bfb4003f34766ace7c5c6080ca583ce5efbb Gerrit-Change-Number: 35257 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Dec 2023 22:35:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in libosmocore[master]: coding: fix doxygen docs for gsm0503_pdtch[_egprs]_decode()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35256?usp=email ) Change subject: coding: fix doxygen docs for gsm0503_pdtch[_egprs]_decode() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35256?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I09a4c52f5704a6436eff524cd2ce5c35347aafde Gerrit-Change-Number: 35256 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Dec 2023 22:34:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in pysim[master]: euicc: the ICCID TLV object uses bcd-swapped-nibble encoding

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35252?usp=email ) Change subject: euicc: the ICCID TLV object uses bcd-swapped-nibble encoding ...................................................................... euicc: the ICCID TLV object uses bcd-swapped-nibble encoding Change-Id: I050f9e0fb128f3e1d472e2330b136a753794a5a1 --- M pySim/euicc.py 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pySim/euicc.py b/pySim/euicc.py index c74ca66..58d19f1 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -149,7 +149,7 @@ class NotificationAddress(BER_TLV_IE, tag=0x82): _construct = Utf8Adapter(GreedyBytes) class Iccid(BER_TLV_IE, tag=0x5a): - _construct = HexAdapter(GreedyBytes) + _construct = BcdAdapter(GreedyBytes) class NotificationMetadata(BER_TLV_IE, tag=0xbf2f, nested=[SeqNumber, ProfileMgmtOperation, NotificationAddress, Iccid]): pass -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35252?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I050f9e0fb128f3e1d472e2330b136a753794a5a1 Gerrit-Change-Number: 35252 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[S] Change in pysim[master]: euicc: Fix encoding of Lc value in STORE DATA

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35260?usp=email ) Change subject: euicc: Fix encoding of Lc value in STORE DATA ...................................................................... euicc: Fix encoding of Lc value in STORE DATA The length value "of course" is a hex value, don't use %02u but %02x This fixes any eUICC command with a Lc > 10 bytes. Change-Id: I1e1efbfb9916fc43699602cc889cf4b3d42736f2 --- M pySim/euicc.py 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/euicc.py b/pySim/euicc.py index 58d19f1..c070525 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -297,7 +297,7 @@ def store_data(scc: SimCardCommands, tx_do: Hexstr) -> Tuple[Hexstr, SwHexstr]: """Perform STORE DATA according to Table 47+48 in Section 5.7.2 of SGP.22. Only single-block store supported for now.""" - capdu = '%sE29100%02u%s' % (scc.cla4lchan('80'), len(tx_do)//2, tx_do) + capdu = '%sE29100%02x%s' % (scc.cla4lchan('80'), len(tx_do)//2, tx_do) return scc._tp.send_apdu_checksw(capdu) @staticmethod -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35260?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1e1efbfb9916fc43699602cc889cf4b3d42736f2 Gerrit-Change-Number: 35260 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[S] Change in pysim[master]: euicc: Fix TLV IE definitions for SetNickname{Req,Resp}

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35262?usp=email ) Change subject: euicc: Fix TLV IE definitions for SetNickname{Req,Resp} ...................................................................... euicc: Fix TLV IE definitions for SetNickname{Req,Resp} The metaclass uese the 'nested' attribute, while the existing code accidentially used the 'children' attribute. The latter is used by instances for actual child classes, while the Class/nested attribute is for the list of classes whose instancse could be potential children. Change-Id: I968bd84d074dcdcec37d99be5d3d4edac9c35a0c --- M pySim/euicc.py 1 file changed, 17 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/euicc.py b/pySim/euicc.py index c070525..19b1c57 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -245,11 +245,11 @@ # SGP.22 Section 5.7.21: ES10c SetNickname class SnrProfileNickname(BER_TLV_IE, tag=0x8f): _construct = Utf8Adapter(GreedyBytes) -class SetNicknameReq(BER_TLV_IE, tag=0xbf29, children=[Iccid, SnrProfileNickname]): +class SetNicknameReq(BER_TLV_IE, tag=0xbf29, nested=[Iccid, SnrProfileNickname]): pass class SetNicknameResult(BER_TLV_IE, tag=0x80): _construct = Enum(Int8ub, ok=0, iccidNotFound=1, undefinedError=127) -class SetNicknameResp(BER_TLV_IE, tag=0xbf29, children=[SetNicknameResult]): +class SetNicknameResp(BER_TLV_IE, tag=0xbf29, nested=[SetNicknameResult]): pass # SGP.32 Section 5.9.10: ES10b: GetCerts -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I968bd84d074dcdcec37d99be5d3d4edac9c35a0c Gerrit-Change-Number: 35262 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 6 months

1
0
0 0

[S] Change in pysim[master]: euicc: Fix TLV IE definitions for SetNickname{Req,Resp}

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35262?usp=email ) Change subject: euicc: Fix TLV IE definitions for SetNickname{Req,Resp} ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: so trivial, marking +2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I968bd84d074dcdcec37d99be5d3d4edac9c35a0c Gerrit-Change-Number: 35262 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Dec 2023 22:33:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in pysim[master]: euicc: Fix encoding of Lc value in STORE DATA

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35260?usp=email ) Change subject: euicc: Fix encoding of Lc value in STORE DATA ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35260?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1e1efbfb9916fc43699602cc889cf4b3d42736f2 Gerrit-Change-Number: 35260 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 07 Dec 2023 22:33:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 6 months

1
0
0 0

[S] Change in pysim[master]: euicc: Fix TLV IE definitions for SetNickname{Req,Resp}

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35262?usp=email ) Change subject: euicc: Fix TLV IE definitions for SetNickname{Req,Resp} ...................................................................... euicc: Fix TLV IE definitions for SetNickname{Req,Resp} The metaclass uese the 'nested' attribute, while the existing code accidentially used the 'children' attribute. The latter is used by instances for actual child classes, while the Class/nested attribute is for the list of classes whose instancse could be potential children. Change-Id: I968bd84d074dcdcec37d99be5d3d4edac9c35a0c --- M pySim/euicc.py 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/62/35262/1 diff --git a/pySim/euicc.py b/pySim/euicc.py index c070525..19b1c57 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -245,11 +245,11 @@ # SGP.22 Section 5.7.21: ES10c SetNickname class SnrProfileNickname(BER_TLV_IE, tag=0x8f): _construct = Utf8Adapter(GreedyBytes) -class SetNicknameReq(BER_TLV_IE, tag=0xbf29, children=[Iccid, SnrProfileNickname]): +class SetNicknameReq(BER_TLV_IE, tag=0xbf29, nested=[Iccid, SnrProfileNickname]): pass class SetNicknameResult(BER_TLV_IE, tag=0x80): _construct = Enum(Int8ub, ok=0, iccidNotFound=1, undefinedError=127) -class SetNicknameResp(BER_TLV_IE, tag=0xbf29, children=[SetNicknameResult]): +class SetNicknameResp(BER_TLV_IE, tag=0xbf29, nested=[SetNicknameResult]): pass # SGP.32 Section 5.9.10: ES10b: GetCerts -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I968bd84d074dcdcec37d99be5d3d4edac9c35a0c Gerrit-Change-Number: 35262 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 0

[S] Change in osmocom-bb[master]: trxcon/{l1sched,l1gprs}: prepare for independent USF decoding

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35261?usp=email ) Change subject: trxcon/{l1sched,l1gprs}: prepare for independent USF decoding ...................................................................... trxcon/{l1sched,l1gprs}: prepare for independent USF decoding Change-Id: I6953e7335e8d39af166d320290e9edfcd06ef141 Related: libosmocore.git I43e8bfb4003f34766ace7c5c6080ca583ce5efbb Related: libosmocore.git I61a3628741c0ac68374fc7f077cf3a07e51277c3 --- M src/host/trxcon/src/sched_lchan_pdtch.c M src/host/trxcon/src/trxcon_fsm.c M src/shared/l1gprs.c 3 files changed, 15 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/61/35261/1 diff --git a/src/host/trxcon/src/sched_lchan_pdtch.c b/src/host/trxcon/src/sched_lchan_pdtch.c index 915b060..ee51005 100644 --- a/src/host/trxcon/src/sched_lchan_pdtch.c +++ b/src/host/trxcon/src/sched_lchan_pdtch.c @@ -37,6 +37,7 @@ int rx_pdtch_fn(struct l1sched_lchan_state *lchan, const struct l1sched_burst_ind *bi) { + uint8_t usf = 0xff; /* invalid value */ uint8_t l2[GPRS_L2_MAX_LEN]; int n_errors, n_bits_total, rc; sbit_t *bursts_p, *burst; @@ -86,8 +87,7 @@ *mask = *mask << 4; /* Attempt to decode */ - rc = gsm0503_pdtch_decode(l2, bursts_p, - NULL, &n_errors, &n_bits_total); + rc = gsm0503_pdtch_decode(l2, bursts_p, &usf, &n_errors, &n_bits_total); if (rc < 0) { LOGP_LCHAND(lchan, LOGL_ERROR, "Received bad frame (rc=%d, ber=%d/%d) at fn=%u\n", diff --git a/src/host/trxcon/src/trxcon_fsm.c b/src/host/trxcon/src/trxcon_fsm.c index f6c9a05..8acc9b7 100644 --- a/src/host/trxcon/src/trxcon_fsm.c +++ b/src/host/trxcon/src/trxcon_fsm.c @@ -615,7 +615,7 @@ const struct trxcon_param_rx_data_ind *ind = data; struct l1gprs_prim_dl_block_ind block_ind; struct msgb *msg; - uint8_t usf = 0xff; + uint8_t usf = 0xff; /* TODO: get from l1sched */ block_ind = (struct l1gprs_prim_dl_block_ind) { .hdr = { diff --git a/src/shared/l1gprs.c b/src/shared/l1gprs.c index 3294a42..20017a7 100644 --- a/src/shared/l1gprs.c +++ b/src/shared/l1gprs.c @@ -714,7 +714,7 @@ .ci_cb = htons(ind->meas.ci_cb), .rx_lev = ind->meas.rx_lev, }, - .usf = 0xff, + .usf = *usf, }; if (ind->data_len == 0) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35261?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6953e7335e8d39af166d320290e9edfcd06ef141 Gerrit-Change-Number: 35261 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2023