November 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-sgsn[master]: sgsn_vty: Fix output in config_write_sgsn

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/35091?usp=email ) Change subject: sgsn_vty: Fix output in config_write_sgsn ...................................................................... sgsn_vty: Fix output in config_write_sgsn The encryption uea option was missing Change-Id: I2c81ced87c53d69a94b3894441323201f81f1a76 --- M src/sgsn/sgsn_vty.c 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/91/35091/1 diff --git a/src/sgsn/sgsn_vty.c b/src/sgsn/sgsn_vty.c index b31fb59..e69307f 100644 --- a/src/sgsn/sgsn_vty.c +++ b/src/sgsn/sgsn_vty.c @@ -282,6 +282,15 @@ vty_out(vty, "%s", VTY_NEWLINE); } + if (g_cfg->uea_encryption_mask != 0) { + vty_out(vty, " encryption uea"); + + for (i = 0; i < _OSMO_UTRAN_UEA_NUM; i++) + if (g_cfg->uea_encryption_mask >> i & 1) + vty_out(vty, " %u", i); + + vty_out(vty, "%s", VTY_NEWLINE); + } if (g_cfg->crypt_cipher_plugin_path) vty_out(vty, "encryption cipher-plugin-path %s%s", g_cfg->crypt_cipher_plugin_path, VTY_NEWLINE); if (g_cfg->sgsn_ipa_name) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/35091?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2c81ced87c53d69a94b3894441323201f81f1a76 Gerrit-Change-Number: 35091 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: make PCUIF_info_ind field bts_model optional

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35090?usp=email ) Change subject: PCUIF_Types: make PCUIF_info_ind field bts_model optional ...................................................................... PCUIF_Types: make PCUIF_info_ind field bts_model optional The field bts_model has been introduced with PCUIF v12, which is now used in master. In latest we still use PCUIF v11, where the bts_model field is not present. This means that when we test against osmo-bts latest there will be an error parsing PCUIF_info_ind. A solution to this problem is to declare the bts_model field as an optional field until PCUIF v12 is also used in latest. Related: OS#6191 Change-Id: I45947f3bddaccafee82824ebb1b8494eabc67e7a --- M library/PCUIF_Types.ttcn 1 file changed, 24 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/90/35090/1 diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn index 12c704f..33b454f 100644 --- a/library/PCUIF_Types.ttcn +++ b/library/PCUIF_Types.ttcn @@ -212,7 +212,11 @@ record length(2) of uint16_t remote_port, PCUIF_RemoteAddr remote_addr, - PCUIF_bts_model bts_model + /* The bts_model field was introduced with PCUIF v12 as a new mandatory field. This also means that when we + * use the testsuite to test against latest builds (still uses PCUIF v11) this field is not included in + * the PCUIF_info_ind message. Since the testsuite does not check on this field we decided to declare the + * field as an optional field until PCUIF v12 is also used in the latest builds.*/ + PCUIF_bts_model bts_model optional } with { variant "" }; type enumerated PCUIF_AddrType { @@ -992,7 +996,8 @@ local_port := ?, remote_port := ?, remote_addr := ?, - bts_model := ? + /* See note in record PCUIF_info_ind */ + bts_model := * } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35090?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I45947f3bddaccafee82824ebb1b8494eabc67e7a Gerrit-Change-Number: 35090 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[S] Change in osmo-bts[master]: LAPDm: Reject (release) establishment on DCC0, SAPI 0 without L3 payload

by jolly

Attention is currently required from: fixeria, laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email ) Change subject: LAPDm: Reject (release) establishment on DCC0, SAPI 0 without L3 payload ...................................................................... Patch Set 2: (1 comment) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/35082/comment/e0478ddf_76a91bf6 PS1, Line 3839: if (msgb_l2len(msg) == sizeof(*rllh) && (rllh->link_id & 0xc7) == 0x00) { > Using our union abis_rsl_link_id and then comparing sapin and cbits individually is probably the mor […] I agree. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6819b51a876b8743c2d4a04165b7900723a1631c Gerrit-Change-Number: 35082 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Nov 2023 14:08:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-bts[master]: LAPDm: Reject (release) establishment on DCC0, SAPI 0 without L3 payload

by jolly

Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: LAPDm: Reject (release) establishment on DCC0, SAPI 0 without L3 payload ...................................................................... LAPDm: Reject (release) establishment on DCC0, SAPI 0 without L3 payload A special flag is used to keep track on the establishment of the data link. If it is being established (not re-established) without L3 payload, it is rejected by a release request inside BTS. Related: OS#5971 Change-Id: I6819b51a876b8743c2d4a04165b7900723a1631c --- M include/osmo-bts/lchan.h M src/common/lchan.c M src/common/rsl.c 3 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/82/35082/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6819b51a876b8743c2d4a04165b7900723a1631c Gerrit-Change-Number: 35082 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 7 months

1
0
0 0

[M] Change in osmo-bts[master]: Use polling based LAPDm with frame numbers

by fixeria

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email ) Change subject: Use polling based LAPDm with frame numbers ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic6d7902b13cf491daaa8752db78f9875387aeffd Gerrit-Change-Number: 35007 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 22 Nov 2023 13:21:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[M] Change in osmo-bts[master]: Use polling based LAPDm with frame numbers

by jolly

Attention is currently required from: fixeria, laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email ) Change subject: Use polling based LAPDm with frame numbers ...................................................................... Patch Set 5: (2 comments) Patchset: PS2: > Not addressed. Done File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/fcdc0a38_fe15f7ae PS3, Line 686: #if 0 > Still missing to log a message, but not critical I guess. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic6d7902b13cf491daaa8752db78f9875387aeffd Gerrit-Change-Number: 35007 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Nov 2023 13:20:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-bts[master]: LAPDm: Reject (release) establishment on DCC0, SAPI 0 without L3 payload

by jolly

Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: LAPDm: Reject (release) establishment on DCC0, SAPI 0 without L3 payload ...................................................................... LAPDm: Reject (release) establishment on DCC0, SAPI 0 without L3 payload A special flag is used to keep track on the establishment of the data link. If it is being established (not re-established) without L3 payload, it is rejected by a release request inside BTS. Related: OS#5971 Change-Id: I6819b51a876b8743c2d4a04165b7900723a1631c --- M include/osmo-bts/lchan.h M src/common/lchan.c M src/common/rsl.c 3 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/82/35082/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6819b51a876b8743c2d4a04165b7900723a1631c Gerrit-Change-Number: 35082 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 7 months

1
0
0 0

[M] Change in osmo-bts[master]: Use polling based LAPDm with frame numbers

by jolly

Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: Use polling based LAPDm with frame numbers ...................................................................... Use polling based LAPDm with frame numbers Osmo-bts uses the new polling based LAPDm implementation. The OML message NM_ATT_T200 is ignored, because T200 timeouts are set to the minimal response time. Longer timeouts would cause lower throughput in case of lost frames. Shorter timeouts would cause LAPDm to fail. Related: OS#4074 Depends: libosmocore.git I6ebe83f829d7751ea9de1d90eb478c7a628db64c Change-Id: Ic6d7902b13cf491daaa8752db78f9875387aeffd --- M include/osmo-bts/bts.h M include/osmo-bts/oml.h M src/common/bts.c M src/common/l1sap.c M src/common/lchan.c M src/common/oml.c 6 files changed, 107 insertions(+), 72 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/07/35007/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic6d7902b13cf491daaa8752db78f9875387aeffd Gerrit-Change-Number: 35007 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 7 months

1
0
0 0

[S] Change in osmocom-bb[master]: firmware: -nostartfiles -nodefaultlibs are not flags of LD but flags ...

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35089?usp=email ) Change subject: firmware: -nostartfiles -nodefaultlibs are not flags of LD but flags of GCC ...................................................................... firmware: -nostartfiles -nodefaultlibs are not flags of LD but flags of GCC It seems that those flags have always been gcc flags, and not ld flags. After decades of tolerating this, binutils 2.36.x no longer tolerates those flags but prints an error: arm-none-eabi-ld: Error: unable to disambiguate: -nostartfiles (did you mean --nostartfiles ?) See also https://github.com/apache/nuttx/issues/3826 and the related https://github.com/apache/nuttx/pull/3836 how this was solved in another project - I adopted that solution here 1:1 Change-Id: Id199e4d03d5aae07a347c98f47791f42c12008c6 --- M src/target/firmware/Makefile.inc 1 file changed, 24 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/89/35089/1 diff --git a/src/target/firmware/Makefile.inc b/src/target/firmware/Makefile.inc index 2be240d..86e8f3c 100644 --- a/src/target/firmware/Makefile.inc +++ b/src/target/firmware/Makefile.inc @@ -4,7 +4,7 @@ CROSS_COMPILE?=arm-none-eabi- CC=gcc -LD=ld +LD=gcc AR=ar SIZE=size OBJCOPY=objcopy @@ -22,7 +22,7 @@ #ASFLAGS=--g$(DEBUGF) $(INCLUDES) -D__ASSEMBLY__ ASFLAGS=$(INCLUDES) -D__ASSEMBLY__ -LDFLAGS = -nostartfiles -nostdlib -nodefaultlibs --gc-sections --cref +LDFLAGS = -nostartfiles -nostdlib -nodefaultlibs -Wl,--gc-sections -Wl,--cref #### QUIET OUTPUT #### @@ -99,8 +99,8 @@ # define compilation rule, also generates map file board/$(2)/$(1).$(3).elf board/$(2)/$(1).$(3).map: $$($(1)_$(2)_$(3)_OBJS) $$($(1)_$(2)_$(3)_LIBS) $$(ENV_$(3)_LDS) $$(Q_LD)$(CROSS_COMPILE)$(LD) $(LDFLAGS) -T $$(ENV_$(3)_LDS) -Bstatic \ - -Map board/$(2)/$(1).$(3).map -o board/$(2)/$(1).$(3).elf \ - --start-group $$($(1)_$(2)_$(3)_OBJS) $$($(1)_$(2)_$(3)_LIBS) --end-group + -Wl,-Map board/$(2)/$(1).$(3).map -o board/$(2)/$(1).$(3).elf \ + -Wl,--start-group $$($(1)_$(2)_$(3)_OBJS) $$($(1)_$(2)_$(3)_LIBS) -Wl,--end-group # define size rule board/$(2)/$(1).$(3).size: board/$(2)/$(1).$(3).elf -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35089?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id199e4d03d5aae07a347c98f47791f42c12008c6 Gerrit-Change-Number: 35089 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests_LAPDm.TC_sabm_retransmit_bts: Fix time to wait

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35054?usp=email ) Change subject: BTS_Tests_LAPDm.TC_sabm_retransmit_bts: Fix time to wait ...................................................................... BTS_Tests_LAPDm.TC_sabm_retransmit_bts: Fix time to wait Wait 20 seconds, because T200 on SDCCH, SAPI 3 lasts about 2 seconds. Relates: OS#5970 Change-Id: I593008420f58cc1d5e4778874f9071914d24f82e --- M bts/BTS_Tests_LAPDm.ttcn 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/bts/BTS_Tests_LAPDm.ttcn b/bts/BTS_Tests_LAPDm.ttcn index 2e984d1..7dda8b8 100644 --- a/bts/BTS_Tests_LAPDm.ttcn +++ b/bts/BTS_Tests_LAPDm.ttcn @@ -287,7 +287,7 @@ LAPDM.clear; RSL.send(ts_RSL_EST_REQ(g_chan_nr, ts_RslLinkID_DCCH(sapi))); - timer T := 8.0; + timer T := 20.0; var integer sabm_received := 0; T.start; alt { @@ -311,6 +311,7 @@ } testcase TC_sabm_retransmit_bts() runs on test_CT { var ConnHdlrPars pars := valueof(t_Pars(t_RslChanNr_Bm(1), ts_RSL_ChanMode_SIGN)); + pars.t_guard := 30.0; f_testmatrix_each_chan(pars, refers(f_TC_sabm_retransmit_bts)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I593008420f58cc1d5e4778874f9071914d24f82e Gerrit-Change-Number: 35054 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2023