October 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: Drop use of deprectated vty callback is_config_node
by laforge 03 Oct '23

03 Oct '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34620?usp=email ) Change subject: Drop use of deprectated vty callback is_config_node ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34620?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I54c5aa5911611b181f80e76556b150f25dd5b60c Gerrit-Change-Number: 34620 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Oct 2023 12:37:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: cosmetic: oc2g_mgr: fix trailing whitespace
by laforge 03 Oct '23

03 Oct '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34619?usp=email ) Change subject: cosmetic: oc2g_mgr: fix trailing whitespace ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I918cbe32d1be692a1747c9721f680ed8a336bf6f Gerrit-Change-Number: 34619 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Oct 2023 12:37:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: cosmetic: oc2g_mgr: fix trailing whitespace
by pespin 03 Oct '23

03 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/34619?usp=email ) Change subject: cosmetic: oc2g_mgr: fix trailing whitespace ...................................................................... cosmetic: oc2g_mgr: fix trailing whitespace Change-Id: I918cbe32d1be692a1747c9721f680ed8a336bf6f --- M src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/19/34619/1 diff --git a/src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c b/src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c index 9693eab..27698a7 100644 --- a/src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c +++ b/src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c @@ -1,5 +1,5 @@ /* Copyright (C) 2015 by Yves Godin <support(a)nuranwireless.com> - * + * * Based on sysmoBTS: * sysmobts_mgr_vty.c * (C) 2014 by oc2gcom - s.f.m.c. GmbH @@ -649,7 +649,7 @@ DEFUN(calibrate_clock, calibrate_clock_cmd, "calibrate clock", - "Calibration commands\n" + "Calibration commands\n" "Calibrate clock against GPS PPS\n") { if (oc2gbts_mgr_calib_run(s_mgr) < 0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I918cbe32d1be692a1747c9721f680ed8a336bf6f Gerrit-Change-Number: 34619 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bts[master]: Drop use of deprectated vty callback is_config_node
by pespin 03 Oct '23

03 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/34620?usp=email ) Change subject: Drop use of deprectated vty callback is_config_node ...................................................................... Drop use of deprectated vty callback is_config_node While compiling: vty.c:169:3: warning: 'is_config_node' is deprecated: Implicit parent node tracking has replaced the use of this callback. This callback is no longer called, ever, and can be left NULL. [-Wdeprecated-declarations] .is_config_node = bts_vty_is_config_node, ^ Change-Id: I54c5aa5911611b181f80e76556b150f25dd5b60c --- M include/osmo-bts/vty.h M src/common/vty.c M src/osmo-bts-lc15/misc/lc15bts_mgr_vty.c M src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c M src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c 5 files changed, 16 insertions(+), 88 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/20/34620/1 diff --git a/include/osmo-bts/vty.h b/include/osmo-bts/vty.h index 4716f7c..d326c5c 100644 --- a/include/osmo-bts/vty.h +++ b/include/osmo-bts/vty.h @@ -21,7 +21,6 @@ struct phy_instance *vty_get_phy_instance(struct vty *vty, int phy_nr, int inst_nr); int bts_vty_go_parent(struct vty *vty); -int bts_vty_is_config_node(struct vty *vty, int node); int bts_vty_init(void *ctx); diff --git a/src/common/vty.c b/src/common/vty.c index f14cc92..014042d 100644 --- a/src/common/vty.c +++ b/src/common/vty.c @@ -140,20 +140,6 @@ return vty->node; } -int bts_vty_is_config_node(struct vty *vty, int node) -{ - switch (node) { - case TRX_NODE: - case BTS_NODE: - case PHY_NODE: - case PHY_INST_NODE: - case OSMUX_NODE: - return 1; - default: - return 0; - } -} - static const char osmobts_copyright[] = "Copyright (C) 2010-2011 by Harald Welte, Andreas Eversberg and On-Waves\r\n" "Copyright (C) 2011-2022 by sysmocom - s.f.m.c. GmbH\r\n" @@ -166,7 +152,6 @@ .version = PACKAGE_VERSION, .copyright = osmobts_copyright, .go_parent_cb = bts_vty_go_parent, - .is_config_node = bts_vty_is_config_node, .usr_attr_desc = { [BTS_VTY_ATTR_NEW_LCHAN] = \ "This command applies for newly created lchans", diff --git a/src/osmo-bts-lc15/misc/lc15bts_mgr_vty.c b/src/osmo-bts-lc15/misc/lc15bts_mgr_vty.c index 424ff18..2cf39de 100644 --- a/src/osmo-bts-lc15/misc/lc15bts_mgr_vty.c +++ b/src/osmo-bts-lc15/misc/lc15bts_mgr_vty.c @@ -89,39 +89,10 @@ return vty->node; } -static int is_config_node(struct vty *vty, int node) -{ - switch (node) { - case MGR_NODE: - case ACT_NORM_NODE: - case ACT_WARN_NODE: - case ACT_CRIT_NODE: - case LIMIT_SUPPLY_TEMP_NODE: - case LIMIT_SOC_NODE: - case LIMIT_FPGA_NODE: - case LIMIT_RMSDET_NODE: - case LIMIT_OCXO_NODE: - case LIMIT_TX0_TEMP_NODE: - case LIMIT_TX1_TEMP_NODE: - case LIMIT_PA0_TEMP_NODE: - case LIMIT_PA1_TEMP_NODE: - case LIMIT_SUPPLY_VOLT_NODE: - case LIMIT_TX0_VSWR_NODE: - case LIMIT_TX1_VSWR_NODE: - case LIMIT_SUPPLY_PWR_NODE: - case LIMIT_PA0_PWR_NODE: - case LIMIT_PA1_PWR_NODE: - return 1; - default: - return 0; - } -} - static struct vty_app_info vty_info = { .name = "lc15bts-mgr", .version = PACKAGE_VERSION, .go_parent_cb = go_to_parent, - .is_config_node = is_config_node, .copyright = copyright, }; diff --git a/src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c b/src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c index 27698a7..431227d 100644 --- a/src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c +++ b/src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c @@ -86,35 +86,10 @@ return vty->node; } -static int is_config_node(struct vty *vty, int node) -{ - switch (node) { - case MGR_NODE: - case ACT_NORM_NODE: - case ACT_WARN_NODE: - case ACT_CRIT_NODE: - case LIMIT_SUPPLY_TEMP_NODE: - case LIMIT_SOC_NODE: - case LIMIT_FPGA_NODE: - case LIMIT_RMSDET_NODE: - case LIMIT_OCXO_NODE: - case LIMIT_TX_TEMP_NODE: - case LIMIT_PA_TEMP_NODE: - case LIMIT_SUPPLY_VOLT_NODE: - case LIMIT_VSWR_NODE: - case LIMIT_SUPPLY_PWR_NODE: - case LIMIT_PA_PWR_NODE: - return 1; - default: - return 0; - } -} - static struct vty_app_info vty_info = { .name = "oc2gbts-mgr", .version = PACKAGE_VERSION, .go_parent_cb = go_to_parent, - .is_config_node = is_config_node, .copyright = copyright, }; diff --git a/src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c b/src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c index fb3987b..54d8d36 100644 --- a/src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c +++ b/src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c @@ -69,28 +69,10 @@ return vty->node; } -static int is_config_node(struct vty *vty, int node) -{ - switch (node) { - case MGR_NODE: - case ACT_NORM_NODE: - case ACT_WARN_NODE: - case ACT_CRIT_NODE: - case LIMIT_RF_NODE: - case LIMIT_DIGITAL_NODE: - case LIMIT_BOARD_NODE: - case LIMIT_PA_NODE: - return 1; - default: - return 0; - } -} - static struct vty_app_info vty_info = { .name = "sysmobts-mgr", .version = PACKAGE_VERSION, .go_parent_cb = go_to_parent, - .is_config_node = is_config_node, .copyright = copyright, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34620?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I54c5aa5911611b181f80e76556b150f25dd5b60c Gerrit-Change-Number: 34620 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: Drop unused local var
by pespin 03 Oct '23

03 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34618?usp=email ) Change subject: Drop unused local var ...................................................................... Drop unused local var Change-Id: I6da89b8861c0bd17fc011b55d5f4979ad6787f80 --- M src/osmo-bsc/bsc_vty.c 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/34618/1 diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index 02f708e..d758832 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -764,14 +764,12 @@ struct gsm_subscriber_connection *conn; struct gsm_network *net = gsmnet_from_vty(vty); bool no_conns = true; - unsigned int count = 0; vty_out(vty, "Active subscriber connections: %s", VTY_NEWLINE); llist_for_each_entry(conn, &net->subscr_conns, entry) { dump_one_subscr_conn(vty, conn); no_conns = false; - count++; } if (no_conns) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34618?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6da89b8861c0bd17fc011b55d5f4979ad6787f80 Gerrit-Change-Number: 34618 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-sccp[master]: sccp: Drop unused local variable
by pespin 03 Oct '23

03 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34617?usp=email ) Change subject: sccp: Drop unused local variable ...................................................................... sccp: Drop unused local variable Change-Id: I7f829f1c285d01faeaad317262ddd51f39e42886 --- M src/sccp.c 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/17/34617/1 diff --git a/src/sccp.c b/src/sccp.c index ecab9ab..85bea6d 100644 --- a/src/sccp.c +++ b/src/sccp.c @@ -840,7 +840,6 @@ struct msgb *request; struct sccp_connection_request *req; uint8_t *data; - uint8_t extra_size = 3 + 1; int called_len; if (l3_data) { @@ -850,8 +849,6 @@ } } - if (l3_data) - extra_size += 2 + l3_length; request = msgb_alloc_headroom(SCCP_MSG_SIZE, SCCP_MSG_HEADROOM, "sccp connection request"); request->l2h = &request->data[0]; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34617?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I7f829f1c285d01faeaad317262ddd51f39e42886 Gerrit-Change-Number: 34617 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmo-gprs[master]: rlcmac: tbf_ul: Fix wrong field assignment (no bug in practice)
by pespin 03 Oct '23

03 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34616?usp=email ) Change subject: rlcmac: tbf_ul: Fix wrong field assignment (no bug in practice) ...................................................................... rlcmac: tbf_ul: Fix wrong field assignment (no bug in practice) Fixes following warning detected by clang: """ tbf_ul.c:1118:37: warning: implicit conversion from enumeration type 'enum gprs_rlcmac_rlc_egprs_ul_reseg_bsn_state' to different enumeration type 'enum gprs_rlcmac_rlc_egprs_dl_reseg_bsn_state' [-Wenum-conversion] blk->spb_status.block_status_dl = reseg_status; """ In practice it's not much of a problem since both fields are put together in a union, so it ends up in the same place in memory. Change-Id: Iccd57b74640754f2aebf81a149a633f141c6e38f --- M src/rlcmac/tbf_ul.c 1 file changed, 21 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/16/34616/1 diff --git a/src/rlcmac/tbf_ul.c b/src/rlcmac/tbf_ul.c index 3786b30..d96891f 100644 --- a/src/rlcmac/tbf_ul.c +++ b/src/rlcmac/tbf_ul.c @@ -1115,7 +1115,7 @@ * function returns the reseg status */ reseg_status = egprs_ul_get_data(ul_tbf, bsn, &block_data); - blk->spb_status.block_status_dl = reseg_status; + blk->spb_status.block_status_ul = reseg_status; /* * If it is first segment of the split block set the state of -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34616?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iccd57b74640754f2aebf81a149a633f141c6e38f Gerrit-Change-Number: 34616 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmocom-bb[master]: Correctly extract bits from SI2*/SI5*
by pespin 03 Oct '23

03 Oct '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34604?usp=email ) Change subject: Correctly extract bits from SI2*/SI5* ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie5349464fed0a4276955235c7c87b5bcb299f20d Gerrit-Change-Number: 34604 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 03 Oct 2023 10:50:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmocom-bb[master]: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$
by pespin 03 Oct '23

03 Oct '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34614?usp=email ) Change subject: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$ ...................................................................... Patch Set 1: (5 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/08754ed4_e6e6f01b PS1, Line 7: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$ what's this $(ASCI)$ here at the end? File src/host/layer23/include/osmocom/bb/common/sysinfo.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/729c00cb_92406627 PS1, Line 179: uint8_t si10_cells; /* number neighbor cells found in SI 10 */ having si10_cells vs si10_cell below is highly misleading and prone to error. Bette call this si10_cell_count or si10_cell_len? File src/host/layer23/src/common/sysinfo.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/0fd03ccb_ebe4cf64 PS1, Line 1040: static int16_t arfcn_from_freq(struct gsm48_sysinfo *s, uint16_t index) according to the param looks mmore like arfcn_from_index ;) is the index value a frequency in Hz? File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/fce466b9_88961418 PS1, Line 2900: /* receive "SYSTEM INFORMATION 10" message (9.1.50) */ why turning the first char into a lowcase her? https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/cd5a39df_e69837c1 PS1, Line 2909: LOGP(DRR, LOGL_INFO, "No cell selected, SYSTEM INFORMATION 10 " all these can git in one line. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34614?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I81c7929f6d951d8eef7d08624f0b72830370c448 Gerrit-Change-Number: 34614 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 03 Oct 2023 10:49:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: ASCI: Add VTY command to display group call neighbor cells
by pespin 03 Oct '23

03 Oct '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34615?usp=email ) Change subject: ASCI: Add VTY command to display group call neighbor cells ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie84221507bdf247c1563b829d6cf0adb53ce161f Gerrit-Change-Number: 34615 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 03 Oct 2023 10:44:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0