October 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: library: add System Information Type 10 Rest Octets codec
by fixeria 04 Oct '23

04 Oct '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34578?usp=email ) Change subject: library: add System Information Type 10 Rest Octets codec ...................................................................... library: add System Information Type 10 Rest Octets codec The CSN.1 definition can be found in 3GPP TS 44.018, section 10.5.2.44. Change-Id: Iab04a588e645abf9b3c99bddef293526ae6752e1 Related: OS#5782 --- M library/GSM_RestOctets.ttcn 1 file changed, 136 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve jolly: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/GSM_RestOctets.ttcn b/library/GSM_RestOctets.ttcn index 6fa781c..eff9546 100644 --- a/library/GSM_RestOctets.ttcn +++ b/library/GSM_RestOctets.ttcn @@ -1241,6 +1241,125 @@ }; +/* 10.5.2.44 SI10 rest octets (ASCI) */ +type record SI10RestOctets { + BIT1 ba_ind, + BIT1 neigh_info_presence, // L/H + SI10NeighInfo neigh_info optional +} with { + variant (neigh_info_presence) "CSN.1 L/H" + variant (neigh_info) "PRESENCE(neigh_info_presence = '1'B)" + + /* The TITAN's RAW encoder generates an octet-aligned octetstring, + * so we should make sure that unused bits contain proper padding. */ + variant "PADDING(yes), PADDING_PATTERN('00101011'B)" +}; + +private type record SI10NeighInfo { + uint5_t first_freq, + SI10CellInfo cell_info, + SI10InfoFieldList info_field optional, + BIT1 info_field_term ('0'B) // L/H +} with { + variant (info_field_term) "CSN.1 L/H" +}; + +private type record SI10CellInfo { + uint6_t bsic, + BIT1 cell_params_presence, // L/H + SI10CellParams cell_params optional +} with { + variant (cell_params_presence) "CSN.1 L/H" + variant (cell_params) "PRESENCE(cell_params_presence = '1'B)" +}; + +private type record SI10CellParams { + BIT1 cell_barred, // L/H + SI10FurtherCellInfo further_cell_info optional +} with { + variant (cell_barred) "CSN.1 L/H" + variant (further_cell_info) "PRESENCE(cell_barred = '0'B)" +}; + +private type record SI10FurtherCellInfo { + BIT1 la_different, // L/H + uint3_t cell_resel_hyst optional, + uint5_t ms_txpwr_max_cch, + uint6_t rxlev_access_min, + uint6_t cell_resel_offset, + uint3_t temp_offset, + uint5_t penalty_time +} with { + variant (la_different) "CSN.1 L/H" + variant (cell_resel_hyst) "PRESENCE(la_different = '1'B)" +}; + +private type record of SI10InfoField SI10InfoFieldList; +private type record SI10InfoField { + BIT1 item_ind ('1'B), + SI10NextFreqList next_freq optional, + BIT1 next_freq_term ('0'B), // L/H + SI10DiffCellInfo diff_cell_info +} with { + variant (item_ind) "CSN.1 L/H" + variant "PRESENCE(item_ind = '1'B)" + variant (next_freq_term) "CSN.1 L/H" +}; + +private type record of SI10NextFreq SI10NextFreqList; +private type BIT1 SI10NextFreq with { variant "CSN.1 L/H" }; + +private type record SI10DiffCellInfo { + BIT1 bcc_or_bsic, // L/H + uint3_t bcc optional, + uint6_t bsic optional, + BIT1 diff_cell_params_presence, // L/H + SI10DiffCellParams diff_cell_params optional +} with { + variant (bcc_or_bsic) "CSN.1 L/H" + variant (bcc) "PRESENCE(bcc_or_bsic = '1'B)" + variant (bsic) "PRESENCE(bcc_or_bsic = '0'B)" + variant (diff_cell_params_presence) "CSN.1 L/H" + variant (diff_cell_params) "PRESENCE(diff_cell_params_presence = '1'B)" +}; + +private type record SI10DiffCellParams { + BIT1 cell_barred, // L/H + SI10FurtherDiffCellInfo further_diff_cell_info optional +} with { + variant (cell_barred) "CSN.1 L/H" + variant (further_diff_cell_info) "PRESENCE(cell_barred = '0'B)" +}; + +private type record SI10FurtherDiffCellInfo { + BIT1 la_different, // L/H + uint3_t cell_resel_hyst optional, + BIT1 ms_txpwr_max_cch_presence, // L/H + uint5_t ms_txpwr_max_cch optional, + BIT1 rxlev_access_min_presence, // L/H + uint6_t rxlev_access_min optional, + BIT1 cell_resel_offset_presence, // L/H + uint6_t cell_resel_offset optional, + BIT1 temp_offset_presence, // L/H + uint3_t temp_offset optional, + BIT1 penalty_time_presence, // L/H + uint5_t penalty_time optional +} with { + variant (la_different) "CSN.1 L/H" + variant (cell_resel_hyst) "PRESENCE(la_different = '1'B)" + variant (ms_txpwr_max_cch_presence) "CSN.1 L/H" + variant (ms_txpwr_max_cch) "PRESENCE(ms_txpwr_max_cch_presence = '1'B)" + variant (rxlev_access_min_presence) "CSN.1 L/H" + variant (rxlev_access_min) "PRESENCE(rxlev_access_min_presence = '1'B)" + variant (cell_resel_offset_presence) "CSN.1 L/H" + variant (cell_resel_offset) "PRESENCE(cell_resel_offset_presence = '1'B)" + variant (temp_offset_presence) "CSN.1 L/H" + variant (temp_offset) "PRESENCE(temp_offset_presence = '1'B)" + variant (penalty_time_presence) "CSN.1 L/H" + variant (penalty_time) "PRESENCE(penalty_time_presence = '1'B)" +}; + + external function enc_SI2quaterRestOctets(in SI2quaterRestOctets ro) return octetstring with { extension "prototype(convert) encode(RAW)" }; external function dec_SI2quaterRestOctets(in octetstring stream) return SI2quaterRestOctets @@ -1266,6 +1385,11 @@ external function dec_SI13RestOctets(in octetstring stream) return SI13RestOctets with { extension "prototype(convert) decode(RAW)" }; +external function enc_SI10RestOctets(in SI10RestOctets ro) return octetstring + with { extension "prototype(convert) encode(RAW)" }; +external function dec_SI10RestOctets(in octetstring stream) return SI10RestOctets + with { extension "prototype(convert) decode(RAW)" }; + /* Basic templates to be extended in place */ template (value) SI3RestOctets ts_SI3RestOctets := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iab04a588e645abf9b3c99bddef293526ae6752e1 Gerrit-Change-Number: 34578 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: library: add System Information Type 10 Rest Octets codec
by fixeria 04 Oct '23

04 Oct '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34578?usp=email ) Change subject: library: add System Information Type 10 Rest Octets codec ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iab04a588e645abf9b3c99bddef293526ae6752e1 Gerrit-Change-Number: 34578 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 04 Oct 2023 10:56:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: Fix potential NULL pointer dereferences, discovered by Coverity Scan
by jolly 04 Oct '23

04 Oct '23

Attention is currently required from: fixeria, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34608?usp=email ) Change subject: Fix potential NULL pointer dereferences, discovered by Coverity Scan ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/34608/comment/c3aa2652_ac1523e9 PS3, Line 7: Fixed potential NULL pointer dereferences, discovered by Coverity Scan > we actually usually use imperative/infinitive in here. Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34608?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I47aa506014d8bddb8c8ce9b506c1c5c7b8056d30 Gerrit-Change-Number: 34608 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Oct 2023 10:56:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: Fix potential NULL pointer dereferences, discovered by Coverity Scan
by jolly 04 Oct '23

04 Oct '23

Attention is currently required from: fixeria, jolly. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34608?usp=email to look at the new patch set (#4). Change subject: Fix potential NULL pointer dereferences, discovered by Coverity Scan ...................................................................... Fix potential NULL pointer dereferences, discovered by Coverity Scan See: CID 323362 + CID 323363 Change-Id: I47aa506014d8bddb8c8ce9b506c1c5c7b8056d30 --- M src/host/layer23/src/mobile/gsm48_mm.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/08/34608/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34608?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I47aa506014d8bddb8c8ce9b506c1c5c7b8056d30 Gerrit-Change-Number: 34608 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmocom-bb[master]: Fix settings for VGCS/VBS
by pespin 04 Oct '23

04 Oct '23

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34644?usp=email ) Change subject: Fix settings for VGCS/VBS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34644?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I81575dd3f2ade70101df32935a1c3d5469327577 Gerrit-Change-Number: 34644 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 04 Oct 2023 10:47:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: Fixed potential NULL pointer dereferences, discovered by Coverity Scan
by pespin 04 Oct '23

04 Oct '23

Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34608?usp=email ) Change subject: Fixed potential NULL pointer dereferences, discovered by Coverity Scan ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/34608/comment/a645cf7e_908f2773 PS3, Line 7: Fixed potential NULL pointer dereferences, discovered by Coverity Scan we actually usually use imperative/infinitive in here. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34608?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I47aa506014d8bddb8c8ce9b506c1c5c7b8056d30 Gerrit-Change-Number: 34608 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Oct 2023 10:47:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmocom-bb[master]: ASCI: Add VTY commands to control voice group/broadcast calls
by jolly 04 Oct '23

04 Oct '23

Attention is currently required from: fixeria, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34495?usp=email ) Change subject: ASCI: Add VTY commands to control voice group/broadcast calls ...................................................................... Patch Set 16: (2 comments) File src/host/layer23/src/mobile/vty_interface.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34495/comment/c75d73d4_ca937e73 PS16, Line 379: ASCI_STR > You're missing `SHOW_STR` here, it should be: […] It is already added in the #define above. I renamed it to SHOW_ASCI_STR, to make this clearer. https://gerrit.osmocom.org/c/osmocom-bb/+/34495/comment/928e0c2b_e0cf94a9 PS16, Line 700: These commands perform VGCS on given MS without entering the VGCS node > So then is there really a need for having a dedicated VTY node for just one command, which is also a […] You can switch between talk and listen without having a full command. Just enter "talk" or "listen" or other sub-commands. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34495?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id32253b4e10b8df48e819d8a92bbcda332dd11e6 Gerrit-Change-Number: 34495 Gerrit-PatchSet: 16 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Oct 2023 10:47:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[L] Change in osmocom-bb[master]: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$
by jolly 04 Oct '23

04 Oct '23

Attention is currently required from: fixeria, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34614?usp=email ) Change subject: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$ ...................................................................... Patch Set 2: (9 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/b91d95a1_9aa56e1d PS1, Line 7: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$ > what's this $(ASCI)$ here at the end? This is the full name of the message. See 9.1.50 in TS 44.018 File src/host/layer23/include/osmocom/bb/common/sysinfo.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/0da1c9c2_badec80b PS1, Line 179: uint8_t si10_cells; /* number neighbor cells found in SI 10 */ > having si10_cells vs si10_cell below is highly misleading and prone to error. […] Done File src/host/layer23/src/common/sysinfo.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/763773c1_947c4915 PS1, Line 613: Band indicator > `BA_IND` is actually BCCH allocation sequence number indication, and not a band indicator? The loggi […] Done https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/8ba02555_3007e56d PS1, Line 632: parameter > parameter(s) Done https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/d6f90d90_1b0eb210 PS1, Line 651: bitvec_get_uint(bv, 6) - 110 > use `rxlev2dbm()` Done https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/5698da68_d3410d58 PS1, Line 1040: static int16_t arfcn_from_freq(struct gsm48_sysinfo *s, uint16_t index) > according to the param looks mmore like arfcn_from_index ;) […] The specs calls it "frequency", but it is actually an index, relative to SI5(bis/ter). I will rename it to arfcn_from_freq_index https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/e341b873_6dd49678 PS1, Line 1091: puts > debugging leftovers? Done File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/62e9932a_17189645 PS1, Line 2900: /* receive "SYSTEM INFORMATION 10" message (9.1.50) */ > why turning the first char into a lowcase her? Done https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/95655a3b_5b9513d1 PS1, Line 2909: LOGP(DRR, LOGL_INFO, "No cell selected, SYSTEM INFORMATION 10 " > all these can git in one line. Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34614?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I81c7929f6d951d8eef7d08624f0b72830370c448 Gerrit-Change-Number: 34614 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Oct 2023 10:47:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: Fix settings for VGCS/VBS
by jolly 04 Oct '23

04 Oct '23

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34644?usp=email ) Change subject: Fix settings for VGCS/VBS ...................................................................... Fix settings for VGCS/VBS The "support" flags must be copied to the settings, because they are enabled by default and may be omitted in the VTY config. Related: OS#5364 Change-Id: I81575dd3f2ade70101df32935a1c3d5469327577 --- M src/host/layer23/src/common/settings.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/44/34644/1 diff --git a/src/host/layer23/src/common/settings.c b/src/host/layer23/src/common/settings.c index 288b03e..395d239 100644 --- a/src/host/layer23/src/common/settings.c +++ b/src/host/layer23/src/common/settings.c @@ -100,6 +100,8 @@ set->ch_cap = sup->ch_cap; set->min_rxlev_dbm = sup->min_rxlev_dbm; set->dsc_max = sup->dsc_max; + set->vgcs = sup->vgcs; + set->vbs = sup->vbs; if (sup->half_v1 || sup->half_v3) set->half = 1; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34644?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I81575dd3f2ade70101df32935a1c3d5469327577 Gerrit-Change-Number: 34644 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 0

[S] Change in osmocom-bb[master]: Correctly extract bits from SI2*/SI5*
by jolly 04 Oct '23

04 Oct '23

Attention is currently required from: fixeria, jolly, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34604?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by pespin, Code-Review+2 by fixeria The change is no longer submittable: Code-Review is unsatisfied now. Change subject: Correctly extract bits from SI2*/SI5* ...................................................................... Correctly extract bits from SI2*/SI5* These bits are: * EXT-IND * BA-IND * Multiband reporting Change-Id: Ie5349464fed0a4276955235c7c87b5bcb299f20d --- M src/host/layer23/src/common/sysinfo.c 1 file changed, 26 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/04/34604/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie5349464fed0a4276955235c7c87b5bcb299f20d Gerrit-Change-Number: 34604 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0