October 2023 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-epdg[master]: osmo_epdg_app: Log app started
by pespin 12 Oct '23

12 Oct '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34723?usp=email ) Change subject: osmo_epdg_app: Log app started ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34723?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I376dfd85c05fec43c475958aff7474e5a43089dd Gerrit-Change-Number: 34723 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Oct 2023 16:06:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in ...osmo-epdg[master]: add general project files
by pespin 12 Oct '23

12 Oct '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34722?usp=email ) Change subject: add general project files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34722?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I3cbfc7f17c61ea9c562382240b304ff46ba62ef3 Gerrit-Change-Number: 34722 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 12 Oct 2023 16:06:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: Fix typo in osmo_epdg.app.src
by pespin 12 Oct '23

12 Oct '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34721?usp=email ) Change subject: Fix typo in osmo_epdg.app.src ...................................................................... Fix typo in osmo_epdg.app.src Change-Id: Ibfe7d9d94ce138a7ff58c3b8bf03514ae6facd0b --- M src/osmo_epdg.app.src 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo_epdg.app.src b/src/osmo_epdg.app.src index b75cf4d..483d339 100644 --- a/src/osmo_epdg.app.src +++ b/src/osmo_epdg.app.src @@ -12,6 +12,6 @@ osmo_gsup, osmo_ss7 ]}, - {mod, {epdg_app, []}}, + {mod, {osmo_epdg_app, []}}, {env, []} ]}. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34721?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ibfe7d9d94ce138a7ff58c3b8bf03514ae6facd0b Gerrit-Change-Number: 34721 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo-epdg[master]: Fix typo in osmo_epdg.app.src
by pespin 12 Oct '23

12 Oct '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34721?usp=email ) Change subject: Fix typo in osmo_epdg.app.src ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34721?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ibfe7d9d94ce138a7ff58c3b8bf03514ae6facd0b Gerrit-Change-Number: 34721 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Oct 2023 16:05:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: IPA_Emulation. Fix error if IPAC_MSGT_ID_GET with no tags is received
by pespin 12 Oct '23

12 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34724?usp=email ) Change subject: IPA_Emulation. Fix error if IPAC_MSGT_ID_GET with no tags is received ...................................................................... IPA_Emulation. Fix error if IPAC_MSGT_ID_GET with no tags is received Change-Id: I69cd519cb3b8f10d10b4724e6354d31d5c5b9da5 --- M library/IPA_Emulation.ttcnpp 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/34724/1 diff --git a/library/IPA_Emulation.ttcnpp b/library/IPA_Emulation.ttcnpp index 0cd7314..7a8e8d6 100644 --- a/library/IPA_Emulation.ttcnpp +++ b/library/IPA_Emulation.ttcnpp @@ -415,6 +415,11 @@ } } + /* If no Tags were present in the received IPA message, .u = omit */ + if (not ispresent(get.u)) { + return resp; + } + for (i := 0; i < sizeof(get.u.get); i := i + 1) { var IpaCcmIdTag tag := get.u.get[i].tag; var charstring foo; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34724?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I69cd519cb3b8f10d10b4724e6354d31d5c5b9da5 Gerrit-Change-Number: 34724 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo-epdg[master]: osmo_epdg_app: Log app started
by pespin 12 Oct '23

12 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34723?usp=email ) Change subject: osmo_epdg_app: Log app started ...................................................................... osmo_epdg_app: Log app started This is useful to find out whether the code really started running... Change-Id: I376dfd85c05fec43c475958aff7474e5a43089dd --- M src/osmo_epdg_app.erl 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/23/34723/1 diff --git a/src/osmo_epdg_app.erl b/src/osmo_epdg_app.erl index 197fb97..2eaaa8a 100644 --- a/src/osmo_epdg_app.erl +++ b/src/osmo_epdg_app.erl @@ -5,6 +5,7 @@ -export([start/2, stop/1]). start(_StartType, _StartArgs) -> + lager:notice("osmo-epdg app started~n"), osmo_epdg_sup:start_link(). stop(_State) -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34723?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I376dfd85c05fec43c475958aff7474e5a43089dd Gerrit-Change-Number: 34723 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in libosmocore[master]: gsmtap: Hide implementation of gsmtap_inst
by pespin 12 Oct '23

12 Oct '23

Attention is currently required from: arehbein, daniel, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email ) Change subject: gsmtap: Hide implementation of gsmtap_inst ...................................................................... Patch Set 4: (1 comment) File TODO-RELEASE: https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/99b31817_01662270 PS4, Line 12: core DEPRECATE gsmtap_inst_fd2() wrong, not deprecating gsmtap_inst_fd2. Better add it in the same line, it's fine for me, then I understand they are related. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e365825555609a5 Gerrit-Change-Number: 34720 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Oct 2023 15:31:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in ...osmo-epdg[master]: add general project files
by pespin 12 Oct '23

12 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34722?usp=email ) Change subject: add general project files ...................................................................... add general project files Change-Id: I3cbfc7f17c61ea9c562382240b304ff46ba62ef3 --- A README.md A TODO.md 2 files changed, 75 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/22/34722/1 diff --git a/README.md b/README.md new file mode 100644 index 0000000..6f93fed --- /dev/null +++ b/README.md @@ -0,0 +1,39 @@ += osmo-ePDG = + +Implement an ePDG with an embedded AAA server. +osmo-ePDG also requires a modify strongswan. + +* [UE] <-> [strongswan] <-> [osmo-ePDG] <> [HSS] + <> [PGW] + +== Building == + +Install erlang and rebar3 packages (not "rebar", that's version 2! You may need +to compile it from source in some distros). + +$ rebar3 compile +$ rebar3 escriptize + +== Testing == + +Unit tests can be run this way: +$ rebar3 eunit + +== Running == + +Once osmo\_epdg is built, you can start it this way: + +$ rebar3 shell + +In the erlang shell: +``` +1> osmo_epdg:start(). +``` + +== Configuration == + +$ rebar3 shell --config ./examples/sys.config +``` +1> osmo_epdg:start(). +``` + diff --git a/TODO.md b/TODO.md new file mode 100644 index 0000000..b4a1e7c --- /dev/null +++ b/TODO.md @@ -0,0 +1,27 @@ +# TODO + +- introduce a gen_fsm to hold all the state +- async calls (e.g. terminate subscription) +- improve and understand the supervisor + - when the gsup_server dies, it should only restart the gsup_server + - same for epdg_diameter_swx + +- linting for erlang? + +## upstream dependencies + +### wireshark + +- add message class 5 -> IPSEC_EPDG + +### libosmocore + +- upstream message class + +### osmo_ss7 + +- upstream changes + +### osmo_gsup + +- upstream changes -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34722?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I3cbfc7f17c61ea9c562382240b304ff46ba62ef3 Gerrit-Change-Number: 34722 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo-epdg[master]: Fix typo in osmo_epdg.app.src
by pespin 12 Oct '23

12 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34721?usp=email ) Change subject: Fix typo in osmo_epdg.app.src ...................................................................... Fix typo in osmo_epdg.app.src Change-Id: Ibfe7d9d94ce138a7ff58c3b8bf03514ae6facd0b --- M src/osmo_epdg.app.src 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/21/34721/1 diff --git a/src/osmo_epdg.app.src b/src/osmo_epdg.app.src index b75cf4d..483d339 100644 --- a/src/osmo_epdg.app.src +++ b/src/osmo_epdg.app.src @@ -12,6 +12,6 @@ osmo_gsup, osmo_ss7 ]}, - {mod, {epdg_app, []}}, + {mod, {osmo_epdg_app, []}}, {env, []} ]}. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34721?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ibfe7d9d94ce138a7ff58c3b8bf03514ae6facd0b Gerrit-Change-Number: 34721 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-dev[master]: ttcn3.sh: use nproc for JOBS
by osmith 12 Oct '23

12 Oct '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/34702?usp=email ) Change subject: ttcn3.sh: use nproc for JOBS ...................................................................... ttcn3.sh: use nproc for JOBS Change-Id: I1971e7758e67a4260ae1398d510cb719db45d101 --- M ttcn3/ttcn3.sh 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved; Verified diff --git a/ttcn3/ttcn3.sh b/ttcn3/ttcn3.sh index 5c5f711..54b4328 100755 --- a/ttcn3/ttcn3.sh +++ b/ttcn3/ttcn3.sh @@ -5,7 +5,7 @@ DIR_MAKE="${DIR_MAKE:-${DIR_OSMODEV}/ttcn3/make}" DIR_OUTPUT="${DIR_OUTPUT:-${DIR_OSMODEV}/ttcn3/out}" DIR_USR_LOCAL="$DIR_OSMODEV/ttcn3/usr_local" -JOBS="${JOBS:-9}" +JOBS="$(nproc)" # Osmocom libraries and programs relevant for the current testsuite will be # built in this container. It must have all build dependencies available and -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/34702?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I1971e7758e67a4260ae1398d510cb719db45d101 Gerrit-Change-Number: 34702 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0