pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34724?usp=email )
Change subject: IPA_Emulation. Fix error if IPAC_MSGT_ID_GET with no tags is received
......................................................................
IPA_Emulation. Fix error if IPAC_MSGT_ID_GET with no tags is received
Change-Id: I69cd519cb3b8f10d10b4724e6354d31d5c5b9da5
---
M library/IPA_Emulation.ttcnpp
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/34724/1
diff --git a/library/IPA_Emulation.ttcnpp b/library/IPA_Emulation.ttcnpp
index 0cd7314..7a8e8d6 100644
--- a/library/IPA_Emulation.ttcnpp
+++ b/library/IPA_Emulation.ttcnpp
@@ -415,6 +415,11 @@
}
}
+ /* If no Tags were present in the received IPA message, .u = omit */
+ if (not ispresent(get.u)) {
+ return resp;
+ }
+
for (i := 0; i < sizeof(get.u.get); i := i + 1) {
var IpaCcmIdTag tag := get.u.get[i].tag;
var charstring foo;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34724?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I69cd519cb3b8f10d10b4724e6354d31d5c5b9da5
Gerrit-Change-Number: 34724
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: arehbein, daniel, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )
Change subject: gsmtap: Hide implementation of gsmtap_inst
......................................................................
Patch Set 4:
(1 comment)
File TODO-RELEASE:
https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/99b31817_01662270
PS4, Line 12: core DEPRECATE gsmtap_inst_fd2()
wrong, not deprecating gsmtap_inst_fd2.
Better add it in the same line, it's fine for me, then I understand they are related.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e365825555609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 4
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Oct 2023 15:31:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/34702?usp=email )
Change subject: ttcn3.sh: use nproc for JOBS
......................................................................
ttcn3.sh: use nproc for JOBS
Change-Id: I1971e7758e67a4260ae1398d510cb719db45d101
---
M ttcn3/ttcn3.sh
1 file changed, 10 insertions(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, approved; Verified
diff --git a/ttcn3/ttcn3.sh b/ttcn3/ttcn3.sh
index 5c5f711..54b4328 100755
--- a/ttcn3/ttcn3.sh
+++ b/ttcn3/ttcn3.sh
@@ -5,7 +5,7 @@
DIR_MAKE="${DIR_MAKE:-${DIR_OSMODEV}/ttcn3/make}"
DIR_OUTPUT="${DIR_OUTPUT:-${DIR_OSMODEV}/ttcn3/out}"
DIR_USR_LOCAL="$DIR_OSMODEV/ttcn3/usr_local"
-JOBS="${JOBS:-9}"
+JOBS="$(nproc)"
# Osmocom libraries and programs relevant for the current testsuite will be
# built in this container. It must have all build dependencies available and
--
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/34702?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: I1971e7758e67a4260ae1398d510cb719db45d101
Gerrit-Change-Number: 34702
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: merged
