October 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: gsm48_ie.c: force rate adaptation mode for CSD calls to V.110
by manawyrm 15 Oct '23

15 Oct '23

Attention is currently required from: fixeria. manawyrm has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34745?usp=email ) Change subject: gsm48_ie.c: force rate adaptation mode for CSD calls to V.110 ...................................................................... Patch Set 3: Code-Review-2 (2 comments) Patchset: PS3: -> https://gerrit.osmocom.org/c/osmo-msc/+/34748 PS3: > Actually, I am not really sure if we want to guess or make assumptions in a library function doing p […] Agreed. This is much better suited in osmo-msc. New change (that replaces this one): https://gerrit.osmocom.org/c/osmo-msc/+/34748 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I260834f3d28034afa6b50a6ca8c89accba8fa65b Gerrit-Change-Number: 34745 Gerrit-PatchSet: 3 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Oct 2023 12:40:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: csd_bs: force rate adaptation mode for CSD calls to V.110
by manawyrm 15 Oct '23

15 Oct '23

manawyrm has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/34748?usp=email ) Change subject: csd_bs: force rate adaptation mode for CSD calls to V.110 ...................................................................... csd_bs: force rate adaptation mode for CSD calls to V.110 Certain calls (seen on very old Nokias) won't have the rate adaptation flag set on "analog" CSD calls. The field for the intermediate rate (after RA) is still filled correctly. Workaround this by setting the RA to V.110 whenever the RA is unset but an intermediate rate is specified. Change-Id: I5b3e5649fe071636f1becddfbfee06f9175a5f17 --- M src/libmsc/csd_bs.c 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/48/34748/1 diff --git a/src/libmsc/csd_bs.c b/src/libmsc/csd_bs.c index caea057..ab0b643 100644 --- a/src/libmsc/csd_bs.c +++ b/src/libmsc/csd_bs.c @@ -236,6 +236,11 @@ enum gsm48_bcap_user_rate rate = cap->data.user_rate; bool async = cap->data.async; + /* 3.1kHz CSD calls won't have the rate adaptation field set + but do require rate adaptation. */ + if (cap->data.interm_rate && !ra) + ra = GSM48_BCAP_RA_V110_X30; + if (ra == GSM48_BCAP_RA_V110_X30 && async && transp) { switch (rate) { case GSM48_BCAP_UR_300: -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34748?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5b3e5649fe071636f1becddfbfee06f9175a5f17 Gerrit-Change-Number: 34748 Gerrit-PatchSet: 1 Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: open5gs-latest: Support debian bookworm
by laforge 15 Oct '23

15 Oct '23

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34712?usp=email ) Change subject: open5gs-latest: Support debian bookworm ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File open5gs-latest/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/34712/comment/41727ea1_378… PS2, Line 40: TODO: centos > if someone wants to add support for it, I prefer having it already prepared for whoever wants to add […] sysmocom only supports centos under contract of one specfic customer - and that customer is only interested in Osmocom CNI / 2G. So yes, we're happy if somebody externally would want to contribute support for CentOS in other parts, but I think it's rather unlikely. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib11a55294b525e3c3806246b133f8e479554a068 Gerrit-Change-Number: 34712 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Oct 2023 12:29:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: hss: Test Operator-Determined-Barring feature
by laforge 15 Oct '23

15 Oct '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34718?usp=email ) Change subject: hss: Test Operator-Determined-Barring feature ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34718?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8deea9e284447f8991bdeced982c14fae2f211c5 Gerrit-Change-Number: 34718 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Oct 2023 12:27:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-ttcn3-hacks[master]: Introduce HSS_Tests testsuite
by laforge 15 Oct '23

15 Oct '23

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34714?usp=email ) Change subject: Introduce HSS_Tests testsuite ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34714?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic2fccd9c54aea04f1a31649a0af47c974939fb2f Gerrit-Change-Number: 34714 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Oct 2023 12:27:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-hss-test-ogs: Adapt mongodb db setup to pass new test
by laforge 15 Oct '23

15 Oct '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34719?usp=email ) Change subject: ttcn3-hss-test-ogs: Adapt mongodb db setup to pass new test ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34719?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I42d6af42bada50c55914ec94c4090fccbe8d1c97 Gerrit-Change-Number: 34719 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Oct 2023 12:27:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in docker-playground[master]: Introduce ttcn3-hss-test-ogs
by laforge 15 Oct '23

15 Oct '23

Attention is currently required from: daniel, fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34715?usp=email ) Change subject: Introduce ttcn3-hss-test-ogs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34715?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iebeefd9689ae2efa54678b99ff929ca255ec64d1 Gerrit-Change-Number: 34715 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <daniel(a)totalueberwachung.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <daniel(a)totalueberwachung.de> Gerrit-Comment-Date: Sun, 15 Oct 2023 12:27:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: common/ttcn3-docker-run.sh: add TEST_NAME env var
by laforge 15 Oct '23

15 Oct '23

Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34732?usp=email ) Change subject: common/ttcn3-docker-run.sh: add TEST_NAME env var ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34732?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1f45a05e089b429918096fcd64f7c02033d5a9dd Gerrit-Change-Number: 34732 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Oct 2023 12:26:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: layer23: send UL/DL GPRS blocks over GSMTAP
by laforge 15 Oct '23

15 Oct '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34733?usp=email ) Change subject: layer23: send UL/DL GPRS blocks over GSMTAP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34733?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I338205bee44fe182233efc5619a3d528cd07d932 Gerrit-Change-Number: 34733 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Oct 2023 12:26:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: IPA_Emulation. Fix error if IPAC_MSGT_ID_GET with no tags is received
by laforge 15 Oct '23

15 Oct '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34724?usp=email ) Change subject: IPA_Emulation. Fix error if IPAC_MSGT_ID_GET with no tags is received ...................................................................... IPA_Emulation. Fix error if IPAC_MSGT_ID_GET with no tags is received Change-Id: I69cd519cb3b8f10d10b4724e6354d31d5c5b9da5 --- M library/IPA_Emulation.ttcnpp 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/IPA_Emulation.ttcnpp b/library/IPA_Emulation.ttcnpp index 0cd7314..7a8e8d6 100644 --- a/library/IPA_Emulation.ttcnpp +++ b/library/IPA_Emulation.ttcnpp @@ -415,6 +415,11 @@ } } + /* If no Tags were present in the received IPA message, .u = omit */ + if (not ispresent(get.u)) { + return resp; + } + for (i := 0; i < sizeof(get.u.get); i := i + 1) { var IpaCcmIdTag tag := get.u.get[i].tag; var charstring foo; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34724?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I69cd519cb3b8f10d10b4724e6354d31d5c5b9da5 Gerrit-Change-Number: 34724 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0