January 2023 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: bsc: Use c_l3_payload instead of random octetstring as l3 payload

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30823 ) Change subject: bsc: Use c_l3_payload instead of random octetstring as l3 payload ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30823 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I012dbdc673ff98a6647280ce3d0245abff86cfa4 Gerrit-Change-Number: 30823 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Jan 2023 13:01:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Move hardcoded octetstring to single constant field

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30822 ) Change subject: bsc: Move hardcoded octetstring to single constant field ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30822 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I888bcc42d4b68bac4c12dfbbf3c74e1734318699 Gerrit-Change-Number: 30822 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Jan 2023 13:00:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_paging_imsi_nochan_ci_resp_invalid_mi

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30840 ) Change subject: bsc: Introduce test TC_paging_imsi_nochan_ci_resp_invalid_mi ...................................................................... bsc: Introduce test TC_paging_imsi_nochan_ci_resp_invalid_mi Related: SYS#6280 Change-Id: Id0d069f00bc77be33ca61ce469bea8079ae9bd16 --- M bsc/BSC_Tests.ttcn 1 file changed, 46 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/40/30840/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 0cc9552..ea73f4a 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3514,6 +3514,51 @@ f_shutdown_helper(); } +/* Send paging response containing invalid (wrongly formatted) MobileIdentity IE. */ +testcase TC_paging_imsi_nochan_ci_resp_invalid_mi() runs on test_CT { + var template BSSMAP_FIELD_CellIdentificationList cid_list; + var BSSAP_N_CONNECT_ind rx_c_ind; + var DchanTuple dt; + var octetstring rr_pag_resp := '06270003535992617965720000'O; + /* { 06 27 } is { GSM48_PDISC_RR, GSM48_MT_RR_PAG_RESP } + * see 3GPP TS 44.018, table 9.1.25.1 + * { 00 } or { 01 } is CKSN + Spare Half Octet, not important + * { 03 53 59 92 } is Mobile Station Classmark + * { 61 79 65 72 00 00 } is the invalid Mobile Identity IE (3GPP TS 24.008, 10.5.1.4), + * Length is 0x61 (97 in decimal). + */ + + cid_list := { cIl_CI := { ts_BSSMAP_CI_CI(cid.ci) } }; + f_pageing_helper('001010000000008'H, cid_list, { 0 }); + + /* Send CHAN RQD and wait for allocation; acknowledge it */ + dt.rsl_chan_nr := f_chreq_act_ack(); + dt.idx := {0, 0}; + + /* Send unsolicited Paging response (no matching Paging CMD stored in BSC) */ + f_ipa_tx(ts_RSL_EST_IND(dt.rsl_chan_nr, valueof(ts_RslLinkID_DCCH(0)), rr_pag_resp)); + + /* Expevct a CR with a matching Paging response on the A-Interface */ + timer T := 5.0; + T.start; + alt { + [] BSSAP.receive(tr_BSSAP_CONNECT_ind(?, ?, tr_BSSMAP_ComplL3(rr_pag_resp))) -> value rx_c_ind { + setverdict(pass); + dt.sccp_conn_id := rx_c_ind.connectionId; + BSSAP.send(ts_BSSAP_CONNECT_res(dt.sccp_conn_id)); + } + [] BSSAP.receive { + setverdict(fail, "Received unexpected message on A-Interface!"); + } + [] T.timeout { + setverdict(fail, "Received nothing on A-Interface!"); + } + } + + f_perform_clear_test_ct(dt); + f_shutdown_helper(); +} + /* Verify paging retransmission interval + count */ /* Verify paging stops after channel establishment */ /* Test behavior under paging overload */ @@ -12237,6 +12282,7 @@ execute( TC_paging_resp_unsol() ); execute( TC_paging_500req() ); execute( TC_paging_450req_no_paging_load_ind() ); + execute( TC_paging_imsi_nochan_ci_resp_invalid_mi() ); execute( TC_rsl_drop_counter() ); execute( TC_rsl_unknown_unit_id() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id0d069f00bc77be33ca61ce469bea8079ae9bd16 Gerrit-Change-Number: 30840 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in pysim[master]: cards: fix typo

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/30839 ) Change subject: cards: fix typo ...................................................................... cards: fix typo Change-Id: I81a6074776bdf67b7bea359fe7a24f906936f46d --- M pySim/cards.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/39/30839/1 diff --git a/pySim/cards.py b/pySim/cards.py index 4eff38c..b8a37d4 100644 --- a/pySim/cards.py +++ b/pySim/cards.py @@ -1331,13 +1331,13 @@ print( "Warning: Programming of the ICCID is not implemented for this type of card.") - # KI (Presumably a propritary file) + # KI (Presumably a proprietary file) # TODO: Add programming of KI if p.get('ki'): print( "Warning: Programming of the KI is not implemented for this type of card.") - # OPc (Presumably a propritary file) + # OPc (Presumably a proprietary file) # TODO: Add programming of OPc if p.get('opc'): print( -- To view, visit https://gerrit.osmocom.org/c/pysim/+/30839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I81a6074776bdf67b7bea359fe7a24f906936f46d Gerrit-Change-Number: 30839 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Move hardcoded octetstring to single constant field

by fixeria

Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30822 ) Change subject: bsc: Move hardcoded octetstring to single constant field ...................................................................... Patch Set 3: (1 comment) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30822/comment/08f778ef_85b4… PS2, Line 118: const octetstring c_l3_payload := '00010203040506'O; > Use 'freind' access modifier here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30822 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I888bcc42d4b68bac4c12dfbbf3c74e1734318699 Gerrit-Change-Number: 30822 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Jan 2023 12:18:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Submit valid l3 payload

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30827 ) Change subject: bsc: Submit valid l3 payload ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30827 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6e99ac39f32c9a981420b73f8d7d1568d2fa1c54 Gerrit-Change-Number: 30827 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Jan 2023 12:16:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: libosmocore: Transition to use of 'telnet_init_default'

by neels

Attention is currently required from: arehbein, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30703 ) Change subject: libosmocore: Transition to use of 'telnet_init_default' ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > I'm not asking you to change all the patches. […] FYI, you cannot change patches that have been merged to master. we can always merge more patches fixing earlier errors, but we cannot amend commit log messages once merged. (theoretically we could, with a force push rewriting history, but the master branch should not receive force pushes.) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 Gerrit-Change-Number: 30703 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Jan 2023 11:29:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmo-abis[master]: GPRS Trau frame encoder/decoder for Ericsson RBS

by pespin

Attention is currently required from: laforge, msuraev, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30717 ) Change subject: GPRS Trau frame encoder/decoder for Ericsson RBS ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib2b232a76588c32cde75b987a7e5fdfddf099cd7 Gerrit-Change-Number: 30717 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Jan 2023 11:29:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmo-abis[master]: GPRS Trau frame encoder/decoder for Ericsson RBS

by dexter

Attention is currently required from: laforge, msuraev. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/30717 to look at the new patch set (#6). Change subject: GPRS Trau frame encoder/decoder for Ericsson RBS ...................................................................... GPRS Trau frame encoder/decoder for Ericsson RBS The Ericsson RBS BTS family is using a propritary TRAU frame dialect to communicate with the GPRS/EGPRS part of their CCU. There are essentially two implementations available: - GPRS over 16kbps I.460 subslots (very limited, supports only CS1 and CS4) - GPRS/EGPRS over full 64kbps timeslots (supports CS1-4 and MCS1-9) Change-Id: Ib2b232a76588c32cde75b987a7e5fdfddf099cd7 Related: OS#5198 --- M include/Makefile.am A include/osmocom/trau/trau_pcu_ericsson.h M src/Makefile.am A src/trau/trau_pcu_ericsson.c M tests/Makefile.am M tests/testsuite.at A tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c A tests/trau_pcu_ericsson/trau_pcu_ericsson_test.ok 8 files changed, 6,266 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/17/30717/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib2b232a76588c32cde75b987a7e5fdfddf099cd7 Gerrit-Change-Number: 30717 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in libosmo-abis[master]: GPRS Trau frame encoder/decoder for Ericsson RBS

by dexter

Attention is currently required from: laforge, msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30717 ) Change subject: GPRS Trau frame encoder/decoder for Ericsson RBS ...................................................................... Patch Set 6: (1 comment) File src/trau/trau_pcu_ericsson.c: https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/cfec397e_3e1c4cec PS4, Line 6: * SPDX-License-Identifier: GPL-2.0+ > Are you sure about this? I see "SPDX-License-Identifier: AGPL-3. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib2b232a76588c32cde75b987a7e5fdfddf099cd7 Gerrit-Change-Number: 30717 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Jan 2023 11:24:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023