January 2023 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: cosmetic: layer23/include/common/Makefile.am: Set one item per line

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30953 ) Change subject: cosmetic: layer23/include/common/Makefile.am: Set one item per line ...................................................................... cosmetic: layer23/include/common/Makefile.am: Set one item per line Change-Id: I2e385d403bd37ad9491fd421509fe7e4104225f9 --- M src/host/layer23/include/osmocom/bb/common/Makefile.am 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/53/30953/1 diff --git a/src/host/layer23/include/osmocom/bb/common/Makefile.am b/src/host/layer23/include/osmocom/bb/common/Makefile.am index f9364cd..31bb6b6 100644 --- a/src/host/layer23/include/osmocom/bb/common/Makefile.am +++ b/src/host/layer23/include/osmocom/bb/common/Makefile.am @@ -1,3 +1,15 @@ -noinst_HEADERS = l1ctl.h l1l2_interface.h l23_app.h logging.h \ - networks.h gps.h sysinfo.h osmocom_data.h utils.h \ - sap_proto.h sap_fsm.h sap_interface.h sim.h +noinst_HEADERS = \ + l1ctl.h \ + l1l2_interface.h \ + l23_app.h \ + logging.h \ + networks.h \ + gps.h \ + sysinfo.h \ + osmocom_data.h \ + utils.h \ + sap_proto.h \ + sap_fsm.h \ + sap_interface.h \ + sim.h \ + $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2e385d403bd37ad9491fd421509fe7e4104225f9 Gerrit-Change-Number: 30953 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: move code that fills in trx info to helper function

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30874 ) Change subject: pcu_sock: move code that fills in trx info to helper function ...................................................................... pcu_sock: move code that fills in trx info to helper function The function pcu_tx_info_ind() fills the trx information in the info indication. Since the function is already quite long, move the trx related part into a sperate helper function. Change-Id: Ic30185c9364adcc61d0a9d3483b0550ac1cdf894 Related: OS#5198 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 35 insertions(+), 26 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index ab3b7d5..ddcf66b 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -103,6 +103,39 @@ ts_info->ma_bit_len = ts->hopping.ma_len * 8 - ts->hopping.ma.cur_bit; } +/* Fill the TRX parameter */ +static void info_ind_fill_trx(struct gsm_pcu_if_info_trx *trx_info, const struct gsm_bts_trx *trx) +{ + unsigned int tn; + const struct gsm_bts_trx_ts *ts; + + trx_info->hlayer1 = 0x2342; + trx_info->pdch_mask = 0; + trx_info->arfcn = trx->arfcn; + + for (tn = 0; tn < ARRAY_SIZE(trx->ts); tn++) { + ts = &trx->ts[tn]; + if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED || + ts->pchan_is != GSM_PCHAN_PDCH) + continue; + + trx_info->pdch_mask |= (1 << tn); + trx_info->ts[tn].tsc = + (ts->tsc >= 0) ? ts->tsc : trx->bts->bsic & 7; + + if (ts->hopping.enabled) + info_ind_fill_fhp(&trx_info->ts[tn], ts); + + LOGP(DPCU, LOGL_INFO, "trx=%d ts=%d: PDCH is available " + "(tsc=%u ", trx->nr, ts->nr, trx_info->ts[tn].tsc); + if (ts->hopping.enabled) + LOGPC(DPCU, LOGL_INFO, "hopping=yes hsn=%u maio=%u ma_bit_len=%u)\n", + ts->hopping.hsn, ts->hopping.maio, trx->ts[tn].hopping.ma.data_len - trx->ts[tn].hopping.ma.cur_bit); + else + LOGPC(DPCU, LOGL_INFO, "hopping=no arfcn=%u)\n", trx->arfcn); + } +} + /* Send BTS properties to the PCU */ static int pcu_tx_info_ind(struct gsm_bts *bts) { @@ -113,8 +146,7 @@ struct gsm_bts_sm *bts_sm; struct gsm_gprs_nsvc *nsvc; struct gsm_bts_trx *trx; - struct gsm_bts_trx_ts *ts; - int i, tn; + int i; OSMO_ASSERT(bts); OSMO_ASSERT(bts->network); @@ -232,30 +264,7 @@ PCU_IF_VERSION, ARRAY_SIZE(info_ind->trx)); break; } - info_ind->trx[i].hlayer1 = 0x2342; - info_ind->trx[i].pdch_mask = 0; - info_ind->trx[i].arfcn = trx->arfcn; - for (tn = 0; tn < ARRAY_SIZE(trx->ts); tn++) { - ts = &trx->ts[tn]; - if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED || - ts->pchan_is != GSM_PCHAN_PDCH) - continue; - - info_ind->trx[i].pdch_mask |= (1 << tn); - info_ind->trx[i].ts[tn].tsc = - (ts->tsc >= 0) ? ts->tsc : bts->bsic & 7; - - if (ts->hopping.enabled) - info_ind_fill_fhp(&info_ind->trx[i].ts[tn], ts); - - LOGP(DPCU, LOGL_INFO, "trx=%d ts=%d: PDCH is available " - "(tsc=%u ", trx->nr, ts->nr, info_ind->trx[i].ts[tn].tsc); - if (ts->hopping.enabled) - LOGPC(DPCU, LOGL_INFO, "hopping=yes hsn=%u maio=%u ma_bit_len=%u)\n", - ts->hopping.hsn, ts->hopping.maio, trx->ts[tn].hopping.ma.data_len - trx->ts[tn].hopping.ma.cur_bit); - else - LOGPC(DPCU, LOGL_INFO, "hopping=no arfcn=%u)\n", trx->arfcn); - } + info_ind_fill_trx(&info_ind->trx[trx->nr], trx); } return pcu_sock_send(bts, msg); 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30874 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic30185c9364adcc61d0a9d3483b0550ac1cdf894 Gerrit-Change-Number: 30874 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: guard against too many TRX

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30873 ) Change subject: pcu_sock: guard against too many TRX ...................................................................... pcu_sock: guard against too many TRX The pcuif only supports a limited but sufficient number of TRXs. When filling in the TRX array in info_ind, we must guard against overflowing the maximum number of TRXs Change-Id: I351080a112f3d3fdf833ee7fa0d77c4cd1d13e42 Related: OS#5198 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index 1dcab56..ab3b7d5 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -226,6 +226,12 @@ trx = gsm_bts_trx_num(bts, i); if (!trx) continue; + if (trx->nr >= ARRAY_SIZE(info_ind->trx)) { + LOG_TRX(trx, DPCU, LOGL_NOTICE, "PCU interface (version %u) " + "cannot handle more than %zu transceivers => skipped\n", + PCU_IF_VERSION, ARRAY_SIZE(info_ind->trx)); + break; + } info_ind->trx[i].hlayer1 = 0x2342; info_ind->trx[i].pdch_mask = 0; info_ind->trx[i].arfcn = trx->arfcn; 5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I351080a112f3d3fdf833ee7fa0d77c4cd1d13e42 Gerrit-Change-Number: 30873 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Add VTY supports for l23_apps

by pespin

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30950 to look at the new patch set (#2). Change subject: layer23: Add VTY supports for l23_apps ...................................................................... layer23: Add VTY supports for l23_apps Initial VTY "boilerplate" code for modem app is already added in this commit as a showcase what's needed by an app to have the VTY config file read and VTY interface initialized. Change-Id: Ife3a3373e5a9c0c8e5959ac714e140e72d6c363a --- M src/host/layer23/include/osmocom/bb/common/l23_app.h M src/host/layer23/src/common/main.c M src/host/layer23/src/misc/Makefile.am M src/host/layer23/src/modem/app_modem.c 4 files changed, 78 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/50/30950/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ife3a3373e5a9c0c8e5959ac714e140e72d6c363a Gerrit-Change-Number: 30950 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: modem: send CHANNEL REQUEST from modem_rx_bcch()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30952 ) Change subject: modem: send CHANNEL REQUEST from modem_rx_bcch() ...................................................................... modem: send CHANNEL REQUEST from modem_rx_bcch() Sending CHANNEL REQUEST from handle_si13() was a bad idea because this function returns early if SI13 was received before SI1. Change-Id: I21f1d68cb9b1d20b356697ba1efe28c3d87fa004 Fixes: 49d993e4abdd8fac8b111e92078563fd9bb28df1 Related: OS#5500 --- M src/host/layer23/src/modem/app_modem.c 1 file changed, 24 insertions(+), 15 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/host/layer23/src/modem/app_modem.c b/src/host/layer23/src/modem/app_modem.c index ec267e5..8af3243 100644 --- a/src/host/layer23/src/modem/app_modem.c +++ b/src/host/layer23/src/modem/app_modem.c @@ -67,6 +67,26 @@ return 0x78 | (rnd & 0x07); } +static int modem_tx_chan_req(struct osmocom_ms *ms, bool single_block) +{ + struct gsm48_rrlayer *rr = &ms->rrlayer; + + OSMO_ASSERT(rr->state == GSM48_RR_ST_IDLE); + + if (!app_data.si.si1) + return -EBUSY; + if (!app_data.si.gprs.supported) + return -ENOTSUP; + + rr->cr_ra = gen_chan_req(single_block); + LOGP(DRR, LOGL_NOTICE, "Sending CHANNEL REQUEST (0x%02x)\n", rr->cr_ra); + l1ctl_tx_rach_req(ms, RSL_CHAN_RACH, 0x00, rr->cr_ra, 0, + app_data.ccch_mode == CCCH_MODE_COMBINED); + + rr->state = GSM48_RR_ST_CONN_PEND; + return 0; +} + static int handle_si1(struct osmocom_ms *ms, struct msgb *msg) { int rc; @@ -147,7 +167,6 @@ static int handle_si13(struct osmocom_ms *ms, struct msgb *msg) { - struct gsm48_rrlayer *rr = &ms->rrlayer; int rc; if (msgb_l3len(msg) != GSM_MACBLOCK_LEN) @@ -159,20 +178,6 @@ if (rc != 0) return rc; - /* HACK: request an Uplink TBF here (one phase access) */ - if (rr->state == GSM48_RR_ST_IDLE) { - if (!app_data.si.si1) - return 0; - if (!app_data.si.gprs.supported) - return 0; - - rr->cr_ra = gen_chan_req(false); - LOGP(DRR, LOGL_NOTICE, "Sending CHANNEL REQUEST (0x%02x)\n", rr->cr_ra); - l1ctl_tx_rach_req(ms, RSL_CHAN_RACH, 0x00, rr->cr_ra, 0, - app_data.ccch_mode == CCCH_MODE_COMBINED); - rr->state = GSM48_RR_ST_CONN_PEND; - } - return 0; } @@ -184,6 +189,10 @@ LOGP(DRR, LOGL_INFO, "BCCH message (type=0x%02x): %s\n", si_type, gsm48_rr_msg_name(si_type)); + /* HACK: request an Uplink TBF here (one phase access) */ + if (ms->rrlayer.state == GSM48_RR_ST_IDLE) + modem_tx_chan_req(ms, false); + switch (si_type) { case GSM48_MT_RR_SYSINFO_1: return handle_si1(ms, msg); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I21f1d68cb9b1d20b356697ba1efe28c3d87fa004 Gerrit-Change-Number: 30952 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: modem: send CHANNEL REQUEST from modem_rx_bcch()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30952 ) Change subject: modem: send CHANNEL REQUEST from modem_rx_bcch() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I21f1d68cb9b1d20b356697ba1efe28c3d87fa004 Gerrit-Change-Number: 30952 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Jan 2023 14:52:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: modem: send CHANNEL REQUEST from modem_rx_bcch()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30952 ) Change subject: modem: send CHANNEL REQUEST from modem_rx_bcch() ...................................................................... modem: send CHANNEL REQUEST from modem_rx_bcch() Sending CHANNEL REQUEST from handle_si13() was a bad idea because this function returns early if SI13 was received before SI1. Change-Id: I21f1d68cb9b1d20b356697ba1efe28c3d87fa004 Fixes: 49d993e4abdd8fac8b111e92078563fd9bb28df1 Related: OS#5500 --- M src/host/layer23/src/modem/app_modem.c 1 file changed, 24 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/52/30952/1 diff --git a/src/host/layer23/src/modem/app_modem.c b/src/host/layer23/src/modem/app_modem.c index ec267e5..8af3243 100644 --- a/src/host/layer23/src/modem/app_modem.c +++ b/src/host/layer23/src/modem/app_modem.c @@ -67,6 +67,26 @@ return 0x78 | (rnd & 0x07); } +static int modem_tx_chan_req(struct osmocom_ms *ms, bool single_block) +{ + struct gsm48_rrlayer *rr = &ms->rrlayer; + + OSMO_ASSERT(rr->state == GSM48_RR_ST_IDLE); + + if (!app_data.si.si1) + return -EBUSY; + if (!app_data.si.gprs.supported) + return -ENOTSUP; + + rr->cr_ra = gen_chan_req(single_block); + LOGP(DRR, LOGL_NOTICE, "Sending CHANNEL REQUEST (0x%02x)\n", rr->cr_ra); + l1ctl_tx_rach_req(ms, RSL_CHAN_RACH, 0x00, rr->cr_ra, 0, + app_data.ccch_mode == CCCH_MODE_COMBINED); + + rr->state = GSM48_RR_ST_CONN_PEND; + return 0; +} + static int handle_si1(struct osmocom_ms *ms, struct msgb *msg) { int rc; @@ -147,7 +167,6 @@ static int handle_si13(struct osmocom_ms *ms, struct msgb *msg) { - struct gsm48_rrlayer *rr = &ms->rrlayer; int rc; if (msgb_l3len(msg) != GSM_MACBLOCK_LEN) @@ -159,20 +178,6 @@ if (rc != 0) return rc; - /* HACK: request an Uplink TBF here (one phase access) */ - if (rr->state == GSM48_RR_ST_IDLE) { - if (!app_data.si.si1) - return 0; - if (!app_data.si.gprs.supported) - return 0; - - rr->cr_ra = gen_chan_req(false); - LOGP(DRR, LOGL_NOTICE, "Sending CHANNEL REQUEST (0x%02x)\n", rr->cr_ra); - l1ctl_tx_rach_req(ms, RSL_CHAN_RACH, 0x00, rr->cr_ra, 0, - app_data.ccch_mode == CCCH_MODE_COMBINED); - rr->state = GSM48_RR_ST_CONN_PEND; - } - return 0; } @@ -184,6 +189,10 @@ LOGP(DRR, LOGL_INFO, "BCCH message (type=0x%02x): %s\n", si_type, gsm48_rr_msg_name(si_type)); + /* HACK: request an Uplink TBF here (one phase access) */ + if (ms->rrlayer.state == GSM48_RR_ST_IDLE) + modem_tx_chan_req(ms, false); + switch (si_type) { case GSM48_MT_RR_SYSINFO_1: return handle_si1(ms, msg); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30952 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I21f1d68cb9b1d20b356697ba1efe28c3d87fa004 Gerrit-Change-Number: 30952 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Add VTY supports for l23_apps

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30950 ) Change subject: layer23: Add VTY supports for l23_apps ...................................................................... Patch Set 1: (2 comments) File src/host/layer23/src/common/main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/0ea8aa82_b4a1bb65 PS1, Line 271: handle_options > I may be missing something, but I believe option parsing, config parsing, and setting up the VTY sho […] It doesn't take VTY config anyway. It's chicken an egg problem we have in all apps. The idea anyway is that l23_app_info() mostly initializes memory, but doesn't "open" stuff which may be prone to errors, etc. that will be done in new l23_app_start() API, which is called after cmdline and VTY parsing. https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/f0d79599_f806c3c8 PS1, Line 331: talloc_free(config_file > This looks wrong to me. […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ife3a3373e5a9c0c8e5959ac714e140e72d6c363a Gerrit-Change-Number: 30950 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Jan 2023 14:49:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: sndcp: Initial support for async SN-XID.ind and SN-XID.rsp

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30907 ) Change subject: sndcp: Initial support for async SN-XID.ind and SN-XID.rsp ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I0a5069fd3dc0d6c3dd28aeae09b51c49dd8be92d Gerrit-Change-Number: 30907 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Jan 2023 14:45:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: sndcp: Initial support for async SN-XID.ind and SN-XID.rsp

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30907 ) Change subject: sndcp: Initial support for async SN-XID.ind and SN-XID.rsp ...................................................................... Patch Set 4: Code-Review+2 (2 comments) File src/sndcp/sndcp.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/30907/comment/ef44c1bb_bff1cc1c PS2, Line 724: compo_fields > comp_fields Done File src/sndcp/sndcp_prim.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/30907/comment/ea37f495_b9599816 PS3, Line 224: PRIM_OP_RESPONSE > (would be cleaner to do this in a separate patch) Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I0a5069fd3dc0d6c3dd28aeae09b51c49dd8be92d Gerrit-Change-Number: 30907 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Jan 2023 14:44:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023